All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Zaborowski <andrew.zaborowski@intel.com>
To: iwd@lists.01.org
Subject: [PATCH] eap-tls: Use the right variable in settings check
Date: Wed, 27 Jan 2021 15:02:25 +0100	[thread overview]
Message-ID: <20210127140225.2476214-1-andrew.zaborowski@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1072 bytes --]

---
 src/eap-tls.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/eap-tls.c b/src/eap-tls.c
index ac7650dc..b20a1b39 100644
--- a/src/eap-tls.c
+++ b/src/eap-tls.c
@@ -174,7 +174,7 @@ static int eap_tls_settings_check(struct l_settings *settings,
 	 * Check whether the combination of settings that are present/missing
 	 * makes sense before validating each setting.
 	 */
-	if (bundle_value && (priv_key_value || client_cert)) {
+	if (bundle_value && (priv_key_value || client_cert_value)) {
 		l_error("Either %s or %s/%s can be used, not both",
 			bundle_setting, priv_key_setting, client_cert_setting);
 		ret = -EEXIST;
@@ -184,7 +184,7 @@ static int eap_tls_settings_check(struct l_settings *settings,
 			priv_key_setting, client_cert_setting);
 		ret = -ENOENT;
 		goto done;
-	} else if (!priv_key_value && client_cert) {
+	} else if (!priv_key_value && client_cert_value) {
 		l_error("%s present but no client private key (%s)",
 			client_cert_setting, priv_key_setting);
 		ret = -ENOENT;
-- 
2.27.0

             reply	other threads:[~2021-01-27 14:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-27 14:02 Andrew Zaborowski [this message]
2021-01-27 15:53 ` [PATCH] eap-tls: Use the right variable in settings check Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210127140225.2476214-1-andrew.zaborowski@intel.com \
    --to=andrew.zaborowski@intel.com \
    --cc=iwd@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.