From: Kari Argillander <kari.argillander@gmail.com>
To: Amy Parker <enbyamy@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] fs/efs/inode.c: follow style guide
Date: Wed, 27 Jan 2021 19:08:28 +0200 [thread overview]
Message-ID: <20210127170828.eydoe7didip7pukr@kari-VirtualBox> (raw)
In-Reply-To: <CAE1WUT55QViS=XE9QUTDp1KQ1_5fwuddLY3+2XSrMdoOuCOyYg@mail.gmail.com>
On Tue, Jan 26, 2021 at 12:58:05PM -0800, Amy Parker wrote:
> This patch updates inode.c for EFS to follow the kernel style guide.
> +++ b/fs/efs/inode.c
> @@ -109,9 +109,9 @@ struct inode *efs_iget(struct super_block *super,
> unsigned long ino)
> /* this is the number of blocks in the file */
> if (inode->i_size == 0) {
Still has { here so you didn't even compile this? Also I think you
should make one patch for whole EFS. Just change one type of thing at
ones. Like
[Patch 1/X] fs/efs: Remove braces from single statments
[Patch 2/X] fs/efs: Add space after C keywords
[Patch 3/X] fs/efs: Fix code indent levels
That way it is super easy to review them. Also because there is no
maintainer it is kind of scary to accept patches. Specially when lot of
different kind of things are changed.
Please also send your patches against cover letter. If you have problem
with your email client plese take a look git send-email. This will work
beautiful for all of this.
And because you are new (i think). Welcome.
next prev parent reply other threads:[~2021-01-27 17:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 20:58 [PATCH 1/2] fs/efs/inode.c: follow style guide Amy Parker
2021-01-27 3:46 ` Randy Dunlap
2021-01-27 3:59 ` Randy Dunlap
2021-01-27 5:13 ` Amy Parker
2021-01-27 6:35 ` Randy Dunlap
2021-01-27 17:08 ` Kari Argillander [this message]
2021-01-27 17:25 ` Amy Parker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210127170828.eydoe7didip7pukr@kari-VirtualBox \
--to=kari.argillander@gmail.com \
--cc=enbyamy@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.