Re: [PATCH v18 01/10] fs/ntfs3: Add headers and misc files

From: Kari Argillander <kari.argillander@gmail.com>
To: Mark Harmstone <mark@harmstone.com>
Cc: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
	linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk,
	linux-kernel@vger.kernel.org, pali@kernel.org, dsterba@suse.cz,
	aaptel@suse.com, willy@infradead.org, rdunlap@infradead.org,
	joe@perches.com, nborisov@suse.com,
	linux-ntfs-dev@lists.sourceforge.net, anton@tuxera.com,
	dan.carpenter@oracle.com, hch@lst.de, ebiggers@kernel.org,
	andy.lavr@gmail.com
Subject: Re: [PATCH v18 01/10] fs/ntfs3: Add headers and misc files
Date: Thu, 28 Jan 2021 09:05:41 +0200	[thread overview]
Message-ID: <20210128070541.ynzsgpniyo2xe23k@kari-VirtualBox> (raw)
In-Reply-To: <45515008-e4a9-26e3-3ce4-026bfacf7d53@harmstone.com>

On Fri, Jan 22, 2021 at 02:55:30PM +0000, Mark Harmstone wrote:
> On 22/1/21 2:01 pm, Konstantin Komarov wrote:
> > diff --git a/fs/ntfs3/upcase.c b/fs/ntfs3/upcase.c

> > +static inline u16 upcase_unicode_char(const u16 *upcase, u16 chr)
> > +{
> > +	if (chr < 'a')
> > +		return chr;
> > +
> > +	if (chr <= 'z')
> > +		return chr - ('a' - 'A');
> > +
> > +	return upcase[chr];
> > +}
> 
> Shouldn't upcase_unicode_char be using the NTFS pseudo-file $UpCase?
> That way you should also be covered for other bicameral alphabets.

return upcase[chr] is just for that? Upcase table from $UpCase is constucted
in super.c and this will get it in and use it.