From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 294B9C433E0 for ; Thu, 28 Jan 2021 16:24:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DB1D864DF9 for ; Thu, 28 Jan 2021 16:23:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232572AbhA1QXn (ORCPT ); Thu, 28 Jan 2021 11:23:43 -0500 Received: from verein.lst.de ([213.95.11.211]:57990 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232541AbhA1QX0 (ORCPT ); Thu, 28 Jan 2021 11:23:26 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id 52BE468AFE; Thu, 28 Jan 2021 17:22:41 +0100 (CET) Date: Thu, 28 Jan 2021 17:22:40 +0100 From: Christoph Hellwig To: Petr Mladek Cc: Christoph Hellwig , Frederic Barrat , Andrew Donnellan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Jessica Yu , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Joe Lawrence , Masahiro Yamada , Michal Marek , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, dri-devel@lists.freedesktop.org, live-patching@vger.kernel.org, linux-kbuild@vger.kernel.org Subject: Re: [PATCH 03/13] livepatch: refactor klp_init_object Message-ID: <20210128162240.GA3417@lst.de> References: <20210121074959.313333-1-hch@lst.de> <20210121074959.313333-4-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 27, 2021 at 01:58:21PM +0100, Petr Mladek wrote: > > --- a/kernel/livepatch/core.c > > +++ b/kernel/livepatch/core.c > > @@ -54,9 +54,6 @@ static void klp_find_object_module(struct klp_object *obj) > > { > > struct module *mod; > > > > - if (!klp_is_module(obj)) > > - return; > > - > > We need to either update the function description or keep this check. > > I prefer to keep the check. The function does the right thing also > for the object "vmlinux". Also the livepatch code includes many > similar paranoid checks that makes the code less error prone > against any further changes. Well, the check is in the caller now where we have a conditional for it. So I'd be tempted to either update the comment, or just drop the patch. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44A82C433E0 for ; Thu, 28 Jan 2021 16:24:45 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 66B1C64DF9 for ; Thu, 28 Jan 2021 16:24:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 66B1C64DF9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4DRQm96g8JzDrg0 for ; Fri, 29 Jan 2021 03:24:41 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lst.de (client-ip=213.95.11.211; helo=verein.lst.de; envelope-from=hch@lst.de; receiver=) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4DRQjy3PjHzDqbc for ; Fri, 29 Jan 2021 03:22:45 +1100 (AEDT) Received: by verein.lst.de (Postfix, from userid 2407) id 52BE468AFE; Thu, 28 Jan 2021 17:22:41 +0100 (CET) Date: Thu, 28 Jan 2021 17:22:40 +0100 From: Christoph Hellwig To: Petr Mladek Subject: Re: [PATCH 03/13] livepatch: refactor klp_init_object Message-ID: <20210128162240.GA3417@lst.de> References: <20210121074959.313333-1-hch@lst.de> <20210121074959.313333-4-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jiri Kosina , Andrew Donnellan , linux-kbuild@vger.kernel.org, David Airlie , Masahiro Yamada , Josh Poimboeuf , Maarten Lankhorst , linux-kernel@vger.kernel.org, Maxime Ripard , live-patching@vger.kernel.org, Michal Marek , Joe Lawrence , dri-devel@lists.freedesktop.org, Thomas Zimmermann , Jessica Yu , Frederic Barrat , Daniel Vetter , Miroslav Benes , linuxppc-dev@lists.ozlabs.org, Christoph Hellwig Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, Jan 27, 2021 at 01:58:21PM +0100, Petr Mladek wrote: > > --- a/kernel/livepatch/core.c > > +++ b/kernel/livepatch/core.c > > @@ -54,9 +54,6 @@ static void klp_find_object_module(struct klp_object *obj) > > { > > struct module *mod; > > > > - if (!klp_is_module(obj)) > > - return; > > - > > We need to either update the function description or keep this check. > > I prefer to keep the check. The function does the right thing also > for the object "vmlinux". Also the livepatch code includes many > similar paranoid checks that makes the code less error prone > against any further changes. Well, the check is in the caller now where we have a conditional for it. So I'd be tempted to either update the comment, or just drop the patch.