From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BB66C433DB for ; Thu, 28 Jan 2021 20:05:21 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC98C6146D for ; Thu, 28 Jan 2021 20:05:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC98C6146D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43974 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l5DXb-0006TG-AN for qemu-devel@archiver.kernel.org; Thu, 28 Jan 2021 15:05:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55402) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l5DVB-0005Z0-8k for qemu-devel@nongnu.org; Thu, 28 Jan 2021 15:02:49 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:56709) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l5DV7-0006Wu-AY for qemu-devel@nongnu.org; Thu, 28 Jan 2021 15:02:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611864164; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2Yw+CxTJiwhviO2vWCtUF8T2PlqR8s06c7/qgVPsiU4=; b=goEQlGHYJaKfGgdq0AvzlqMV3IE2dI3FikMwp8bk3KZ65KryEywp4iXaztEZH15wqRdBOf IDmxQoOvbcEgltZ6IvfJysrtSs0K/+I3QziXj9/ApfkgCVdlRAUjkkvyyusaq7pP0zHZMJ TVoN8Qz4gUlxHwcYzUfcei6bODZY5s0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-175-VHC5ONVENnWCf8m1qw9T-A-1; Thu, 28 Jan 2021 15:02:42 -0500 X-MC-Unique: VHC5ONVENnWCf8m1qw9T-A-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7805C107ACE4; Thu, 28 Jan 2021 20:02:40 +0000 (UTC) Received: from work-vm (ovpn-115-60.ams2.redhat.com [10.36.115.60]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 79DEE5D9F4; Thu, 28 Jan 2021 20:02:25 +0000 (UTC) Date: Thu, 28 Jan 2021 20:02:23 +0000 From: "Dr. David Alan Gilbert" To: Paolo Bonzini Subject: Re: [PATCH] vfio/migrate: Move switch of dirty tracking into vfio_memory_listener Message-ID: <20210128200223.GJ2951@work-vm> References: <20210111073439.20236-1-zhukeqian1@huawei.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dgilbert@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.252, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Andrew Jones , Eduardo Habkost , Keqian Zhu , jiangkunkun@huawei.com, Alex Williamson , Peter Xu , qemu-devel@nongnu.org, Kirti Wankhede , qemu-arm@nongnu.org, Stefan Hajnoczi , wanghaibin.wang@huawei.com, Zenghui Yu , Igor Mammedov , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Paolo Bonzini (pbonzini@redhat.com) wrote: > On 11/01/21 08:34, Keqian Zhu wrote: > > +static void vfio_listener_log_start(MemoryListener *listener, > > + MemoryRegionSection *section, > > + int old, int new) > > +{ > > + VFIOContainer *container = container_of(listener, VFIOContainer, listener); > > + > > + vfio_set_dirty_page_tracking(container, true); > > +} > > + > > +static void vfio_listener_log_stop(MemoryListener *listener, > > + MemoryRegionSection *section, > > + int old, int new) > > +{ > > + VFIOContainer *container = container_of(listener, VFIOContainer, listener); > > + > > + vfio_set_dirty_page_tracking(container, false); > > +} > > + > > This would enable dirty page tracking also just for having a framebuffer > (DIRTY_MEMORY_VGA). Technically it would be correct, but it would also be > more heavyweight than expected. Wouldn't that only happen on emulated video devices? > In order to only cover live migration, you can use the log_global_start and > log_global_stop callbacks instead. > > If you want to use log_start and log_stop, you need to add respectively > > if (old != 0) { > return; > } > > and > > if (new != 0) { > return; > } Why 0, wouldn't you be checking for DIRTY_LOG_MIGRATION somewhere? Dave > before the calls to vfio_set_dirty_page_tracking. But I think it's more > appropriate for VFIO to use log_global_*. > > Thanks, > > Paolo > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK