All of lore.kernel.org
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Stefan Berger <stefanb@linux.vnet.ibm.com>
Cc: keyrings@vger.kernel.org, linux-crypto@vger.kernel.org,
	linux-kernel@vger.kernel.org, patrick@puiterwijk.org,
	linux-integrity@vger.kernel.org,
	Stefan Berger <stefanb@linux.ibm.com>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v5 1/4] crypto: Add support for ECDSA signature verification
Date: Sat, 30 Jan 2021 06:44:07 +1100	[thread overview]
Message-ID: <20210129194407.GA24780@gondor.apana.org.au> (raw)
In-Reply-To: <20210129150355.850093-2-stefanb@linux.vnet.ibm.com>

On Fri, Jan 29, 2021 at 10:03:52AM -0500, Stefan Berger wrote:
>
> +		.cra_name = "ecdsa-nist-p256",
> +		.cra_driver_name = "ecdsa-nist-p256",

The driver name should have a "-generic" suffix in case a driver
provides this algorithm too.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

       reply	other threads:[~2021-01-29 19:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210129155529.brxbmgzzosvtwrzw@altlinux.org>
     [not found] ` <20210129150355.850093-1-stefanb@linux.vnet.ibm.com>
     [not found]   ` <20210129150355.850093-2-stefanb@linux.vnet.ibm.com>
2021-01-29 19:44     ` Herbert Xu [this message]
     [not found]   ` <20210129150355.850093-5-stefanb@linux.vnet.ibm.com>
2021-02-01 13:19     ` [PATCH v5 4/4] ima: Support EC keys for signature verification David Howells
2021-02-01 13:23   ` [PATCH v5 2/4] x509: Detect sm2 keys by their parameters OID David Howells
2021-02-01 14:35     ` Stefan Berger
2021-02-01 14:54       ` Mimi Zohar
2021-02-01 15:07       ` David Howells
2021-02-02  3:56         ` Herbert Xu
2021-02-02  8:27         ` David Howells
2021-02-02  8:55           ` Herbert Xu
2021-02-02  9:33           ` David Howells
2021-02-02  9:42             ` Herbert Xu
2021-02-02 10:16             ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210129194407.GA24780@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=davem@davemloft.net \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patrick@puiterwijk.org \
    --cc=stefanb@linux.ibm.com \
    --cc=stefanb@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.