From: Vladimir Oltean <olteanv@gmail.com>
To: Prasanna Vengateshan <prasanna.vengateshan@microchip.com>
Cc: andrew@lunn.ch, netdev@vger.kernel.org, robh+dt@kernel.org,
kuba@kernel.org, vivien.didelot@gmail.com, f.fainelli@gmail.com,
davem@davemloft.net, UNGLinuxDriver@microchip.com,
Woojung.Huh@microchip.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH net-next 1/8] dt-bindings: net: dsa: dt bindings for microchip lan937x
Date: Sat, 30 Jan 2021 04:02:27 +0200 [thread overview]
Message-ID: <20210130020227.ahiee4goetpp2hb7@skbuf> (raw)
In-Reply-To: <20210128064112.372883-2-prasanna.vengateshan@microchip.com>
On Thu, Jan 28, 2021 at 12:11:05PM +0530, Prasanna Vengateshan wrote:
> + spi-max-frequency:
> + maximum: 50000000
And it actually works at 50 MHz? Cool.
> +
> + reset-gpios:
> + description: Optional gpio specifier for a reset line
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + //Ethernet switch connected via spi to the host, CPU port wired to eth1
> + eth1 {
So if you do bother to add the DSA master in the example, can this be
ð1 so that we could associate with the phandle below?
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + fixed-link {
> + speed = <1000>;
> + full-duplex;
> + };
> + };
> +
> + spi1 {
Is this a label or a node name? spi1 or spi@1?
> + #address-cells = <1>;
> + #size-cells = <0>;
> + pinctrl-0 = <&pinctrl_spi_ksz>;
> + cs-gpios = <0>, <0>, <0>, <&pioC 28 0>;
> + id = <1>;
I know this is the SPI controller and thus mostly irrelevant, but what
is "id = <1>"?
> +
> + lan9374: switch@0 {
> + compatible = "microchip,lan9374";
> + reg = <0>;
> +
> + spi-max-frequency = <44000000>;
> +
> + ethernet-ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + port@0 {
> + reg = <0>;
> + label = "lan1";
> + };
> + port@1 {
> + reg = <1>;
> + label = "lan2";
> + };
> + port@2 {
> + reg = <7>;
reg should match node index (port@2), here and everywhere below. As for
the net device labels, I'm not sure if the mismatch is deliberate there.
> + label = "lan3";
> + };
> + port@3 {
> + reg = <2>;
> + label = "lan4";
> + };
> + port@4 {
> + reg = <6>;
> + label = "lan5";
> + };
> + port@5 {
> + reg = <3>;
> + label = "lan6";
> + };
> + port@6 {
> + reg = <4>;
> + label = "cpu";
label for CPU port is not needed/used.
> + ethernet = <ð1>;
> + fixed-link {
> + speed = <1000>;
> + full-duplex;
> + };
> + };
> + port@7 {
> + reg = <5>;
> + label = "lan7";
> + fixed-link {
> + speed = <1000>;
> + full-duplex;
> + };
> + };
> + };
> + };
> + };
next prev parent reply other threads:[~2021-01-30 2:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 6:41 [PATCH net-next 0/8] net: dsa: microchip: DSA driver support for LAN937x switch Prasanna Vengateshan
2021-01-28 6:41 ` [PATCH net-next 1/8] dt-bindings: net: dsa: dt bindings for microchip lan937x Prasanna Vengateshan
2021-01-30 2:02 ` Vladimir Oltean [this message]
2021-02-10 11:46 ` Prasanna Vengateshan Varadharajan
2021-02-10 18:57 ` Andrew Lunn
2021-02-09 19:35 ` Rob Herring
2021-01-28 6:41 ` [PATCH net-next 2/8] net: dsa: tag_ksz: add tag handling for Microchip LAN937x Prasanna Vengateshan
2021-01-28 18:03 ` Andrew Lunn
2021-01-30 2:27 ` Vladimir Oltean
2021-02-10 11:55 ` Prasanna Vengateshan Varadharajan
2021-01-28 6:41 ` [PATCH net-next 3/8] net: dsa: microchip: add DSA support for microchip lan937x Prasanna Vengateshan
2021-01-29 1:07 ` Andrew Lunn
2021-02-05 12:48 ` Prasanna Vengateshan Varadharajan
2021-02-05 13:27 ` Andrew Lunn
2021-03-15 6:25 ` Prasanna Vengateshan Varadharajan
2021-01-28 6:41 ` [PATCH net-next 4/8] net: dsa: microchip: add support for phylink management Prasanna Vengateshan
2021-01-29 1:12 ` Andrew Lunn
2021-01-28 6:41 ` [PATCH net-next 5/8] net: dsa: microchip: add support for ethtool port counters Prasanna Vengateshan
2021-01-28 6:41 ` [PATCH net-next 6/8] net: dsa: microchip: add support for port mirror operations Prasanna Vengateshan
2021-01-28 6:41 ` [PATCH net-next 7/8] net: dsa: microchip: add support for fdb and mdb management Prasanna Vengateshan
2021-01-28 6:41 ` [PATCH net-next 8/8] net: dsa: microchip: add support for vlan operations Prasanna Vengateshan
2021-01-28 17:55 ` [PATCH net-next 0/8] net: dsa: microchip: DSA driver support for LAN937x switch Florian Fainelli
2021-01-30 2:09 ` Vladimir Oltean
2021-02-02 1:25 ` Woojung.Huh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210130020227.ahiee4goetpp2hb7@skbuf \
--to=olteanv@gmail.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=Woojung.Huh@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=prasanna.vengateshan@microchip.com \
--cc=robh+dt@kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.