From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,BIGNUM_EMAILS, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC310C433DB for ; Mon, 1 Feb 2021 12:10:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B085364E8F for ; Mon, 1 Feb 2021 12:10:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231310AbhBAMJ6 (ORCPT ); Mon, 1 Feb 2021 07:09:58 -0500 Received: from relay2.uni-heidelberg.de ([129.206.119.212]:12334 "EHLO relay2.uni-heidelberg.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231222AbhBAMJq (ORCPT ); Mon, 1 Feb 2021 07:09:46 -0500 X-IPAS-Result: =?us-ascii?q?A2BOAAAA7xdg/1BqzoFiHAEBAQEBAQcBARIBAQQEAQFAg?= =?us-ascii?q?TwGAQELAYMLa2eDekaRWY9gimcUgXMBAQEBAQEBAQEJLAECBAEBhkQCJTUID?= =?us-ascii?q?gIDAQEBAwIDAQEBAQYBAQEBAQYEhl+FdAEFIzAmEAsYAgImAgIUKCEThi2wS?= =?us-ascii?q?oEyiRmBISOBDioBjWMPgU0/hCo+hAkBEgGDOjSCLASCRoEPgQNtFYEbjy4Jp?= =?us-ascii?q?n+BWywHgWiBEYEdC5pGAg0igy+KPYU5j26XRp50gVgBgR5wMxokgzhQGQ2ca?= =?us-ascii?q?0MwAjUCBgoBAQMJWQEBizoBAQ?= X-IronPort-Anti-Spam-Filtered: true Received: from lemon.iwr.uni-heidelberg.de ([129.206.106.80]) by relay2.uni-heidelberg.de with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 01 Feb 2021 13:08:16 +0100 Received: from hlauer by lemon.iwr.uni-heidelberg.de with local (Exim 4.92) (envelope-from ) id 1l6Xzv-00045i-Ei; Mon, 01 Feb 2021 13:08:03 +0100 Date: Mon, 1 Feb 2021 13:08:03 +0100 From: Hermann Lauer To: Maxime Ripard Cc: linux-arm-kernel@lists.infradead.org, wens@csie.org, jernej.skrabec@siol.net, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: Re: [PATCH v4] ARM: dts: sun7i: a20: bananapro: Fix ethernet phy-mode Message-ID: <20210201120803.GF15207@lemon.iwr.uni-heidelberg.de> References: <20210121170836.GA4948@lemon.iwr.uni-heidelberg.de> <20210128094040.GD11559@lemon.iwr.uni-heidelberg.de> <20210128111842.GA11919@lemon.iwr.uni-heidelberg.de> <20210128145937.vtdi4e2aih7milmt@gilmour> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210128145937.vtdi4e2aih7milmt@gilmour> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 28, 2021 at 03:59:37PM +0100, Maxime Ripard wrote: > On Thu, Jan 28, 2021 at 12:18:42PM +0100, Hermann.Lauer@uni-heidelberg.de wrote: > > BPi Pro needs TX and RX delay for Gbit to work reliable and avoid high > > packet loss rates. The realtek phy driver overrides the settings of the > > pull ups for the delays, so fix this for BananaPro. > > > > Fix the phy-mode description to correctly reflect this so that the > > implementation doesn't reconfigure the delays incorrectly. This > > happened with commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e > > rx/tx delay config"). > > > > Fixes: 10662a33dcd9 ("ARM: dts: sun7i: Add dts file for Bananapro board") > > Signed-off-by: Hermann Lauer > > Applied since it's a fix simple enough, but please provide a changelog > between versions. v3 added the correct fixes tag, where the problem originated (initial commit of banana pro device tree). That worked in the past until a change in the phy device driver for realtek phy on banana pro overrode the phyical configuration of the hardware pull-ups. v4 added the commit which implemented that driver change (shamelessly stolen from the commit of the fix of the identical problem on the banana pi) Thanks, greetings Hermann -- Administration/Zentrale Dienste, Interdiziplinaeres Zentrum fuer wissenschaftliches Rechnen der Universitaet Heidelberg IWR; INF 205; 69120 Heidelberg; Tel: (06221)54-14405 Fax: -14427 Email: Hermann.Lauer@iwr.uni-heidelberg.de From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,BIGNUM_EMAILS, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F30E9C433DB for ; Mon, 1 Feb 2021 12:11:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BB73561477 for ; Mon, 1 Feb 2021 12:11:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB73561477 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=iwr.uni-heidelberg.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1Mu4M0a+WsLLDkOZAgTXdRQJaq2wqJt/pjs1Df52cOg=; b=Xxiycg8Dg0IQK/NXbuJKpBByc hriWbfS+1RPmqxV+QJc+30rFYVIxq5vTBgMT1dwbanjvRY2sQHg3l21214U6nM0x4rMDJx7z71ZIR djTbUxCzlb3gwqgM0G+I6evaBNzMpsPaT10cAsrjeCQW+BCyR4aP6IxJJpE37wetMu/AB+dX+aDXk XVpJYddLZocDsJf1efU1mmf62Oa18IjC0Q3KT9yxo5ApPDVE2zBnmaDoV6qf0CJMnBRYBarQ1n1G0 O8jd9aeBOnv6JndFowXF3+7jj30TbUGOKWe3DhY8we1OC8FXKDKNLCRErayx9aQeoQ4JlPZfXB/mO h5c6PH22Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6Y1J-0000CG-Mt; Mon, 01 Feb 2021 12:09:29 +0000 Received: from relay2.uni-heidelberg.de ([129.206.119.212]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6Y15-0008UG-GX for linux-arm-kernel@lists.infradead.org; Mon, 01 Feb 2021 12:09:26 +0000 X-IPAS-Result: =?us-ascii?q?A2BOAAAA7xdg/1BqzoFiHAEBAQEBAQcBARIBAQQEAQFAg?= =?us-ascii?q?TwGAQELAYMLa2eDekaRWY9gimcUgXMBAQEBAQEBAQEJLAECBAEBhkQCJTUID?= =?us-ascii?q?gIDAQEBAwIDAQEBAQYBAQEBAQYEhl+FdAEFIzAmEAsYAgImAgIUKCEThi2wS?= =?us-ascii?q?oEyiRmBISOBDioBjWMPgU0/hCo+hAkBEgGDOjSCLASCRoEPgQNtFYEbjy4Jp?= =?us-ascii?q?n+BWywHgWiBEYEdC5pGAg0igy+KPYU5j26XRp50gVgBgR5wMxokgzhQGQ2ca?= =?us-ascii?q?0MwAjUCBgoBAQMJWQEBizoBAQ?= X-IronPort-Anti-Spam-Filtered: true Received: from lemon.iwr.uni-heidelberg.de ([129.206.106.80]) by relay2.uni-heidelberg.de with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 01 Feb 2021 13:08:16 +0100 Received: from hlauer by lemon.iwr.uni-heidelberg.de with local (Exim 4.92) (envelope-from ) id 1l6Xzv-00045i-Ei; Mon, 01 Feb 2021 13:08:03 +0100 Date: Mon, 1 Feb 2021 13:08:03 +0100 From: Hermann Lauer To: Maxime Ripard Subject: Re: Re: [PATCH v4] ARM: dts: sun7i: a20: bananapro: Fix ethernet phy-mode Message-ID: <20210201120803.GF15207@lemon.iwr.uni-heidelberg.de> References: <20210121170836.GA4948@lemon.iwr.uni-heidelberg.de> <20210128094040.GD11559@lemon.iwr.uni-heidelberg.de> <20210128111842.GA11919@lemon.iwr.uni-heidelberg.de> <20210128145937.vtdi4e2aih7milmt@gilmour> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210128145937.vtdi4e2aih7milmt@gilmour> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210201_070915_840814_8EF844AF X-CRM114-Status: GOOD ( 15.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, jernej.skrabec@siol.net, linux-kernel@vger.kernel.org, wens@csie.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 28, 2021 at 03:59:37PM +0100, Maxime Ripard wrote: > On Thu, Jan 28, 2021 at 12:18:42PM +0100, Hermann.Lauer@uni-heidelberg.de wrote: > > BPi Pro needs TX and RX delay for Gbit to work reliable and avoid high > > packet loss rates. The realtek phy driver overrides the settings of the > > pull ups for the delays, so fix this for BananaPro. > > > > Fix the phy-mode description to correctly reflect this so that the > > implementation doesn't reconfigure the delays incorrectly. This > > happened with commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e > > rx/tx delay config"). > > > > Fixes: 10662a33dcd9 ("ARM: dts: sun7i: Add dts file for Bananapro board") > > Signed-off-by: Hermann Lauer > > Applied since it's a fix simple enough, but please provide a changelog > between versions. v3 added the correct fixes tag, where the problem originated (initial commit of banana pro device tree). That worked in the past until a change in the phy device driver for realtek phy on banana pro overrode the phyical configuration of the hardware pull-ups. v4 added the commit which implemented that driver change (shamelessly stolen from the commit of the fix of the identical problem on the banana pi) Thanks, greetings Hermann -- Administration/Zentrale Dienste, Interdiziplinaeres Zentrum fuer wissenschaftliches Rechnen der Universitaet Heidelberg IWR; INF 205; 69120 Heidelberg; Tel: (06221)54-14405 Fax: -14427 Email: Hermann.Lauer@iwr.uni-heidelberg.de _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel