From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B18DFC433E0 for ; Mon, 1 Feb 2021 22:45:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8370664EAA for ; Mon, 1 Feb 2021 22:45:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230111AbhBAWow (ORCPT ); Mon, 1 Feb 2021 17:44:52 -0500 Received: from mail.kernel.org ([198.145.29.99]:60984 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229525AbhBAWot (ORCPT ); Mon, 1 Feb 2021 17:44:49 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2619D64ECC; Mon, 1 Feb 2021 22:44:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1612219448; bh=bY5TMOz0te68qLVeDd3OlEIhLNM0l3Gtrel8LOEYnS0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Hhq7UvD4wMRGOAqhcU/qsOVoDxHKVK4v+m5plQ3IOEyAVCqYZWoarIQ61bAGp2NDW AMCIZRU6gRuxKGLC0odOIFPLShjvVOdNBD1kgPCNR7otmV3AUuvuYF0ewt3n2llhfd KgyxYOikqbFtLbW479v5j5+9fDNqLOIzANLFubQE= Date: Mon, 1 Feb 2021 14:44:07 -0800 From: Andrew Morton To: Andrey Konovalov Cc: Catalin Marinas , Vincenzo Frascino , Dmitry Vyukov , Alexander Potapenko , Marco Elver , Will Deacon , Andrey Ryabinin , Peter Collingbourne , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 10/12] arm64: kasan: simplify and inline MTE functions Message-Id: <20210201144407.dd603ec4edcd589643654057@linux-foundation.org> In-Reply-To: <17d6bef698d193f5fe0d8baee0e232a351e23a32.1612208222.git.andreyknvl@google.com> References: <17d6bef698d193f5fe0d8baee0e232a351e23a32.1612208222.git.andreyknvl@google.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 1 Feb 2021 20:43:34 +0100 Andrey Konovalov wrote: > This change provides a simpler implementation of mte_get_mem_tag(), > mte_get_random_tag(), and mte_set_mem_tag_range(). > > Simplifications include removing system_supports_mte() checks as these > functions are onlye called from KASAN runtime that had already checked > system_supports_mte(). Besides that, size and address alignment checks > are removed from mte_set_mem_tag_range(), as KASAN now does those. > > This change also moves these functions into the asm/mte-kasan.h header > and implements mte_set_mem_tag_range() via inline assembly to avoid > unnecessary functions calls. > > Co-developed-by: Vincenzo Frascino > Signed-off-by: Andrey Konovalov Co-developed-by requires a Signed-off-by: as well. Vincenzo, please send us one? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD757C433E0 for ; Mon, 1 Feb 2021 22:45:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 98AF964EAA for ; Mon, 1 Feb 2021 22:45:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 98AF964EAA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To:Message-Id: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=C8+F4kjYaUraajvadVsaKknfYEFRpDFWfo9kVJDlP/Y=; b=wOLvkRGO6C/cBsDLhLuCoTAty xvfr/tSFgjkYK6/8of3b+Ymw1XKYV/SNAhSY3AtK0pPg7Hvo8AHTfhsjGqtGBm0fIK7EB2kVA6QNw Rkqc5AqFz3jpW2gW6sgnUakN1vST5SofmXkoG4xPYFezQntl7kDX3HU6/KxqQbWbwu61xiPeJFabp ZAad86zQbBViMNYMQDqK8TUsPDcy5DNdq2VstDhaYsLqw+dp+IBRpScRlN9A91qEQfq4Bje4FOkMq I803aIJQqnkPLHAFMylV52IW6Im3u94gg47v47AtpnhqMClH9o85pJaK4mlHZCwqEdQqDiDgwEO8j n/M0iukOA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6hvZ-0007ev-Gl; Mon, 01 Feb 2021 22:44:13 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6hvW-0007eC-GZ for linux-arm-kernel@lists.infradead.org; Mon, 01 Feb 2021 22:44:12 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2619D64ECC; Mon, 1 Feb 2021 22:44:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1612219448; bh=bY5TMOz0te68qLVeDd3OlEIhLNM0l3Gtrel8LOEYnS0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Hhq7UvD4wMRGOAqhcU/qsOVoDxHKVK4v+m5plQ3IOEyAVCqYZWoarIQ61bAGp2NDW AMCIZRU6gRuxKGLC0odOIFPLShjvVOdNBD1kgPCNR7otmV3AUuvuYF0ewt3n2llhfd KgyxYOikqbFtLbW479v5j5+9fDNqLOIzANLFubQE= Date: Mon, 1 Feb 2021 14:44:07 -0800 From: Andrew Morton To: Andrey Konovalov Subject: Re: [PATCH 10/12] arm64: kasan: simplify and inline MTE functions Message-Id: <20210201144407.dd603ec4edcd589643654057@linux-foundation.org> In-Reply-To: <17d6bef698d193f5fe0d8baee0e232a351e23a32.1612208222.git.andreyknvl@google.com> References: <17d6bef698d193f5fe0d8baee0e232a351e23a32.1612208222.git.andreyknvl@google.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210201_174411_368677_0D7B65F3 X-CRM114-Status: GOOD ( 11.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Marco Elver , Catalin Marinas , Kevin Brodsky , Will Deacon , Branislav Rankov , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alexander Potapenko , Evgenii Stepanov , Andrey Ryabinin , Vincenzo Frascino , Peter Collingbourne , Dmitry Vyukov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 1 Feb 2021 20:43:34 +0100 Andrey Konovalov wrote: > This change provides a simpler implementation of mte_get_mem_tag(), > mte_get_random_tag(), and mte_set_mem_tag_range(). > > Simplifications include removing system_supports_mte() checks as these > functions are onlye called from KASAN runtime that had already checked > system_supports_mte(). Besides that, size and address alignment checks > are removed from mte_set_mem_tag_range(), as KASAN now does those. > > This change also moves these functions into the asm/mte-kasan.h header > and implements mte_set_mem_tag_range() via inline assembly to avoid > unnecessary functions calls. > > Co-developed-by: Vincenzo Frascino > Signed-off-by: Andrey Konovalov Co-developed-by requires a Signed-off-by: as well. Vincenzo, please send us one? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel