From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75997C433E0 for ; Mon, 1 Feb 2021 16:15:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 17B0A64E2B for ; Mon, 1 Feb 2021 16:15:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 17B0A64E2B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48662 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l6bqw-000370-5k for qemu-devel@archiver.kernel.org; Mon, 01 Feb 2021 11:15:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47826) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6bq1-0002B3-Jp for qemu-devel@nongnu.org; Mon, 01 Feb 2021 11:14:06 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:26039) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l6bpz-0002bX-G5 for qemu-devel@nongnu.org; Mon, 01 Feb 2021 11:14:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612196042; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2K7vj447FIzZIHeLCGi7Kd1DSaJbEh+E++itykmsnlQ=; b=O1/+kjiHfkUkDQifFlZNEvng2Df3GDgFvo7t+M/+I6X4Edp3bUkHunvDJ6Nen0S1bOSJxz BUWCIzg6Yq8shNjnudKtZULynQSGP41wzBTrRDfWer4W5IHuy71rNuWikS6FKYSJz2olLK h4ETLol5nbnYZJvtuOOMjY/sskSNoBg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-480-B8oxTTeTP52OKwxU8FFoXw-1; Mon, 01 Feb 2021 11:14:00 -0500 X-MC-Unique: B8oxTTeTP52OKwxU8FFoXw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CE8C9800D55; Mon, 1 Feb 2021 16:13:58 +0000 (UTC) Received: from merkur.fritz.box (ovpn-112-72.ams2.redhat.com [10.36.112.72]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DC3CF5D6BA; Mon, 1 Feb 2021 16:13:53 +0000 (UTC) Date: Mon, 1 Feb 2021 17:13:52 +0100 From: Kevin Wolf To: BALATON Zoltan Subject: Re: [PULL 10/11] trace: document how to specify multiple --trace patterns Message-ID: <20210201161352.GH13157@merkur.fritz.box> References: <20210201154703.180022-1-stefanha@redhat.com> <20210201154703.180022-11-stefanha@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kwolf@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.351, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Eduardo Habkost , qemu-block@nongnu.org, Markus Armbruster , qemu-devel@nongnu.org, Stefan Hajnoczi , Cleber Rosa , Paolo Bonzini , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 01.02.2021 um 17:05 hat BALATON Zoltan geschrieben: > On Mon, 1 Feb 2021, Stefan Hajnoczi wrote: > > It is possible to repeat the --trace option to specify multiple > > patterns. This may be preferrable to users who do not want to create a > > file with a list of patterns. > > > > Suggested-by: BALATON Zoltan > > Signed-off-by: Stefan Hajnoczi > > Reviewed-by: Philippe Mathieu-Daudé > > Message-id: 20210112165859.225534-2-stefanha@redhat.com > > Signed-off-by: Stefan Hajnoczi > > --- > > docs/devel/tracing.rst | 9 +++++++-- > > 1 file changed, 7 insertions(+), 2 deletions(-) > > > > diff --git a/docs/devel/tracing.rst b/docs/devel/tracing.rst > > index af395e957d..e8f9b82c5e 100644 > > --- a/docs/devel/tracing.rst > > +++ b/docs/devel/tracing.rst > > @@ -22,10 +22,15 @@ events:: > > This output comes from the "log" trace backend that is enabled by default when > > ``./configure --enable-trace-backends=BACKENDS`` was not explicitly specified. > > > > -More than one trace event pattern can be specified by providing a file > > -instead:: > > +Multiple patterns can be specified by repeating the ``--trace`` option:: > > + > > + $ qemu --trace "kvm_*" --trace "virtio_*" ... > > Does that actually work? I've always used -trace enable="pattern1" -trace > enable="pattern2" Not sure if omitting enable= is the same. qemu_trace_opts has .implied_opt_name = "enable", so without having tested it, I assume this works. Kevin