From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32E9EC43381 for ; Mon, 1 Feb 2021 16:38:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DF07C60235 for ; Mon, 1 Feb 2021 16:38:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231191AbhBAQix (ORCPT ); Mon, 1 Feb 2021 11:38:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229866AbhBAQit (ORCPT ); Mon, 1 Feb 2021 11:38:49 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0151C061573 for ; Mon, 1 Feb 2021 08:37:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=DiYAma/MBy6d/6tlWAVVUX9ISv3Qk+f30UuNARw1WNs=; b=fvEQCjgvdCcZe8Xne0Rfl02dV MvST6TvtR+1gQxy0FPmQi99pVXI//4AtDNmaKJl+5zDQt12hpXfY4qT4JarsgVtZtFpb6ytMMTRcS bxpZpuaBy4n9eOqVQU/3D3ODef721+pW2ovO3gNA6i7VYICbTK5MzC+nH+76vpcM2SVR4ujpbLII8 3vpUnpt6bMuXpyN13XRqdjBqwLpTo1loOaDzoBJHQbkOQgtlhQUkW5fn65yVHNyNbtcoDDp5aFdyE s0G7sHLFK+xi8IlXevRPfNPS9aVZhxUo2W2igmToHkHsB87a3TERJLmOY1N3kakEl3HNkQtrcQRHe dyE0mUAZA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:37818) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l6cD1-0003VV-RR; Mon, 01 Feb 2021 16:37:51 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1l6cD0-0002A0-U9; Mon, 01 Feb 2021 16:37:50 +0000 Date: Mon, 1 Feb 2021 16:37:50 +0000 From: Russell King - ARM Linux admin To: Mark Rutland Cc: Giancarlo Ferrari , linux-kernel@vger.kernel.org, penberg@kernel.org, geert@linux-m68k.org, linux-arm-kernel@lists.infradead.org, akpm@linux-foundation.org, rppt@kernel.org, giancarlo.ferrari@nokia.com Subject: Re: [PATCH] ARM: kexec: Fix panic after TLB are invalidated Message-ID: <20210201163750.GI1463@shell.armlinux.org.uk> References: <1612140296-12546-1-git-send-email-giancarlo.ferrari89@gmail.com> <20210201124720.GA66060@C02TD0UTHF1T.local> <20210201130344.GF1463@shell.armlinux.org.uk> <20210201135714.GB66060@C02TD0UTHF1T.local> <20210201160838.GH1463@shell.armlinux.org.uk> <20210201163240.GE66060@C02TD0UTHF1T.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210201163240.GE66060@C02TD0UTHF1T.local> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King - ARM Linux admin Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 01, 2021 at 04:32:40PM +0000, Mark Rutland wrote: > I reckon here we need: > > __cpuc_flush_dcache_area(reboot_code_buffer, > relocate_new_kernel_size + sizeof(*data)); > > ... to make sure both the instructions and data are visible with the MMU > off (since fncpy() only cleans to the PoU, not the PoC). We don't. When soft_restart() turns the MMU off, and it calls flush_cache_all() before and afterwards to ensure that all dirty lines are pushed out. The flushing to PoU in fncpy() is to cover other cases. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C012CC433DB for ; Mon, 1 Feb 2021 16:39:10 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6089964EA3 for ; Mon, 1 Feb 2021 16:39:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6089964EA3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JJjWLZ4tWMRCCxU4nNjgbVS/NIQ4uXNokLyq/+Ogp5I=; b=2xQ7Z12+u000/B5e3qjqldLnd aQEQzehDs8WZe4EXrK22HYw+/UXXxQGSphYzBOKmlFGgp9yX0PTWzEuwl3RUBb9ejpl5pGZBYTlM3 zB9biDYHhXB49VBCbpqAlLPzOLdGevTIIPGf9vDrf2I95LgRLBlFXdg+K27unFL6gv27SQX66iMM2 PcfyDr4Z72jRQYRCBIviKfhGz5dIUqdq0KChkVmaTeZTtF0KtOPo0HFnLq9zcgoKDEoUDTCD4lKAs Aag4n74y4N+lKa93U1SMNflyUEK6gaFaSO0n1AgLLhY+0k/rGhcqkJ/7X8CkmyYfSbOR60T49lTu4 JnGn1Yi3g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6cD8-00023y-7u; Mon, 01 Feb 2021 16:37:58 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6cD5-00023W-AH for linux-arm-kernel@lists.infradead.org; Mon, 01 Feb 2021 16:37:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=DiYAma/MBy6d/6tlWAVVUX9ISv3Qk+f30UuNARw1WNs=; b=fvEQCjgvdCcZe8Xne0Rfl02dV MvST6TvtR+1gQxy0FPmQi99pVXI//4AtDNmaKJl+5zDQt12hpXfY4qT4JarsgVtZtFpb6ytMMTRcS bxpZpuaBy4n9eOqVQU/3D3ODef721+pW2ovO3gNA6i7VYICbTK5MzC+nH+76vpcM2SVR4ujpbLII8 3vpUnpt6bMuXpyN13XRqdjBqwLpTo1loOaDzoBJHQbkOQgtlhQUkW5fn65yVHNyNbtcoDDp5aFdyE s0G7sHLFK+xi8IlXevRPfNPS9aVZhxUo2W2igmToHkHsB87a3TERJLmOY1N3kakEl3HNkQtrcQRHe dyE0mUAZA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:37818) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l6cD1-0003VV-RR; Mon, 01 Feb 2021 16:37:51 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1l6cD0-0002A0-U9; Mon, 01 Feb 2021 16:37:50 +0000 Date: Mon, 1 Feb 2021 16:37:50 +0000 From: Russell King - ARM Linux admin To: Mark Rutland Subject: Re: [PATCH] ARM: kexec: Fix panic after TLB are invalidated Message-ID: <20210201163750.GI1463@shell.armlinux.org.uk> References: <1612140296-12546-1-git-send-email-giancarlo.ferrari89@gmail.com> <20210201124720.GA66060@C02TD0UTHF1T.local> <20210201130344.GF1463@shell.armlinux.org.uk> <20210201135714.GB66060@C02TD0UTHF1T.local> <20210201160838.GH1463@shell.armlinux.org.uk> <20210201163240.GE66060@C02TD0UTHF1T.local> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210201163240.GE66060@C02TD0UTHF1T.local> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210201_113755_428415_FA7F43F5 X-CRM114-Status: UNSURE ( 9.59 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, penberg@kernel.org, geert@linux-m68k.org, rppt@kernel.org, Giancarlo Ferrari , akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org, giancarlo.ferrari@nokia.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 01, 2021 at 04:32:40PM +0000, Mark Rutland wrote: > I reckon here we need: > > __cpuc_flush_dcache_area(reboot_code_buffer, > relocate_new_kernel_size + sizeof(*data)); > > ... to make sure both the instructions and data are visible with the MMU > off (since fncpy() only cleans to the PoU, not the PoC). We don't. When soft_restart() turns the MMU off, and it calls flush_cache_all() before and afterwards to ensure that all dirty lines are pushed out. The flushing to PoU in fncpy() is to cover other cases. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel