From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8050C433DB for ; Mon, 1 Feb 2021 17:32:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 88CD664EAA for ; Mon, 1 Feb 2021 17:32:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232149AbhBARci (ORCPT ); Mon, 1 Feb 2021 12:32:38 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:34875 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231929AbhBARad (ORCPT ); Mon, 1 Feb 2021 12:30:33 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 45B775C01A3; Mon, 1 Feb 2021 12:29:25 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Mon, 01 Feb 2021 12:29:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=1IUuUKCPAXxczZPng3dD+OMdufW kUYU8yPZFDLY8qxA=; b=nk9xxsmaDDQfr2BHNj30Wqc/Amyb2hDdxvLQgY865L5 WRWEwHYgTr4Gxq3zqoqdwUjKL/D5Q5Y37rGUAa+kCUog+zVAl+t6bOGsapwKb8dG 372/dP4yh/zlSn1wyOI1O5GjhWUFppnzBxc3rGrmBEbF9sZE1iSavrljtfQuVEvD 5GxQcbIz1N2ljxmlqeOMjq7RL7udQ8QE8RjmMRNY3D1KVNIqdWW7e8kCPsv/Fg/y RSyAbCBvqfZ8QyK+2mj2XUNPbQNb1CeSw57lVsTXSnu1V52bt8B+AhknogFRFV7j 1DFgIlj2O3reYO2kVsgSyDqRxm3ORqeOTfCQDiW06Cg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=1IUuUK CPAXxczZPng3dD+OMdufWkUYU8yPZFDLY8qxA=; b=M4Mf14ytHT8ThgDN2aJX8A qSqW27PP3IwZnIILo/mow7LmJd2t3VqifdcMxAr10iMZblyunuTVvta/KftcFYAv AnL6lOzOWNgOMeLeEILnN310W7vvNM+xrdPC3neFBAmHO2lFWz9xJgq6BoDpBAQp yjwViCqQ7RmiXVCAQRKJ/bJ9BuIIagTveeDx+Dq6uXXY6WT5sVqlc7GvOYp2NziM oBitYTalshMQ1oM9R8kAy6BS+6E19LvrAz+tSID/4Cc12dHnxgI+zszC2AOMIe6F P5LrijJuTU1D7W1pi4s2n8wXFF9wd5vNWisaQIVXbCVQ0CpAwaFuikrI+SulmoMg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfeekgddutdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id CD45024005A; Mon, 1 Feb 2021 12:29:23 -0500 (EST) Date: Mon, 1 Feb 2021 18:29:22 +0100 From: Maxime Ripard To: Hermann Lauer Cc: linux-arm-kernel@lists.infradead.org, wens@csie.org, jernej.skrabec@siol.net, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] ARM: dts: sun7i: a20: bananapro: Fix ethernet phy-mode Message-ID: <20210201172922.vnelblciqun46szk@gilmour> References: <20210121170836.GA4948@lemon.iwr.uni-heidelberg.de> <20210128094040.GD11559@lemon.iwr.uni-heidelberg.de> <20210128111842.GA11919@lemon.iwr.uni-heidelberg.de> <20210128145937.vtdi4e2aih7milmt@gilmour> <20210201120803.GF15207@lemon.iwr.uni-heidelberg.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zp4sfxddimiu2ffh" Content-Disposition: inline In-Reply-To: <20210201120803.GF15207@lemon.iwr.uni-heidelberg.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --zp4sfxddimiu2ffh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 01, 2021 at 01:08:03PM +0100, Hermann Lauer wrote: > On Thu, Jan 28, 2021 at 03:59:37PM +0100, Maxime Ripard wrote: > > On Thu, Jan 28, 2021 at 12:18:42PM +0100, Hermann.Lauer@uni-heidelberg.= de wrote: > > > BPi Pro needs TX and RX delay for Gbit to work reliable and avoid high > > > packet loss rates. The realtek phy driver overrides the settings of t= he > > > pull ups for the delays, so fix this for BananaPro. > > > =20 > > > Fix the phy-mode description to correctly reflect this so that the > > > implementation doesn't reconfigure the delays incorrectly. This > > > happened with commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e > > > rx/tx delay config"). > > >=20 > > > Fixes: 10662a33dcd9 ("ARM: dts: sun7i: Add dts file for Bananapro boa= rd") > > > Signed-off-by: Hermann Lauer > >=20 > > Applied since it's a fix simple enough, but please provide a changelog > > between versions. >=20 > v3 added the correct fixes tag, where the problem originated (initial com= mit > of banana pro device tree). That worked in the past until a change in > the phy device driver for realtek phy on banana pro overrode the > phyical configuration of the hardware pull-ups. >=20 > v4 added the commit which implemented that driver change (shamelessly sto= len > from the commit of the fix of the identical problem on the banana pi) Thanks :) For future patches make sure to have that description either in a cover letter or below the --- after your commit log Maxime --zp4sfxddimiu2ffh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYBg6cgAKCRDj7w1vZxhR xZh1AQCq36tZ5n4FdroUZgnTNa601zD0ugKC3008GoIsUQUJBAD/TFa/YIFAgisI zGDcarCcGZBBkXx/HEiCI1i0+wIGDQA= =gu8h -----END PGP SIGNATURE----- --zp4sfxddimiu2ffh-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF120C433E0 for ; Mon, 1 Feb 2021 17:30:50 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4DB4864EAA for ; Mon, 1 Feb 2021 17:30:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4DB4864EAA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pvLr3VgbeTKxQgfFaw1ci/5a6Rh8ugnpHMYVrETDNhU=; b=jB7FHaWGg8QRKAReoYA16RWnJ swBuAGrEqeVFt8Vb0qnC7aS4RO+8hMCe8usk9unpbhPi+tz7dLjmY0w6lyOEbMURIfa3T01uxD9Bp i+rbzNlHx9lShuxYaf/X68LGmYQD4mka/yxIxtmfy5Au7/KLJuBtgcW8bMNgyZ+t5ODvXxlkXzKL9 etsjkT6VYVEnqDtJv/tRAfpnNVsmWsw6tfzAPvx1uY4EWK5K3US/DbFMFmyyVuU7X889DrP28sh/m 7AVj6xrhI8fux2bGEVrUUUZS8DlY4v+stvrMNk90d/MQ7BOBQvmmhkt+M6+NYr+usWcDrWvhkfTce bCcc6OGNA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6d10-0006Ce-NN; Mon, 01 Feb 2021 17:29:30 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6d0y-0006Aq-04 for linux-arm-kernel@lists.infradead.org; Mon, 01 Feb 2021 17:29:29 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 45B775C01A3; Mon, 1 Feb 2021 12:29:25 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Mon, 01 Feb 2021 12:29:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=1IUuUKCPAXxczZPng3dD+OMdufW kUYU8yPZFDLY8qxA=; b=nk9xxsmaDDQfr2BHNj30Wqc/Amyb2hDdxvLQgY865L5 WRWEwHYgTr4Gxq3zqoqdwUjKL/D5Q5Y37rGUAa+kCUog+zVAl+t6bOGsapwKb8dG 372/dP4yh/zlSn1wyOI1O5GjhWUFppnzBxc3rGrmBEbF9sZE1iSavrljtfQuVEvD 5GxQcbIz1N2ljxmlqeOMjq7RL7udQ8QE8RjmMRNY3D1KVNIqdWW7e8kCPsv/Fg/y RSyAbCBvqfZ8QyK+2mj2XUNPbQNb1CeSw57lVsTXSnu1V52bt8B+AhknogFRFV7j 1DFgIlj2O3reYO2kVsgSyDqRxm3ORqeOTfCQDiW06Cg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=1IUuUK CPAXxczZPng3dD+OMdufWkUYU8yPZFDLY8qxA=; b=M4Mf14ytHT8ThgDN2aJX8A qSqW27PP3IwZnIILo/mow7LmJd2t3VqifdcMxAr10iMZblyunuTVvta/KftcFYAv AnL6lOzOWNgOMeLeEILnN310W7vvNM+xrdPC3neFBAmHO2lFWz9xJgq6BoDpBAQp yjwViCqQ7RmiXVCAQRKJ/bJ9BuIIagTveeDx+Dq6uXXY6WT5sVqlc7GvOYp2NziM oBitYTalshMQ1oM9R8kAy6BS+6E19LvrAz+tSID/4Cc12dHnxgI+zszC2AOMIe6F P5LrijJuTU1D7W1pi4s2n8wXFF9wd5vNWisaQIVXbCVQ0CpAwaFuikrI+SulmoMg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfeekgddutdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id CD45024005A; Mon, 1 Feb 2021 12:29:23 -0500 (EST) Date: Mon, 1 Feb 2021 18:29:22 +0100 From: Maxime Ripard To: Hermann Lauer Subject: Re: [PATCH v4] ARM: dts: sun7i: a20: bananapro: Fix ethernet phy-mode Message-ID: <20210201172922.vnelblciqun46szk@gilmour> References: <20210121170836.GA4948@lemon.iwr.uni-heidelberg.de> <20210128094040.GD11559@lemon.iwr.uni-heidelberg.de> <20210128111842.GA11919@lemon.iwr.uni-heidelberg.de> <20210128145937.vtdi4e2aih7milmt@gilmour> <20210201120803.GF15207@lemon.iwr.uni-heidelberg.de> MIME-Version: 1.0 In-Reply-To: <20210201120803.GF15207@lemon.iwr.uni-heidelberg.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210201_122928_275267_6DBBD13D X-CRM114-Status: GOOD ( 19.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, jernej.skrabec@siol.net, linux-kernel@vger.kernel.org, wens@csie.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============5975946020752352580==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5975946020752352580== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zp4sfxddimiu2ffh" Content-Disposition: inline --zp4sfxddimiu2ffh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 01, 2021 at 01:08:03PM +0100, Hermann Lauer wrote: > On Thu, Jan 28, 2021 at 03:59:37PM +0100, Maxime Ripard wrote: > > On Thu, Jan 28, 2021 at 12:18:42PM +0100, Hermann.Lauer@uni-heidelberg.= de wrote: > > > BPi Pro needs TX and RX delay for Gbit to work reliable and avoid high > > > packet loss rates. The realtek phy driver overrides the settings of t= he > > > pull ups for the delays, so fix this for BananaPro. > > > =20 > > > Fix the phy-mode description to correctly reflect this so that the > > > implementation doesn't reconfigure the delays incorrectly. This > > > happened with commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e > > > rx/tx delay config"). > > >=20 > > > Fixes: 10662a33dcd9 ("ARM: dts: sun7i: Add dts file for Bananapro boa= rd") > > > Signed-off-by: Hermann Lauer > >=20 > > Applied since it's a fix simple enough, but please provide a changelog > > between versions. >=20 > v3 added the correct fixes tag, where the problem originated (initial com= mit > of banana pro device tree). That worked in the past until a change in > the phy device driver for realtek phy on banana pro overrode the > phyical configuration of the hardware pull-ups. >=20 > v4 added the commit which implemented that driver change (shamelessly sto= len > from the commit of the fix of the identical problem on the banana pi) Thanks :) For future patches make sure to have that description either in a cover letter or below the --- after your commit log Maxime --zp4sfxddimiu2ffh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYBg6cgAKCRDj7w1vZxhR xZh1AQCq36tZ5n4FdroUZgnTNa601zD0ugKC3008GoIsUQUJBAD/TFa/YIFAgisI zGDcarCcGZBBkXx/HEiCI1i0+wIGDQA= =gu8h -----END PGP SIGNATURE----- --zp4sfxddimiu2ffh-- --===============5975946020752352580== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5975946020752352580==--