All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: jsnow@redhat.com, qemu-devel@nongnu.org, peterx@redhat.com
Subject: Re: [PATCH 3/3] qmp: Resume OOB-enabled monitor before processing the request
Date: Mon, 1 Feb 2021 19:02:29 +0100	[thread overview]
Message-ID: <20210201180229.GK13157@merkur.fritz.box> (raw)
In-Reply-To: <20210201161504.1976989-4-armbru@redhat.com>

Am 01.02.2021 um 17:15 hat Markus Armbruster geschrieben:
> monitor_qmp_dispatcher_co() needs to resume the monitor if
> handle_qmp_command() suspended it.  Two cases:
> 
> 1. OOB enabled: suspended if mon->qmp_requests has no more space
> 
> 2. OOB disabled: suspended always
> 
> We resume only after we processed the request.  Which can take a long
> time.
> 
> Resume the monitor right when the queue has space to keep the monitor
> available for out-of-band commands even in this corner case.
> 
> Leave the "OOB disabled" case alone.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

> +        /*
> +         * We need to resume the monitor if handle_qmp_command()
> +         * suspended it.  Two cases:
> +         * 1. OOB enabled: mon->qmp_requests has no more space
> +         *    Resume right away, so that OOB commands can get executed while
> +         *    this request is being processed.
> +         * 2. OOB disabled: always
> +         *    Resume only after we're done processing the request, 

This line has trailing whitespace.

With this fixed, the whole series is:
Reviewed-by: Kevin Wolf <kwolf@redhat.com>



  reply	other threads:[~2021-02-01 18:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-01 16:15 [PATCH 0/3] Maximize QMP availability for OOB commands Markus Armbruster
2021-02-01 16:15 ` [PATCH 1/3] qmp: Fix up comments after commit 9ce44e2ce2 Markus Armbruster
2021-02-01 16:15 ` [PATCH 2/3] qmp: Add more tracepoints Markus Armbruster
2021-02-01 16:15 ` [PATCH 3/3] qmp: Resume OOB-enabled monitor before processing the request Markus Armbruster
2021-02-01 18:02   ` Kevin Wolf [this message]
2021-02-02  7:38     ` Markus Armbruster
2021-02-01 16:27 ` [PATCH 0/3] Maximize QMP availability for OOB commands no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210201180229.GK13157@merkur.fritz.box \
    --to=kwolf@redhat.com \
    --cc=armbru@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.