From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4477C433DB for ; Mon, 1 Feb 2021 19:15:09 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 698BD64DA8 for ; Mon, 1 Feb 2021 19:15:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 698BD64DA8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F2FD16E868; Mon, 1 Feb 2021 19:15:08 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 149A06E868 for ; Mon, 1 Feb 2021 19:15:08 +0000 (UTC) IronPort-SDR: UOFT/swmVrxwYN+ictpZDZfgukkVS+7SJYGkvtKucs5Y2JLVPBPsgIaPxXbsooqelkTjp1VDxG LNZyuiPJ8CBw== X-IronPort-AV: E=McAfee;i="6000,8403,9882"; a="180882047" X-IronPort-AV: E=Sophos;i="5.79,393,1602572400"; d="scan'208";a="180882047" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2021 11:15:06 -0800 IronPort-SDR: kVVpeHaKAnnpkUWIxQtDSOWUzlzmsXJ9VvqgbFkXtJNJ3fE9LwrVVCewuCbk50cqMgUGE/YB0U aBoUkz5WxbyQ== X-IronPort-AV: E=Sophos;i="5.79,393,1602572400"; d="scan'208";a="405871407" Received: from scewbso01.amr.corp.intel.com (HELO ldmartin-desk1) ([10.209.142.9]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2021 11:15:04 -0800 Date: Mon, 1 Feb 2021 11:15:01 -0800 From: Lucas De Marchi To: Ville Syrjala Message-ID: <20210201191501.gazaowftjohnj5tw@ldmartin-desk1> X-Patchwork-Hint: comment References: <20210201183343.15292-1-ville.syrjala@linux.intel.com> <20210201183343.15292-11-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210201183343.15292-11-ville.syrjala@linux.intel.com> Subject: Re: [Intel-gfx] [PATCH 10/15] drm/i915: Sprinkle a few missing locks around shared DDI clock registers X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, Feb 01, 2021 at 08:33:38PM +0200, Ville Syrj=E4l=E4 wrote: >From: Ville Syrj=E4l=E4 > >The current code attempts to protect the RMWs into global >clock routing registers with a mutex, but forgets to do so >in a few places. Let's remedy that. Forgets or doesn't do on purpose? In the first patches in this series I was actually wondering why do we even have to take the lock you were adding for some platforms. > >Note that at the moment we serialize all modesets onto single >wq, so this shouldn't actually matter. But maybe one day we >wish to attempt parallel modesets again... and this answers that. But why don't we just stop getting the lock and reintroduce them if/when we attempt parallel modeset? Lucas De Marchi > >Signed-off-by: Ville Syrj=E4l=E4 >--- > drivers/gpu/drm/i915/display/intel_ddi.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > >diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i9= 15/display/intel_ddi.c >index 7137929f58bd..93552f3c2c43 100644 >--- a/drivers/gpu/drm/i915/display/intel_ddi.c >+++ b/drivers/gpu/drm/i915/display/intel_ddi.c >@@ -3463,8 +3463,12 @@ static void cnl_ddi_disable_clock(struct intel_enco= der *encoder) > struct drm_i915_private *dev_priv =3D to_i915(encoder->base.dev); > enum port port =3D encoder->port; > >+ mutex_lock(&dev_priv->dpll.lock); >+ > intel_de_rmw(dev_priv, DPCLKA_CFGCR0, > 0, DPCLKA_CFGCR0_DDI_CLK_OFF(port)); >+ >+ mutex_unlock(&dev_priv->dpll.lock); > } > > static void skl_ddi_enable_clock(struct intel_encoder *encoder, >@@ -3493,8 +3497,12 @@ static void skl_ddi_disable_clock(struct intel_enco= der *encoder) > struct drm_i915_private *dev_priv =3D to_i915(encoder->base.dev); > enum port port =3D encoder->port; > >+ mutex_lock(&dev_priv->dpll.lock); >+ > intel_de_rmw(dev_priv, DPLL_CTRL2, > 0, DPLL_CTRL2_DDI_CLK_OFF(port)); >+ >+ mutex_unlock(&dev_priv->dpll.lock); > } > > static void hsw_ddi_enable_clock(struct intel_encoder *encoder, >-- = >2.26.2 > >_______________________________________________ >Intel-gfx mailing list >Intel-gfx@lists.freedesktop.org >https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx