From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B33AC433E0 for ; Mon, 1 Feb 2021 23:45:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2EF4064EC6 for ; Mon, 1 Feb 2021 23:45:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231136AbhBAXpZ (ORCPT ); Mon, 1 Feb 2021 18:45:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229683AbhBAXpP (ORCPT ); Mon, 1 Feb 2021 18:45:15 -0500 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B975CC06174A for ; Mon, 1 Feb 2021 15:44:34 -0800 (PST) Received: by mail-pl1-x629.google.com with SMTP id e12so1926104pls.4 for ; Mon, 01 Feb 2021 15:44:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=fwm6mluZA5z9j5m60X7bcq1KDPR0kK7jE0BbvE8y0SA=; b=zPvtRhY8I6xZhECNQRtxMIuGfx13gF4xR1FwvDj3y/r4s6hy2esITYebzwYaiNPkMF 3Mqr3aNVKTd6mMRWz6CagJxYOVTWq4vXsnKQwl4mv531lgd1bm4OOGYkfHxj1II3Sgs6 kgkN3T5V1B1tXq+1qUhwmtNcEYE7GXbkZC5N4nYz2s2pI269IK9Dy/NGtCL5Tu7/uQf4 VJhA3fK31DPiS1Jq38zUlaS7KeYvaUg4jjlQ8rS6IDBUmVl6Mc1J5g6hEVcGyX0SxXDz 8ehmHsDyK0sFzcjgJLlDgZZtDiCEVyjNyOKXtxPjqC17RHLTTYo4bTyqLlb6+ODuAdOO L8gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fwm6mluZA5z9j5m60X7bcq1KDPR0kK7jE0BbvE8y0SA=; b=EPBDLlbpCIXpUFxooDXns1jAHIHD2YX7CCH4k6tVUHRrdY4zcAIuyFa2gcuh4MKl0q pjX45cNHDRjAxENbAg6di1rygSx9PMwoz7wm7n7KZL63Kky9kFkSXOIyeCQieysjIgdG AYwlM25760LqIJzKBLdiCHUGCdxYnwKCg7RW+r1CN0L878xkVBEIgDg86NwoC88UsQy9 XWpWK19D929f7ThmYjH1bj2IOMnChefDJtjRVtMhVjYU7/iP1RLxpSxEHHBchZbxRzdk l17US0vZ65AQ93QJEouMZoaq4hvBFZHAmUSxiu191v9y/yiNKp4RpPN3AEh5pr3W1Rna o2vg== X-Gm-Message-State: AOAM531F1K7jDj35BVW/SuetImaUTquts1rQKLqEX6lhLoKiYecAbyK9 Pozr+BqcoMNusGToQP7Bk3Fttg== X-Google-Smtp-Source: ABdhPJxBU043CZGZI8fRbH2HsQrhXMmtUPQ7rnAVcDNrNRrS3Q/L54u4bE8a6bj3tFWn/tEbHg4f7Q== X-Received: by 2002:a17:90b:3907:: with SMTP id ob7mr1279309pjb.18.1612223074311; Mon, 01 Feb 2021 15:44:34 -0800 (PST) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id c23sm20513453pgc.72.2021.02.01.15.44.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 15:44:33 -0800 (PST) Date: Mon, 1 Feb 2021 16:44:31 -0700 From: Mathieu Poirier To: Anshuman Khandual Cc: linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org, suzuki.poulose@arm.com, mike.leach@linaro.org, lcherian@marvell.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH V3 02/14] coresight: Do not scan for graph if none is present Message-ID: <20210201234431.GC1475392@xps15> References: <1611737738-1493-1-git-send-email-anshuman.khandual@arm.com> <1611737738-1493-3-git-send-email-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1611737738-1493-3-git-send-email-anshuman.khandual@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 27, 2021 at 02:25:26PM +0530, Anshuman Khandual wrote: > From: Suzuki K Poulose > > If a graph node is not found for a given node, of_get_next_endpoint() > will emit the following error message : > > OF: graph: no port node found in / > > If the given component doesn't have any explicit connections (e.g, > ETE) we could simply ignore the graph parsing. > > Cc: Mathieu Poirier > Cc: Mike Leach > Signed-off-by: Suzuki K Poulose > Signed-off-by: Anshuman Khandual > --- > drivers/hwtracing/coresight/coresight-platform.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/hwtracing/coresight/coresight-platform.c b/drivers/hwtracing/coresight/coresight-platform.c > index 3629b78..c594f45 100644 > --- a/drivers/hwtracing/coresight/coresight-platform.c > +++ b/drivers/hwtracing/coresight/coresight-platform.c > @@ -90,6 +90,12 @@ static void of_coresight_get_ports_legacy(const struct device_node *node, > struct of_endpoint endpoint; > int in = 0, out = 0; > > + /* > + * Avoid warnings in of_graph_get_next_endpoint() > + * if the device doesn't have any graph connections > + */ > + if (!of_graph_is_present(node)) > + return; Reviewed-by: Mathieu Poirier > do { > ep = of_graph_get_next_endpoint(node, ep); > if (!ep) > -- > 2.7.4 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25C83C433E0 for ; Mon, 1 Feb 2021 23:46:16 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D389564DDD for ; Mon, 1 Feb 2021 23:46:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D389564DDD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=H2eb61QWdgAxPaxWbtb6V7lrEUt/y865lkO7pRnRNpg=; b=JDAgHKJo6XehRIWZPBEetmkDo XR0fiH1Qp3bzm0/LxrNfIX+7rv4pWJrdtkFwYEqoDCLWZQuD11lw3GbyQ1fW8JUstdNkpt8TBIQhR 0RmNnddZDNMu72wfQ/Zjb7S6tKG8hcSLWs98S48uqetaQ3hl/3x4vDO4STYPpVyNZezmrFifVbAjQ rPDCWfBnaKYwVGKY9xKUb1B/8A5KWQ3t+ywyBi8W1wc+vjobTsxlSKyEBfhWnG/9/It5XQhKdxhQG F/p8V54PjoH+vrdq4hqPzzO5Y1bGCxvJ206Fw55hOuIQSy0U5byNzvj7Hc7J2dyQgID+6PI1xgHwf 6sqQKxCTg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6is4-0002xe-DC; Mon, 01 Feb 2021 23:44:40 +0000 Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6is1-0002xL-03 for linux-arm-kernel@lists.infradead.org; Mon, 01 Feb 2021 23:44:38 +0000 Received: by mail-pj1-x102f.google.com with SMTP id z9so933145pjl.5 for ; Mon, 01 Feb 2021 15:44:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=fwm6mluZA5z9j5m60X7bcq1KDPR0kK7jE0BbvE8y0SA=; b=zPvtRhY8I6xZhECNQRtxMIuGfx13gF4xR1FwvDj3y/r4s6hy2esITYebzwYaiNPkMF 3Mqr3aNVKTd6mMRWz6CagJxYOVTWq4vXsnKQwl4mv531lgd1bm4OOGYkfHxj1II3Sgs6 kgkN3T5V1B1tXq+1qUhwmtNcEYE7GXbkZC5N4nYz2s2pI269IK9Dy/NGtCL5Tu7/uQf4 VJhA3fK31DPiS1Jq38zUlaS7KeYvaUg4jjlQ8rS6IDBUmVl6Mc1J5g6hEVcGyX0SxXDz 8ehmHsDyK0sFzcjgJLlDgZZtDiCEVyjNyOKXtxPjqC17RHLTTYo4bTyqLlb6+ODuAdOO L8gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fwm6mluZA5z9j5m60X7bcq1KDPR0kK7jE0BbvE8y0SA=; b=eFtlJ5siqWHbxb7cr5lYCe187WXCuTcIETWP9tKEEl0Bvzzc57t9pQdc7DzZEbmkGq TWY3XxPqryqqIyNHrV6mXnz1gsQGD/8k/iCcFCcJc61XyLr4ZxN7mq/ELRqIs9N+UST3 qw/W0T3zNxdJFjaJH0Q5LN37xKIz15U8ThlB7OwezdM8spB1yjtk/YAmOk6UN2TaRSkf YQdbKjlUDAw8XP/7G4tGEPHsxU/EWUooMrvlx+ihmmTEOo498Ys+fHds0lhlJ+/HKS/k q0eszQJm/k8+WFD0jDt2nYA8dWaf+C+wolU741p6J1QJKDLho7r4Y2IDHupwKA0k1wiw Q56g== X-Gm-Message-State: AOAM530ZFiI3QSIgWpOMudzacAiS6WXDNKPNA6mYpH60jgSHrrgWHXPv Rt+npJxXwu201RjdOZQLOcAqcA== X-Google-Smtp-Source: ABdhPJxBU043CZGZI8fRbH2HsQrhXMmtUPQ7rnAVcDNrNRrS3Q/L54u4bE8a6bj3tFWn/tEbHg4f7Q== X-Received: by 2002:a17:90b:3907:: with SMTP id ob7mr1279309pjb.18.1612223074311; Mon, 01 Feb 2021 15:44:34 -0800 (PST) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id c23sm20513453pgc.72.2021.02.01.15.44.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 15:44:33 -0800 (PST) Date: Mon, 1 Feb 2021 16:44:31 -0700 From: Mathieu Poirier To: Anshuman Khandual Subject: Re: [PATCH V3 02/14] coresight: Do not scan for graph if none is present Message-ID: <20210201234431.GC1475392@xps15> References: <1611737738-1493-1-git-send-email-anshuman.khandual@arm.com> <1611737738-1493-3-git-send-email-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1611737738-1493-3-git-send-email-anshuman.khandual@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210201_184437_341693_5303312F X-CRM114-Status: GOOD ( 21.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: suzuki.poulose@arm.com, coresight@lists.linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, lcherian@marvell.com, mike.leach@linaro.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 27, 2021 at 02:25:26PM +0530, Anshuman Khandual wrote: > From: Suzuki K Poulose > > If a graph node is not found for a given node, of_get_next_endpoint() > will emit the following error message : > > OF: graph: no port node found in / > > If the given component doesn't have any explicit connections (e.g, > ETE) we could simply ignore the graph parsing. > > Cc: Mathieu Poirier > Cc: Mike Leach > Signed-off-by: Suzuki K Poulose > Signed-off-by: Anshuman Khandual > --- > drivers/hwtracing/coresight/coresight-platform.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/hwtracing/coresight/coresight-platform.c b/drivers/hwtracing/coresight/coresight-platform.c > index 3629b78..c594f45 100644 > --- a/drivers/hwtracing/coresight/coresight-platform.c > +++ b/drivers/hwtracing/coresight/coresight-platform.c > @@ -90,6 +90,12 @@ static void of_coresight_get_ports_legacy(const struct device_node *node, > struct of_endpoint endpoint; > int in = 0, out = 0; > > + /* > + * Avoid warnings in of_graph_get_next_endpoint() > + * if the device doesn't have any graph connections > + */ > + if (!of_graph_is_present(node)) > + return; Reviewed-by: Mathieu Poirier > do { > ep = of_graph_get_next_endpoint(node, ep); > if (!ep) > -- > 2.7.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel