From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B4EAC433E0 for ; Tue, 2 Feb 2021 05:15:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0AF0764ED5 for ; Tue, 2 Feb 2021 05:15:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229685AbhBBFPQ (ORCPT ); Tue, 2 Feb 2021 00:15:16 -0500 Received: from helcar.hmeau.com ([216.24.177.18]:43898 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229850AbhBBFO6 (ORCPT ); Tue, 2 Feb 2021 00:14:58 -0500 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1l6o0Y-0001Ei-Md; Tue, 02 Feb 2021 16:13:47 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Tue, 02 Feb 2021 16:13:46 +1100 Date: Tue, 2 Feb 2021 16:13:46 +1100 From: Herbert Xu To: Daniele Alessandrelli Cc: Ard Biesheuvel , Meng Yu , "David S. Miller" , Linux Crypto Mailing List , Zaibo Xu , wangzhou1@hisilicon.com, Linux Kernel Mailing List , Mark Gross , "Khurana, Prabhjot" , "Reshetova, Elena" , Daniele Alessandrelli Subject: Re: [PATCH v7 4/7] crypto: add ecc curve and expose them Message-ID: <20210202051346.GB27641@gondor.apana.org.au> References: <1611299395-675-1-git-send-email-yumeng18@huawei.com> <1611299395-675-5-git-send-email-yumeng18@huawei.com> <20210128050354.GA30874@gondor.apana.org.au> <20210128103908.GA32495@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Mon, Feb 01, 2021 at 05:09:41PM +0000, Daniele Alessandrelli wrote: > What's the downside of letting device drivers enable all the curves > supported by the HW (with the exception of obsolete curves / > algorithms), even if there is (currently) no user of such curves in the > kernel? Code size and maintainability? The issue is that we always require a software implementation for any given hardware algorithm. As otherwise kernel users cannot rely on the algorithm to work. Of course we don't want to add every single algorithm out there to the kernel so that's why require there to be an actual in-kernel user before adding a given algorithm. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt