From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 184B7C433DB for ; Tue, 2 Feb 2021 08:43:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B3F9664E27 for ; Tue, 2 Feb 2021 08:43:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232466AbhBBInk (ORCPT ); Tue, 2 Feb 2021 03:43:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230115AbhBBInh (ORCPT ); Tue, 2 Feb 2021 03:43:37 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C8F0C061573 for ; Tue, 2 Feb 2021 00:42:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=LMKxm51u7GIF4wA49UhO1hNwr0RMWL6oQDYDdCQ2lqA=; b=pTRuAtx0tyR2wbUH6x4nowryFU eV/JKZXX//FXeE3tex/7f8qWwJ4S0a3tb2Ayvh86QiZu3Yxmke5s5OP0w9bBpXx1j7w3fKlS6nqoU XdiVJSaH0mDrei83j756AWK028ZtSf6KTi/NZIh/8XtF0YCeVAs/J0XTsqcDHec8TMVFzPokIm+I0 JF7ez2PdA7RlnlIxt6WU5htjx3zUMqEysdVq65mdQWAYkYSgJkOcMUvpK4xuG1HPSSWvxi5EZQZPh +QXZ+wEXfLODQI2RM7VV9kKLp5TP02dxzBoxbFqpaRwmKaKp238fXjuswEyJcBYAmgYiKx2sp1LL9 1JTdWgmA==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1l6rGl-00EwIn-AX; Tue, 02 Feb 2021 08:42:44 +0000 Date: Tue, 2 Feb 2021 08:42:43 +0000 From: Christoph Hellwig To: Pavel Tatashin Cc: jmorris@namei.org, sashal@kernel.org, ebiederm@xmission.com, linux-kernel@vger.kernel.org, corbet@lwn.net, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, maz@kernel.org, james.morse@arm.com, vladimir.murzin@arm.com, matthias.bgg@gmail.com, mark.rutland@arm.com, steve.capper@arm.com, rfontana@redhat.com, selindag@gmail.com, tyhicks@linux.microsoft.com Subject: Re: [PATCH 1/1] arm64: hibernate: add __force attribute to gfp_t casting Message-ID: <20210202084243.GA3558964@infradead.org> References: <20210201150306.54099-1-pasha.tatashin@soleen.com> <20210201150306.54099-2-pasha.tatashin@soleen.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210201150306.54099-2-pasha.tatashin@soleen.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 01, 2021 at 10:03:06AM -0500, Pavel Tatashin wrote: > Two new warnings are reported by sparse: > > "sparse warnings: (new ones prefixed by >>)" > >> arch/arm64/kernel/hibernate.c:181:39: sparse: sparse: cast to > restricted gfp_t > >> arch/arm64/kernel/hibernate.c:202:44: sparse: sparse: cast from > restricted gfp_t > > gfp_t has __bitwise type attribute and requires __force added to casting > in order to avoid these warnings. > > Fixes: 50f53fb72181 ("arm64: trans_pgd: make trans_pgd_map_page generic") > Reported-by: kernel test robot > Signed-off-by: Pavel Tatashin What about just passing the gfp_t value by reference which would be much cleaner? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 251F8C433DB for ; Tue, 2 Feb 2021 08:44:05 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A5A1C64E06 for ; Tue, 2 Feb 2021 08:44:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A5A1C64E06 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/OQz+aDg3oXuhHjZYZkpRD2ZpyTwaaZXr7sqISHHRBQ=; b=j9cpts8VAYOkbblaMls9b31ha IfVViYRbkvOmZVM9xRuvo4iY6i5uFCOjh1facTfgRGk63i1H8ppEB+JzNE7CQpXh5sisLFI7cXkZq PCXvttfhnph5kSjI6HuyuFh5Q+8jGPn7DwtbP6KQprnwaywAYKg/Gm915CGsBjZino0ayo+lCNmhJ MyHsEQ0cQ9Fc7dOYCTeUheh2Eecfzv0M69S4noFu3UQS56rBnSUXoUeIhXPZLcKWtELAspWOAKq60 Q7eTh7woY0tc+b96Beni+/E2vbU0SwSA6ujCSZ08RQ3tJOK0ewZUBJRLm6QaPe+KT74SYXK+zJ1st KQvEVt4aQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6rGs-0005Mx-2a; Tue, 02 Feb 2021 08:42:50 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6rGr-0005Mr-Aw for linux-arm-kernel@merlin.infradead.org; Tue, 02 Feb 2021 08:42:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=LMKxm51u7GIF4wA49UhO1hNwr0RMWL6oQDYDdCQ2lqA=; b=pTRuAtx0tyR2wbUH6x4nowryFU eV/JKZXX//FXeE3tex/7f8qWwJ4S0a3tb2Ayvh86QiZu3Yxmke5s5OP0w9bBpXx1j7w3fKlS6nqoU XdiVJSaH0mDrei83j756AWK028ZtSf6KTi/NZIh/8XtF0YCeVAs/J0XTsqcDHec8TMVFzPokIm+I0 JF7ez2PdA7RlnlIxt6WU5htjx3zUMqEysdVq65mdQWAYkYSgJkOcMUvpK4xuG1HPSSWvxi5EZQZPh +QXZ+wEXfLODQI2RM7VV9kKLp5TP02dxzBoxbFqpaRwmKaKp238fXjuswEyJcBYAmgYiKx2sp1LL9 1JTdWgmA==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1l6rGl-00EwIn-AX; Tue, 02 Feb 2021 08:42:44 +0000 Date: Tue, 2 Feb 2021 08:42:43 +0000 From: Christoph Hellwig To: Pavel Tatashin Subject: Re: [PATCH 1/1] arm64: hibernate: add __force attribute to gfp_t casting Message-ID: <20210202084243.GA3558964@infradead.org> References: <20210201150306.54099-1-pasha.tatashin@soleen.com> <20210201150306.54099-2-pasha.tatashin@soleen.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210201150306.54099-2-pasha.tatashin@soleen.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sashal@kernel.org, mark.rutland@arm.com, vladimir.murzin@arm.com, corbet@lwn.net, catalin.marinas@arm.com, selindag@gmail.com, steve.capper@arm.com, linux-kernel@vger.kernel.org, jmorris@namei.org, rfontana@redhat.com, tyhicks@linux.microsoft.com, james.morse@arm.com, ebiederm@xmission.com, maz@kernel.org, matthias.bgg@gmail.com, will@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 01, 2021 at 10:03:06AM -0500, Pavel Tatashin wrote: > Two new warnings are reported by sparse: > > "sparse warnings: (new ones prefixed by >>)" > >> arch/arm64/kernel/hibernate.c:181:39: sparse: sparse: cast to > restricted gfp_t > >> arch/arm64/kernel/hibernate.c:202:44: sparse: sparse: cast from > restricted gfp_t > > gfp_t has __bitwise type attribute and requires __force added to casting > in order to avoid these warnings. > > Fixes: 50f53fb72181 ("arm64: trans_pgd: make trans_pgd_map_page generic") > Reported-by: kernel test robot > Signed-off-by: Pavel Tatashin What about just passing the gfp_t value by reference which would be much cleaner? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel