From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D42D3C433E0 for ; Tue, 2 Feb 2021 10:25:00 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 1030864ED7 for ; Tue, 2 Feb 2021 10:24:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1030864ED7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C765E240358; Tue, 2 Feb 2021 11:24:58 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 67E5024033C; Tue, 2 Feb 2021 11:24:57 +0100 (CET) IronPort-SDR: 6Om1sg1F/yRWoiHA+MY6fOueVnA7gUZb9EUqiuVGNxSScHj07j51n/wFotSxOYqE1IfnDXUHef FVohwfmMIwxw== X-IronPort-AV: E=McAfee;i="6000,8403,9882"; a="244913627" X-IronPort-AV: E=Sophos;i="5.79,394,1602572400"; d="scan'208";a="244913627" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2021 02:24:56 -0800 IronPort-SDR: IEXSYcsxgXQBkMnNThd3Y8CtkX9DdBZwfPkWcSmz9gF6x9bS/Pm2TyVEbcrBW4QjlHGD32zZDg BEFMEdKNvlIw== X-IronPort-AV: E=Sophos;i="5.79,394,1602572400"; d="scan'208";a="391402229" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.15.2]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 02 Feb 2021 02:24:53 -0800 Date: Tue, 2 Feb 2021 10:24:50 +0000 From: Bruce Richardson To: Leyi Rong Cc: david.marchand@redhat.com, qi.z.zhang@intel.com, ferruh.yigit@intel.com, thomas@monjalon.net, talshn@nvidia.com, pallavi.kadam@intel.com, ranjit.menon@intel.com, beilei.xing@intel.com, aconole@redhat.com, dev@dpdk.org, ci@dpdk.org Message-ID: <20210202102450.GA139@bricha3-MOBL.ger.corp.intel.com> References: <20210202090639.83164-1-leyi.rong@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210202090639.83164-1-leyi.rong@intel.com> Subject: Re: [dpdk-dev] [PATCH] net/i40e: disable AVX512 with MinGW X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Feb 02, 2021 at 05:06:39PM +0800, Leyi Rong wrote: > Disable i40e AVX512 code path for Windows build regardless of CPU > capability to avoid the MinGW build error: > Error: invalid register for .seh_savexmm > > Signed-off-by: Leyi Rong > --- > drivers/net/i40e/meson.build | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/i40e/meson.build b/drivers/net/i40e/meson.build > index f5fc5a17e..26cd201ee 100644 > --- a/drivers/net/i40e/meson.build > +++ b/drivers/net/i40e/meson.build > @@ -56,6 +56,7 @@ if arch_subdir == 'x86' > > if is_windows and cc.get_id() != 'clang' > i40e_avx512_cc_support = false > + i40e_avx512_cpu_support = false > endif > This fix seems to imply that there is something else wrong in the logic in the build file. If the compiler does not support avx512, the fact that the CPU supports it should be completely irrelevant. Therefore, I think a more correct fix (logically) should be to remove the "i40e_avx512_cpu_support" from the next "if" condition, and only check the compiler support. We don't do anything with the cpu support variable. /Bruce