From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 112E6C433DB for ; Tue, 2 Feb 2021 11:14:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B463764E06 for ; Tue, 2 Feb 2021 11:14:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230286AbhBBLO3 (ORCPT ); Tue, 2 Feb 2021 06:14:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229606AbhBBLOZ (ORCPT ); Tue, 2 Feb 2021 06:14:25 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9F92C061573; Tue, 2 Feb 2021 03:13:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=3j9vOVOCZYCRcd/9oHYQqp9mHmLEYzOeZeVPeCqGHSo=; b=e4n+GEXCFgV3PZ41aiD6Dqw6g o4/Nm9vRF/rykkphyuewQKKaCsvwPjQ7qjDpkSl2rehqrN+HgWejfdEkRcMKFr+PU5t52JWcU0+16 VxaKrqDybMSHpFdQdqnPi2lKQAZLpUzrluIUz/u3AVmjwFaRSiBTOfz8NIo0v3xQQ/0u+pMSwCW0W PJsgCCqfMtuwlQG5WX+FAA8ByzjmaUI3ysryKq/qYtKRzxHRKOPhR6B+pnvHt0ljbpSUh7rcQ7kTp ufQ5KhlgyerqAdZ06+9XIiPICqtXkbEgP/Fc57JZGidmE9JT+In/wMitHA2JS63JAuFRQQVRkiukk p2PQ5Minw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:38186) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l6tcZ-0004HT-Ki; Tue, 02 Feb 2021 11:13:23 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1l6tcV-0002zg-Gy; Tue, 02 Feb 2021 11:13:19 +0000 Date: Tue, 2 Feb 2021 11:13:19 +0000 From: Russell King - ARM Linux admin To: Nicholas Piggin Cc: linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Jonathan Cameron , Christoph Hellwig , Christophe Leroy , Rick Edgecombe , Ding Tianhong , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v12 01/14] ARM: mm: add missing pud_page define to 2-level page tables Message-ID: <20210202111319.GL1463@shell.armlinux.org.uk> References: <20210202110515.3575274-1-npiggin@gmail.com> <20210202110515.3575274-2-npiggin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210202110515.3575274-2-npiggin@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King - ARM Linux admin Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 02, 2021 at 09:05:02PM +1000, Nicholas Piggin wrote: > diff --git a/arch/arm/include/asm/pgtable.h b/arch/arm/include/asm/pgtable.h > index c02f24400369..d63a5bb6bd0c 100644 > --- a/arch/arm/include/asm/pgtable.h > +++ b/arch/arm/include/asm/pgtable.h > @@ -166,6 +166,9 @@ extern struct page *empty_zero_page; > > extern pgd_t swapper_pg_dir[PTRS_PER_PGD]; > > +#define pud_page(pud) pmd_page(__pmd(pud_val(pud))) > +#define pud_write(pud) pmd_write(__pmd(pud_val(pud))) As there is no PUD, does it really make sense to return a valid struct page (which will be the PTE page) for pud_page(), which is several tables above? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B222C433E0 for ; Wed, 3 Feb 2021 01:21:58 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A6AB64F4C for ; Wed, 3 Feb 2021 01:21:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A6AB64F4C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4DVkRl5KsrzDwhC for ; Wed, 3 Feb 2021 12:21:55 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=armlinux.org.uk (client-ip=2001:4d48:ad52:32c8:5054:ff:fe00:142; helo=pandora.armlinux.org.uk; envelope-from=linux+linuxppc-dev=lists.ozlabs.org@armlinux.org.uk; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.a=rsa-sha256 header.s=pandora-2019 header.b=e4n+GEXC; dkim-atps=neutral Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4DVMxp6lMzzDqNX for ; Tue, 2 Feb 2021 22:28:12 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=3j9vOVOCZYCRcd/9oHYQqp9mHmLEYzOeZeVPeCqGHSo=; b=e4n+GEXCFgV3PZ41aiD6Dqw6g o4/Nm9vRF/rykkphyuewQKKaCsvwPjQ7qjDpkSl2rehqrN+HgWejfdEkRcMKFr+PU5t52JWcU0+16 VxaKrqDybMSHpFdQdqnPi2lKQAZLpUzrluIUz/u3AVmjwFaRSiBTOfz8NIo0v3xQQ/0u+pMSwCW0W PJsgCCqfMtuwlQG5WX+FAA8ByzjmaUI3ysryKq/qYtKRzxHRKOPhR6B+pnvHt0ljbpSUh7rcQ7kTp ufQ5KhlgyerqAdZ06+9XIiPICqtXkbEgP/Fc57JZGidmE9JT+In/wMitHA2JS63JAuFRQQVRkiukk p2PQ5Minw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:38186) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l6tcZ-0004HT-Ki; Tue, 02 Feb 2021 11:13:23 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1l6tcV-0002zg-Gy; Tue, 02 Feb 2021 11:13:19 +0000 Date: Tue, 2 Feb 2021 11:13:19 +0000 From: Russell King - ARM Linux admin To: Nicholas Piggin Subject: Re: [PATCH v12 01/14] ARM: mm: add missing pud_page define to 2-level page tables Message-ID: <20210202111319.GL1463@shell.armlinux.org.uk> References: <20210202110515.3575274-1-npiggin@gmail.com> <20210202110515.3575274-2-npiggin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210202110515.3575274-2-npiggin@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Ding Tianhong , linux-kernel@vger.kernel.org, Christoph Hellwig , linux-mm@kvack.org, Jonathan Cameron , Andrew Morton , Rick Edgecombe , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Feb 02, 2021 at 09:05:02PM +1000, Nicholas Piggin wrote: > diff --git a/arch/arm/include/asm/pgtable.h b/arch/arm/include/asm/pgtable.h > index c02f24400369..d63a5bb6bd0c 100644 > --- a/arch/arm/include/asm/pgtable.h > +++ b/arch/arm/include/asm/pgtable.h > @@ -166,6 +166,9 @@ extern struct page *empty_zero_page; > > extern pgd_t swapper_pg_dir[PTRS_PER_PGD]; > > +#define pud_page(pud) pmd_page(__pmd(pud_val(pud))) > +#define pud_write(pud) pmd_write(__pmd(pud_val(pud))) As there is no PUD, does it really make sense to return a valid struct page (which will be the PTE page) for pud_page(), which is several tables above? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73C97C433DB for ; Tue, 2 Feb 2021 11:17:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0AA8564E4C for ; Tue, 2 Feb 2021 11:17:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0AA8564E4C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kjA0USbgA3n++QgH/x/iTASO6zvCR8l3JGgAue6m+e0=; b=DvVllY9A87NkNlhbdXTUik1K6 vvT7TzGLcA9Quoa/OXqX0rkPp0XzJkJhN/oxWsVWwQZvVGHuCPYyD1wDckysxkuhYU7D9IsLDVw2Y sh+5IhBvzV0tEpti3ELbRrXPOYVHmWKEQm4H3JICnv3nIhadZmJ+5Sg3OT9srWRaUCr1PPAH0hBeH cNQVe5Q5+Z1jflLj7Ka/+bmeLJT7IbtHJKwyewvsf4gwHmsoWOTxD7OMnWD5zWGPluOpKw4lzCMiM vDsgPVHdf0Q2/zRuTPOseacRekMTK3ucgKucgxup6N0OiBwRPMGM3bHl4D/aR8PXWRjymIfl8as1k UrVYDGCog==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6tew-0003ae-Hy; Tue, 02 Feb 2021 11:15:50 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6teu-0003a5-9O for linux-arm-kernel@lists.infradead.org; Tue, 02 Feb 2021 11:15:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=3j9vOVOCZYCRcd/9oHYQqp9mHmLEYzOeZeVPeCqGHSo=; b=e4n+GEXCFgV3PZ41aiD6Dqw6g o4/Nm9vRF/rykkphyuewQKKaCsvwPjQ7qjDpkSl2rehqrN+HgWejfdEkRcMKFr+PU5t52JWcU0+16 VxaKrqDybMSHpFdQdqnPi2lKQAZLpUzrluIUz/u3AVmjwFaRSiBTOfz8NIo0v3xQQ/0u+pMSwCW0W PJsgCCqfMtuwlQG5WX+FAA8ByzjmaUI3ysryKq/qYtKRzxHRKOPhR6B+pnvHt0ljbpSUh7rcQ7kTp ufQ5KhlgyerqAdZ06+9XIiPICqtXkbEgP/Fc57JZGidmE9JT+In/wMitHA2JS63JAuFRQQVRkiukk p2PQ5Minw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:38186) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l6tcZ-0004HT-Ki; Tue, 02 Feb 2021 11:13:23 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1l6tcV-0002zg-Gy; Tue, 02 Feb 2021 11:13:19 +0000 Date: Tue, 2 Feb 2021 11:13:19 +0000 From: Russell King - ARM Linux admin To: Nicholas Piggin Subject: Re: [PATCH v12 01/14] ARM: mm: add missing pud_page define to 2-level page tables Message-ID: <20210202111319.GL1463@shell.armlinux.org.uk> References: <20210202110515.3575274-1-npiggin@gmail.com> <20210202110515.3575274-2-npiggin@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210202110515.3575274-2-npiggin@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210202_061548_380044_B1380C1A X-CRM114-Status: GOOD ( 12.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Ding Tianhong , linux-kernel@vger.kernel.org, Christophe Leroy , Christoph Hellwig , linux-mm@kvack.org, Jonathan Cameron , Andrew Morton , Rick Edgecombe , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 02, 2021 at 09:05:02PM +1000, Nicholas Piggin wrote: > diff --git a/arch/arm/include/asm/pgtable.h b/arch/arm/include/asm/pgtable.h > index c02f24400369..d63a5bb6bd0c 100644 > --- a/arch/arm/include/asm/pgtable.h > +++ b/arch/arm/include/asm/pgtable.h > @@ -166,6 +166,9 @@ extern struct page *empty_zero_page; > > extern pgd_t swapper_pg_dir[PTRS_PER_PGD]; > > +#define pud_page(pud) pmd_page(__pmd(pud_val(pud))) > +#define pud_write(pud) pmd_write(__pmd(pud_val(pud))) As there is no PUD, does it really make sense to return a valid struct page (which will be the PTE page) for pud_page(), which is several tables above? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel