From: Jakub Kicinski <kuba@kernel.org>
To: Andrea Parri <parri.andrea@gmail.com>
Cc: davem@davemloft.net, linux-kernel@vger.kernel.org,
kys@microsoft.com, haiyangz@microsoft.com,
sthemmin@microsoft.com, wei.liu@kernel.org,
mikelley@microsoft.com, linux-hyperv@vger.kernel.org,
skarade@microsoft.com, juvazq@microsoft.com,
netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next] hv_netvsc: Copy packets sent by Hyper-V out of the receive buffer
Date: Tue, 2 Feb 2021 11:45:49 -0800 [thread overview]
Message-ID: <20210202114549.7488f5bd@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210202081843.GA3923@anparri>
On Tue, 2 Feb 2021 09:18:43 +0100 Andrea Parri wrote:
> Hi net maintainers,
>
>
> On Sat, Jan 30, 2021 at 12:50:06AM +0000, patchwork-bot+netdevbpf@kernel.org wrote:
> > Hello:
> >
> > This patch was applied to netdev/net-next.git (refs/heads/master):
> >
> > On Tue, 26 Jan 2021 17:29:07 +0100 you wrote:
> > > Pointers to receive-buffer packets sent by Hyper-V are used within the
> > > guest VM. Hyper-V can send packets with erroneous values or modify
> > > packet fields after they are processed by the guest. To defend against
> > > these scenarios, copy (sections of) the incoming packet after validating
> > > their length and offset fields in netvsc_filter_receive(). In this way,
> > > the packet can no longer be modified by the host.
> > >
> > > [...]
> >
> > Here is the summary with links:
> > - [v2,net-next] hv_netvsc: Copy packets sent by Hyper-V out of the receive buffer
> > https://git.kernel.org/netdev/net-next/c/0ba35fe91ce3
>
> I'd have some fixes on top of this and I'm wondering about the process: would
> you consider fixes/patches on top of this commit now?
Fixes for bugs present in Linus's tree?
You need to target the net tree, and give us instructions on how to
resolve the conflict which will arise from merging net into net-next.
> would you rather prefer me to squash these fixes into a v3? other?
Networking trees are immutable, and v2 was already applied. We could
do a revert, apply fix, apply v3, but we prefer to just handle the
merge conflict.
next prev parent reply other threads:[~2021-02-02 19:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 16:29 [PATCH v2 net-next] hv_netvsc: Copy packets sent by Hyper-V out of the receive buffer Andrea Parri (Microsoft)
2021-01-30 0:50 ` patchwork-bot+netdevbpf
2021-02-02 8:18 ` Andrea Parri
2021-02-02 19:45 ` Jakub Kicinski [this message]
2021-02-03 11:17 ` Andrea Parri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210202114549.7488f5bd@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=haiyangz@microsoft.com \
--cc=juvazq@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=parri.andrea@gmail.com \
--cc=skarade@microsoft.com \
--cc=sthemmin@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.