From: Christoph Hellwig <hch@lst.de> To: Frederic Barrat <fbarrat@linux.ibm.com>, Andrew Donnellan <ajd@linux.ibm.com>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Jessica Yu <jeyu@kernel.org>, Josh Poimboeuf <jpoimboe@redhat.com>, Jiri Kosina <jikos@kernel.org>, Miroslav Benes <mbenes@suse.cz>, Petr Mladek <pmladek@suse.com>, Joe Lawrence <joe.lawrence@redhat.com> Cc: Masahiro Yamada <masahiroy@kernel.org>, Michal Marek <michal.lkml@markovi.net>, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, dri-devel@lists.freedesktop.org, live-patching@vger.kernel.org, linux-kbuild@vger.kernel.org Subject: [PATCH 01/13] powerpc/powernv: remove get_cxl_module Date: Tue, 2 Feb 2021 13:13:22 +0100 [thread overview] Message-ID: <20210202121334.1361503-2-hch@lst.de> (raw) In-Reply-To: <20210202121334.1361503-1-hch@lst.de> The static inline get_cxl_module function is entirely unused since commit 8bf6b91a5125a ("Revert "powerpc/powernv: Add support for the cxl kernel api on the real phb"), so remove it. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Andrew Donnellan <ajd@linux.ibm.com> --- arch/powerpc/platforms/powernv/pci-cxl.c | 22 ---------------------- 1 file changed, 22 deletions(-) diff --git a/arch/powerpc/platforms/powernv/pci-cxl.c b/arch/powerpc/platforms/powernv/pci-cxl.c index 8c739c94ed28d6..53172862d23bd3 100644 --- a/arch/powerpc/platforms/powernv/pci-cxl.c +++ b/arch/powerpc/platforms/powernv/pci-cxl.c @@ -150,25 +150,3 @@ int pnv_cxl_ioda_msi_setup(struct pci_dev *dev, unsigned int hwirq, return 0; } EXPORT_SYMBOL(pnv_cxl_ioda_msi_setup); - -#if IS_MODULE(CONFIG_CXL) -static inline int get_cxl_module(void) -{ - struct module *cxl_module; - - mutex_lock(&module_mutex); - - cxl_module = find_module("cxl"); - if (cxl_module) - __module_get(cxl_module); - - mutex_unlock(&module_mutex); - - if (!cxl_module) - return -ENODEV; - - return 0; -} -#else -static inline int get_cxl_module(void) { return 0; } -#endif -- 2.29.2
WARNING: multiple messages have this Message-ID
From: Christoph Hellwig <hch@lst.de> To: Frederic Barrat <fbarrat@linux.ibm.com>, Andrew Donnellan <ajd@linux.ibm.com>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Jessica Yu <jeyu@kernel.org>, Josh Poimboeuf <jpoimboe@redhat.com>, Jiri Kosina <jikos@kernel.org>, Miroslav Benes <mbenes@suse.cz>, Petr Mladek <pmladek@suse.com>, Joe Lawrence <joe.lawrence@redhat.com> Cc: Michal Marek <michal.lkml@markovi.net>, linux-kbuild@vger.kernel.org, Masahiro Yamada <masahiroy@kernel.org>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, live-patching@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: [PATCH 01/13] powerpc/powernv: remove get_cxl_module Date: Tue, 2 Feb 2021 13:13:22 +0100 [thread overview] Message-ID: <20210202121334.1361503-2-hch@lst.de> (raw) In-Reply-To: <20210202121334.1361503-1-hch@lst.de> The static inline get_cxl_module function is entirely unused since commit 8bf6b91a5125a ("Revert "powerpc/powernv: Add support for the cxl kernel api on the real phb"), so remove it. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Andrew Donnellan <ajd@linux.ibm.com> --- arch/powerpc/platforms/powernv/pci-cxl.c | 22 ---------------------- 1 file changed, 22 deletions(-) diff --git a/arch/powerpc/platforms/powernv/pci-cxl.c b/arch/powerpc/platforms/powernv/pci-cxl.c index 8c739c94ed28d6..53172862d23bd3 100644 --- a/arch/powerpc/platforms/powernv/pci-cxl.c +++ b/arch/powerpc/platforms/powernv/pci-cxl.c @@ -150,25 +150,3 @@ int pnv_cxl_ioda_msi_setup(struct pci_dev *dev, unsigned int hwirq, return 0; } EXPORT_SYMBOL(pnv_cxl_ioda_msi_setup); - -#if IS_MODULE(CONFIG_CXL) -static inline int get_cxl_module(void) -{ - struct module *cxl_module; - - mutex_lock(&module_mutex); - - cxl_module = find_module("cxl"); - if (cxl_module) - __module_get(cxl_module); - - mutex_unlock(&module_mutex); - - if (!cxl_module) - return -ENODEV; - - return 0; -} -#else -static inline int get_cxl_module(void) { return 0; } -#endif -- 2.29.2
next prev parent reply other threads:[~2021-02-02 12:15 UTC|newest] Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-02 12:13 module loader dead code removal and cleanups v3 Christoph Hellwig 2021-02-02 12:13 ` Christoph Hellwig 2021-02-02 12:13 ` Christoph Hellwig [this message] 2021-02-02 12:13 ` [PATCH 01/13] powerpc/powernv: remove get_cxl_module Christoph Hellwig 2021-02-04 10:44 ` Michael Ellerman 2021-02-04 10:44 ` Michael Ellerman 2021-02-04 10:44 ` Michael Ellerman 2021-02-02 12:13 ` [PATCH 02/13] drm: remove drm_fb_helper_modinit Christoph Hellwig 2021-02-02 12:13 ` Christoph Hellwig 2021-02-02 12:13 ` [PATCH 03/13] module: unexport find_module and module_mutex Christoph Hellwig 2021-02-02 12:13 ` Christoph Hellwig 2021-02-02 12:13 ` [PATCH 04/13] module: use RCU to synchronize find_module Christoph Hellwig 2021-02-02 12:13 ` Christoph Hellwig 2021-02-02 12:13 ` [PATCH 05/13] kallsyms: refactor {,module_}kallsyms_on_each_symbol Christoph Hellwig 2021-02-02 12:13 ` Christoph Hellwig 2021-02-03 8:58 ` Petr Mladek 2021-02-03 8:58 ` Petr Mladek 2021-02-03 8:58 ` Petr Mladek 2021-02-02 12:13 ` [PATCH 06/13] kallsyms: only build {,module_}kallsyms_on_each_symbol when required Christoph Hellwig 2021-02-02 12:13 ` [PATCH 06/13] kallsyms: only build {, module_}kallsyms_on_each_symbol " Christoph Hellwig 2021-02-02 14:03 ` [PATCH 06/13] kallsyms: only build {,module_}kallsyms_on_each_symbol " Miroslav Benes 2021-02-02 14:03 ` [PATCH 06/13] kallsyms: only build {, module_}kallsyms_on_each_symbol " Miroslav Benes 2021-02-02 14:03 ` Miroslav Benes 2021-02-02 12:13 ` [PATCH 07/13] module: mark module_mutex static Christoph Hellwig 2021-02-02 12:13 ` Christoph Hellwig 2021-02-02 14:04 ` Miroslav Benes 2021-02-02 14:04 ` Miroslav Benes 2021-02-02 14:04 ` Miroslav Benes 2021-02-02 12:13 ` [PATCH 08/13] module: remove each_symbol_in_section Christoph Hellwig 2021-02-02 12:13 ` Christoph Hellwig 2021-02-02 14:04 ` Miroslav Benes 2021-02-02 14:04 ` Miroslav Benes 2021-02-02 14:04 ` Miroslav Benes 2021-02-02 12:13 ` [PATCH 09/13] module: merge each_symbol_section into find_symbol Christoph Hellwig 2021-02-02 12:13 ` Christoph Hellwig 2021-02-02 14:04 ` Miroslav Benes 2021-02-02 14:04 ` Miroslav Benes 2021-02-02 14:04 ` Miroslav Benes 2021-02-02 12:13 ` [PATCH 10/13] module: pass struct find_symbol_args to find_symbol Christoph Hellwig 2021-02-02 12:13 ` Christoph Hellwig 2021-02-02 14:07 ` Miroslav Benes 2021-02-02 14:07 ` Miroslav Benes 2021-02-02 14:07 ` Miroslav Benes 2021-02-02 15:41 ` Christoph Hellwig 2021-02-02 15:41 ` Christoph Hellwig 2021-02-03 9:04 ` Christoph Hellwig 2021-02-03 9:04 ` Christoph Hellwig 2021-02-03 9:31 ` Miroslav Benes 2021-02-03 9:31 ` Miroslav Benes 2021-02-03 9:31 ` Miroslav Benes 2021-02-02 12:13 ` [PATCH 11/13] module: move struct symsearch to module.c Christoph Hellwig 2021-02-02 12:13 ` Christoph Hellwig 2021-02-02 14:10 ` Miroslav Benes 2021-02-02 14:10 ` Miroslav Benes 2021-02-02 14:10 ` Miroslav Benes 2021-02-02 12:13 ` [PATCH 12/13] module: remove EXPORT_SYMBOL_GPL_FUTURE Christoph Hellwig 2021-02-02 12:13 ` Christoph Hellwig 2021-02-02 14:12 ` Miroslav Benes 2021-02-02 14:12 ` Miroslav Benes 2021-02-02 14:12 ` Miroslav Benes 2021-02-02 12:13 ` [PATCH 13/13] module: remove EXPORT_UNUSED_SYMBOL* Christoph Hellwig 2021-02-02 12:13 ` Christoph Hellwig 2021-02-02 14:21 ` Miroslav Benes 2021-02-02 14:21 ` Miroslav Benes 2021-02-02 14:21 ` Miroslav Benes 2021-02-02 14:37 ` module loader dead code removal and cleanups v3 Jessica Yu 2021-02-02 14:37 ` Jessica Yu 2021-02-02 14:37 ` Jessica Yu 2021-02-02 15:23 ` Christoph Hellwig 2021-02-02 15:23 ` Christoph Hellwig 2021-02-02 17:38 ` Emil Velikov 2021-02-02 17:38 ` Emil Velikov 2021-02-02 17:38 ` Emil Velikov 2021-02-08 11:36 ` Jessica Yu 2021-02-08 11:36 ` Jessica Yu 2021-02-08 11:36 ` Jessica Yu -- strict thread matches above, loose matches on Subject: below -- 2021-01-28 18:14 module loader dead code removal and cleanups v2 Christoph Hellwig 2021-01-28 18:14 ` [PATCH 01/13] powerpc/powernv: remove get_cxl_module Christoph Hellwig 2021-01-28 18:14 ` Christoph Hellwig 2021-01-21 7:49 module loader dead code removal and cleanusp Christoph Hellwig 2021-01-21 7:49 ` [PATCH 01/13] powerpc/powernv: remove get_cxl_module Christoph Hellwig 2021-01-21 7:49 ` Christoph Hellwig 2021-01-21 9:09 ` Andrew Donnellan 2021-01-21 9:09 ` Andrew Donnellan 2021-01-21 9:09 ` Andrew Donnellan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210202121334.1361503-2-hch@lst.de \ --to=hch@lst.de \ --cc=airlied@linux.ie \ --cc=ajd@linux.ibm.com \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=fbarrat@linux.ibm.com \ --cc=jeyu@kernel.org \ --cc=jikos@kernel.org \ --cc=joe.lawrence@redhat.com \ --cc=jpoimboe@redhat.com \ --cc=linux-kbuild@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=live-patching@vger.kernel.org \ --cc=maarten.lankhorst@linux.intel.com \ --cc=masahiroy@kernel.org \ --cc=mbenes@suse.cz \ --cc=michal.lkml@markovi.net \ --cc=mripard@kernel.org \ --cc=pmladek@suse.com \ --cc=tzimmermann@suse.de \ --subject='Re: [PATCH 01/13] powerpc/powernv: remove get_cxl_module' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.