From: Olivia Mackintosh <livvy@base.nu>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 1/2] ALSA: usb-audio: Add DJM450 to Pioneer format quirk
Date: Tue, 2 Feb 2021 12:54:10 +0000 [thread overview]
Message-ID: <20210202125404.c24roplg7hx6tmdh@base.nu> (raw)
In-Reply-To: <s5h4kiug0j3.wl-tiwai@suse.de>
Apologies. I am just getting used to the git-send-email mailer for
emailing threaded patch sets and made a few oversights. I will correct
these, add Signed-off-by line and resubmit as thread.
Olivia
On Tue, Feb 02, 2021 at 12:41:04PM +0100, Takashi Iwai wrote:
> On Tue, 02 Feb 2021 01:02:37 +0100,
> Olivia Mackintosh wrote:
> >
> > Like the DJM-750, ensure that the format control message is passed to
> > the device when opening a stream. It seems as though fmt->sync_ep is not
> > always set when this function is called hence the passing of the value
> > at the call site. If this can be fixed, fmt->sync_up should be used as
> > the wvalue.
>
> Could you give your Signed-off-by line?
>
> > +static int pioneer_djm_set_format_quirk(struct snd_usb_substream *subs,
> > + u16 windex)
> > +{
> > + unsigned int cur_rate = subs->data_endpoint->cur_rate;
> > + u8 sr[3];
> > + // Convert to little endian
> > + sr[0] = cur_rate&0xff;
> > + sr[1] = (cur_rate>>8)&0xff;
> > + sr[2] = (cur_rate>>16)&0xff;
>
> Better to have some appropriate spaces around operators.
>
> Also, instead of open-code, you can use cpu_to_le32() and pass its
> pointer, too.
>
>
> thanks,
>
> Takashi
prev parent reply other threads:[~2021-02-02 12:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 0:02 [PATCH 1/2] ALSA: usb-audio: Add DJM450 to Pioneer format quirk Olivia Mackintosh
2021-02-02 11:41 ` Takashi Iwai
2021-02-02 12:54 ` Olivia Mackintosh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210202125404.c24roplg7hx6tmdh@base.nu \
--to=livvy@base.nu \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.