From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42507C433E0 for ; Tue, 2 Feb 2021 19:49:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1150B64E43 for ; Tue, 2 Feb 2021 19:49:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239833AbhBBTt0 (ORCPT ); Tue, 2 Feb 2021 14:49:26 -0500 Received: from 8bytes.org ([81.169.241.247]:53998 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233190AbhBBNwN (ORCPT ); Tue, 2 Feb 2021 08:52:13 -0500 Received: by theia.8bytes.org (Postfix, from userid 1000) id B01A03D4; Tue, 2 Feb 2021 14:51:31 +0100 (CET) Date: Tue, 2 Feb 2021 14:51:30 +0100 From: Joerg Roedel To: Lu Baolu Cc: iommu@lists.linux-foundation.org, Yian Chen , Ashok Raj , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] iommu/vt-d: Add new enum value and structure for SATC Message-ID: <20210202135130.GV32671@8bytes.org> References: <20210202044057.615277-1-baolu.lu@linux.intel.com> <20210202044057.615277-2-baolu.lu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210202044057.615277-2-baolu.lu@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Baolu, On Tue, Feb 02, 2021 at 12:40:55PM +0800, Lu Baolu wrote: > @@ -514,7 +514,8 @@ enum acpi_dmar_type { > ACPI_DMAR_TYPE_ROOT_ATS = 2, > ACPI_DMAR_TYPE_HARDWARE_AFFINITY = 3, > ACPI_DMAR_TYPE_NAMESPACE = 4, > - ACPI_DMAR_TYPE_RESERVED = 5 /* 5 and greater are reserved */ > + ACPI_DMAR_TYPE_SATC = 5, > + ACPI_DMAR_TYPE_RESERVED = 6 /* 5 and greater are reserved */ Nit: The comment needs to be updated too. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36AF4C433E0 for ; Tue, 2 Feb 2021 13:51:39 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B0BC364F64 for ; Tue, 2 Feb 2021 13:51:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B0BC364F64 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=8bytes.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 697D08666D; Tue, 2 Feb 2021 13:51:38 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xLvqcJE37wRM; Tue, 2 Feb 2021 13:51:35 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id AE59F863E0; Tue, 2 Feb 2021 13:51:35 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 932A4C0174; Tue, 2 Feb 2021 13:51:35 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 41298C013A for ; Tue, 2 Feb 2021 13:51:34 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 3823886180 for ; Tue, 2 Feb 2021 13:51:34 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PAT13qSR8IQt for ; Tue, 2 Feb 2021 13:51:33 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from theia.8bytes.org (8bytes.org [81.169.241.247]) by whitealder.osuosl.org (Postfix) with ESMTPS id 85C768613C for ; Tue, 2 Feb 2021 13:51:33 +0000 (UTC) Received: by theia.8bytes.org (Postfix, from userid 1000) id B01A03D4; Tue, 2 Feb 2021 14:51:31 +0100 (CET) Date: Tue, 2 Feb 2021 14:51:30 +0100 From: Joerg Roedel To: Lu Baolu Subject: Re: [PATCH 1/3] iommu/vt-d: Add new enum value and structure for SATC Message-ID: <20210202135130.GV32671@8bytes.org> References: <20210202044057.615277-1-baolu.lu@linux.intel.com> <20210202044057.615277-2-baolu.lu@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210202044057.615277-2-baolu.lu@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: iommu@lists.linux-foundation.org, Ashok Raj , linux-kernel@vger.kernel.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" Hi Baolu, On Tue, Feb 02, 2021 at 12:40:55PM +0800, Lu Baolu wrote: > @@ -514,7 +514,8 @@ enum acpi_dmar_type { > ACPI_DMAR_TYPE_ROOT_ATS = 2, > ACPI_DMAR_TYPE_HARDWARE_AFFINITY = 3, > ACPI_DMAR_TYPE_NAMESPACE = 4, > - ACPI_DMAR_TYPE_RESERVED = 5 /* 5 and greater are reserved */ > + ACPI_DMAR_TYPE_SATC = 5, > + ACPI_DMAR_TYPE_RESERVED = 6 /* 5 and greater are reserved */ Nit: The comment needs to be updated too. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu