From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FB98C433DB for ; Tue, 2 Feb 2021 19:39:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 316BB64E56 for ; Tue, 2 Feb 2021 19:39:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239935AbhBBTiQ (ORCPT ); Tue, 2 Feb 2021 14:38:16 -0500 Received: from 8bytes.org ([81.169.241.247]:54014 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233162AbhBBNzq (ORCPT ); Tue, 2 Feb 2021 08:55:46 -0500 Received: by theia.8bytes.org (Postfix, from userid 1000) id 5FB4B3D4; Tue, 2 Feb 2021 14:55:03 +0100 (CET) Date: Tue, 2 Feb 2021 14:55:01 +0100 From: Joerg Roedel To: Lu Baolu Cc: iommu@lists.linux-foundation.org, Yian Chen , Ashok Raj , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] iommu/vt-d: Apply SATC policy Message-ID: <20210202135501.GX32671@8bytes.org> References: <20210202044057.615277-1-baolu.lu@linux.intel.com> <20210202044057.615277-4-baolu.lu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210202044057.615277-4-baolu.lu@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 02, 2021 at 12:40:57PM +0800, Lu Baolu wrote: > + list_for_each_entry_rcu(satcu, &dmar_satc_units, list) { > + satc = container_of(satcu->hdr, struct acpi_dmar_satc, header); > + if (satc->segment == pci_domain_nr(dev->bus) && satcu->atc_required) { You can safe a level of indentation and make this look nicer if you do: if (satc->segment != pci_domain_nr(dev->bus) || !satcu->atc_required) continue; > + for_each_dev_scope(satcu->devices, satcu->devices_cnt, i, tmp) > + if (to_pci_dev(tmp) == dev) > + goto out; > + } > + } > + ret = 0; > +out: > + rcu_read_unlock(); > + return ret; > +} From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EC90C433E6 for ; Tue, 2 Feb 2021 13:55:13 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1CB1F64FC6 for ; Tue, 2 Feb 2021 13:55:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1CB1F64FC6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=8bytes.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id CDCE420492; Tue, 2 Feb 2021 13:55:12 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8+t4IbHIwN1j; Tue, 2 Feb 2021 13:55:09 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id DDEB420341; Tue, 2 Feb 2021 13:55:09 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id C64EBC0174; Tue, 2 Feb 2021 13:55:09 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1BB85C013A for ; Tue, 2 Feb 2021 13:55:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 16BB22046B for ; Tue, 2 Feb 2021 13:55:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Cm-Trri5Sl5l for ; Tue, 2 Feb 2021 13:55:06 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from theia.8bytes.org (8bytes.org [81.169.241.247]) by silver.osuosl.org (Postfix) with ESMTPS id 3C86020341 for ; Tue, 2 Feb 2021 13:55:06 +0000 (UTC) Received: by theia.8bytes.org (Postfix, from userid 1000) id 5FB4B3D4; Tue, 2 Feb 2021 14:55:03 +0100 (CET) Date: Tue, 2 Feb 2021 14:55:01 +0100 From: Joerg Roedel To: Lu Baolu Subject: Re: [PATCH 3/3] iommu/vt-d: Apply SATC policy Message-ID: <20210202135501.GX32671@8bytes.org> References: <20210202044057.615277-1-baolu.lu@linux.intel.com> <20210202044057.615277-4-baolu.lu@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210202044057.615277-4-baolu.lu@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: iommu@lists.linux-foundation.org, Ashok Raj , linux-kernel@vger.kernel.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Tue, Feb 02, 2021 at 12:40:57PM +0800, Lu Baolu wrote: > + list_for_each_entry_rcu(satcu, &dmar_satc_units, list) { > + satc = container_of(satcu->hdr, struct acpi_dmar_satc, header); > + if (satc->segment == pci_domain_nr(dev->bus) && satcu->atc_required) { You can safe a level of indentation and make this look nicer if you do: if (satc->segment != pci_domain_nr(dev->bus) || !satcu->atc_required) continue; > + for_each_dev_scope(satcu->devices, satcu->devices_cnt, i, tmp) > + if (to_pci_dev(tmp) == dev) > + goto out; > + } > + } > + ret = 0; > +out: > + rcu_read_unlock(); > + return ret; > +} _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu