From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44277C433DB for ; Tue, 2 Feb 2021 15:44:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0D9A164F4B for ; Tue, 2 Feb 2021 15:44:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232427AbhBBPnv (ORCPT ); Tue, 2 Feb 2021 10:43:51 -0500 Received: from mail.kernel.org ([198.145.29.99]:46134 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235752AbhBBPmr (ORCPT ); Tue, 2 Feb 2021 10:42:47 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id F04BF64F4B; Tue, 2 Feb 2021 15:42:03 +0000 (UTC) Date: Tue, 2 Feb 2021 15:42:01 +0000 From: Catalin Marinas To: Andrey Konovalov Cc: Vincenzo Frascino , Dmitry Vyukov , Alexander Potapenko , Marco Elver , Andrew Morton , Will Deacon , Andrey Ryabinin , Peter Collingbourne , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 10/12] arm64: kasan: simplify and inline MTE functions Message-ID: <20210202154200.GC26895@gaia> References: <17d6bef698d193f5fe0d8baee0e232a351e23a32.1612208222.git.andreyknvl@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17d6bef698d193f5fe0d8baee0e232a351e23a32.1612208222.git.andreyknvl@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 01, 2021 at 08:43:34PM +0100, Andrey Konovalov wrote: > +/* > + * Assign allocation tags for a region of memory based on the pointer tag. > + * Note: The address must be non-NULL and MTE_GRANULE_SIZE aligned and > + * size must be non-zero and MTE_GRANULE_SIZE aligned. > + */ OK, so we rely on the caller to sanity-check the range. Fine by me but I can see (un)poison_range() only doing this for the size. Do we guarantee that the start address is aligned? > +static __always_inline void mte_set_mem_tag_range(void *addr, size_t size, u8 tag) > +{ > + u64 curr, end; > + > + if (!size) > + return; > + > + curr = (u64)__tag_set(addr, tag); > + end = curr + size; > + > + do { > + /* > + * 'asm volatile' is required to prevent the compiler to move > + * the statement outside of the loop. > + */ > + asm volatile(__MTE_PREAMBLE "stg %0, [%0]" > + : > + : "r" (curr) > + : "memory"); > + > + curr += MTE_GRANULE_SIZE; > + } while (curr != end); > +} > > void mte_enable_kernel_sync(void); > void mte_enable_kernel_async(void); > @@ -47,10 +95,12 @@ static inline u8 mte_get_mem_tag(void *addr) > { > return 0xFF; > } > + > static inline u8 mte_get_random_tag(void) > { > return 0xFF; > } > + > static inline void *mte_set_mem_tag_range(void *addr, size_t size, u8 tag) This function used to return a pointer and that's what the dummy static inline does here. However, the new mte_set_mem_tag_range() doesn't return anything. We should have consistency between the two (the new static void definition is fine by me). Otherwise the patch looks fine. Reviewed-by: Catalin Marinas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 446C3C433DB for ; Tue, 2 Feb 2021 15:43:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F18E064F4B for ; Tue, 2 Feb 2021 15:43:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F18E064F4B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fXirwCE8IFnTPDI6++01LTUXBcs12ZwKS6fd9tghjJw=; b=YBcSMi1RbZx2jqIDfW3cHgdO3 6CAgJMbvaSUHA0z+SPy/3HUV2+1TG7OWtJ+marEi75w74D1pgnmeljsW21GP1uXNofL9taIeA4bJl d5U7N1DdS7qEya2sSD8OQ1VXBYmDmpn2UNTDhxHZntBzEPgzfOc11LCvwXUrndze0YtuvpJqKucaB pStM3+PHYzX2bRvE5sLxe8ZGJJbp0HvBgfQKAArYXH5TCXuj5ANTS0dXHx/yAbbe8H2Up6pyzZ/gg /93Rc8f3tpwW+xAbj6kP/L8mGBaoSyImRazmfnh6Sjz5w0H1jPkn9U/R8/E0pk9kow4fMN0HK5YZz /sNzGhgNw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6xof-00011f-Ld; Tue, 02 Feb 2021 15:42:09 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6xod-00011H-Hs for linux-arm-kernel@lists.infradead.org; Tue, 02 Feb 2021 15:42:08 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id F04BF64F4B; Tue, 2 Feb 2021 15:42:03 +0000 (UTC) Date: Tue, 2 Feb 2021 15:42:01 +0000 From: Catalin Marinas To: Andrey Konovalov Subject: Re: [PATCH 10/12] arm64: kasan: simplify and inline MTE functions Message-ID: <20210202154200.GC26895@gaia> References: <17d6bef698d193f5fe0d8baee0e232a351e23a32.1612208222.git.andreyknvl@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <17d6bef698d193f5fe0d8baee0e232a351e23a32.1612208222.git.andreyknvl@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210202_104207_736442_3954C97D X-CRM114-Status: GOOD ( 16.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Marco Elver , Kevin Brodsky , Will Deacon , Branislav Rankov , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alexander Potapenko , Evgenii Stepanov , Andrey Ryabinin , Andrew Morton , Vincenzo Frascino , Peter Collingbourne , Dmitry Vyukov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 01, 2021 at 08:43:34PM +0100, Andrey Konovalov wrote: > +/* > + * Assign allocation tags for a region of memory based on the pointer tag. > + * Note: The address must be non-NULL and MTE_GRANULE_SIZE aligned and > + * size must be non-zero and MTE_GRANULE_SIZE aligned. > + */ OK, so we rely on the caller to sanity-check the range. Fine by me but I can see (un)poison_range() only doing this for the size. Do we guarantee that the start address is aligned? > +static __always_inline void mte_set_mem_tag_range(void *addr, size_t size, u8 tag) > +{ > + u64 curr, end; > + > + if (!size) > + return; > + > + curr = (u64)__tag_set(addr, tag); > + end = curr + size; > + > + do { > + /* > + * 'asm volatile' is required to prevent the compiler to move > + * the statement outside of the loop. > + */ > + asm volatile(__MTE_PREAMBLE "stg %0, [%0]" > + : > + : "r" (curr) > + : "memory"); > + > + curr += MTE_GRANULE_SIZE; > + } while (curr != end); > +} > > void mte_enable_kernel_sync(void); > void mte_enable_kernel_async(void); > @@ -47,10 +95,12 @@ static inline u8 mte_get_mem_tag(void *addr) > { > return 0xFF; > } > + > static inline u8 mte_get_random_tag(void) > { > return 0xFF; > } > + > static inline void *mte_set_mem_tag_range(void *addr, size_t size, u8 tag) This function used to return a pointer and that's what the dummy static inline does here. However, the new mte_set_mem_tag_range() doesn't return anything. We should have consistency between the two (the new static void definition is fine by me). Otherwise the patch looks fine. Reviewed-by: Catalin Marinas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel