From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 538E6C433E0 for ; Tue, 2 Feb 2021 15:46:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1FECA64ECE for ; Tue, 2 Feb 2021 15:46:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235381AbhBBPqQ (ORCPT ); Tue, 2 Feb 2021 10:46:16 -0500 Received: from mail.kernel.org ([198.145.29.99]:46582 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235269AbhBBPoO (ORCPT ); Tue, 2 Feb 2021 10:44:14 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 149EB64F65; Tue, 2 Feb 2021 15:43:29 +0000 (UTC) Date: Tue, 2 Feb 2021 15:43:27 +0000 From: Catalin Marinas To: Andrey Konovalov Cc: Vincenzo Frascino , Dmitry Vyukov , Alexander Potapenko , Marco Elver , Andrew Morton , Will Deacon , Andrey Ryabinin , Peter Collingbourne , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 12/12] arm64: kasan: export MTE symbols for KASAN tests Message-ID: <20210202154327.GD26895@gaia> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 01, 2021 at 08:43:36PM +0100, Andrey Konovalov wrote: > Export mte_enable_kernel() and mte_set_report_once() to fix: > > ERROR: modpost: "mte_enable_kernel" [lib/test_kasan.ko] undefined! > ERROR: modpost: "mte_set_report_once" [lib/test_kasan.ko] undefined! > > Signed-off-by: Andrey Konovalov > --- > arch/arm64/kernel/mte.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/kernel/mte.c b/arch/arm64/kernel/mte.c > index 8b27b70e1aac..2c91bd288ea4 100644 > --- a/arch/arm64/kernel/mte.c > +++ b/arch/arm64/kernel/mte.c > @@ -120,6 +120,7 @@ void mte_enable_kernel_sync(void) > { > __mte_enable_kernel("synchronous", SCTLR_ELx_TCF_SYNC); > } > +EXPORT_SYMBOL(mte_enable_kernel_sync); > > void mte_enable_kernel_async(void) > { > @@ -130,6 +131,7 @@ void mte_set_report_once(bool state) > { > WRITE_ONCE(report_fault_once, state); > } > +EXPORT_SYMBOL(mte_set_report_once); With EXPORT_SYMBOL_GPL: Acked-by: Catalin Marinas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2BF8C433E0 for ; Tue, 2 Feb 2021 15:44:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8085764F4B for ; Tue, 2 Feb 2021 15:44:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8085764F4B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NrBeWtiJTBPhAWCoFPOB/GRjSZi3Fq5hj8U5em7ZEBk=; b=F6sHFbrrEXjph+sYvrcGG8Dzl NjQifsvTVu3dBTswOvhlpsyWGzxs8R7aEtDYb9piGqmIMVk14TyEWBXX54g9nfX5meZ+UaB0mJW5V pJoeB4UVjJpVPxy707b/p2CMiolJUeTBiTbOjO/+sy/SepYn3Es7ytpNd7mSbnTCoxOx9XsmrdoX3 953Mop3G+m1krl/FyvCXjrW0T4d2RnXjZad5Wt8JBhB11UroLLSNlNkk4UT/WG/iYLimORs3u0V/e XkjEZHTn++hvlCPqyl8GWV7FGTMfL4wsitR7lUZno2tmy12Qe6O4WnPAe4PLqiY78gFJ4yv9PgGV+ cD9V0eSkw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6xq6-0001EY-FM; Tue, 02 Feb 2021 15:43:38 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6xq1-0001Ci-HY for linux-arm-kernel@lists.infradead.org; Tue, 02 Feb 2021 15:43:36 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 149EB64F65; Tue, 2 Feb 2021 15:43:29 +0000 (UTC) Date: Tue, 2 Feb 2021 15:43:27 +0000 From: Catalin Marinas To: Andrey Konovalov Subject: Re: [PATCH 12/12] arm64: kasan: export MTE symbols for KASAN tests Message-ID: <20210202154327.GD26895@gaia> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210202_104333_664848_497CA892 X-CRM114-Status: GOOD ( 13.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Marco Elver , Kevin Brodsky , Will Deacon , Branislav Rankov , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alexander Potapenko , Evgenii Stepanov , Andrey Ryabinin , Andrew Morton , Vincenzo Frascino , Peter Collingbourne , Dmitry Vyukov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 01, 2021 at 08:43:36PM +0100, Andrey Konovalov wrote: > Export mte_enable_kernel() and mte_set_report_once() to fix: > > ERROR: modpost: "mte_enable_kernel" [lib/test_kasan.ko] undefined! > ERROR: modpost: "mte_set_report_once" [lib/test_kasan.ko] undefined! > > Signed-off-by: Andrey Konovalov > --- > arch/arm64/kernel/mte.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/kernel/mte.c b/arch/arm64/kernel/mte.c > index 8b27b70e1aac..2c91bd288ea4 100644 > --- a/arch/arm64/kernel/mte.c > +++ b/arch/arm64/kernel/mte.c > @@ -120,6 +120,7 @@ void mte_enable_kernel_sync(void) > { > __mte_enable_kernel("synchronous", SCTLR_ELx_TCF_SYNC); > } > +EXPORT_SYMBOL(mte_enable_kernel_sync); > > void mte_enable_kernel_async(void) > { > @@ -130,6 +131,7 @@ void mte_set_report_once(bool state) > { > WRITE_ONCE(report_fault_once, state); > } > +EXPORT_SYMBOL(mte_set_report_once); With EXPORT_SYMBOL_GPL: Acked-by: Catalin Marinas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel