* [PATCH u-boot-marvell] mmc: mv_sdhci: call mmc_of_parse()
@ 2021-02-02 17:37 ` Marek Behún
2021-02-02 17:52 ` Baruch Siach
2021-02-02 23:32 ` Jaehoon Chung
0 siblings, 2 replies; 9+ messages in thread
From: Marek Behún @ 2021-02-02 17:37 UTC (permalink / raw)
To: u-boot
This is needed to parse more capabilities such as `non-removable`.
Commit da18c62b6e6a ("mmc: sdhci: Implement SDHCI card detect") caused
a regression on Turris Omnia, because mv_sdhci driver did not fill out
host_caps from device-tree.
Signed-off-by: Marek Beh?n <marek.behun@nic.cz>
Fixes: da18c62b6e6a ("mmc: sdhci: Implement SDHCI card detect")
Cc: pali at kernel.org
Cc: Baruch Siach <baruch@tkos.co.il>
Cc: Stefan Roese <sr@denx.de>
---
drivers/mmc/mv_sdhci.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/mmc/mv_sdhci.c b/drivers/mmc/mv_sdhci.c
index 556dd38046..4dc4a0d2be 100644
--- a/drivers/mmc/mv_sdhci.c
+++ b/drivers/mmc/mv_sdhci.c
@@ -118,6 +118,10 @@ static int mv_sdhci_probe(struct udevice *dev)
host->mmc->dev = dev;
host->mmc->priv = host;
+ ret = mmc_of_parse(dev, &plat->cfg);
+ if (ret)
+ return ret;
+
ret = sdhci_setup_cfg(&plat->cfg, host, 0, 0);
if (ret)
return ret;
--
2.26.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH u-boot-marvell] mmc: mv_sdhci: call mmc_of_parse()
2021-02-02 17:37 ` [PATCH u-boot-marvell] mmc: mv_sdhci: call mmc_of_parse() Marek Behún
@ 2021-02-02 17:52 ` Baruch Siach
2021-02-02 18:02 ` Marek Behún
2021-02-02 23:32 ` Jaehoon Chung
1 sibling, 1 reply; 9+ messages in thread
From: Baruch Siach @ 2021-02-02 17:52 UTC (permalink / raw)
To: u-boot
Hi Marek,
On Tue, Feb 02 2021, Marek Beh?n wrote:
> This is needed to parse more capabilities such as `non-removable`.
>
> Commit da18c62b6e6a ("mmc: sdhci: Implement SDHCI card detect") caused
> a regression on Turris Omnia, because mv_sdhci driver did not fill out
> host_caps from device-tree.
I posted a similar patch earlier today:
https://patchwork.ozlabs.org/project/uboot/patch/7dcd24e8d0149618cf686c47cce6728a64dffe2b.1612248184.git.baruch at tkos.co.il/
> Signed-off-by: Marek Beh?n <marek.behun@nic.cz>
> Fixes: da18c62b6e6a ("mmc: sdhci: Implement SDHCI card detect")
My patch is missing this tag, though.
baruch
> Cc: pali at kernel.org
> Cc: Baruch Siach <baruch@tkos.co.il>
> Cc: Stefan Roese <sr@denx.de>
> ---
> drivers/mmc/mv_sdhci.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/mmc/mv_sdhci.c b/drivers/mmc/mv_sdhci.c
> index 556dd38046..4dc4a0d2be 100644
> --- a/drivers/mmc/mv_sdhci.c
> +++ b/drivers/mmc/mv_sdhci.c
> @@ -118,6 +118,10 @@ static int mv_sdhci_probe(struct udevice *dev)
> host->mmc->dev = dev;
> host->mmc->priv = host;
>
> + ret = mmc_of_parse(dev, &plat->cfg);
> + if (ret)
> + return ret;
> +
> ret = sdhci_setup_cfg(&plat->cfg, host, 0, 0);
> if (ret)
> return ret;
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH u-boot-marvell] mmc: mv_sdhci: call mmc_of_parse()
2021-02-02 17:52 ` Baruch Siach
@ 2021-02-02 18:02 ` Marek Behún
0 siblings, 0 replies; 9+ messages in thread
From: Marek Behún @ 2021-02-02 18:02 UTC (permalink / raw)
To: u-boot
> Hi Marek,
> I posted a similar patch earlier today:
> > Fixes: da18c62b6e6a ("mmc: sdhci: Implement SDHCI card detect")
> My patch is missing this tag, though.
> baruch
OK, lets leave it on Stefan to decide which one to apply.
Marek
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH u-boot-marvell] mmc: mv_sdhci: call mmc_of_parse()
2021-02-02 17:37 ` [PATCH u-boot-marvell] mmc: mv_sdhci: call mmc_of_parse() Marek Behún
2021-02-02 17:52 ` Baruch Siach
@ 2021-02-02 23:32 ` Jaehoon Chung
2021-02-03 13:41 ` Marek Behun
1 sibling, 1 reply; 9+ messages in thread
From: Jaehoon Chung @ 2021-02-02 23:32 UTC (permalink / raw)
To: u-boot
On 2/3/21 2:37 AM, Marek Beh?n wrote:
> This is needed to parse more capabilities such as `non-removable`.
>
> Commit da18c62b6e6a ("mmc: sdhci: Implement SDHCI card detect") caused
> a regression on Turris Omnia, because mv_sdhci driver did not fill out
> host_caps from device-tree.
>
> Signed-off-by: Marek Beh?n <marek.behun@nic.cz>
> Fixes: da18c62b6e6a ("mmc: sdhci: Implement SDHCI card detect")
I don't think that this patch is for fixing its commit.
Best Regards,
Jaehoon Chung
> Cc: pali at kernel.org
> Cc: Baruch Siach <baruch@tkos.co.il>
> Cc: Stefan Roese <sr@denx.de>
> ---
> drivers/mmc/mv_sdhci.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/mmc/mv_sdhci.c b/drivers/mmc/mv_sdhci.c
> index 556dd38046..4dc4a0d2be 100644
> --- a/drivers/mmc/mv_sdhci.c
> +++ b/drivers/mmc/mv_sdhci.c
> @@ -118,6 +118,10 @@ static int mv_sdhci_probe(struct udevice *dev)
> host->mmc->dev = dev;
> host->mmc->priv = host;
>
> + ret = mmc_of_parse(dev, &plat->cfg);
> + if (ret)
> + return ret;
> +
> ret = sdhci_setup_cfg(&plat->cfg, host, 0, 0);
> if (ret)
> return ret;
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH u-boot-marvell] mmc: mv_sdhci: call mmc_of_parse()
2021-02-02 23:32 ` Jaehoon Chung
@ 2021-02-03 13:41 ` Marek Behun
2021-02-03 22:18 ` Jaehoon Chung
0 siblings, 1 reply; 9+ messages in thread
From: Marek Behun @ 2021-02-03 13:41 UTC (permalink / raw)
To: u-boot
On Wed, 3 Feb 2021 08:32:45 +0900
Jaehoon Chung <jh80.chung@samsung.com> wrote:
> On 2/3/21 2:37 AM, Marek Beh?n wrote:
> > This is needed to parse more capabilities such as `non-removable`.
> >
> > Commit da18c62b6e6a ("mmc: sdhci: Implement SDHCI card detect") caused
> > a regression on Turris Omnia, because mv_sdhci driver did not fill out
> > host_caps from device-tree.
> >
> > Signed-off-by: Marek Beh?n <marek.behun@nic.cz>
> > Fixes: da18c62b6e6a ("mmc: sdhci: Implement SDHCI card detect")
>
> I don't think that this patch is for fixing its commit.
>
> Best Regards,
> Jaehoon Chung
Commit da18c62b6e6a causes the regression. The Fixes tag, as I
understand, should link to commit with which the regression first
occured, so that if someone wanted to backport my patch to previous
version of U-Boot, they would know that they only have to do it if
their repository contains that commit.
Marek
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH u-boot-marvell] mmc: mv_sdhci: call mmc_of_parse()
2021-02-03 13:41 ` Marek Behun
@ 2021-02-03 22:18 ` Jaehoon Chung
2021-02-04 16:38 ` Marek Behún
0 siblings, 1 reply; 9+ messages in thread
From: Jaehoon Chung @ 2021-02-03 22:18 UTC (permalink / raw)
To: u-boot
On 2/3/21 10:41 PM, Marek Behun wrote:
> On Wed, 3 Feb 2021 08:32:45 +0900
> Jaehoon Chung <jh80.chung@samsung.com> wrote:
>
>> On 2/3/21 2:37 AM, Marek Beh?n wrote:
>>> This is needed to parse more capabilities such as `non-removable`.
>>>
>>> Commit da18c62b6e6a ("mmc: sdhci: Implement SDHCI card detect") caused
>>> a regression on Turris Omnia, because mv_sdhci driver did not fill out
>>> host_caps from device-tree.
>>>
>>> Signed-off-by: Marek Beh?n <marek.behun@nic.cz>
>>> Fixes: da18c62b6e6a ("mmc: sdhci: Implement SDHCI card detect")
>>
>> I don't think that this patch is for fixing its commit.
>>
>> Best Regards,
>> Jaehoon Chung
>
> Commit da18c62b6e6a causes the regression. The Fixes tag, as I
> understand, should link to commit with which the regression first
> occured, so that if someone wanted to backport my patch to previous
> version of U-Boot, they would know that they only have to do it if
> their repository contains that commit.
Well, i don't think so. This patch is not a bug fix patch about commit da18c62b6e6a.
Just mv_sdhci driver didn't use mmc_of_parse() before.
(If someone set to MMC_NON_REMOVABLE capabilities in host->cap, it should be working.)
Not need to add *Fixes*. Its commit is a generic callback function.
And mmc_of_parse() is also generic function to use Driver-model.
Best Regards,
Jaehoon Chung
>
> Marek
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH u-boot-marvell] mmc: mv_sdhci: call mmc_of_parse()
2021-02-03 22:18 ` Jaehoon Chung
@ 2021-02-04 16:38 ` Marek Behún
2021-02-04 22:21 ` Jaehoon Chung
2021-02-08 11:40 ` Stefan Roese
0 siblings, 2 replies; 9+ messages in thread
From: Marek Behún @ 2021-02-04 16:38 UTC (permalink / raw)
To: u-boot
On Thu, 4 Feb 2021 07:18:23 +0900
Jaehoon Chung <jh80.chung@samsung.com> wrote:
> > Commit da18c62b6e6a causes the regression. The Fixes tag, as I
> > understand, should link to commit with which the regression first
> > occured, so that if someone wanted to backport my patch to previous
> > version of U-Boot, they would know that they only have to do it if
> > their repository contains that commit.
>
> Well, i don't think so. This patch is not a bug fix patch about
> commit da18c62b6e6a. Just mv_sdhci driver didn't use mmc_of_parse()
> before. (If someone set to MMC_NON_REMOVABLE capabilities in
> host->cap, it should be working.)
>
> Not need to add *Fixes*. Its commit is a generic callback function.
> And mmc_of_parse() is also generic function to use Driver-model.
Lets apply Baruch's version. I don't really care if the Fixes tag is
there or not...
Marek
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH u-boot-marvell] mmc: mv_sdhci: call mmc_of_parse()
2021-02-04 16:38 ` Marek Behún
@ 2021-02-04 22:21 ` Jaehoon Chung
2021-02-08 11:40 ` Stefan Roese
1 sibling, 0 replies; 9+ messages in thread
From: Jaehoon Chung @ 2021-02-04 22:21 UTC (permalink / raw)
To: u-boot
Dear Marek,
On 2/5/21 1:38 AM, Marek Beh?n wrote:
> On Thu, 4 Feb 2021 07:18:23 +0900
> Jaehoon Chung <jh80.chung@samsung.com> wrote:
>
>>> Commit da18c62b6e6a causes the regression. The Fixes tag, as I
>>> understand, should link to commit with which the regression first
>>> occured, so that if someone wanted to backport my patch to previous
>>> version of U-Boot, they would know that they only have to do it if
>>> their repository contains that commit.
>>
>> Well, i don't think so. This patch is not a bug fix patch about
>> commit da18c62b6e6a. Just mv_sdhci driver didn't use mmc_of_parse()
>> before. (If someone set to MMC_NON_REMOVABLE capabilities in
>> host->cap, it should be working.)
>>
>> Not need to add *Fixes*. Its commit is a generic callback function.
>> And mmc_of_parse() is also generic function to use Driver-model.
>
> Lets apply Baruch's version. I don't really care if the Fixes tag is
> there or not...
I don't have any objection with your patch. It was just my opinion.
But it needs to choose one of them. Yours and Baruch's patch are same.
If you want to add Fixes tags, i think that it has to add in Baruch's patch.
Because his patch was firstly posted than yours.
Best Regards,
Jaehoon Chung
>
> Marek
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH u-boot-marvell] mmc: mv_sdhci: call mmc_of_parse()
2021-02-04 16:38 ` Marek Behún
2021-02-04 22:21 ` Jaehoon Chung
@ 2021-02-08 11:40 ` Stefan Roese
1 sibling, 0 replies; 9+ messages in thread
From: Stefan Roese @ 2021-02-08 11:40 UTC (permalink / raw)
To: u-boot
On 04.02.21 17:38, Marek Beh?n wrote:
> On Thu, 4 Feb 2021 07:18:23 +0900
> Jaehoon Chung <jh80.chung@samsung.com> wrote:
>
>>> Commit da18c62b6e6a causes the regression. The Fixes tag, as I
>>> understand, should link to commit with which the regression first
>>> occured, so that if someone wanted to backport my patch to previous
>>> version of U-Boot, they would know that they only have to do it if
>>> their repository contains that commit.
>>
>> Well, i don't think so. This patch is not a bug fix patch about
>> commit da18c62b6e6a. Just mv_sdhci driver didn't use mmc_of_parse()
>> before. (If someone set to MMC_NON_REMOVABLE capabilities in
>> host->cap, it should be working.)
>>
>> Not need to add *Fixes*. Its commit is a generic callback function.
>> And mmc_of_parse() is also generic function to use Driver-model.
>
> Lets apply Baruch's version. I don't really care if the Fixes tag is
> there or not...
I'll pull in Baruch's patch now.
Thanks,
Stefan
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-02-08 11:40 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20210202173759epcas1p25f47e0c37663fa3db9da5b10c7f589e9@epcas1p2.samsung.com>
2021-02-02 17:37 ` [PATCH u-boot-marvell] mmc: mv_sdhci: call mmc_of_parse() Marek Behún
2021-02-02 17:52 ` Baruch Siach
2021-02-02 18:02 ` Marek Behún
2021-02-02 23:32 ` Jaehoon Chung
2021-02-03 13:41 ` Marek Behun
2021-02-03 22:18 ` Jaehoon Chung
2021-02-04 16:38 ` Marek Behún
2021-02-04 22:21 ` Jaehoon Chung
2021-02-08 11:40 ` Stefan Roese
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.