All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Stephen Boyd <sboyd@kernel.org>,
	Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	Daniel Palmer <daniel@thingy.jp>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
	Andrew Jeffery <andrew@aj.id.au>, Joel Stanley <joel@jms.id.au>,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	Vincent Cheng <vincent.cheng.xh@renesas.com>,
	linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org,
	linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org,
	iommu@lists.linux-foundation.org, linux-watchdog@vger.kernel.org
Subject: [PATCH 2/3] dt-bindings: iommu: renesas,ipmmu-vmsa: Make 'power-domains' conditionally required
Date: Tue,  2 Feb 2021 14:55:43 -0600	[thread overview]
Message-ID: <20210202205544.24812-2-robh@kernel.org> (raw)
In-Reply-To: <20210202205544.24812-1-robh@kernel.org>

Fixing the compatible string typos results in an error in the example:

Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.example.dt.yaml:
  iommu@fe951000: 'power-domains' is a required property

Based on the dts files, a 'power-domains' property only exists on Gen 3
which can be conditioned on !renesas,ipmmu-vmsa.

Cc: Joerg Roedel <joro@8bytes.org>
Cc: Will Deacon <will@kernel.org>
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: iommu@lists.linux-foundation.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
 .../bindings/iommu/renesas,ipmmu-vmsa.yaml           | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
index 349633108bbd..dda44976acc1 100644
--- a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
+++ b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
@@ -76,7 +76,6 @@ required:
   - compatible
   - reg
   - '#iommu-cells'
-  - power-domains
 
 oneOf:
   - required:
@@ -86,6 +85,17 @@ oneOf:
 
 additionalProperties: false
 
+allOf:
+  - if:
+      properties:
+        compatible:
+          not:
+            contains:
+              const: renesas,ipmmu-vmsa
+    then:
+      required:
+        - power-domains
+
 examples:
   - |
     #include <dt-bindings/clock/r8a7791-cpg-mssr.h>
-- 
2.27.0


WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: devicetree@vger.kernel.org
Cc: Tomer Maimon <tmaimon77@gmail.com>,
	Andrew Jeffery <andrew@aj.id.au>,
	Linus Walleij <linus.walleij@linaro.org>,
	Vincent Cheng <vincent.cheng.xh@renesas.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Daniel Palmer <daniel@thingy.jp>,
	linux-i2c@vger.kernel.org, Will Deacon <will@kernel.org>,
	linux-clk@vger.kernel.org,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	Chen-Yu Tsai <wens@csie.org>, Joel Stanley <joel@jms.id.au>,
	Guenter Roeck <linux@roeck-us.net>,
	linux-watchdog@vger.kernel.org,
	Maxime Ripard <mripard@kernel.org>,
	linux-gpio@vger.kernel.org,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	Avi Fishman <avifishman70@gmail.com>,
	linux-kernel@vger.kernel.org, Stephen Boyd <sboyd@kernel.org>,
	iommu@lists.linux-foundation.org, linux-crypto@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>
Subject: [PATCH 2/3] dt-bindings: iommu: renesas, ipmmu-vmsa: Make 'power-domains' conditionally required
Date: Tue,  2 Feb 2021 14:55:43 -0600	[thread overview]
Message-ID: <20210202205544.24812-2-robh@kernel.org> (raw)
In-Reply-To: <20210202205544.24812-1-robh@kernel.org>

Fixing the compatible string typos results in an error in the example:

Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.example.dt.yaml:
  iommu@fe951000: 'power-domains' is a required property

Based on the dts files, a 'power-domains' property only exists on Gen 3
which can be conditioned on !renesas,ipmmu-vmsa.

Cc: Joerg Roedel <joro@8bytes.org>
Cc: Will Deacon <will@kernel.org>
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: iommu@lists.linux-foundation.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
 .../bindings/iommu/renesas,ipmmu-vmsa.yaml           | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
index 349633108bbd..dda44976acc1 100644
--- a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
+++ b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
@@ -76,7 +76,6 @@ required:
   - compatible
   - reg
   - '#iommu-cells'
-  - power-domains
 
 oneOf:
   - required:
@@ -86,6 +85,17 @@ oneOf:
 
 additionalProperties: false
 
+allOf:
+  - if:
+      properties:
+        compatible:
+          not:
+            contains:
+              const: renesas,ipmmu-vmsa
+    then:
+      required:
+        - power-domains
+
 examples:
   - |
     #include <dt-bindings/clock/r8a7791-cpg-mssr.h>
-- 
2.27.0

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

  reply	other threads:[~2021-02-02 20:57 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-02 20:55 [PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples Rob Herring
2021-02-02 20:55 ` Rob Herring
2021-02-02 20:55 ` Rob Herring [this message]
2021-02-02 20:55   ` [PATCH 2/3] dt-bindings: iommu: renesas, ipmmu-vmsa: Make 'power-domains' conditionally required Rob Herring
2021-02-04  1:23   ` [PATCH 2/3] dt-bindings: iommu: renesas,ipmmu-vmsa: " Yoshihiro Shimoda
2021-02-04  1:23     ` Yoshihiro Shimoda
2021-02-02 20:55 ` [PATCH 3/3] dt-bindings: Fix errors in 'if' schemas Rob Herring
2021-02-02 20:55   ` Rob Herring
2021-02-02 20:55   ` Rob Herring
2021-02-03  8:01   ` Geert Uytterhoeven
2021-02-03  8:01     ` Geert Uytterhoeven
2021-02-03  8:01     ` Geert Uytterhoeven
2021-02-03 15:55     ` Rob Herring
2021-02-03 15:55       ` Rob Herring
2021-02-03 15:55       ` Rob Herring
2021-02-03 16:02       ` Geert Uytterhoeven
2021-02-03 16:02         ` Geert Uytterhoeven
2021-02-03 16:02         ` Geert Uytterhoeven
2021-02-03  8:22   ` Maxime Ripard
2021-02-03  8:22     ` Maxime Ripard
2021-02-03  8:22     ` Maxime Ripard
2021-02-03 11:22   ` Vinod Koul
2021-02-03 11:22     ` Vinod Koul
2021-02-03 11:22     ` Vinod Koul
2021-02-03 11:55   ` Nicolas Saenz Julienne
2021-02-03 11:55     ` Nicolas Saenz Julienne
2021-02-03 11:55     ` Nicolas Saenz Julienne
2021-02-02 21:03 ` [PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples Guenter Roeck
2021-02-02 21:03   ` Guenter Roeck
2021-02-02 22:26 ` Andrew Jeffery
2021-02-02 22:26   ` Andrew Jeffery
2021-02-03  0:33 ` Stephen Boyd
2021-02-03  8:22   ` Maxime Ripard
2021-02-03  8:22     ` Maxime Ripard
2021-02-03 21:09   ` Rob Herring
2021-02-03 21:09     ` Rob Herring
2021-02-03  9:35 ` Linus Walleij
2021-02-03  9:35   ` Linus Walleij
2021-02-03  9:48 ` Daniel Palmer
2021-02-03  9:48   ` Daniel Palmer
2021-02-04  0:46 ` Yoshihiro Shimoda
2021-02-04  0:46   ` Yoshihiro Shimoda
2021-02-06  1:25 ` Wolfram Sang
2021-02-06  1:25   ` Wolfram Sang
2021-02-06  1:44 ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210202205544.24812-2-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=andrew@aj.id.au \
    --cc=avifishman70@gmail.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=daniel@thingy.jp \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joel@jms.id.au \
    --cc=joro@8bytes.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mripard@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=tali.perry1@gmail.com \
    --cc=tmaimon77@gmail.com \
    --cc=vincent.cheng.xh@renesas.com \
    --cc=wens@csie.org \
    --cc=will@kernel.org \
    --cc=wim@linux-watchdog.org \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.