Re: [PATCH] 9p: Convert to cut-down fscache I/O API rewrite

[Dominique Martinet <asmadeus@codewreck.org>]

Hi David,

David Howells wrote on Tue, Feb 02, 2021 at 11:04:23AM +0000:
> Here's a draft of a patch to convert 9P to use the cut-down part of the
> fscache I/O API rewrite (I've removed all the cookie and object state machine
> changes for now).  It compiles, but I've no way to test it.  This is built on
> top of my fscache-netfs-lib branch:
> 
> 	https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=fscache-netfs-lib

Thanks for going the extra mile with all this, it's appreciated!

> I'm hoping to ask Linus to pull the netfs lib, afs and ceph changes in the
> next merge window.
> 
> Would you be able to give it a whirl?

I'm afraid I won't have much time to give for the next merge window (in
roughly 2-4 weeks iiuc)
I can probably find some time to run very basic tests from my usual
setup but testing actual fscache capabilities will take more time and
I'm quite short right now -- I honestly have no idea if anyone uses
fscache or if it's even working right now so I'd rather take a moment to
test it properly before/after, and it's time I don't have right now.


OTOH I'd support getting the netfs lib in as planned this merge window,
and I'll definitely take the time to test this patch into my tree before
the next one in ~3months.
I think the whole point of the rework you've done is we can do things
more smoothly and there is no reason to rush it anymore, having the new
lib get tested through afs/ceph in the real world can only be reassuring
for other filesystems.

Cheers,
-- 
Dominique