* [PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples
@ 2021-02-02 20:55 ` Rob Herring
0 siblings, 0 replies; 45+ messages in thread
From: Rob Herring @ 2021-02-02 20:55 UTC (permalink / raw)
To: devicetree
Cc: linux-kernel, Stephen Boyd, Maxime Ripard, Chen-Yu Tsai,
Linus Walleij, Herbert Xu, David S. Miller, Daniel Palmer,
Bartosz Golaszewski, Avi Fishman, Tomer Maimon, Tali Perry,
Joerg Roedel, Will Deacon, Andrew Jeffery, Joel Stanley,
Wim Van Sebroeck, Guenter Roeck, Yoshihiro Shimoda,
Vincent Cheng, linux-clk, linux-crypto, linux-gpio, linux-i2c,
iommu, linux-watchdog
Running 'dt-validate -m' will flag any compatible strings missing a schema.
Fix all the errors found in DT binding examples. Most of these are just
typos.
Cc: Stephen Boyd <sboyd@kernel.org>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Daniel Palmer <daniel@thingy.jp>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Avi Fishman <avifishman70@gmail.com>
Cc: Tomer Maimon <tmaimon77@gmail.com>
Cc: Tali Perry <tali.perry1@gmail.com>
Cc: Joerg Roedel <joro@8bytes.org>
Cc: Will Deacon <will@kernel.org>
Cc: Andrew Jeffery <andrew@aj.id.au>
Cc: Joel Stanley <joel@jms.id.au>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: Vincent Cheng <vincent.cheng.xh@renesas.com>
Cc: linux-clk@vger.kernel.org
Cc: linux-crypto@vger.kernel.org
Cc: linux-gpio@vger.kernel.org
Cc: linux-i2c@vger.kernel.org
Cc: iommu@lists.linux-foundation.org
Cc: linux-watchdog@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
.../bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml | 2 +-
Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml | 4 ++--
Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml | 2 +-
Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml | 2 +-
.../devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml | 2 +-
.../devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml | 2 +-
.../devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml | 2 +-
.../devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml | 2 +-
.../devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml | 2 +-
Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml | 4 +---
Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml | 4 ++--
11 files changed, 13 insertions(+), 15 deletions(-)
diff --git a/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml b/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
index fa0ee03a527f..53cc6df0df96 100644
--- a/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
+++ b/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
@@ -18,7 +18,7 @@ properties:
const: 1
compatible:
- const: allwinner,sun9i-a80-usb-clocks
+ const: allwinner,sun9i-a80-usb-clks
reg:
maxItems: 1
diff --git a/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml b/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
index eb241587efd1..118c5543e037 100644
--- a/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
+++ b/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
@@ -66,8 +66,8 @@ properties:
- arm,syscon-icst525-integratorcp-cm-mem
- arm,integrator-cm-auxosc
- arm,versatile-cm-auxosc
- - arm,impd-vco1
- - arm,impd-vco2
+ - arm,impd1-vco1
+ - arm,impd1-vco2
clocks:
description: Parent clock for the ICST VCO
diff --git a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
index 1465c9ebaf93..1d48ac712b23 100644
--- a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
+++ b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
@@ -66,7 +66,7 @@ examples:
#include <dt-bindings/soc/ti,sci_pm_domain.h>
main_crypto: crypto@4e00000 {
- compatible = "ti,j721-sa2ul";
+ compatible = "ti,j721e-sa2ul";
reg = <0x4e00000 0x1200>;
power-domains = <&k3_pds 264 TI_SCI_PD_EXCLUSIVE>;
dmas = <&main_udmap 0xc000>, <&main_udmap 0x4000>,
diff --git a/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml b/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
index 1f2ef408bb43..fe1e1c63ffe3 100644
--- a/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
+++ b/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
@@ -46,7 +46,7 @@ examples:
#include <dt-bindings/gpio/msc313-gpio.h>
gpio: gpio@207800 {
- compatible = "mstar,msc313e-gpio";
+ compatible = "mstar,msc313-gpio";
#gpio-cells = <2>;
reg = <0x207800 0x200>;
gpio-controller;
diff --git a/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml b/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
index e3ef2d36f372..128444942aec 100644
--- a/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
+++ b/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
@@ -17,7 +17,7 @@ maintainers:
properties:
compatible:
- const: nuvoton,npcm7xx-i2c
+ const: nuvoton,npcm750-i2c
reg:
maxItems: 1
diff --git a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
index cde1afa8dfd6..349633108bbd 100644
--- a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
+++ b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
@@ -93,7 +93,7 @@ examples:
#include <dt-bindings/power/r8a7791-sysc.h>
ipmmu_mx: iommu@fe951000 {
- compatible = "renasas,ipmmu-r8a7791", "renasas,ipmmu-vmsa";
+ compatible = "renesas,ipmmu-r8a7791", "renesas,ipmmu-vmsa";
reg = <0xfe951000 0x1000>;
interrupts = <GIC_SPI 222 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 221 IRQ_TYPE_LEVEL_HIGH>;
diff --git a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml
index 54631dc1adb0..5dbb84049ff6 100644
--- a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml
@@ -63,7 +63,7 @@ examples:
reg = <0x1e6e2000 0x1a8>;
pinctrl: pinctrl {
- compatible = "aspeed,g4-pinctrl";
+ compatible = "aspeed,ast2400-pinctrl";
pinctrl_i2c3_default: i2c3_default {
function = "I2C3";
diff --git a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml
index a90c0fe0495f..ad1c33364b38 100644
--- a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml
@@ -81,7 +81,7 @@ examples:
reg = <0x1e6e2000 0x1a8>;
pinctrl: pinctrl {
- compatible = "aspeed,g5-pinctrl";
+ compatible = "aspeed,ast2500-pinctrl";
aspeed,external-nodes = <&gfx>, <&lhc>;
pinctrl_i2c3_default: i2c3_default {
diff --git a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml
index c78ab7e2eee7..ad91c0bc54da 100644
--- a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml
@@ -95,7 +95,7 @@ examples:
reg = <0x1e6e2000 0xf6c>;
pinctrl: pinctrl {
- compatible = "aspeed,g6-pinctrl";
+ compatible = "aspeed,ast2600-pinctrl";
pinctrl_pwm10g1_default: pwm10g1_default {
function = "PWM10";
diff --git a/Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml b/Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml
index 239b49fad805..658cec67743e 100644
--- a/Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml
+++ b/Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml
@@ -59,9 +59,7 @@ additionalProperties: false
examples:
- |
- i2c@1 {
- compatible = "abc,acme-1234";
- reg = <0x01 0x400>;
+ i2c {
#address-cells = <1>;
#size-cells = <0>;
phc@5b {
diff --git a/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml b/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml
index c1348db59374..054584d7543a 100644
--- a/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml
@@ -57,8 +57,8 @@ examples:
*/
#include <dt-bindings/soc/ti,sci_pm_domain.h>
- watchdog0: rti@2200000 {
- compatible = "ti,rti-wdt";
+ watchdog@2200000 {
+ compatible = "ti,j7-rti-wdt";
reg = <0x2200000 0x100>;
clocks = <&k3_clks 252 1>;
power-domains = <&k3_pds 252 TI_SCI_PD_EXCLUSIVE>;
--
2.27.0
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples
@ 2021-02-02 20:55 ` Rob Herring
0 siblings, 0 replies; 45+ messages in thread
From: Rob Herring @ 2021-02-02 20:55 UTC (permalink / raw)
To: devicetree
Cc: Tomer Maimon, Andrew Jeffery, Linus Walleij, Vincent Cheng,
Tali Perry, Daniel Palmer, linux-i2c, Will Deacon, linux-clk,
Herbert Xu, Bartosz Golaszewski, Chen-Yu Tsai, Joel Stanley,
Guenter Roeck, linux-watchdog, Maxime Ripard, linux-gpio,
Wim Van Sebroeck, Avi Fishman, linux-kernel, Stephen Boyd, iommu,
linux-crypto, David S. Miller
Running 'dt-validate -m' will flag any compatible strings missing a schema.
Fix all the errors found in DT binding examples. Most of these are just
typos.
Cc: Stephen Boyd <sboyd@kernel.org>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Daniel Palmer <daniel@thingy.jp>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Avi Fishman <avifishman70@gmail.com>
Cc: Tomer Maimon <tmaimon77@gmail.com>
Cc: Tali Perry <tali.perry1@gmail.com>
Cc: Joerg Roedel <joro@8bytes.org>
Cc: Will Deacon <will@kernel.org>
Cc: Andrew Jeffery <andrew@aj.id.au>
Cc: Joel Stanley <joel@jms.id.au>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: Vincent Cheng <vincent.cheng.xh@renesas.com>
Cc: linux-clk@vger.kernel.org
Cc: linux-crypto@vger.kernel.org
Cc: linux-gpio@vger.kernel.org
Cc: linux-i2c@vger.kernel.org
Cc: iommu@lists.linux-foundation.org
Cc: linux-watchdog@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
.../bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml | 2 +-
Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml | 4 ++--
Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml | 2 +-
Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml | 2 +-
.../devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml | 2 +-
.../devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml | 2 +-
.../devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml | 2 +-
.../devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml | 2 +-
.../devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml | 2 +-
Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml | 4 +---
Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml | 4 ++--
11 files changed, 13 insertions(+), 15 deletions(-)
diff --git a/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml b/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
index fa0ee03a527f..53cc6df0df96 100644
--- a/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
+++ b/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
@@ -18,7 +18,7 @@ properties:
const: 1
compatible:
- const: allwinner,sun9i-a80-usb-clocks
+ const: allwinner,sun9i-a80-usb-clks
reg:
maxItems: 1
diff --git a/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml b/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
index eb241587efd1..118c5543e037 100644
--- a/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
+++ b/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
@@ -66,8 +66,8 @@ properties:
- arm,syscon-icst525-integratorcp-cm-mem
- arm,integrator-cm-auxosc
- arm,versatile-cm-auxosc
- - arm,impd-vco1
- - arm,impd-vco2
+ - arm,impd1-vco1
+ - arm,impd1-vco2
clocks:
description: Parent clock for the ICST VCO
diff --git a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
index 1465c9ebaf93..1d48ac712b23 100644
--- a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
+++ b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
@@ -66,7 +66,7 @@ examples:
#include <dt-bindings/soc/ti,sci_pm_domain.h>
main_crypto: crypto@4e00000 {
- compatible = "ti,j721-sa2ul";
+ compatible = "ti,j721e-sa2ul";
reg = <0x4e00000 0x1200>;
power-domains = <&k3_pds 264 TI_SCI_PD_EXCLUSIVE>;
dmas = <&main_udmap 0xc000>, <&main_udmap 0x4000>,
diff --git a/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml b/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
index 1f2ef408bb43..fe1e1c63ffe3 100644
--- a/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
+++ b/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
@@ -46,7 +46,7 @@ examples:
#include <dt-bindings/gpio/msc313-gpio.h>
gpio: gpio@207800 {
- compatible = "mstar,msc313e-gpio";
+ compatible = "mstar,msc313-gpio";
#gpio-cells = <2>;
reg = <0x207800 0x200>;
gpio-controller;
diff --git a/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml b/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
index e3ef2d36f372..128444942aec 100644
--- a/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
+++ b/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
@@ -17,7 +17,7 @@ maintainers:
properties:
compatible:
- const: nuvoton,npcm7xx-i2c
+ const: nuvoton,npcm750-i2c
reg:
maxItems: 1
diff --git a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
index cde1afa8dfd6..349633108bbd 100644
--- a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
+++ b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
@@ -93,7 +93,7 @@ examples:
#include <dt-bindings/power/r8a7791-sysc.h>
ipmmu_mx: iommu@fe951000 {
- compatible = "renasas,ipmmu-r8a7791", "renasas,ipmmu-vmsa";
+ compatible = "renesas,ipmmu-r8a7791", "renesas,ipmmu-vmsa";
reg = <0xfe951000 0x1000>;
interrupts = <GIC_SPI 222 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 221 IRQ_TYPE_LEVEL_HIGH>;
diff --git a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml
index 54631dc1adb0..5dbb84049ff6 100644
--- a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml
@@ -63,7 +63,7 @@ examples:
reg = <0x1e6e2000 0x1a8>;
pinctrl: pinctrl {
- compatible = "aspeed,g4-pinctrl";
+ compatible = "aspeed,ast2400-pinctrl";
pinctrl_i2c3_default: i2c3_default {
function = "I2C3";
diff --git a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml
index a90c0fe0495f..ad1c33364b38 100644
--- a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml
@@ -81,7 +81,7 @@ examples:
reg = <0x1e6e2000 0x1a8>;
pinctrl: pinctrl {
- compatible = "aspeed,g5-pinctrl";
+ compatible = "aspeed,ast2500-pinctrl";
aspeed,external-nodes = <&gfx>, <&lhc>;
pinctrl_i2c3_default: i2c3_default {
diff --git a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml
index c78ab7e2eee7..ad91c0bc54da 100644
--- a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml
@@ -95,7 +95,7 @@ examples:
reg = <0x1e6e2000 0xf6c>;
pinctrl: pinctrl {
- compatible = "aspeed,g6-pinctrl";
+ compatible = "aspeed,ast2600-pinctrl";
pinctrl_pwm10g1_default: pwm10g1_default {
function = "PWM10";
diff --git a/Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml b/Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml
index 239b49fad805..658cec67743e 100644
--- a/Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml
+++ b/Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml
@@ -59,9 +59,7 @@ additionalProperties: false
examples:
- |
- i2c@1 {
- compatible = "abc,acme-1234";
- reg = <0x01 0x400>;
+ i2c {
#address-cells = <1>;
#size-cells = <0>;
phc@5b {
diff --git a/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml b/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml
index c1348db59374..054584d7543a 100644
--- a/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml
@@ -57,8 +57,8 @@ examples:
*/
#include <dt-bindings/soc/ti,sci_pm_domain.h>
- watchdog0: rti@2200000 {
- compatible = "ti,rti-wdt";
+ watchdog@2200000 {
+ compatible = "ti,j7-rti-wdt";
reg = <0x2200000 0x100>;
clocks = <&k3_clks 252 1>;
power-domains = <&k3_pds 252 TI_SCI_PD_EXCLUSIVE>;
--
2.27.0
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PATCH 2/3] dt-bindings: iommu: renesas,ipmmu-vmsa: Make 'power-domains' conditionally required
2021-02-02 20:55 ` Rob Herring
@ 2021-02-02 20:55 ` Rob Herring
-1 siblings, 0 replies; 45+ messages in thread
From: Rob Herring @ 2021-02-02 20:55 UTC (permalink / raw)
To: devicetree
Cc: linux-kernel, Stephen Boyd, Maxime Ripard, Chen-Yu Tsai,
Linus Walleij, Herbert Xu, David S. Miller, Daniel Palmer,
Bartosz Golaszewski, Avi Fishman, Tomer Maimon, Tali Perry,
Joerg Roedel, Will Deacon, Andrew Jeffery, Joel Stanley,
Wim Van Sebroeck, Guenter Roeck, Yoshihiro Shimoda,
Vincent Cheng, linux-clk, linux-crypto, linux-gpio, linux-i2c,
iommu, linux-watchdog
Fixing the compatible string typos results in an error in the example:
Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.example.dt.yaml:
iommu@fe951000: 'power-domains' is a required property
Based on the dts files, a 'power-domains' property only exists on Gen 3
which can be conditioned on !renesas,ipmmu-vmsa.
Cc: Joerg Roedel <joro@8bytes.org>
Cc: Will Deacon <will@kernel.org>
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: iommu@lists.linux-foundation.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
.../bindings/iommu/renesas,ipmmu-vmsa.yaml | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
index 349633108bbd..dda44976acc1 100644
--- a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
+++ b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
@@ -76,7 +76,6 @@ required:
- compatible
- reg
- '#iommu-cells'
- - power-domains
oneOf:
- required:
@@ -86,6 +85,17 @@ oneOf:
additionalProperties: false
+allOf:
+ - if:
+ properties:
+ compatible:
+ not:
+ contains:
+ const: renesas,ipmmu-vmsa
+ then:
+ required:
+ - power-domains
+
examples:
- |
#include <dt-bindings/clock/r8a7791-cpg-mssr.h>
--
2.27.0
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PATCH 2/3] dt-bindings: iommu: renesas, ipmmu-vmsa: Make 'power-domains' conditionally required
@ 2021-02-02 20:55 ` Rob Herring
0 siblings, 0 replies; 45+ messages in thread
From: Rob Herring @ 2021-02-02 20:55 UTC (permalink / raw)
To: devicetree
Cc: Tomer Maimon, Andrew Jeffery, Linus Walleij, Vincent Cheng,
Tali Perry, Daniel Palmer, linux-i2c, Will Deacon, linux-clk,
Herbert Xu, Bartosz Golaszewski, Chen-Yu Tsai, Joel Stanley,
Guenter Roeck, linux-watchdog, Maxime Ripard, linux-gpio,
Wim Van Sebroeck, Avi Fishman, linux-kernel, Stephen Boyd, iommu,
linux-crypto, David S. Miller
Fixing the compatible string typos results in an error in the example:
Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.example.dt.yaml:
iommu@fe951000: 'power-domains' is a required property
Based on the dts files, a 'power-domains' property only exists on Gen 3
which can be conditioned on !renesas,ipmmu-vmsa.
Cc: Joerg Roedel <joro@8bytes.org>
Cc: Will Deacon <will@kernel.org>
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: iommu@lists.linux-foundation.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
.../bindings/iommu/renesas,ipmmu-vmsa.yaml | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
index 349633108bbd..dda44976acc1 100644
--- a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
+++ b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
@@ -76,7 +76,6 @@ required:
- compatible
- reg
- '#iommu-cells'
- - power-domains
oneOf:
- required:
@@ -86,6 +85,17 @@ oneOf:
additionalProperties: false
+allOf:
+ - if:
+ properties:
+ compatible:
+ not:
+ contains:
+ const: renesas,ipmmu-vmsa
+ then:
+ required:
+ - power-domains
+
examples:
- |
#include <dt-bindings/clock/r8a7791-cpg-mssr.h>
--
2.27.0
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PATCH 3/3] dt-bindings: Fix errors in 'if' schemas
2021-02-02 20:55 ` Rob Herring
(?)
@ 2021-02-02 20:55 ` Rob Herring
-1 siblings, 0 replies; 45+ messages in thread
From: Rob Herring @ 2021-02-02 20:55 UTC (permalink / raw)
To: devicetree
Cc: linux-kernel, Stephen Boyd, Maxime Ripard, Chen-Yu Tsai,
Linus Walleij, Herbert Xu, David S. Miller, Daniel Palmer,
Bartosz Golaszewski, Avi Fishman, Tomer Maimon, Tali Perry,
Joerg Roedel, Will Deacon, Andrew Jeffery, Joel Stanley,
Wim Van Sebroeck, Guenter Roeck, Yoshihiro Shimoda,
Vincent Cheng, linux-clk, linux-crypto, linux-gpio, linux-i2c,
iommu, linux-watchdog, Eric Anholt, Nicolas Saenz Julienne,
Florian Fainelli, Ray Jui, Scott Branden, Pavel Machek,
Ulf Hansson, Kishon Vijay Abraham I, Vinod Koul,
Geert Uytterhoeven, Daniel Lezcano, dri-devel, linux-leds,
linux-mmc
Properties in if/then schemas weren't getting checked by the meta-schemas.
Enabling meta-schema checks finds several errors.
The use of an 'items' schema (as opposed to the list form) is wrong in
some cases as it applies to all entries. 'contains' is the correct schema
to use in the case of multiple entries.
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: Eric Anholt <eric@anholt.net>
Cc: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: Ray Jui <rjui@broadcom.com>
Cc: Scott Branden <sbranden@broadcom.com>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Vinod Koul <vkoul@kernel.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: linux-crypto@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: linux-leds@vger.kernel.org
Cc: linux-mmc@vger.kernel.org
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
.../devicetree/bindings/crypto/allwinner,sun8i-ce.yaml | 3 +--
.../devicetree/bindings/display/brcm,bcm2835-hvs.yaml | 2 +-
Documentation/devicetree/bindings/leds/ti,tca6507.yaml | 1 +
Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml | 2 +-
Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml | 3 +--
.../devicetree/bindings/phy/renesas,usb2-phy.yaml | 5 ++---
.../devicetree/bindings/pinctrl/renesas,pfc.yaml | 9 ++++-----
.../bindings/timer/allwinner,sun5i-a13-hstimer.yaml | 3 +--
8 files changed, 12 insertions(+), 16 deletions(-)
diff --git a/Documentation/devicetree/bindings/crypto/allwinner,sun8i-ce.yaml b/Documentation/devicetree/bindings/crypto/allwinner,sun8i-ce.yaml
index 7a60d84289cc..6ab07eba7778 100644
--- a/Documentation/devicetree/bindings/crypto/allwinner,sun8i-ce.yaml
+++ b/Documentation/devicetree/bindings/crypto/allwinner,sun8i-ce.yaml
@@ -46,8 +46,7 @@ properties:
if:
properties:
compatible:
- items:
- const: allwinner,sun50i-h6-crypto
+ const: allwinner,sun50i-h6-crypto
then:
properties:
clocks:
diff --git a/Documentation/devicetree/bindings/display/brcm,bcm2835-hvs.yaml b/Documentation/devicetree/bindings/display/brcm,bcm2835-hvs.yaml
index e826ab0adb75..2e8566f47e63 100644
--- a/Documentation/devicetree/bindings/display/brcm,bcm2835-hvs.yaml
+++ b/Documentation/devicetree/bindings/display/brcm,bcm2835-hvs.yaml
@@ -36,7 +36,7 @@ if:
properties:
compatible:
contains:
- const: brcm,bcm2711-hvs"
+ const: brcm,bcm2711-hvs
then:
required:
diff --git a/Documentation/devicetree/bindings/leds/ti,tca6507.yaml b/Documentation/devicetree/bindings/leds/ti,tca6507.yaml
index 94c307c98762..32c600387895 100644
--- a/Documentation/devicetree/bindings/leds/ti,tca6507.yaml
+++ b/Documentation/devicetree/bindings/leds/ti,tca6507.yaml
@@ -69,6 +69,7 @@ patternProperties:
if:
patternProperties:
"^gpio@[0-6]$":
+ type: object
properties:
compatible:
contains:
diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
index 6bbf29b5c239..6c13703b31db 100644
--- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
+++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
@@ -123,7 +123,7 @@ required:
if:
properties:
compatible:
- items:
+ contains:
enum:
- renesas,sdhi-r7s72100
- renesas,sdhi-r7s9210
diff --git a/Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml b/Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml
index 58c3ef8004ad..04edda504ab6 100644
--- a/Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml
@@ -99,8 +99,7 @@ patternProperties:
if:
properties:
compatible:
- items:
- const: brcm,iproc-ns2-sata-phy
+ const: brcm,iproc-ns2-sata-phy
then:
properties:
reg:
diff --git a/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml b/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
index 829e8c7e467a..0f358d5b84ef 100644
--- a/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
@@ -81,9 +81,8 @@ properties:
if:
properties:
compatible:
- items:
- enum:
- - renesas,usb2-phy-r7s9210
+ contains:
+ const: renesas,usb2-phy-r7s9210
then:
required:
- clock-names
diff --git a/Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml b/Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml
index 5b5b1b9d2ec7..5d3947902f2d 100644
--- a/Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml
@@ -76,11 +76,10 @@ required:
if:
properties:
compatible:
- items:
- enum:
- - renesas,pfc-r8a73a4
- - renesas,pfc-r8a7740
- - renesas,pfc-sh73a0
+ enum:
+ - renesas,pfc-r8a73a4
+ - renesas,pfc-r8a7740
+ - renesas,pfc-sh73a0
then:
required:
- interrupts-extended
diff --git a/Documentation/devicetree/bindings/timer/allwinner,sun5i-a13-hstimer.yaml b/Documentation/devicetree/bindings/timer/allwinner,sun5i-a13-hstimer.yaml
index 40fc4bcb3145..b6a6d03a08b2 100644
--- a/Documentation/devicetree/bindings/timer/allwinner,sun5i-a13-hstimer.yaml
+++ b/Documentation/devicetree/bindings/timer/allwinner,sun5i-a13-hstimer.yaml
@@ -46,8 +46,7 @@ required:
if:
properties:
compatible:
- items:
- const: allwinner,sun5i-a13-hstimer
+ const: allwinner,sun5i-a13-hstimer
then:
properties:
--
2.27.0
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PATCH 3/3] dt-bindings: Fix errors in 'if' schemas
@ 2021-02-02 20:55 ` Rob Herring
0 siblings, 0 replies; 45+ messages in thread
From: Rob Herring @ 2021-02-02 20:55 UTC (permalink / raw)
To: devicetree
Cc: Ulf Hansson, Tomer Maimon, Geert Uytterhoeven, Andrew Jeffery,
Linus Walleij, Vincent Cheng, dri-devel, Tali Perry, Eric Anholt,
Daniel Palmer, linux-i2c, Pavel Machek, Will Deacon, linux-clk,
linux-leds, Florian Fainelli, Herbert Xu, Daniel Lezcano,
Vinod Koul, Kishon Vijay Abraham I, Bartosz Golaszewski,
Chen-Yu Tsai, Joel Stanley, Guenter Roeck, linux-watchdog,
Ray Jui, Maxime Ripard, linux-gpio, Wim Van Sebroeck,
Scott Branden, Avi Fishman, linux-mmc, linux-kernel,
Stephen Boyd, iommu, linux-crypto, David S. Miller
Properties in if/then schemas weren't getting checked by the meta-schemas.
Enabling meta-schema checks finds several errors.
The use of an 'items' schema (as opposed to the list form) is wrong in
some cases as it applies to all entries. 'contains' is the correct schema
to use in the case of multiple entries.
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: Eric Anholt <eric@anholt.net>
Cc: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: Ray Jui <rjui@broadcom.com>
Cc: Scott Branden <sbranden@broadcom.com>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Vinod Koul <vkoul@kernel.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: linux-crypto@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: linux-leds@vger.kernel.org
Cc: linux-mmc@vger.kernel.org
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
.../devicetree/bindings/crypto/allwinner,sun8i-ce.yaml | 3 +--
.../devicetree/bindings/display/brcm,bcm2835-hvs.yaml | 2 +-
Documentation/devicetree/bindings/leds/ti,tca6507.yaml | 1 +
Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml | 2 +-
Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml | 3 +--
.../devicetree/bindings/phy/renesas,usb2-phy.yaml | 5 ++---
.../devicetree/bindings/pinctrl/renesas,pfc.yaml | 9 ++++-----
.../bindings/timer/allwinner,sun5i-a13-hstimer.yaml | 3 +--
8 files changed, 12 insertions(+), 16 deletions(-)
diff --git a/Documentation/devicetree/bindings/crypto/allwinner,sun8i-ce.yaml b/Documentation/devicetree/bindings/crypto/allwinner,sun8i-ce.yaml
index 7a60d84289cc..6ab07eba7778 100644
--- a/Documentation/devicetree/bindings/crypto/allwinner,sun8i-ce.yaml
+++ b/Documentation/devicetree/bindings/crypto/allwinner,sun8i-ce.yaml
@@ -46,8 +46,7 @@ properties:
if:
properties:
compatible:
- items:
- const: allwinner,sun50i-h6-crypto
+ const: allwinner,sun50i-h6-crypto
then:
properties:
clocks:
diff --git a/Documentation/devicetree/bindings/display/brcm,bcm2835-hvs.yaml b/Documentation/devicetree/bindings/display/brcm,bcm2835-hvs.yaml
index e826ab0adb75..2e8566f47e63 100644
--- a/Documentation/devicetree/bindings/display/brcm,bcm2835-hvs.yaml
+++ b/Documentation/devicetree/bindings/display/brcm,bcm2835-hvs.yaml
@@ -36,7 +36,7 @@ if:
properties:
compatible:
contains:
- const: brcm,bcm2711-hvs"
+ const: brcm,bcm2711-hvs
then:
required:
diff --git a/Documentation/devicetree/bindings/leds/ti,tca6507.yaml b/Documentation/devicetree/bindings/leds/ti,tca6507.yaml
index 94c307c98762..32c600387895 100644
--- a/Documentation/devicetree/bindings/leds/ti,tca6507.yaml
+++ b/Documentation/devicetree/bindings/leds/ti,tca6507.yaml
@@ -69,6 +69,7 @@ patternProperties:
if:
patternProperties:
"^gpio@[0-6]$":
+ type: object
properties:
compatible:
contains:
diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
index 6bbf29b5c239..6c13703b31db 100644
--- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
+++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
@@ -123,7 +123,7 @@ required:
if:
properties:
compatible:
- items:
+ contains:
enum:
- renesas,sdhi-r7s72100
- renesas,sdhi-r7s9210
diff --git a/Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml b/Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml
index 58c3ef8004ad..04edda504ab6 100644
--- a/Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml
@@ -99,8 +99,7 @@ patternProperties:
if:
properties:
compatible:
- items:
- const: brcm,iproc-ns2-sata-phy
+ const: brcm,iproc-ns2-sata-phy
then:
properties:
reg:
diff --git a/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml b/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
index 829e8c7e467a..0f358d5b84ef 100644
--- a/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
@@ -81,9 +81,8 @@ properties:
if:
properties:
compatible:
- items:
- enum:
- - renesas,usb2-phy-r7s9210
+ contains:
+ const: renesas,usb2-phy-r7s9210
then:
required:
- clock-names
diff --git a/Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml b/Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml
index 5b5b1b9d2ec7..5d3947902f2d 100644
--- a/Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml
@@ -76,11 +76,10 @@ required:
if:
properties:
compatible:
- items:
- enum:
- - renesas,pfc-r8a73a4
- - renesas,pfc-r8a7740
- - renesas,pfc-sh73a0
+ enum:
+ - renesas,pfc-r8a73a4
+ - renesas,pfc-r8a7740
+ - renesas,pfc-sh73a0
then:
required:
- interrupts-extended
diff --git a/Documentation/devicetree/bindings/timer/allwinner,sun5i-a13-hstimer.yaml b/Documentation/devicetree/bindings/timer/allwinner,sun5i-a13-hstimer.yaml
index 40fc4bcb3145..b6a6d03a08b2 100644
--- a/Documentation/devicetree/bindings/timer/allwinner,sun5i-a13-hstimer.yaml
+++ b/Documentation/devicetree/bindings/timer/allwinner,sun5i-a13-hstimer.yaml
@@ -46,8 +46,7 @@ required:
if:
properties:
compatible:
- items:
- const: allwinner,sun5i-a13-hstimer
+ const: allwinner,sun5i-a13-hstimer
then:
properties:
--
2.27.0
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PATCH 3/3] dt-bindings: Fix errors in 'if' schemas
@ 2021-02-02 20:55 ` Rob Herring
0 siblings, 0 replies; 45+ messages in thread
From: Rob Herring @ 2021-02-02 20:55 UTC (permalink / raw)
To: devicetree
Cc: Ulf Hansson, Tomer Maimon, Geert Uytterhoeven, Andrew Jeffery,
Vincent Cheng, dri-devel, Tali Perry, Daniel Palmer, linux-i2c,
Pavel Machek, Will Deacon, linux-clk, linux-leds,
Florian Fainelli, Herbert Xu, Joerg Roedel, Daniel Lezcano,
Vinod Koul, Kishon Vijay Abraham I, Bartosz Golaszewski,
Chen-Yu Tsai, Joel Stanley, Guenter Roeck, linux-watchdog,
Ray Jui, linux-gpio, Wim Van Sebroeck, Scott Branden,
Avi Fishman, Yoshihiro Shimoda, linux-mmc, linux-kernel,
Stephen Boyd, iommu, linux-crypto, David S. Miller,
Nicolas Saenz Julienne
Properties in if/then schemas weren't getting checked by the meta-schemas.
Enabling meta-schema checks finds several errors.
The use of an 'items' schema (as opposed to the list form) is wrong in
some cases as it applies to all entries. 'contains' is the correct schema
to use in the case of multiple entries.
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: Eric Anholt <eric@anholt.net>
Cc: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: Ray Jui <rjui@broadcom.com>
Cc: Scott Branden <sbranden@broadcom.com>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Vinod Koul <vkoul@kernel.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: linux-crypto@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: linux-leds@vger.kernel.org
Cc: linux-mmc@vger.kernel.org
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
.../devicetree/bindings/crypto/allwinner,sun8i-ce.yaml | 3 +--
.../devicetree/bindings/display/brcm,bcm2835-hvs.yaml | 2 +-
Documentation/devicetree/bindings/leds/ti,tca6507.yaml | 1 +
Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml | 2 +-
Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml | 3 +--
.../devicetree/bindings/phy/renesas,usb2-phy.yaml | 5 ++---
.../devicetree/bindings/pinctrl/renesas,pfc.yaml | 9 ++++-----
.../bindings/timer/allwinner,sun5i-a13-hstimer.yaml | 3 +--
8 files changed, 12 insertions(+), 16 deletions(-)
diff --git a/Documentation/devicetree/bindings/crypto/allwinner,sun8i-ce.yaml b/Documentation/devicetree/bindings/crypto/allwinner,sun8i-ce.yaml
index 7a60d84289cc..6ab07eba7778 100644
--- a/Documentation/devicetree/bindings/crypto/allwinner,sun8i-ce.yaml
+++ b/Documentation/devicetree/bindings/crypto/allwinner,sun8i-ce.yaml
@@ -46,8 +46,7 @@ properties:
if:
properties:
compatible:
- items:
- const: allwinner,sun50i-h6-crypto
+ const: allwinner,sun50i-h6-crypto
then:
properties:
clocks:
diff --git a/Documentation/devicetree/bindings/display/brcm,bcm2835-hvs.yaml b/Documentation/devicetree/bindings/display/brcm,bcm2835-hvs.yaml
index e826ab0adb75..2e8566f47e63 100644
--- a/Documentation/devicetree/bindings/display/brcm,bcm2835-hvs.yaml
+++ b/Documentation/devicetree/bindings/display/brcm,bcm2835-hvs.yaml
@@ -36,7 +36,7 @@ if:
properties:
compatible:
contains:
- const: brcm,bcm2711-hvs"
+ const: brcm,bcm2711-hvs
then:
required:
diff --git a/Documentation/devicetree/bindings/leds/ti,tca6507.yaml b/Documentation/devicetree/bindings/leds/ti,tca6507.yaml
index 94c307c98762..32c600387895 100644
--- a/Documentation/devicetree/bindings/leds/ti,tca6507.yaml
+++ b/Documentation/devicetree/bindings/leds/ti,tca6507.yaml
@@ -69,6 +69,7 @@ patternProperties:
if:
patternProperties:
"^gpio@[0-6]$":
+ type: object
properties:
compatible:
contains:
diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
index 6bbf29b5c239..6c13703b31db 100644
--- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
+++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
@@ -123,7 +123,7 @@ required:
if:
properties:
compatible:
- items:
+ contains:
enum:
- renesas,sdhi-r7s72100
- renesas,sdhi-r7s9210
diff --git a/Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml b/Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml
index 58c3ef8004ad..04edda504ab6 100644
--- a/Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml
@@ -99,8 +99,7 @@ patternProperties:
if:
properties:
compatible:
- items:
- const: brcm,iproc-ns2-sata-phy
+ const: brcm,iproc-ns2-sata-phy
then:
properties:
reg:
diff --git a/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml b/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
index 829e8c7e467a..0f358d5b84ef 100644
--- a/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
@@ -81,9 +81,8 @@ properties:
if:
properties:
compatible:
- items:
- enum:
- - renesas,usb2-phy-r7s9210
+ contains:
+ const: renesas,usb2-phy-r7s9210
then:
required:
- clock-names
diff --git a/Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml b/Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml
index 5b5b1b9d2ec7..5d3947902f2d 100644
--- a/Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml
@@ -76,11 +76,10 @@ required:
if:
properties:
compatible:
- items:
- enum:
- - renesas,pfc-r8a73a4
- - renesas,pfc-r8a7740
- - renesas,pfc-sh73a0
+ enum:
+ - renesas,pfc-r8a73a4
+ - renesas,pfc-r8a7740
+ - renesas,pfc-sh73a0
then:
required:
- interrupts-extended
diff --git a/Documentation/devicetree/bindings/timer/allwinner,sun5i-a13-hstimer.yaml b/Documentation/devicetree/bindings/timer/allwinner,sun5i-a13-hstimer.yaml
index 40fc4bcb3145..b6a6d03a08b2 100644
--- a/Documentation/devicetree/bindings/timer/allwinner,sun5i-a13-hstimer.yaml
+++ b/Documentation/devicetree/bindings/timer/allwinner,sun5i-a13-hstimer.yaml
@@ -46,8 +46,7 @@ required:
if:
properties:
compatible:
- items:
- const: allwinner,sun5i-a13-hstimer
+ const: allwinner,sun5i-a13-hstimer
then:
properties:
--
2.27.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 45+ messages in thread
* Re: [PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples
2021-02-02 20:55 ` Rob Herring
@ 2021-02-02 21:03 ` Guenter Roeck
-1 siblings, 0 replies; 45+ messages in thread
From: Guenter Roeck @ 2021-02-02 21:03 UTC (permalink / raw)
To: Rob Herring, devicetree
Cc: linux-kernel, Stephen Boyd, Maxime Ripard, Chen-Yu Tsai,
Linus Walleij, Herbert Xu, David S. Miller, Daniel Palmer,
Bartosz Golaszewski, Avi Fishman, Tomer Maimon, Tali Perry,
Joerg Roedel, Will Deacon, Andrew Jeffery, Joel Stanley,
Wim Van Sebroeck, Yoshihiro Shimoda, Vincent Cheng, linux-clk,
linux-crypto, linux-gpio, linux-i2c, iommu, linux-watchdog
On 2/2/21 12:55 PM, Rob Herring wrote:
> Running 'dt-validate -m' will flag any compatible strings missing a schema.
> Fix all the errors found in DT binding examples. Most of these are just
> typos.
>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Daniel Palmer <daniel@thingy.jp>
> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Cc: Avi Fishman <avifishman70@gmail.com>
> Cc: Tomer Maimon <tmaimon77@gmail.com>
> Cc: Tali Perry <tali.perry1@gmail.com>
> Cc: Joerg Roedel <joro@8bytes.org>
> Cc: Will Deacon <will@kernel.org>
> Cc: Andrew Jeffery <andrew@aj.id.au>
> Cc: Joel Stanley <joel@jms.id.au>
> Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Cc: Vincent Cheng <vincent.cheng.xh@renesas.com>
> Cc: linux-clk@vger.kernel.org
> Cc: linux-crypto@vger.kernel.org
> Cc: linux-gpio@vger.kernel.org
> Cc: linux-i2c@vger.kernel.org
> Cc: iommu@lists.linux-foundation.org
> Cc: linux-watchdog@vger.kernel.org
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml | 2 +-
> Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml | 4 ++--
> Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml | 2 +-
> Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml | 2 +-
> .../devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml | 2 +-
> .../devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml | 2 +-
> .../devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml | 2 +-
> .../devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml | 2 +-
> .../devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml | 2 +-
> Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml | 4 +---
> Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml | 4 ++--
> 11 files changed, 13 insertions(+), 15 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml b/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
> index fa0ee03a527f..53cc6df0df96 100644
> --- a/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
> +++ b/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
> @@ -18,7 +18,7 @@ properties:
> const: 1
>
> compatible:
> - const: allwinner,sun9i-a80-usb-clocks
> + const: allwinner,sun9i-a80-usb-clks
>
> reg:
> maxItems: 1
> diff --git a/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml b/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> index eb241587efd1..118c5543e037 100644
> --- a/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> +++ b/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> @@ -66,8 +66,8 @@ properties:
> - arm,syscon-icst525-integratorcp-cm-mem
> - arm,integrator-cm-auxosc
> - arm,versatile-cm-auxosc
> - - arm,impd-vco1
> - - arm,impd-vco2
> + - arm,impd1-vco1
> + - arm,impd1-vco2
>
> clocks:
> description: Parent clock for the ICST VCO
> diff --git a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> index 1465c9ebaf93..1d48ac712b23 100644
> --- a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> +++ b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> @@ -66,7 +66,7 @@ examples:
> #include <dt-bindings/soc/ti,sci_pm_domain.h>
>
> main_crypto: crypto@4e00000 {
> - compatible = "ti,j721-sa2ul";
> + compatible = "ti,j721e-sa2ul";
> reg = <0x4e00000 0x1200>;
> power-domains = <&k3_pds 264 TI_SCI_PD_EXCLUSIVE>;
> dmas = <&main_udmap 0xc000>, <&main_udmap 0x4000>,
> diff --git a/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml b/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
> index 1f2ef408bb43..fe1e1c63ffe3 100644
> --- a/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
> @@ -46,7 +46,7 @@ examples:
> #include <dt-bindings/gpio/msc313-gpio.h>
>
> gpio: gpio@207800 {
> - compatible = "mstar,msc313e-gpio";
> + compatible = "mstar,msc313-gpio";
> #gpio-cells = <2>;
> reg = <0x207800 0x200>;
> gpio-controller;
> diff --git a/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml b/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
> index e3ef2d36f372..128444942aec 100644
> --- a/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
> @@ -17,7 +17,7 @@ maintainers:
>
> properties:
> compatible:
> - const: nuvoton,npcm7xx-i2c
> + const: nuvoton,npcm750-i2c
>
> reg:
> maxItems: 1
> diff --git a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> index cde1afa8dfd6..349633108bbd 100644
> --- a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> +++ b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> @@ -93,7 +93,7 @@ examples:
> #include <dt-bindings/power/r8a7791-sysc.h>
>
> ipmmu_mx: iommu@fe951000 {
> - compatible = "renasas,ipmmu-r8a7791", "renasas,ipmmu-vmsa";
> + compatible = "renesas,ipmmu-r8a7791", "renesas,ipmmu-vmsa";
> reg = <0xfe951000 0x1000>;
> interrupts = <GIC_SPI 222 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 221 IRQ_TYPE_LEVEL_HIGH>;
> diff --git a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml
> index 54631dc1adb0..5dbb84049ff6 100644
> --- a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml
> @@ -63,7 +63,7 @@ examples:
> reg = <0x1e6e2000 0x1a8>;
>
> pinctrl: pinctrl {
> - compatible = "aspeed,g4-pinctrl";
> + compatible = "aspeed,ast2400-pinctrl";
>
> pinctrl_i2c3_default: i2c3_default {
> function = "I2C3";
> diff --git a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml
> index a90c0fe0495f..ad1c33364b38 100644
> --- a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml
> @@ -81,7 +81,7 @@ examples:
> reg = <0x1e6e2000 0x1a8>;
>
> pinctrl: pinctrl {
> - compatible = "aspeed,g5-pinctrl";
> + compatible = "aspeed,ast2500-pinctrl";
> aspeed,external-nodes = <&gfx>, <&lhc>;
>
> pinctrl_i2c3_default: i2c3_default {
> diff --git a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml
> index c78ab7e2eee7..ad91c0bc54da 100644
> --- a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml
> @@ -95,7 +95,7 @@ examples:
> reg = <0x1e6e2000 0xf6c>;
>
> pinctrl: pinctrl {
> - compatible = "aspeed,g6-pinctrl";
> + compatible = "aspeed,ast2600-pinctrl";
>
> pinctrl_pwm10g1_default: pwm10g1_default {
> function = "PWM10";
> diff --git a/Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml b/Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml
> index 239b49fad805..658cec67743e 100644
> --- a/Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml
> +++ b/Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml
> @@ -59,9 +59,7 @@ additionalProperties: false
>
> examples:
> - |
> - i2c@1 {
> - compatible = "abc,acme-1234";
> - reg = <0x01 0x400>;
> + i2c {
> #address-cells = <1>;
> #size-cells = <0>;
> phc@5b {
> diff --git a/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml b/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml
> index c1348db59374..054584d7543a 100644
> --- a/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml
> @@ -57,8 +57,8 @@ examples:
> */
> #include <dt-bindings/soc/ti,sci_pm_domain.h>
>
> - watchdog0: rti@2200000 {
> - compatible = "ti,rti-wdt";
> + watchdog@2200000 {
> + compatible = "ti,j7-rti-wdt";
> reg = <0x2200000 0x100>;
> clocks = <&k3_clks 252 1>;
> power-domains = <&k3_pds 252 TI_SCI_PD_EXCLUSIVE>;
>
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples
@ 2021-02-02 21:03 ` Guenter Roeck
0 siblings, 0 replies; 45+ messages in thread
From: Guenter Roeck @ 2021-02-02 21:03 UTC (permalink / raw)
To: Rob Herring, devicetree
Cc: Tomer Maimon, Andrew Jeffery, Linus Walleij, Vincent Cheng,
Tali Perry, Daniel Palmer, linux-i2c, Will Deacon, linux-clk,
Herbert Xu, Bartosz Golaszewski, Chen-Yu Tsai, Joel Stanley,
linux-watchdog, Maxime Ripard, linux-gpio, Wim Van Sebroeck,
Avi Fishman, linux-kernel, Stephen Boyd, iommu, linux-crypto,
David S. Miller
On 2/2/21 12:55 PM, Rob Herring wrote:
> Running 'dt-validate -m' will flag any compatible strings missing a schema.
> Fix all the errors found in DT binding examples. Most of these are just
> typos.
>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Daniel Palmer <daniel@thingy.jp>
> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Cc: Avi Fishman <avifishman70@gmail.com>
> Cc: Tomer Maimon <tmaimon77@gmail.com>
> Cc: Tali Perry <tali.perry1@gmail.com>
> Cc: Joerg Roedel <joro@8bytes.org>
> Cc: Will Deacon <will@kernel.org>
> Cc: Andrew Jeffery <andrew@aj.id.au>
> Cc: Joel Stanley <joel@jms.id.au>
> Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Cc: Vincent Cheng <vincent.cheng.xh@renesas.com>
> Cc: linux-clk@vger.kernel.org
> Cc: linux-crypto@vger.kernel.org
> Cc: linux-gpio@vger.kernel.org
> Cc: linux-i2c@vger.kernel.org
> Cc: iommu@lists.linux-foundation.org
> Cc: linux-watchdog@vger.kernel.org
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml | 2 +-
> Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml | 4 ++--
> Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml | 2 +-
> Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml | 2 +-
> .../devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml | 2 +-
> .../devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml | 2 +-
> .../devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml | 2 +-
> .../devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml | 2 +-
> .../devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml | 2 +-
> Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml | 4 +---
> Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml | 4 ++--
> 11 files changed, 13 insertions(+), 15 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml b/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
> index fa0ee03a527f..53cc6df0df96 100644
> --- a/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
> +++ b/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
> @@ -18,7 +18,7 @@ properties:
> const: 1
>
> compatible:
> - const: allwinner,sun9i-a80-usb-clocks
> + const: allwinner,sun9i-a80-usb-clks
>
> reg:
> maxItems: 1
> diff --git a/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml b/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> index eb241587efd1..118c5543e037 100644
> --- a/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> +++ b/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> @@ -66,8 +66,8 @@ properties:
> - arm,syscon-icst525-integratorcp-cm-mem
> - arm,integrator-cm-auxosc
> - arm,versatile-cm-auxosc
> - - arm,impd-vco1
> - - arm,impd-vco2
> + - arm,impd1-vco1
> + - arm,impd1-vco2
>
> clocks:
> description: Parent clock for the ICST VCO
> diff --git a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> index 1465c9ebaf93..1d48ac712b23 100644
> --- a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> +++ b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> @@ -66,7 +66,7 @@ examples:
> #include <dt-bindings/soc/ti,sci_pm_domain.h>
>
> main_crypto: crypto@4e00000 {
> - compatible = "ti,j721-sa2ul";
> + compatible = "ti,j721e-sa2ul";
> reg = <0x4e00000 0x1200>;
> power-domains = <&k3_pds 264 TI_SCI_PD_EXCLUSIVE>;
> dmas = <&main_udmap 0xc000>, <&main_udmap 0x4000>,
> diff --git a/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml b/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
> index 1f2ef408bb43..fe1e1c63ffe3 100644
> --- a/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
> @@ -46,7 +46,7 @@ examples:
> #include <dt-bindings/gpio/msc313-gpio.h>
>
> gpio: gpio@207800 {
> - compatible = "mstar,msc313e-gpio";
> + compatible = "mstar,msc313-gpio";
> #gpio-cells = <2>;
> reg = <0x207800 0x200>;
> gpio-controller;
> diff --git a/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml b/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
> index e3ef2d36f372..128444942aec 100644
> --- a/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
> @@ -17,7 +17,7 @@ maintainers:
>
> properties:
> compatible:
> - const: nuvoton,npcm7xx-i2c
> + const: nuvoton,npcm750-i2c
>
> reg:
> maxItems: 1
> diff --git a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> index cde1afa8dfd6..349633108bbd 100644
> --- a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> +++ b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> @@ -93,7 +93,7 @@ examples:
> #include <dt-bindings/power/r8a7791-sysc.h>
>
> ipmmu_mx: iommu@fe951000 {
> - compatible = "renasas,ipmmu-r8a7791", "renasas,ipmmu-vmsa";
> + compatible = "renesas,ipmmu-r8a7791", "renesas,ipmmu-vmsa";
> reg = <0xfe951000 0x1000>;
> interrupts = <GIC_SPI 222 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 221 IRQ_TYPE_LEVEL_HIGH>;
> diff --git a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml
> index 54631dc1adb0..5dbb84049ff6 100644
> --- a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml
> @@ -63,7 +63,7 @@ examples:
> reg = <0x1e6e2000 0x1a8>;
>
> pinctrl: pinctrl {
> - compatible = "aspeed,g4-pinctrl";
> + compatible = "aspeed,ast2400-pinctrl";
>
> pinctrl_i2c3_default: i2c3_default {
> function = "I2C3";
> diff --git a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml
> index a90c0fe0495f..ad1c33364b38 100644
> --- a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml
> @@ -81,7 +81,7 @@ examples:
> reg = <0x1e6e2000 0x1a8>;
>
> pinctrl: pinctrl {
> - compatible = "aspeed,g5-pinctrl";
> + compatible = "aspeed,ast2500-pinctrl";
> aspeed,external-nodes = <&gfx>, <&lhc>;
>
> pinctrl_i2c3_default: i2c3_default {
> diff --git a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml
> index c78ab7e2eee7..ad91c0bc54da 100644
> --- a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml
> @@ -95,7 +95,7 @@ examples:
> reg = <0x1e6e2000 0xf6c>;
>
> pinctrl: pinctrl {
> - compatible = "aspeed,g6-pinctrl";
> + compatible = "aspeed,ast2600-pinctrl";
>
> pinctrl_pwm10g1_default: pwm10g1_default {
> function = "PWM10";
> diff --git a/Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml b/Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml
> index 239b49fad805..658cec67743e 100644
> --- a/Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml
> +++ b/Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml
> @@ -59,9 +59,7 @@ additionalProperties: false
>
> examples:
> - |
> - i2c@1 {
> - compatible = "abc,acme-1234";
> - reg = <0x01 0x400>;
> + i2c {
> #address-cells = <1>;
> #size-cells = <0>;
> phc@5b {
> diff --git a/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml b/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml
> index c1348db59374..054584d7543a 100644
> --- a/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml
> @@ -57,8 +57,8 @@ examples:
> */
> #include <dt-bindings/soc/ti,sci_pm_domain.h>
>
> - watchdog0: rti@2200000 {
> - compatible = "ti,rti-wdt";
> + watchdog@2200000 {
> + compatible = "ti,j7-rti-wdt";
> reg = <0x2200000 0x100>;
> clocks = <&k3_clks 252 1>;
> power-domains = <&k3_pds 252 TI_SCI_PD_EXCLUSIVE>;
>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples
2021-02-02 20:55 ` Rob Herring
@ 2021-02-02 22:26 ` Andrew Jeffery
-1 siblings, 0 replies; 45+ messages in thread
From: Andrew Jeffery @ 2021-02-02 22:26 UTC (permalink / raw)
To: Rob Herring, devicetree
Cc: linux-kernel, Stephen Boyd, Maxime Ripard, Chen-Yu Tsai,
Linus Walleij, Herbert Xu, David Miller, Daniel Palmer,
Bartosz Golaszewski, Avi Fishman, Tomer Maimon, Tali Perry,
Joerg Roedel, Will Deacon, Joel Stanley, Wim Van Sebroeck,
Guenter Roeck, Yoshihiro Shimoda, Vincent Cheng, linux-clk,
Linux Crypto Mailing List, linux-gpio, linux-i2c, iommu,
linux-watchdog
On Wed, 3 Feb 2021, at 07:25, Rob Herring wrote:
> Running 'dt-validate -m' will flag any compatible strings missing a schema.
> Fix all the errors found in DT binding examples. Most of these are just
> typos.
>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Daniel Palmer <daniel@thingy.jp>
> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Cc: Avi Fishman <avifishman70@gmail.com>
> Cc: Tomer Maimon <tmaimon77@gmail.com>
> Cc: Tali Perry <tali.perry1@gmail.com>
> Cc: Joerg Roedel <joro@8bytes.org>
> Cc: Will Deacon <will@kernel.org>
> Cc: Andrew Jeffery <andrew@aj.id.au>
> Cc: Joel Stanley <joel@jms.id.au>
> Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Cc: Vincent Cheng <vincent.cheng.xh@renesas.com>
> Cc: linux-clk@vger.kernel.org
> Cc: linux-crypto@vger.kernel.org
> Cc: linux-gpio@vger.kernel.org
> Cc: linux-i2c@vger.kernel.org
> Cc: iommu@lists.linux-foundation.org
> Cc: linux-watchdog@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml | 2 +-
> Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml | 4 ++--
> Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml | 2 +-
> Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml | 2 +-
> .../devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml | 2 +-
> .../devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml | 2 +-
> .../devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml | 2 +-
> .../devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml | 2 +-
> .../devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml | 2 +-
> Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml | 4 +---
> Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml | 4 ++--
> 11 files changed, 13 insertions(+), 15 deletions(-)
>
> diff --git
> a/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml b/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
> index fa0ee03a527f..53cc6df0df96 100644
> ---
> a/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
> +++
> b/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
> @@ -18,7 +18,7 @@ properties:
> const: 1
>
> compatible:
> - const: allwinner,sun9i-a80-usb-clocks
> + const: allwinner,sun9i-a80-usb-clks
>
> reg:
> maxItems: 1
> diff --git
> a/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> b/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> index eb241587efd1..118c5543e037 100644
> --- a/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> +++ b/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> @@ -66,8 +66,8 @@ properties:
> - arm,syscon-icst525-integratorcp-cm-mem
> - arm,integrator-cm-auxosc
> - arm,versatile-cm-auxosc
> - - arm,impd-vco1
> - - arm,impd-vco2
> + - arm,impd1-vco1
> + - arm,impd1-vco2
>
> clocks:
> description: Parent clock for the ICST VCO
> diff --git a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> index 1465c9ebaf93..1d48ac712b23 100644
> --- a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> +++ b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> @@ -66,7 +66,7 @@ examples:
> #include <dt-bindings/soc/ti,sci_pm_domain.h>
>
> main_crypto: crypto@4e00000 {
> - compatible = "ti,j721-sa2ul";
> + compatible = "ti,j721e-sa2ul";
> reg = <0x4e00000 0x1200>;
> power-domains = <&k3_pds 264 TI_SCI_PD_EXCLUSIVE>;
> dmas = <&main_udmap 0xc000>, <&main_udmap 0x4000>,
> diff --git
> a/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
> b/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
> index 1f2ef408bb43..fe1e1c63ffe3 100644
> --- a/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
> @@ -46,7 +46,7 @@ examples:
> #include <dt-bindings/gpio/msc313-gpio.h>
>
> gpio: gpio@207800 {
> - compatible = "mstar,msc313e-gpio";
> + compatible = "mstar,msc313-gpio";
> #gpio-cells = <2>;
> reg = <0x207800 0x200>;
> gpio-controller;
> diff --git
> a/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
> b/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
> index e3ef2d36f372..128444942aec 100644
> --- a/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
> @@ -17,7 +17,7 @@ maintainers:
>
> properties:
> compatible:
> - const: nuvoton,npcm7xx-i2c
> + const: nuvoton,npcm750-i2c
>
> reg:
> maxItems: 1
> diff --git
> a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> index cde1afa8dfd6..349633108bbd 100644
> --- a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> +++ b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> @@ -93,7 +93,7 @@ examples:
> #include <dt-bindings/power/r8a7791-sysc.h>
>
> ipmmu_mx: iommu@fe951000 {
> - compatible = "renasas,ipmmu-r8a7791", "renasas,ipmmu-vmsa";
> + compatible = "renesas,ipmmu-r8a7791", "renesas,ipmmu-vmsa";
> reg = <0xfe951000 0x1000>;
> interrupts = <GIC_SPI 222 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 221 IRQ_TYPE_LEVEL_HIGH>;
> diff --git
> a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml
> b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml
> index 54631dc1adb0..5dbb84049ff6 100644
> ---
> a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml
> +++
> b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml
> @@ -63,7 +63,7 @@ examples:
> reg = <0x1e6e2000 0x1a8>;
>
> pinctrl: pinctrl {
> - compatible = "aspeed,g4-pinctrl";
> + compatible = "aspeed,ast2400-pinctrl";
>
> pinctrl_i2c3_default: i2c3_default {
> function = "I2C3";
> diff --git
> a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml
> b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml
> index a90c0fe0495f..ad1c33364b38 100644
> ---
> a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml
> +++
> b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml
> @@ -81,7 +81,7 @@ examples:
> reg = <0x1e6e2000 0x1a8>;
>
> pinctrl: pinctrl {
> - compatible = "aspeed,g5-pinctrl";
> + compatible = "aspeed,ast2500-pinctrl";
> aspeed,external-nodes = <&gfx>, <&lhc>;
>
> pinctrl_i2c3_default: i2c3_default {
> diff --git
> a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml
> b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml
> index c78ab7e2eee7..ad91c0bc54da 100644
> ---
> a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml
> +++
> b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml
> @@ -95,7 +95,7 @@ examples:
> reg = <0x1e6e2000 0xf6c>;
>
> pinctrl: pinctrl {
> - compatible = "aspeed,g6-pinctrl";
> + compatible = "aspeed,ast2600-pinctrl";
Ah, thanks. For the Aspeed changes:
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples
@ 2021-02-02 22:26 ` Andrew Jeffery
0 siblings, 0 replies; 45+ messages in thread
From: Andrew Jeffery @ 2021-02-02 22:26 UTC (permalink / raw)
To: Rob Herring, devicetree
Cc: Tomer Maimon, Linus Walleij, Vincent Cheng, Tali Perry,
Daniel Palmer, linux-i2c, Will Deacon, linux-clk, Herbert Xu,
Bartosz Golaszewski, Chen-Yu Tsai, Joel Stanley, Guenter Roeck,
linux-watchdog, Maxime Ripard, linux-gpio, Wim Van Sebroeck,
Avi Fishman, linux-kernel, Stephen Boyd, iommu,
Linux Crypto Mailing List, David Miller
On Wed, 3 Feb 2021, at 07:25, Rob Herring wrote:
> Running 'dt-validate -m' will flag any compatible strings missing a schema.
> Fix all the errors found in DT binding examples. Most of these are just
> typos.
>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Daniel Palmer <daniel@thingy.jp>
> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Cc: Avi Fishman <avifishman70@gmail.com>
> Cc: Tomer Maimon <tmaimon77@gmail.com>
> Cc: Tali Perry <tali.perry1@gmail.com>
> Cc: Joerg Roedel <joro@8bytes.org>
> Cc: Will Deacon <will@kernel.org>
> Cc: Andrew Jeffery <andrew@aj.id.au>
> Cc: Joel Stanley <joel@jms.id.au>
> Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Cc: Vincent Cheng <vincent.cheng.xh@renesas.com>
> Cc: linux-clk@vger.kernel.org
> Cc: linux-crypto@vger.kernel.org
> Cc: linux-gpio@vger.kernel.org
> Cc: linux-i2c@vger.kernel.org
> Cc: iommu@lists.linux-foundation.org
> Cc: linux-watchdog@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml | 2 +-
> Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml | 4 ++--
> Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml | 2 +-
> Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml | 2 +-
> .../devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml | 2 +-
> .../devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml | 2 +-
> .../devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml | 2 +-
> .../devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml | 2 +-
> .../devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml | 2 +-
> Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml | 4 +---
> Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml | 4 ++--
> 11 files changed, 13 insertions(+), 15 deletions(-)
>
> diff --git
> a/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml b/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
> index fa0ee03a527f..53cc6df0df96 100644
> ---
> a/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
> +++
> b/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
> @@ -18,7 +18,7 @@ properties:
> const: 1
>
> compatible:
> - const: allwinner,sun9i-a80-usb-clocks
> + const: allwinner,sun9i-a80-usb-clks
>
> reg:
> maxItems: 1
> diff --git
> a/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> b/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> index eb241587efd1..118c5543e037 100644
> --- a/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> +++ b/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> @@ -66,8 +66,8 @@ properties:
> - arm,syscon-icst525-integratorcp-cm-mem
> - arm,integrator-cm-auxosc
> - arm,versatile-cm-auxosc
> - - arm,impd-vco1
> - - arm,impd-vco2
> + - arm,impd1-vco1
> + - arm,impd1-vco2
>
> clocks:
> description: Parent clock for the ICST VCO
> diff --git a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> index 1465c9ebaf93..1d48ac712b23 100644
> --- a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> +++ b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> @@ -66,7 +66,7 @@ examples:
> #include <dt-bindings/soc/ti,sci_pm_domain.h>
>
> main_crypto: crypto@4e00000 {
> - compatible = "ti,j721-sa2ul";
> + compatible = "ti,j721e-sa2ul";
> reg = <0x4e00000 0x1200>;
> power-domains = <&k3_pds 264 TI_SCI_PD_EXCLUSIVE>;
> dmas = <&main_udmap 0xc000>, <&main_udmap 0x4000>,
> diff --git
> a/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
> b/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
> index 1f2ef408bb43..fe1e1c63ffe3 100644
> --- a/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
> @@ -46,7 +46,7 @@ examples:
> #include <dt-bindings/gpio/msc313-gpio.h>
>
> gpio: gpio@207800 {
> - compatible = "mstar,msc313e-gpio";
> + compatible = "mstar,msc313-gpio";
> #gpio-cells = <2>;
> reg = <0x207800 0x200>;
> gpio-controller;
> diff --git
> a/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
> b/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
> index e3ef2d36f372..128444942aec 100644
> --- a/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
> @@ -17,7 +17,7 @@ maintainers:
>
> properties:
> compatible:
> - const: nuvoton,npcm7xx-i2c
> + const: nuvoton,npcm750-i2c
>
> reg:
> maxItems: 1
> diff --git
> a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> index cde1afa8dfd6..349633108bbd 100644
> --- a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> +++ b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> @@ -93,7 +93,7 @@ examples:
> #include <dt-bindings/power/r8a7791-sysc.h>
>
> ipmmu_mx: iommu@fe951000 {
> - compatible = "renasas,ipmmu-r8a7791", "renasas,ipmmu-vmsa";
> + compatible = "renesas,ipmmu-r8a7791", "renesas,ipmmu-vmsa";
> reg = <0xfe951000 0x1000>;
> interrupts = <GIC_SPI 222 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 221 IRQ_TYPE_LEVEL_HIGH>;
> diff --git
> a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml
> b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml
> index 54631dc1adb0..5dbb84049ff6 100644
> ---
> a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml
> +++
> b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml
> @@ -63,7 +63,7 @@ examples:
> reg = <0x1e6e2000 0x1a8>;
>
> pinctrl: pinctrl {
> - compatible = "aspeed,g4-pinctrl";
> + compatible = "aspeed,ast2400-pinctrl";
>
> pinctrl_i2c3_default: i2c3_default {
> function = "I2C3";
> diff --git
> a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml
> b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml
> index a90c0fe0495f..ad1c33364b38 100644
> ---
> a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml
> +++
> b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml
> @@ -81,7 +81,7 @@ examples:
> reg = <0x1e6e2000 0x1a8>;
>
> pinctrl: pinctrl {
> - compatible = "aspeed,g5-pinctrl";
> + compatible = "aspeed,ast2500-pinctrl";
> aspeed,external-nodes = <&gfx>, <&lhc>;
>
> pinctrl_i2c3_default: i2c3_default {
> diff --git
> a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml
> b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml
> index c78ab7e2eee7..ad91c0bc54da 100644
> ---
> a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml
> +++
> b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml
> @@ -95,7 +95,7 @@ examples:
> reg = <0x1e6e2000 0xf6c>;
>
> pinctrl: pinctrl {
> - compatible = "aspeed,g6-pinctrl";
> + compatible = "aspeed,ast2600-pinctrl";
Ah, thanks. For the Aspeed changes:
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples
2021-02-02 20:55 ` Rob Herring
` (4 preceding siblings ...)
(?)
@ 2021-02-03 0:33 ` Stephen Boyd
2021-02-03 8:22 ` Maxime Ripard
2021-02-03 21:09 ` Rob Herring
-1 siblings, 2 replies; 45+ messages in thread
From: Stephen Boyd @ 2021-02-03 0:33 UTC (permalink / raw)
To: Rob Herring, devicetree
Cc: Tomer Maimon, Linus Walleij, Vincent Cheng, Tali Perry,
Daniel Palmer, linux-i2c, Will Deacon, linux-clk, Herbert Xu,
Bartosz Golaszewski, Chen-Yu Tsai, Joel Stanley, Guenter Roeck,
linux-watchdog, Maxime Ripard, linux-gpio, Wim Van Sebroeck,
Avi Fishman, linux-kernel, Andrew Jeffery, iommu, linux-crypto,
David S. Miller
Quoting Rob Herring (2021-02-02 12:55:42)
>
> diff --git a/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml b/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
> index fa0ee03a527f..53cc6df0df96 100644
> --- a/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
> +++ b/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
> @@ -18,7 +18,7 @@ properties:
> const: 1
>
> compatible:
> - const: allwinner,sun9i-a80-usb-clocks
> + const: allwinner,sun9i-a80-usb-clks
Should the file name change too?
>
> reg:
> maxItems: 1
> diff --git a/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml b/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> index eb241587efd1..118c5543e037 100644
> --- a/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> +++ b/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> @@ -66,8 +66,8 @@ properties:
> - arm,syscon-icst525-integratorcp-cm-mem
> - arm,integrator-cm-auxosc
> - arm,versatile-cm-auxosc
> - - arm,impd-vco1
> - - arm,impd-vco2
> + - arm,impd1-vco1
> + - arm,impd1-vco2
>
> clocks:
> description: Parent clock for the ICST VCO
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 3/3] dt-bindings: Fix errors in 'if' schemas
2021-02-02 20:55 ` Rob Herring
(?)
@ 2021-02-03 8:01 ` Geert Uytterhoeven
-1 siblings, 0 replies; 45+ messages in thread
From: Geert Uytterhoeven @ 2021-02-03 8:01 UTC (permalink / raw)
To: Rob Herring
Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List, Stephen Boyd, Maxime Ripard,
Chen-Yu Tsai, Linus Walleij, Herbert Xu, David S. Miller,
Daniel Palmer, Bartosz Golaszewski, Avi Fishman, Tomer Maimon,
Tali Perry, Joerg Roedel, Will Deacon, Andrew Jeffery,
Joel Stanley, Wim Van Sebroeck, Guenter Roeck, Yoshihiro Shimoda,
Vincent Cheng, linux-clk, Linux Crypto Mailing List,
open list:GPIO SUBSYSTEM, Linux I2C, Linux IOMMU,
Linux Watchdog Mailing List, Eric Anholt, Nicolas Saenz Julienne,
Florian Fainelli, Ray Jui, Scott Branden, Pavel Machek,
Ulf Hansson, Kishon Vijay Abraham I, Vinod Koul,
Geert Uytterhoeven, Daniel Lezcano, DRI Development, linux-leds,
Linux MMC List
Hi Rob,
On Tue, Feb 2, 2021 at 9:55 PM Rob Herring <robh@kernel.org> wrote:
> Properties in if/then schemas weren't getting checked by the meta-schemas.
> Enabling meta-schema checks finds several errors.
>
> The use of an 'items' schema (as opposed to the list form) is wrong in
> some cases as it applies to all entries. 'contains' is the correct schema
> to use in the case of multiple entries.
> Signed-off-by: Rob Herring <robh@kernel.org>
Thanks for your patch!
> --- a/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> @@ -81,9 +81,8 @@ properties:
> if:
> properties:
> compatible:
> - items:
> - enum:
> - - renesas,usb2-phy-r7s9210
> + contains:
> + const: renesas,usb2-phy-r7s9210
Single entry, so "contains" not needed?
> --- a/Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml
> @@ -76,11 +76,10 @@ required:
> if:
> properties:
> compatible:
> - items:
> - enum:
> - - renesas,pfc-r8a73a4
> - - renesas,pfc-r8a7740
> - - renesas,pfc-sh73a0
> + enum:
> + - renesas,pfc-r8a73a4
> + - renesas,pfc-r8a7740
> + - renesas,pfc-sh73a0
Missing "contains"?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 3/3] dt-bindings: Fix errors in 'if' schemas
@ 2021-02-03 8:01 ` Geert Uytterhoeven
0 siblings, 0 replies; 45+ messages in thread
From: Geert Uytterhoeven @ 2021-02-03 8:01 UTC (permalink / raw)
To: Rob Herring
Cc: Ulf Hansson, Tomer Maimon, Geert Uytterhoeven, Linus Walleij,
Vincent Cheng, DRI Development, Tali Perry, Eric Anholt,
Daniel Palmer, Linux I2C, Pavel Machek, Will Deacon, linux-clk,
linux-leds, Florian Fainelli, Herbert Xu, Daniel Lezcano,
Vinod Koul, Kishon Vijay Abraham I, Bartosz Golaszewski,
Chen-Yu Tsai, Joel Stanley, Guenter Roeck,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Watchdog Mailing List, Ray Jui, Maxime Ripard,
open list:GPIO SUBSYSTEM, Wim Van Sebroeck, Avi Fishman,
Scott Branden, Stephen Boyd, Linux MMC List,
Linux Kernel Mailing List, Andrew Jeffery, Linux IOMMU,
Linux Crypto Mailing List, David S. Miller
Hi Rob,
On Tue, Feb 2, 2021 at 9:55 PM Rob Herring <robh@kernel.org> wrote:
> Properties in if/then schemas weren't getting checked by the meta-schemas.
> Enabling meta-schema checks finds several errors.
>
> The use of an 'items' schema (as opposed to the list form) is wrong in
> some cases as it applies to all entries. 'contains' is the correct schema
> to use in the case of multiple entries.
> Signed-off-by: Rob Herring <robh@kernel.org>
Thanks for your patch!
> --- a/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> @@ -81,9 +81,8 @@ properties:
> if:
> properties:
> compatible:
> - items:
> - enum:
> - - renesas,usb2-phy-r7s9210
> + contains:
> + const: renesas,usb2-phy-r7s9210
Single entry, so "contains" not needed?
> --- a/Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml
> @@ -76,11 +76,10 @@ required:
> if:
> properties:
> compatible:
> - items:
> - enum:
> - - renesas,pfc-r8a73a4
> - - renesas,pfc-r8a7740
> - - renesas,pfc-sh73a0
> + enum:
> + - renesas,pfc-r8a73a4
> + - renesas,pfc-r8a7740
> + - renesas,pfc-sh73a0
Missing "contains"?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 3/3] dt-bindings: Fix errors in 'if' schemas
@ 2021-02-03 8:01 ` Geert Uytterhoeven
0 siblings, 0 replies; 45+ messages in thread
From: Geert Uytterhoeven @ 2021-02-03 8:01 UTC (permalink / raw)
To: Rob Herring
Cc: Ulf Hansson, Tomer Maimon, Geert Uytterhoeven, Vincent Cheng,
DRI Development, Tali Perry, Daniel Palmer, Linux I2C,
Pavel Machek, Will Deacon, linux-clk, linux-leds,
Florian Fainelli, Herbert Xu, Joerg Roedel, Daniel Lezcano,
Vinod Koul, Kishon Vijay Abraham I, Bartosz Golaszewski,
Chen-Yu Tsai, Joel Stanley, Guenter Roeck,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Watchdog Mailing List, Ray Jui, open list:GPIO SUBSYSTEM,
Wim Van Sebroeck, Avi Fishman, Scott Branden, Stephen Boyd,
Yoshihiro Shimoda, Linux MMC List, Linux Kernel Mailing List,
Andrew Jeffery, Linux IOMMU, Linux Crypto Mailing List,
David S. Miller, Nicolas Saenz Julienne
Hi Rob,
On Tue, Feb 2, 2021 at 9:55 PM Rob Herring <robh@kernel.org> wrote:
> Properties in if/then schemas weren't getting checked by the meta-schemas.
> Enabling meta-schema checks finds several errors.
>
> The use of an 'items' schema (as opposed to the list form) is wrong in
> some cases as it applies to all entries. 'contains' is the correct schema
> to use in the case of multiple entries.
> Signed-off-by: Rob Herring <robh@kernel.org>
Thanks for your patch!
> --- a/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> @@ -81,9 +81,8 @@ properties:
> if:
> properties:
> compatible:
> - items:
> - enum:
> - - renesas,usb2-phy-r7s9210
> + contains:
> + const: renesas,usb2-phy-r7s9210
Single entry, so "contains" not needed?
> --- a/Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml
> @@ -76,11 +76,10 @@ required:
> if:
> properties:
> compatible:
> - items:
> - enum:
> - - renesas,pfc-r8a73a4
> - - renesas,pfc-r8a7740
> - - renesas,pfc-sh73a0
> + enum:
> + - renesas,pfc-r8a73a4
> + - renesas,pfc-r8a7740
> + - renesas,pfc-sh73a0
Missing "contains"?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples
2021-02-03 0:33 ` Stephen Boyd
@ 2021-02-03 8:22 ` Maxime Ripard
2021-02-03 21:09 ` Rob Herring
1 sibling, 0 replies; 45+ messages in thread
From: Maxime Ripard @ 2021-02-03 8:22 UTC (permalink / raw)
To: Stephen Boyd
Cc: Rob Herring, devicetree, linux-kernel, Chen-Yu Tsai,
Linus Walleij, Herbert Xu, David S. Miller, Daniel Palmer,
Bartosz Golaszewski, Avi Fishman, Tomer Maimon, Tali Perry,
Joerg Roedel, Will Deacon, Andrew Jeffery, Joel Stanley,
Wim Van Sebroeck, Guenter Roeck, Yoshihiro Shimoda,
Vincent Cheng, linux-clk, linux-crypto, linux-gpio, linux-i2c,
iommu, linux-watchdog
[-- Attachment #1: Type: text/plain, Size: 813 bytes --]
On Tue, Feb 02, 2021 at 04:33:56PM -0800, Stephen Boyd wrote:
> Quoting Rob Herring (2021-02-02 12:55:42)
> >
> > diff --git a/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml b/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
> > index fa0ee03a527f..53cc6df0df96 100644
> > --- a/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
> > +++ b/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
> > @@ -18,7 +18,7 @@ properties:
> > const: 1
> >
> > compatible:
> > - const: allwinner,sun9i-a80-usb-clocks
> > + const: allwinner,sun9i-a80-usb-clks
>
> Should the file name change too?
Ideally yes, and with that change
Acked-by: Maxime Ripard <mripard@kernel.org>
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples
@ 2021-02-03 8:22 ` Maxime Ripard
0 siblings, 0 replies; 45+ messages in thread
From: Maxime Ripard @ 2021-02-03 8:22 UTC (permalink / raw)
To: Stephen Boyd
Cc: Tomer Maimon, Linus Walleij, Vincent Cheng, Tali Perry,
Daniel Palmer, linux-i2c, Will Deacon, linux-clk, Rob Herring,
Herbert Xu, Bartosz Golaszewski, Chen-Yu Tsai, Joel Stanley,
Guenter Roeck, devicetree, linux-watchdog, linux-gpio,
Wim Van Sebroeck, Avi Fishman, linux-kernel, Andrew Jeffery,
iommu, linux-crypto, David S. Miller
[-- Attachment #1.1: Type: text/plain, Size: 813 bytes --]
On Tue, Feb 02, 2021 at 04:33:56PM -0800, Stephen Boyd wrote:
> Quoting Rob Herring (2021-02-02 12:55:42)
> >
> > diff --git a/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml b/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
> > index fa0ee03a527f..53cc6df0df96 100644
> > --- a/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
> > +++ b/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
> > @@ -18,7 +18,7 @@ properties:
> > const: 1
> >
> > compatible:
> > - const: allwinner,sun9i-a80-usb-clocks
> > + const: allwinner,sun9i-a80-usb-clks
>
> Should the file name change too?
Ideally yes, and with that change
Acked-by: Maxime Ripard <mripard@kernel.org>
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 156 bytes --]
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 3/3] dt-bindings: Fix errors in 'if' schemas
2021-02-02 20:55 ` Rob Herring
(?)
@ 2021-02-03 8:22 ` Maxime Ripard
-1 siblings, 0 replies; 45+ messages in thread
From: Maxime Ripard @ 2021-02-03 8:22 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, linux-kernel, Stephen Boyd, Chen-Yu Tsai,
Linus Walleij, Herbert Xu, David S. Miller, Daniel Palmer,
Bartosz Golaszewski, Avi Fishman, Tomer Maimon, Tali Perry,
Joerg Roedel, Will Deacon, Andrew Jeffery, Joel Stanley,
Wim Van Sebroeck, Guenter Roeck, Yoshihiro Shimoda,
Vincent Cheng, linux-clk, linux-crypto, linux-gpio, linux-i2c,
iommu, linux-watchdog, Eric Anholt, Nicolas Saenz Julienne,
Florian Fainelli, Ray Jui, Scott Branden, Pavel Machek,
Ulf Hansson, Kishon Vijay Abraham I, Vinod Koul,
Geert Uytterhoeven, Daniel Lezcano, dri-devel, linux-leds,
linux-mmc
[-- Attachment #1: Type: text/plain, Size: 1381 bytes --]
On Tue, Feb 02, 2021 at 02:55:44PM -0600, Rob Herring wrote:
> Properties in if/then schemas weren't getting checked by the meta-schemas.
> Enabling meta-schema checks finds several errors.
>
> The use of an 'items' schema (as opposed to the list form) is wrong in
> some cases as it applies to all entries. 'contains' is the correct schema
> to use in the case of multiple entries.
>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: Eric Anholt <eric@anholt.net>
> Cc: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: Ray Jui <rjui@broadcom.com>
> Cc: Scott Branden <sbranden@broadcom.com>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: linux-crypto@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-leds@vger.kernel.org
> Cc: linux-mmc@vger.kernel.org
> Cc: linux-gpio@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
Acked-by: Maxime Ripard <mripard@kernel.org>
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 3/3] dt-bindings: Fix errors in 'if' schemas
@ 2021-02-03 8:22 ` Maxime Ripard
0 siblings, 0 replies; 45+ messages in thread
From: Maxime Ripard @ 2021-02-03 8:22 UTC (permalink / raw)
To: Rob Herring
Cc: Ulf Hansson, Tomer Maimon, Geert Uytterhoeven, Linus Walleij,
Vincent Cheng, dri-devel, Tali Perry, Eric Anholt, Daniel Palmer,
linux-i2c, Pavel Machek, Will Deacon, linux-clk, linux-leds,
Florian Fainelli, Herbert Xu, Daniel Lezcano, Vinod Koul,
Kishon Vijay Abraham I, Bartosz Golaszewski, Chen-Yu Tsai,
Joel Stanley, Guenter Roeck, devicetree, linux-watchdog, Ray Jui,
linux-gpio, Wim Van Sebroeck, Avi Fishman, Scott Branden,
Stephen Boyd, linux-mmc, linux-kernel, Andrew Jeffery, iommu,
linux-crypto, David S. Miller
[-- Attachment #1.1: Type: text/plain, Size: 1381 bytes --]
On Tue, Feb 02, 2021 at 02:55:44PM -0600, Rob Herring wrote:
> Properties in if/then schemas weren't getting checked by the meta-schemas.
> Enabling meta-schema checks finds several errors.
>
> The use of an 'items' schema (as opposed to the list form) is wrong in
> some cases as it applies to all entries. 'contains' is the correct schema
> to use in the case of multiple entries.
>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: Eric Anholt <eric@anholt.net>
> Cc: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: Ray Jui <rjui@broadcom.com>
> Cc: Scott Branden <sbranden@broadcom.com>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: linux-crypto@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-leds@vger.kernel.org
> Cc: linux-mmc@vger.kernel.org
> Cc: linux-gpio@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
Acked-by: Maxime Ripard <mripard@kernel.org>
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 156 bytes --]
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 3/3] dt-bindings: Fix errors in 'if' schemas
@ 2021-02-03 8:22 ` Maxime Ripard
0 siblings, 0 replies; 45+ messages in thread
From: Maxime Ripard @ 2021-02-03 8:22 UTC (permalink / raw)
To: Rob Herring
Cc: Ulf Hansson, Tomer Maimon, Geert Uytterhoeven, Vincent Cheng,
dri-devel, Tali Perry, Daniel Palmer, linux-i2c, Pavel Machek,
Will Deacon, linux-clk, linux-leds, Florian Fainelli, Herbert Xu,
Joerg Roedel, Daniel Lezcano, Vinod Koul, Kishon Vijay Abraham I,
Bartosz Golaszewski, Chen-Yu Tsai, Joel Stanley, Guenter Roeck,
devicetree, linux-watchdog, Ray Jui, linux-gpio,
Wim Van Sebroeck, Avi Fishman, Scott Branden, Stephen Boyd,
Yoshihiro Shimoda, linux-mmc, linux-kernel, Andrew Jeffery,
iommu, linux-crypto, David S. Miller, Nicolas Saenz Julienne
[-- Attachment #1.1: Type: text/plain, Size: 1381 bytes --]
On Tue, Feb 02, 2021 at 02:55:44PM -0600, Rob Herring wrote:
> Properties in if/then schemas weren't getting checked by the meta-schemas.
> Enabling meta-schema checks finds several errors.
>
> The use of an 'items' schema (as opposed to the list form) is wrong in
> some cases as it applies to all entries. 'contains' is the correct schema
> to use in the case of multiple entries.
>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: Eric Anholt <eric@anholt.net>
> Cc: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: Ray Jui <rjui@broadcom.com>
> Cc: Scott Branden <sbranden@broadcom.com>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: linux-crypto@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-leds@vger.kernel.org
> Cc: linux-mmc@vger.kernel.org
> Cc: linux-gpio@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
Acked-by: Maxime Ripard <mripard@kernel.org>
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples
2021-02-02 20:55 ` Rob Herring
@ 2021-02-03 9:35 ` Linus Walleij
-1 siblings, 0 replies; 45+ messages in thread
From: Linus Walleij @ 2021-02-03 9:35 UTC (permalink / raw)
To: Rob Herring
Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-kernel, Stephen Boyd, Maxime Ripard, Chen-Yu Tsai,
Herbert Xu, David S. Miller, Daniel Palmer, Bartosz Golaszewski,
Avi Fishman, Tomer Maimon, Tali Perry, Joerg Roedel, Will Deacon,
Andrew Jeffery, Joel Stanley, Wim Van Sebroeck, Guenter Roeck,
Yoshihiro Shimoda, Vincent Cheng, linux-clk,
Linux Crypto Mailing List, open list:GPIO SUBSYSTEM, linux-i2c,
list@263.net:IOMMU DRIVERS
<iommu@lists.linux-foundation.org>,
Joerg Roedel <joro@8bytes.org>,,
LINUXWATCHDOG
On Tue, Feb 2, 2021 at 9:55 PM Rob Herring <robh@kernel.org> wrote:
> Running 'dt-validate -m' will flag any compatible strings missing a schema.
> Fix all the errors found in DT binding examples. Most of these are just
> typos.
>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Daniel Palmer <daniel@thingy.jp>
> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Cc: Avi Fishman <avifishman70@gmail.com>
> Cc: Tomer Maimon <tmaimon77@gmail.com>
> Cc: Tali Perry <tali.perry1@gmail.com>
> Cc: Joerg Roedel <joro@8bytes.org>
> Cc: Will Deacon <will@kernel.org>
> Cc: Andrew Jeffery <andrew@aj.id.au>
> Cc: Joel Stanley <joel@jms.id.au>
> Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Cc: Vincent Cheng <vincent.cheng.xh@renesas.com>
> Cc: linux-clk@vger.kernel.org
> Cc: linux-crypto@vger.kernel.org
> Cc: linux-gpio@vger.kernel.org
> Cc: linux-i2c@vger.kernel.org
> Cc: iommu@lists.linux-foundation.org
> Cc: linux-watchdog@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
Ooops.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples
@ 2021-02-03 9:35 ` Linus Walleij
0 siblings, 0 replies; 45+ messages in thread
From: Linus Walleij @ 2021-02-03 9:35 UTC (permalink / raw)
To: Rob Herring
Cc: Tomer Maimon, Vincent Cheng, Tali Perry, Daniel Palmer,
linux-i2c, Will Deacon, linux-clk, Herbert Xu,
Bartosz Golaszewski, Chen-Yu Tsai, Joel Stanley, Guenter Roeck,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
LINUXWATCHDOG, Maxime Ripard, open list:GPIO SUBSYSTEM,
Wim Van Sebroeck, Avi Fishman, Stephen Boyd, linux-kernel,
Andrew Jeffery,
list@263.net:IOMMU DRIVERS
<iommu@lists.linux-foundation.org>,
Joerg Roedel <joro@8bytes.org>, ,
Linux Crypto Mailing List, David S. Miller
On Tue, Feb 2, 2021 at 9:55 PM Rob Herring <robh@kernel.org> wrote:
> Running 'dt-validate -m' will flag any compatible strings missing a schema.
> Fix all the errors found in DT binding examples. Most of these are just
> typos.
>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Daniel Palmer <daniel@thingy.jp>
> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Cc: Avi Fishman <avifishman70@gmail.com>
> Cc: Tomer Maimon <tmaimon77@gmail.com>
> Cc: Tali Perry <tali.perry1@gmail.com>
> Cc: Joerg Roedel <joro@8bytes.org>
> Cc: Will Deacon <will@kernel.org>
> Cc: Andrew Jeffery <andrew@aj.id.au>
> Cc: Joel Stanley <joel@jms.id.au>
> Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Cc: Vincent Cheng <vincent.cheng.xh@renesas.com>
> Cc: linux-clk@vger.kernel.org
> Cc: linux-crypto@vger.kernel.org
> Cc: linux-gpio@vger.kernel.org
> Cc: linux-i2c@vger.kernel.org
> Cc: iommu@lists.linux-foundation.org
> Cc: linux-watchdog@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
Ooops.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples
2021-02-02 20:55 ` Rob Herring
@ 2021-02-03 9:48 ` Daniel Palmer
-1 siblings, 0 replies; 45+ messages in thread
From: Daniel Palmer @ 2021-02-03 9:48 UTC (permalink / raw)
To: Rob Herring
Cc: DTML, Linux Kernel Mailing List, Stephen Boyd, Maxime Ripard,
Chen-Yu Tsai, Linus Walleij, Herbert Xu, David S. Miller,
Daniel Palmer, Bartosz Golaszewski, Avi Fishman, Tomer Maimon,
Tali Perry, Joerg Roedel, Will Deacon, Andrew Jeffery,
Joel Stanley, Wim Van Sebroeck, Guenter Roeck, Yoshihiro Shimoda,
Vincent Cheng, linux-clk, linux-crypto, open list:GPIO SUBSYSTEM,
linux-i2c, iommu, linux-watchdog
Hi Rob,
On Wed, 3 Feb 2021 at 05:55, Rob Herring <robh@kernel.org> wrote:
> diff --git a/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml b/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
> index 1f2ef408bb43..fe1e1c63ffe3 100644
> --- a/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
> @@ -46,7 +46,7 @@ examples:
> #include <dt-bindings/gpio/msc313-gpio.h>
>
> gpio: gpio@207800 {
> - compatible = "mstar,msc313e-gpio";
> + compatible = "mstar,msc313-gpio";
> #gpio-cells = <2>;
> reg = <0x207800 0x200>;
> gpio-controller;
This is correct. The compatible string dropped the e at some point and
I must have missed the example.
Thanks for the fix.
Reviewed-by: Daniel Palmer <daniel@thingy.jp>
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples
@ 2021-02-03 9:48 ` Daniel Palmer
0 siblings, 0 replies; 45+ messages in thread
From: Daniel Palmer @ 2021-02-03 9:48 UTC (permalink / raw)
To: Rob Herring
Cc: Tomer Maimon, Linus Walleij, Vincent Cheng, Tali Perry,
Daniel Palmer, linux-i2c, Will Deacon, linux-clk, Herbert Xu,
Bartosz Golaszewski, Chen-Yu Tsai, Joel Stanley, Guenter Roeck,
DTML, linux-watchdog, Maxime Ripard, open list:GPIO SUBSYSTEM,
Wim Van Sebroeck, Avi Fishman, Stephen Boyd,
Linux Kernel Mailing List, Andrew Jeffery, iommu, linux-crypto,
David S. Miller
Hi Rob,
On Wed, 3 Feb 2021 at 05:55, Rob Herring <robh@kernel.org> wrote:
> diff --git a/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml b/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
> index 1f2ef408bb43..fe1e1c63ffe3 100644
> --- a/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
> @@ -46,7 +46,7 @@ examples:
> #include <dt-bindings/gpio/msc313-gpio.h>
>
> gpio: gpio@207800 {
> - compatible = "mstar,msc313e-gpio";
> + compatible = "mstar,msc313-gpio";
> #gpio-cells = <2>;
> reg = <0x207800 0x200>;
> gpio-controller;
This is correct. The compatible string dropped the e at some point and
I must have missed the example.
Thanks for the fix.
Reviewed-by: Daniel Palmer <daniel@thingy.jp>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 3/3] dt-bindings: Fix errors in 'if' schemas
2021-02-02 20:55 ` Rob Herring
(?)
@ 2021-02-03 11:22 ` Vinod Koul
-1 siblings, 0 replies; 45+ messages in thread
From: Vinod Koul @ 2021-02-03 11:22 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, linux-kernel, Stephen Boyd, Maxime Ripard,
Chen-Yu Tsai, Linus Walleij, Herbert Xu, David S. Miller,
Daniel Palmer, Bartosz Golaszewski, Avi Fishman, Tomer Maimon,
Tali Perry, Joerg Roedel, Will Deacon, Andrew Jeffery,
Joel Stanley, Wim Van Sebroeck, Guenter Roeck, Yoshihiro Shimoda,
Vincent Cheng, linux-clk, linux-crypto, linux-gpio, linux-i2c,
iommu, linux-watchdog, Eric Anholt, Nicolas Saenz Julienne,
Florian Fainelli, Ray Jui, Scott Branden, Pavel Machek,
Ulf Hansson, Kishon Vijay Abraham I, Geert Uytterhoeven,
Daniel Lezcano, dri-devel, linux-leds, linux-mmc
On 02-02-21, 14:55, Rob Herring wrote:
> Properties in if/then schemas weren't getting checked by the meta-schemas.
> Enabling meta-schema checks finds several errors.
>
> The use of an 'items' schema (as opposed to the list form) is wrong in
> some cases as it applies to all entries. 'contains' is the correct schema
> to use in the case of multiple entries.
>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: Eric Anholt <eric@anholt.net>
> Cc: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: Ray Jui <rjui@broadcom.com>
> Cc: Scott Branden <sbranden@broadcom.com>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: linux-crypto@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-leds@vger.kernel.org
> Cc: linux-mmc@vger.kernel.org
> Cc: linux-gpio@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../devicetree/bindings/crypto/allwinner,sun8i-ce.yaml | 3 +--
> .../devicetree/bindings/display/brcm,bcm2835-hvs.yaml | 2 +-
> Documentation/devicetree/bindings/leds/ti,tca6507.yaml | 1 +
> Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml | 2 +-
> Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml | 3 +--
> .../devicetree/bindings/phy/renesas,usb2-phy.yaml | 5 ++---
For phy:
Acked-By: Vinod Koul <vkoul@kernel.org>
--
~Vinod
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 3/3] dt-bindings: Fix errors in 'if' schemas
@ 2021-02-03 11:22 ` Vinod Koul
0 siblings, 0 replies; 45+ messages in thread
From: Vinod Koul @ 2021-02-03 11:22 UTC (permalink / raw)
To: Rob Herring
Cc: Ulf Hansson, Tomer Maimon, Geert Uytterhoeven, Linus Walleij,
Vincent Cheng, dri-devel, Tali Perry, Eric Anholt, Daniel Palmer,
linux-i2c, Pavel Machek, Will Deacon, linux-clk, linux-leds,
Florian Fainelli, Herbert Xu, Daniel Lezcano,
Kishon Vijay Abraham I, Bartosz Golaszewski, Chen-Yu Tsai,
Joel Stanley, Guenter Roeck, devicetree, linux-watchdog, Ray Jui,
Maxime Ripard, linux-gpio, Wim Van Sebroeck, Avi Fishman,
Scott Branden, Stephen Boyd, linux-mmc, linux-kernel,
Andrew Jeffery, iommu, linux-crypto, David S. Miller
On 02-02-21, 14:55, Rob Herring wrote:
> Properties in if/then schemas weren't getting checked by the meta-schemas.
> Enabling meta-schema checks finds several errors.
>
> The use of an 'items' schema (as opposed to the list form) is wrong in
> some cases as it applies to all entries. 'contains' is the correct schema
> to use in the case of multiple entries.
>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: Eric Anholt <eric@anholt.net>
> Cc: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: Ray Jui <rjui@broadcom.com>
> Cc: Scott Branden <sbranden@broadcom.com>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: linux-crypto@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-leds@vger.kernel.org
> Cc: linux-mmc@vger.kernel.org
> Cc: linux-gpio@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../devicetree/bindings/crypto/allwinner,sun8i-ce.yaml | 3 +--
> .../devicetree/bindings/display/brcm,bcm2835-hvs.yaml | 2 +-
> Documentation/devicetree/bindings/leds/ti,tca6507.yaml | 1 +
> Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml | 2 +-
> Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml | 3 +--
> .../devicetree/bindings/phy/renesas,usb2-phy.yaml | 5 ++---
For phy:
Acked-By: Vinod Koul <vkoul@kernel.org>
--
~Vinod
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 3/3] dt-bindings: Fix errors in 'if' schemas
@ 2021-02-03 11:22 ` Vinod Koul
0 siblings, 0 replies; 45+ messages in thread
From: Vinod Koul @ 2021-02-03 11:22 UTC (permalink / raw)
To: Rob Herring
Cc: Ulf Hansson, Tomer Maimon, Geert Uytterhoeven, Vincent Cheng,
dri-devel, Tali Perry, Daniel Palmer, linux-i2c, Pavel Machek,
Will Deacon, linux-clk, linux-leds, Florian Fainelli, Herbert Xu,
Joerg Roedel, Daniel Lezcano, Kishon Vijay Abraham I,
Bartosz Golaszewski, Chen-Yu Tsai, Joel Stanley, Guenter Roeck,
devicetree, linux-watchdog, Ray Jui, linux-gpio,
Wim Van Sebroeck, Avi Fishman, Scott Branden, Stephen Boyd,
Yoshihiro Shimoda, linux-mmc, linux-kernel, Andrew Jeffery,
iommu, linux-crypto, David S. Miller, Nicolas Saenz Julienne
On 02-02-21, 14:55, Rob Herring wrote:
> Properties in if/then schemas weren't getting checked by the meta-schemas.
> Enabling meta-schema checks finds several errors.
>
> The use of an 'items' schema (as opposed to the list form) is wrong in
> some cases as it applies to all entries. 'contains' is the correct schema
> to use in the case of multiple entries.
>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: Eric Anholt <eric@anholt.net>
> Cc: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: Ray Jui <rjui@broadcom.com>
> Cc: Scott Branden <sbranden@broadcom.com>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: linux-crypto@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-leds@vger.kernel.org
> Cc: linux-mmc@vger.kernel.org
> Cc: linux-gpio@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../devicetree/bindings/crypto/allwinner,sun8i-ce.yaml | 3 +--
> .../devicetree/bindings/display/brcm,bcm2835-hvs.yaml | 2 +-
> Documentation/devicetree/bindings/leds/ti,tca6507.yaml | 1 +
> Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml | 2 +-
> Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml | 3 +--
> .../devicetree/bindings/phy/renesas,usb2-phy.yaml | 5 ++---
For phy:
Acked-By: Vinod Koul <vkoul@kernel.org>
--
~Vinod
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 3/3] dt-bindings: Fix errors in 'if' schemas
2021-02-02 20:55 ` Rob Herring
(?)
@ 2021-02-03 11:55 ` Nicolas Saenz Julienne
-1 siblings, 0 replies; 45+ messages in thread
From: Nicolas Saenz Julienne @ 2021-02-03 11:55 UTC (permalink / raw)
To: Rob Herring, devicetree
Cc: linux-kernel, Stephen Boyd, Maxime Ripard, Chen-Yu Tsai,
Linus Walleij, Herbert Xu, David S. Miller, Daniel Palmer,
Bartosz Golaszewski, Avi Fishman, Tomer Maimon, Tali Perry,
Joerg Roedel, Will Deacon, Andrew Jeffery, Joel Stanley,
Wim Van Sebroeck, Guenter Roeck, Yoshihiro Shimoda,
Vincent Cheng, linux-clk, linux-crypto, linux-gpio, linux-i2c,
iommu, linux-watchdog, Eric Anholt, Florian Fainelli, Ray Jui,
Scott Branden, Pavel Machek, Ulf Hansson, Kishon Vijay Abraham I,
Vinod Koul, Geert Uytterhoeven, Daniel Lezcano, dri-devel,
linux-leds, linux-mmc
[-- Attachment #1: Type: text/plain, Size: 1389 bytes --]
On Tue, 2021-02-02 at 14:55 -0600, Rob Herring wrote:
> Properties in if/then schemas weren't getting checked by the meta-schemas.
> Enabling meta-schema checks finds several errors.
>
> The use of an 'items' schema (as opposed to the list form) is wrong in
> some cases as it applies to all entries. 'contains' is the correct schema
> to use in the case of multiple entries.
>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: Eric Anholt <eric@anholt.net>
> Cc: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: Ray Jui <rjui@broadcom.com>
> Cc: Scott Branden <sbranden@broadcom.com>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: linux-crypto@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-leds@vger.kernel.org
> Cc: linux-mmc@vger.kernel.org
> Cc: linux-gpio@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 3/3] dt-bindings: Fix errors in 'if' schemas
@ 2021-02-03 11:55 ` Nicolas Saenz Julienne
0 siblings, 0 replies; 45+ messages in thread
From: Nicolas Saenz Julienne @ 2021-02-03 11:55 UTC (permalink / raw)
To: Rob Herring, devicetree
Cc: Ulf Hansson, Tomer Maimon, Geert Uytterhoeven, Andrew Jeffery,
Linus Walleij, Vincent Cheng, dri-devel, Tali Perry, Eric Anholt,
Daniel Palmer, linux-i2c, Pavel Machek, Will Deacon, linux-clk,
linux-leds, Florian Fainelli, Herbert Xu, Daniel Lezcano,
Vinod Koul, Kishon Vijay Abraham I, Bartosz Golaszewski,
Chen-Yu Tsai, Joel Stanley, Guenter Roeck, linux-watchdog,
Ray Jui, Maxime Ripard, linux-gpio, Wim Van Sebroeck,
Scott Branden, Avi Fishman, linux-mmc, linux-kernel,
Stephen Boyd, iommu, linux-crypto, David S. Miller
[-- Attachment #1.1: Type: text/plain, Size: 1389 bytes --]
On Tue, 2021-02-02 at 14:55 -0600, Rob Herring wrote:
> Properties in if/then schemas weren't getting checked by the meta-schemas.
> Enabling meta-schema checks finds several errors.
>
> The use of an 'items' schema (as opposed to the list form) is wrong in
> some cases as it applies to all entries. 'contains' is the correct schema
> to use in the case of multiple entries.
>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: Eric Anholt <eric@anholt.net>
> Cc: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: Ray Jui <rjui@broadcom.com>
> Cc: Scott Branden <sbranden@broadcom.com>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: linux-crypto@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-leds@vger.kernel.org
> Cc: linux-mmc@vger.kernel.org
> Cc: linux-gpio@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 156 bytes --]
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 3/3] dt-bindings: Fix errors in 'if' schemas
@ 2021-02-03 11:55 ` Nicolas Saenz Julienne
0 siblings, 0 replies; 45+ messages in thread
From: Nicolas Saenz Julienne @ 2021-02-03 11:55 UTC (permalink / raw)
To: Rob Herring, devicetree
Cc: Ulf Hansson, Tomer Maimon, Geert Uytterhoeven, Andrew Jeffery,
Vincent Cheng, dri-devel, Tali Perry, Daniel Palmer, linux-i2c,
Pavel Machek, Will Deacon, linux-clk, linux-leds,
Florian Fainelli, Herbert Xu, Joerg Roedel, Daniel Lezcano,
Vinod Koul, Kishon Vijay Abraham I, Bartosz Golaszewski,
Chen-Yu Tsai, Joel Stanley, Guenter Roeck, linux-watchdog,
Ray Jui, linux-gpio, Wim Van Sebroeck, Scott Branden,
Avi Fishman, Yoshihiro Shimoda, linux-mmc, linux-kernel,
Stephen Boyd, iommu, linux-crypto, David S. Miller
[-- Attachment #1.1: Type: text/plain, Size: 1389 bytes --]
On Tue, 2021-02-02 at 14:55 -0600, Rob Herring wrote:
> Properties in if/then schemas weren't getting checked by the meta-schemas.
> Enabling meta-schema checks finds several errors.
>
> The use of an 'items' schema (as opposed to the list form) is wrong in
> some cases as it applies to all entries. 'contains' is the correct schema
> to use in the case of multiple entries.
>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: Eric Anholt <eric@anholt.net>
> Cc: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: Ray Jui <rjui@broadcom.com>
> Cc: Scott Branden <sbranden@broadcom.com>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: linux-crypto@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-leds@vger.kernel.org
> Cc: linux-mmc@vger.kernel.org
> Cc: linux-gpio@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 3/3] dt-bindings: Fix errors in 'if' schemas
2021-02-03 8:01 ` Geert Uytterhoeven
(?)
@ 2021-02-03 15:55 ` Rob Herring
-1 siblings, 0 replies; 45+ messages in thread
From: Rob Herring @ 2021-02-03 15:55 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List, Stephen Boyd, Maxime Ripard,
Chen-Yu Tsai, Linus Walleij, Herbert Xu, David S. Miller,
Daniel Palmer, Bartosz Golaszewski, Avi Fishman, Tomer Maimon,
Tali Perry, Joerg Roedel, Will Deacon, Andrew Jeffery,
Joel Stanley, Wim Van Sebroeck, Guenter Roeck, Yoshihiro Shimoda,
Vincent Cheng, linux-clk, Linux Crypto Mailing List,
open list:GPIO SUBSYSTEM, Linux I2C, Linux IOMMU,
Linux Watchdog Mailing List, Eric Anholt, Nicolas Saenz Julienne,
Florian Fainelli, Ray Jui, Scott Branden, Pavel Machek,
Ulf Hansson, Kishon Vijay Abraham I, Vinod Koul,
Geert Uytterhoeven, Daniel Lezcano, DRI Development, linux-leds,
Linux MMC List
On Wed, Feb 03, 2021 at 09:01:23AM +0100, Geert Uytterhoeven wrote:
> Hi Rob,
>
> On Tue, Feb 2, 2021 at 9:55 PM Rob Herring <robh@kernel.org> wrote:
> > Properties in if/then schemas weren't getting checked by the meta-schemas.
> > Enabling meta-schema checks finds several errors.
> >
> > The use of an 'items' schema (as opposed to the list form) is wrong in
> > some cases as it applies to all entries. 'contains' is the correct schema
> > to use in the case of multiple entries.
>
> > Signed-off-by: Rob Herring <robh@kernel.org>
>
> Thanks for your patch!
>
> > --- a/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> > +++ b/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> > @@ -81,9 +81,8 @@ properties:
> > if:
> > properties:
> > compatible:
> > - items:
> > - enum:
> > - - renesas,usb2-phy-r7s9210
> > + contains:
> > + const: renesas,usb2-phy-r7s9210
>
> Single entry, so "contains" not needed?
No, you are misunderstanding how these work. 'contains' means at least
one entry in an array passes with the subschema. In this case,
'renesas,usb2-phy-r7s9210' must appear somewhere in the 'compatible'
values. (Before, it said *every* entry must be
'renesas,usb2-phy-r7s9210'.) As there is a fallback compatible, we need
'contains'.
> > --- a/Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml
> > +++ b/Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml
> > @@ -76,11 +76,10 @@ required:
> > if:
> > properties:
> > compatible:
> > - items:
> > - enum:
> > - - renesas,pfc-r8a73a4
> > - - renesas,pfc-r8a7740
> > - - renesas,pfc-sh73a0
> > + enum:
> > + - renesas,pfc-r8a73a4
> > + - renesas,pfc-r8a7740
> > + - renesas,pfc-sh73a0
>
> Missing "contains"?
No. In this case, 'compatible' is always a single entry, so no
'contains' needed (but would work). If compatible is one of these 3
strings, then the 'if' is true.
The original way would actually work in this case (i.e. is valid
json-schema), but we require 'items' to have a size (maxItems/minItems)
in our meta-schema.
Rob
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 3/3] dt-bindings: Fix errors in 'if' schemas
@ 2021-02-03 15:55 ` Rob Herring
0 siblings, 0 replies; 45+ messages in thread
From: Rob Herring @ 2021-02-03 15:55 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Ulf Hansson, Tomer Maimon, Geert Uytterhoeven, Linus Walleij,
Vincent Cheng, DRI Development, Tali Perry, Eric Anholt,
Daniel Palmer, Linux I2C, Pavel Machek, Will Deacon, linux-clk,
linux-leds, Florian Fainelli, Herbert Xu, Daniel Lezcano,
Vinod Koul, Kishon Vijay Abraham I, Bartosz Golaszewski,
Chen-Yu Tsai, Joel Stanley, Guenter Roeck,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Watchdog Mailing List, Ray Jui, Maxime Ripard,
open list:GPIO SUBSYSTEM, Wim Van Sebroeck, Avi Fishman,
Scott Branden, Stephen Boyd, Linux MMC List,
Linux Kernel Mailing List, Andrew Jeffery, Linux IOMMU,
Linux Crypto Mailing List, David S. Miller
On Wed, Feb 03, 2021 at 09:01:23AM +0100, Geert Uytterhoeven wrote:
> Hi Rob,
>
> On Tue, Feb 2, 2021 at 9:55 PM Rob Herring <robh@kernel.org> wrote:
> > Properties in if/then schemas weren't getting checked by the meta-schemas.
> > Enabling meta-schema checks finds several errors.
> >
> > The use of an 'items' schema (as opposed to the list form) is wrong in
> > some cases as it applies to all entries. 'contains' is the correct schema
> > to use in the case of multiple entries.
>
> > Signed-off-by: Rob Herring <robh@kernel.org>
>
> Thanks for your patch!
>
> > --- a/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> > +++ b/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> > @@ -81,9 +81,8 @@ properties:
> > if:
> > properties:
> > compatible:
> > - items:
> > - enum:
> > - - renesas,usb2-phy-r7s9210
> > + contains:
> > + const: renesas,usb2-phy-r7s9210
>
> Single entry, so "contains" not needed?
No, you are misunderstanding how these work. 'contains' means at least
one entry in an array passes with the subschema. In this case,
'renesas,usb2-phy-r7s9210' must appear somewhere in the 'compatible'
values. (Before, it said *every* entry must be
'renesas,usb2-phy-r7s9210'.) As there is a fallback compatible, we need
'contains'.
> > --- a/Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml
> > +++ b/Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml
> > @@ -76,11 +76,10 @@ required:
> > if:
> > properties:
> > compatible:
> > - items:
> > - enum:
> > - - renesas,pfc-r8a73a4
> > - - renesas,pfc-r8a7740
> > - - renesas,pfc-sh73a0
> > + enum:
> > + - renesas,pfc-r8a73a4
> > + - renesas,pfc-r8a7740
> > + - renesas,pfc-sh73a0
>
> Missing "contains"?
No. In this case, 'compatible' is always a single entry, so no
'contains' needed (but would work). If compatible is one of these 3
strings, then the 'if' is true.
The original way would actually work in this case (i.e. is valid
json-schema), but we require 'items' to have a size (maxItems/minItems)
in our meta-schema.
Rob
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 3/3] dt-bindings: Fix errors in 'if' schemas
@ 2021-02-03 15:55 ` Rob Herring
0 siblings, 0 replies; 45+ messages in thread
From: Rob Herring @ 2021-02-03 15:55 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Ulf Hansson, Tomer Maimon, Geert Uytterhoeven, Vincent Cheng,
DRI Development, Tali Perry, Daniel Palmer, Linux I2C,
Pavel Machek, Will Deacon, linux-clk, linux-leds,
Florian Fainelli, Herbert Xu, Joerg Roedel, Daniel Lezcano,
Vinod Koul, Kishon Vijay Abraham I, Bartosz Golaszewski,
Chen-Yu Tsai, Joel Stanley, Guenter Roeck,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Watchdog Mailing List, Ray Jui, open list:GPIO SUBSYSTEM,
Wim Van Sebroeck, Avi Fishman, Scott Branden, Stephen Boyd,
Yoshihiro Shimoda, Linux MMC List, Linux Kernel Mailing List,
Andrew Jeffery, Linux IOMMU, Linux Crypto Mailing List,
David S. Miller, Nicolas Saenz Julienne
On Wed, Feb 03, 2021 at 09:01:23AM +0100, Geert Uytterhoeven wrote:
> Hi Rob,
>
> On Tue, Feb 2, 2021 at 9:55 PM Rob Herring <robh@kernel.org> wrote:
> > Properties in if/then schemas weren't getting checked by the meta-schemas.
> > Enabling meta-schema checks finds several errors.
> >
> > The use of an 'items' schema (as opposed to the list form) is wrong in
> > some cases as it applies to all entries. 'contains' is the correct schema
> > to use in the case of multiple entries.
>
> > Signed-off-by: Rob Herring <robh@kernel.org>
>
> Thanks for your patch!
>
> > --- a/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> > +++ b/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> > @@ -81,9 +81,8 @@ properties:
> > if:
> > properties:
> > compatible:
> > - items:
> > - enum:
> > - - renesas,usb2-phy-r7s9210
> > + contains:
> > + const: renesas,usb2-phy-r7s9210
>
> Single entry, so "contains" not needed?
No, you are misunderstanding how these work. 'contains' means at least
one entry in an array passes with the subschema. In this case,
'renesas,usb2-phy-r7s9210' must appear somewhere in the 'compatible'
values. (Before, it said *every* entry must be
'renesas,usb2-phy-r7s9210'.) As there is a fallback compatible, we need
'contains'.
> > --- a/Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml
> > +++ b/Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml
> > @@ -76,11 +76,10 @@ required:
> > if:
> > properties:
> > compatible:
> > - items:
> > - enum:
> > - - renesas,pfc-r8a73a4
> > - - renesas,pfc-r8a7740
> > - - renesas,pfc-sh73a0
> > + enum:
> > + - renesas,pfc-r8a73a4
> > + - renesas,pfc-r8a7740
> > + - renesas,pfc-sh73a0
>
> Missing "contains"?
No. In this case, 'compatible' is always a single entry, so no
'contains' needed (but would work). If compatible is one of these 3
strings, then the 'if' is true.
The original way would actually work in this case (i.e. is valid
json-schema), but we require 'items' to have a size (maxItems/minItems)
in our meta-schema.
Rob
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 3/3] dt-bindings: Fix errors in 'if' schemas
2021-02-03 15:55 ` Rob Herring
(?)
@ 2021-02-03 16:02 ` Geert Uytterhoeven
-1 siblings, 0 replies; 45+ messages in thread
From: Geert Uytterhoeven @ 2021-02-03 16:02 UTC (permalink / raw)
To: Rob Herring
Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List, Stephen Boyd, Maxime Ripard,
Chen-Yu Tsai, Linus Walleij, Herbert Xu, David S. Miller,
Daniel Palmer, Bartosz Golaszewski, Avi Fishman, Tomer Maimon,
Tali Perry, Joerg Roedel, Will Deacon, Andrew Jeffery,
Joel Stanley, Wim Van Sebroeck, Guenter Roeck, Yoshihiro Shimoda,
Vincent Cheng, linux-clk, Linux Crypto Mailing List,
open list:GPIO SUBSYSTEM, Linux I2C, Linux IOMMU,
Linux Watchdog Mailing List, Eric Anholt, Nicolas Saenz Julienne,
Florian Fainelli, Ray Jui, Scott Branden, Pavel Machek,
Ulf Hansson, Kishon Vijay Abraham I, Vinod Koul,
Geert Uytterhoeven, Daniel Lezcano, DRI Development, linux-leds,
Linux MMC List
Hi Rob,
On Wed, Feb 3, 2021 at 4:55 PM Rob Herring <robh@kernel.org> wrote:
> On Wed, Feb 03, 2021 at 09:01:23AM +0100, Geert Uytterhoeven wrote:
> > On Tue, Feb 2, 2021 at 9:55 PM Rob Herring <robh@kernel.org> wrote:
> > > Properties in if/then schemas weren't getting checked by the meta-schemas.
> > > Enabling meta-schema checks finds several errors.
> > >
> > > The use of an 'items' schema (as opposed to the list form) is wrong in
> > > some cases as it applies to all entries. 'contains' is the correct schema
> > > to use in the case of multiple entries.
> >
> > > Signed-off-by: Rob Herring <robh@kernel.org>
> >
> > Thanks for your patch!
> >
> > > --- a/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> > > +++ b/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> > > @@ -81,9 +81,8 @@ properties:
> > > if:
> > > properties:
> > > compatible:
> > > - items:
> > > - enum:
> > > - - renesas,usb2-phy-r7s9210
> > > + contains:
> > > + const: renesas,usb2-phy-r7s9210
> >
> > Single entry, so "contains" not needed?
>
> No, you are misunderstanding how these work. 'contains' means at least
> one entry in an array passes with the subschema. In this case,
> 'renesas,usb2-phy-r7s9210' must appear somewhere in the 'compatible'
> values. (Before, it said *every* entry must be
> 'renesas,usb2-phy-r7s9210'.) As there is a fallback compatible, we need
> 'contains'.
>
> > > --- a/Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml
> > > +++ b/Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml
> > > @@ -76,11 +76,10 @@ required:
> > > if:
> > > properties:
> > > compatible:
> > > - items:
> > > - enum:
> > > - - renesas,pfc-r8a73a4
> > > - - renesas,pfc-r8a7740
> > > - - renesas,pfc-sh73a0
> > > + enum:
> > > + - renesas,pfc-r8a73a4
> > > + - renesas,pfc-r8a7740
> > > + - renesas,pfc-sh73a0
> >
> > Missing "contains"?
>
> No. In this case, 'compatible' is always a single entry, so no
> 'contains' needed (but would work). If compatible is one of these 3
> strings, then the 'if' is true.
>
> The original way would actually work in this case (i.e. is valid
> json-schema), but we require 'items' to have a size (maxItems/minItems)
> in our meta-schema.
Thanks for the explanation!
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 3/3] dt-bindings: Fix errors in 'if' schemas
@ 2021-02-03 16:02 ` Geert Uytterhoeven
0 siblings, 0 replies; 45+ messages in thread
From: Geert Uytterhoeven @ 2021-02-03 16:02 UTC (permalink / raw)
To: Rob Herring
Cc: Ulf Hansson, Tomer Maimon, Geert Uytterhoeven, Linus Walleij,
Vincent Cheng, DRI Development, Tali Perry, Eric Anholt,
Daniel Palmer, Linux I2C, Pavel Machek, Will Deacon, linux-clk,
linux-leds, Florian Fainelli, Herbert Xu, Daniel Lezcano,
Vinod Koul, Kishon Vijay Abraham I, Bartosz Golaszewski,
Chen-Yu Tsai, Joel Stanley, Guenter Roeck,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Watchdog Mailing List, Ray Jui, Maxime Ripard,
open list:GPIO SUBSYSTEM, Wim Van Sebroeck, Avi Fishman,
Scott Branden, Stephen Boyd, Linux MMC List,
Linux Kernel Mailing List, Andrew Jeffery, Linux IOMMU,
Linux Crypto Mailing List, David S. Miller
Hi Rob,
On Wed, Feb 3, 2021 at 4:55 PM Rob Herring <robh@kernel.org> wrote:
> On Wed, Feb 03, 2021 at 09:01:23AM +0100, Geert Uytterhoeven wrote:
> > On Tue, Feb 2, 2021 at 9:55 PM Rob Herring <robh@kernel.org> wrote:
> > > Properties in if/then schemas weren't getting checked by the meta-schemas.
> > > Enabling meta-schema checks finds several errors.
> > >
> > > The use of an 'items' schema (as opposed to the list form) is wrong in
> > > some cases as it applies to all entries. 'contains' is the correct schema
> > > to use in the case of multiple entries.
> >
> > > Signed-off-by: Rob Herring <robh@kernel.org>
> >
> > Thanks for your patch!
> >
> > > --- a/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> > > +++ b/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> > > @@ -81,9 +81,8 @@ properties:
> > > if:
> > > properties:
> > > compatible:
> > > - items:
> > > - enum:
> > > - - renesas,usb2-phy-r7s9210
> > > + contains:
> > > + const: renesas,usb2-phy-r7s9210
> >
> > Single entry, so "contains" not needed?
>
> No, you are misunderstanding how these work. 'contains' means at least
> one entry in an array passes with the subschema. In this case,
> 'renesas,usb2-phy-r7s9210' must appear somewhere in the 'compatible'
> values. (Before, it said *every* entry must be
> 'renesas,usb2-phy-r7s9210'.) As there is a fallback compatible, we need
> 'contains'.
>
> > > --- a/Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml
> > > +++ b/Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml
> > > @@ -76,11 +76,10 @@ required:
> > > if:
> > > properties:
> > > compatible:
> > > - items:
> > > - enum:
> > > - - renesas,pfc-r8a73a4
> > > - - renesas,pfc-r8a7740
> > > - - renesas,pfc-sh73a0
> > > + enum:
> > > + - renesas,pfc-r8a73a4
> > > + - renesas,pfc-r8a7740
> > > + - renesas,pfc-sh73a0
> >
> > Missing "contains"?
>
> No. In this case, 'compatible' is always a single entry, so no
> 'contains' needed (but would work). If compatible is one of these 3
> strings, then the 'if' is true.
>
> The original way would actually work in this case (i.e. is valid
> json-schema), but we require 'items' to have a size (maxItems/minItems)
> in our meta-schema.
Thanks for the explanation!
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 3/3] dt-bindings: Fix errors in 'if' schemas
@ 2021-02-03 16:02 ` Geert Uytterhoeven
0 siblings, 0 replies; 45+ messages in thread
From: Geert Uytterhoeven @ 2021-02-03 16:02 UTC (permalink / raw)
To: Rob Herring
Cc: Ulf Hansson, Tomer Maimon, Geert Uytterhoeven, Vincent Cheng,
DRI Development, Tali Perry, Daniel Palmer, Linux I2C,
Pavel Machek, Will Deacon, linux-clk, linux-leds,
Florian Fainelli, Herbert Xu, Joerg Roedel, Daniel Lezcano,
Vinod Koul, Kishon Vijay Abraham I, Bartosz Golaszewski,
Chen-Yu Tsai, Joel Stanley, Guenter Roeck,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Watchdog Mailing List, Ray Jui, open list:GPIO SUBSYSTEM,
Wim Van Sebroeck, Avi Fishman, Scott Branden, Stephen Boyd,
Yoshihiro Shimoda, Linux MMC List, Linux Kernel Mailing List,
Andrew Jeffery, Linux IOMMU, Linux Crypto Mailing List,
David S. Miller, Nicolas Saenz Julienne
Hi Rob,
On Wed, Feb 3, 2021 at 4:55 PM Rob Herring <robh@kernel.org> wrote:
> On Wed, Feb 03, 2021 at 09:01:23AM +0100, Geert Uytterhoeven wrote:
> > On Tue, Feb 2, 2021 at 9:55 PM Rob Herring <robh@kernel.org> wrote:
> > > Properties in if/then schemas weren't getting checked by the meta-schemas.
> > > Enabling meta-schema checks finds several errors.
> > >
> > > The use of an 'items' schema (as opposed to the list form) is wrong in
> > > some cases as it applies to all entries. 'contains' is the correct schema
> > > to use in the case of multiple entries.
> >
> > > Signed-off-by: Rob Herring <robh@kernel.org>
> >
> > Thanks for your patch!
> >
> > > --- a/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> > > +++ b/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> > > @@ -81,9 +81,8 @@ properties:
> > > if:
> > > properties:
> > > compatible:
> > > - items:
> > > - enum:
> > > - - renesas,usb2-phy-r7s9210
> > > + contains:
> > > + const: renesas,usb2-phy-r7s9210
> >
> > Single entry, so "contains" not needed?
>
> No, you are misunderstanding how these work. 'contains' means at least
> one entry in an array passes with the subschema. In this case,
> 'renesas,usb2-phy-r7s9210' must appear somewhere in the 'compatible'
> values. (Before, it said *every* entry must be
> 'renesas,usb2-phy-r7s9210'.) As there is a fallback compatible, we need
> 'contains'.
>
> > > --- a/Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml
> > > +++ b/Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml
> > > @@ -76,11 +76,10 @@ required:
> > > if:
> > > properties:
> > > compatible:
> > > - items:
> > > - enum:
> > > - - renesas,pfc-r8a73a4
> > > - - renesas,pfc-r8a7740
> > > - - renesas,pfc-sh73a0
> > > + enum:
> > > + - renesas,pfc-r8a73a4
> > > + - renesas,pfc-r8a7740
> > > + - renesas,pfc-sh73a0
> >
> > Missing "contains"?
>
> No. In this case, 'compatible' is always a single entry, so no
> 'contains' needed (but would work). If compatible is one of these 3
> strings, then the 'if' is true.
>
> The original way would actually work in this case (i.e. is valid
> json-schema), but we require 'items' to have a size (maxItems/minItems)
> in our meta-schema.
Thanks for the explanation!
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples
2021-02-03 0:33 ` Stephen Boyd
@ 2021-02-03 21:09 ` Rob Herring
2021-02-03 21:09 ` Rob Herring
1 sibling, 0 replies; 45+ messages in thread
From: Rob Herring @ 2021-02-03 21:09 UTC (permalink / raw)
To: Stephen Boyd
Cc: devicetree, linux-kernel, Maxime Ripard, Chen-Yu Tsai,
Linus Walleij, Herbert Xu, David S. Miller, Daniel Palmer,
Bartosz Golaszewski, Avi Fishman, Tomer Maimon, Tali Perry,
Joerg Roedel, Will Deacon, Andrew Jeffery, Joel Stanley,
Wim Van Sebroeck, Guenter Roeck, Yoshihiro Shimoda,
Vincent Cheng, linux-clk, linux-crypto, linux-gpio, linux-i2c,
iommu, linux-watchdog
On Tue, Feb 02, 2021 at 04:33:56PM -0800, Stephen Boyd wrote:
> Quoting Rob Herring (2021-02-02 12:55:42)
> >
> > diff --git a/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml b/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
> > index fa0ee03a527f..53cc6df0df96 100644
> > --- a/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
> > +++ b/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
> > @@ -18,7 +18,7 @@ properties:
> > const: 1
> >
> > compatible:
> > - const: allwinner,sun9i-a80-usb-clocks
> > + const: allwinner,sun9i-a80-usb-clks
>
> Should the file name change too?
Yes, I'll fix that while applying.
Rob
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples
@ 2021-02-03 21:09 ` Rob Herring
0 siblings, 0 replies; 45+ messages in thread
From: Rob Herring @ 2021-02-03 21:09 UTC (permalink / raw)
To: Stephen Boyd
Cc: Tomer Maimon, Linus Walleij, Vincent Cheng, Tali Perry,
Daniel Palmer, linux-i2c, Will Deacon, linux-clk, Herbert Xu,
Bartosz Golaszewski, Chen-Yu Tsai, Joel Stanley, Guenter Roeck,
devicetree, linux-watchdog, Maxime Ripard, linux-gpio,
Wim Van Sebroeck, Avi Fishman, linux-kernel, Andrew Jeffery,
iommu, linux-crypto, David S. Miller
On Tue, Feb 02, 2021 at 04:33:56PM -0800, Stephen Boyd wrote:
> Quoting Rob Herring (2021-02-02 12:55:42)
> >
> > diff --git a/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml b/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
> > index fa0ee03a527f..53cc6df0df96 100644
> > --- a/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
> > +++ b/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
> > @@ -18,7 +18,7 @@ properties:
> > const: 1
> >
> > compatible:
> > - const: allwinner,sun9i-a80-usb-clocks
> > + const: allwinner,sun9i-a80-usb-clks
>
> Should the file name change too?
Yes, I'll fix that while applying.
Rob
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 45+ messages in thread
* RE: [PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples
2021-02-02 20:55 ` Rob Herring
@ 2021-02-04 0:46 ` Yoshihiro Shimoda
-1 siblings, 0 replies; 45+ messages in thread
From: Yoshihiro Shimoda @ 2021-02-04 0:46 UTC (permalink / raw)
To: Rob Herring, devicetree
Cc: linux-kernel, Stephen Boyd, Maxime Ripard, Chen-Yu Tsai,
Linus Walleij, Herbert Xu, David S. Miller, Daniel Palmer,
Bartosz Golaszewski, Avi Fishman, Tomer Maimon, Tali Perry,
Joerg Roedel, Will Deacon, Andrew Jeffery, Joel Stanley,
Wim Van Sebroeck, Guenter Roeck, Vincent Cheng, linux-clk,
linux-crypto, linux-gpio, linux-i2c, iommu, linux-watchdog
Hi Rob,
> From: Rob Herring, Sent: Wednesday, February 3, 2021 5:56 AM
>
> Running 'dt-validate -m' will flag any compatible strings missing a schema.
> Fix all the errors found in DT binding examples. Most of these are just
> typos.
>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Daniel Palmer <daniel@thingy.jp>
> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Cc: Avi Fishman <avifishman70@gmail.com>
> Cc: Tomer Maimon <tmaimon77@gmail.com>
> Cc: Tali Perry <tali.perry1@gmail.com>
> Cc: Joerg Roedel <joro@8bytes.org>
> Cc: Will Deacon <will@kernel.org>
> Cc: Andrew Jeffery <andrew@aj.id.au>
> Cc: Joel Stanley <joel@jms.id.au>
> Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Cc: Vincent Cheng <vincent.cheng.xh@renesas.com>
> Cc: linux-clk@vger.kernel.org
> Cc: linux-crypto@vger.kernel.org
> Cc: linux-gpio@vger.kernel.org
> Cc: linux-i2c@vger.kernel.org
> Cc: iommu@lists.linux-foundation.org
> Cc: linux-watchdog@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
<snip>
> diff --git a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> index cde1afa8dfd6..349633108bbd 100644
> --- a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> +++ b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> @@ -93,7 +93,7 @@ examples:
> #include <dt-bindings/power/r8a7791-sysc.h>
>
> ipmmu_mx: iommu@fe951000 {
> - compatible = "renasas,ipmmu-r8a7791", "renasas,ipmmu-vmsa";
> + compatible = "renesas,ipmmu-r8a7791", "renesas,ipmmu-vmsa";
Oops. Thank you for fixing this.
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Best regards,
Yoshihiro Shimoda
^ permalink raw reply [flat|nested] 45+ messages in thread
* RE: [PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples
@ 2021-02-04 0:46 ` Yoshihiro Shimoda
0 siblings, 0 replies; 45+ messages in thread
From: Yoshihiro Shimoda @ 2021-02-04 0:46 UTC (permalink / raw)
To: Rob Herring, devicetree
Cc: Tomer Maimon, Andrew Jeffery, Linus Walleij, Vincent Cheng,
Tali Perry, Daniel Palmer, linux-i2c, Will Deacon, linux-clk,
Herbert Xu, Bartosz Golaszewski, Chen-Yu Tsai, Joel Stanley,
Guenter Roeck, linux-watchdog, Maxime Ripard, linux-gpio,
Wim Van Sebroeck, Avi Fishman, linux-kernel, Stephen Boyd, iommu,
linux-crypto, David S. Miller
Hi Rob,
> From: Rob Herring, Sent: Wednesday, February 3, 2021 5:56 AM
>
> Running 'dt-validate -m' will flag any compatible strings missing a schema.
> Fix all the errors found in DT binding examples. Most of these are just
> typos.
>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Daniel Palmer <daniel@thingy.jp>
> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Cc: Avi Fishman <avifishman70@gmail.com>
> Cc: Tomer Maimon <tmaimon77@gmail.com>
> Cc: Tali Perry <tali.perry1@gmail.com>
> Cc: Joerg Roedel <joro@8bytes.org>
> Cc: Will Deacon <will@kernel.org>
> Cc: Andrew Jeffery <andrew@aj.id.au>
> Cc: Joel Stanley <joel@jms.id.au>
> Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Cc: Vincent Cheng <vincent.cheng.xh@renesas.com>
> Cc: linux-clk@vger.kernel.org
> Cc: linux-crypto@vger.kernel.org
> Cc: linux-gpio@vger.kernel.org
> Cc: linux-i2c@vger.kernel.org
> Cc: iommu@lists.linux-foundation.org
> Cc: linux-watchdog@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
<snip>
> diff --git a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> index cde1afa8dfd6..349633108bbd 100644
> --- a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> +++ b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> @@ -93,7 +93,7 @@ examples:
> #include <dt-bindings/power/r8a7791-sysc.h>
>
> ipmmu_mx: iommu@fe951000 {
> - compatible = "renasas,ipmmu-r8a7791", "renasas,ipmmu-vmsa";
> + compatible = "renesas,ipmmu-r8a7791", "renesas,ipmmu-vmsa";
Oops. Thank you for fixing this.
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Best regards,
Yoshihiro Shimoda
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 45+ messages in thread
* RE: [PATCH 2/3] dt-bindings: iommu: renesas,ipmmu-vmsa: Make 'power-domains' conditionally required
2021-02-02 20:55 ` [PATCH 2/3] dt-bindings: iommu: renesas, ipmmu-vmsa: " Rob Herring
@ 2021-02-04 1:23 ` Yoshihiro Shimoda
-1 siblings, 0 replies; 45+ messages in thread
From: Yoshihiro Shimoda @ 2021-02-04 1:23 UTC (permalink / raw)
To: Rob Herring, devicetree
Cc: linux-kernel, Stephen Boyd, Maxime Ripard, Chen-Yu Tsai,
Linus Walleij, Herbert Xu, David S. Miller, Daniel Palmer,
Bartosz Golaszewski, Avi Fishman, Tomer Maimon, Tali Perry,
Joerg Roedel, Will Deacon, Andrew Jeffery, Joel Stanley,
Wim Van Sebroeck, Guenter Roeck, Vincent Cheng, linux-clk,
linux-crypto, linux-gpio, linux-i2c, iommu, linux-watchdog
Hi Rob,
> From: Rob Herring, Sent: Wednesday, February 3, 2021 5:56 AM
>
> Fixing the compatible string typos results in an error in the example:
>
> Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.example.dt.yaml:
> iommu@fe951000: 'power-domains' is a required property
>
> Based on the dts files, a 'power-domains' property only exists on Gen 3
> which can be conditioned on !renesas,ipmmu-vmsa.
>
> Cc: Joerg Roedel <joro@8bytes.org>
> Cc: Will Deacon <will@kernel.org>
> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Cc: iommu@lists.linux-foundation.org
> Signed-off-by: Rob Herring <robh@kernel.org>
Thank you for the patch!
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Best regards,
Yoshihiro Shimoda
^ permalink raw reply [flat|nested] 45+ messages in thread
* RE: [PATCH 2/3] dt-bindings: iommu: renesas,ipmmu-vmsa: Make 'power-domains' conditionally required
@ 2021-02-04 1:23 ` Yoshihiro Shimoda
0 siblings, 0 replies; 45+ messages in thread
From: Yoshihiro Shimoda @ 2021-02-04 1:23 UTC (permalink / raw)
To: Rob Herring, devicetree
Cc: Tomer Maimon, Andrew Jeffery, Linus Walleij, Vincent Cheng,
Tali Perry, Daniel Palmer, linux-i2c, Will Deacon, linux-clk,
Herbert Xu, Bartosz Golaszewski, Chen-Yu Tsai, Joel Stanley,
Guenter Roeck, linux-watchdog, Maxime Ripard, linux-gpio,
Wim Van Sebroeck, Avi Fishman, linux-kernel, Stephen Boyd, iommu,
linux-crypto, David S. Miller
Hi Rob,
> From: Rob Herring, Sent: Wednesday, February 3, 2021 5:56 AM
>
> Fixing the compatible string typos results in an error in the example:
>
> Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.example.dt.yaml:
> iommu@fe951000: 'power-domains' is a required property
>
> Based on the dts files, a 'power-domains' property only exists on Gen 3
> which can be conditioned on !renesas,ipmmu-vmsa.
>
> Cc: Joerg Roedel <joro@8bytes.org>
> Cc: Will Deacon <will@kernel.org>
> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Cc: iommu@lists.linux-foundation.org
> Signed-off-by: Rob Herring <robh@kernel.org>
Thank you for the patch!
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Best regards,
Yoshihiro Shimoda
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples
2021-02-02 20:55 ` Rob Herring
@ 2021-02-06 1:25 ` Wolfram Sang
-1 siblings, 0 replies; 45+ messages in thread
From: Wolfram Sang @ 2021-02-06 1:25 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, linux-kernel, Stephen Boyd, Maxime Ripard,
Chen-Yu Tsai, Linus Walleij, Herbert Xu, David S. Miller,
Daniel Palmer, Bartosz Golaszewski, Avi Fishman, Tomer Maimon,
Tali Perry, Joerg Roedel, Will Deacon, Andrew Jeffery,
Joel Stanley, Wim Van Sebroeck, Guenter Roeck, Yoshihiro Shimoda,
Vincent Cheng, linux-clk, linux-crypto, linux-gpio, linux-i2c,
iommu, linux-watchdog
[-- Attachment #1: Type: text/plain, Size: 1385 bytes --]
On Tue, Feb 02, 2021 at 02:55:42PM -0600, Rob Herring wrote:
> Running 'dt-validate -m' will flag any compatible strings missing a schema.
> Fix all the errors found in DT binding examples. Most of these are just
> typos.
>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Daniel Palmer <daniel@thingy.jp>
> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Cc: Avi Fishman <avifishman70@gmail.com>
> Cc: Tomer Maimon <tmaimon77@gmail.com>
> Cc: Tali Perry <tali.perry1@gmail.com>
> Cc: Joerg Roedel <joro@8bytes.org>
> Cc: Will Deacon <will@kernel.org>
> Cc: Andrew Jeffery <andrew@aj.id.au>
> Cc: Joel Stanley <joel@jms.id.au>
> Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Cc: Vincent Cheng <vincent.cheng.xh@renesas.com>
> Cc: linux-clk@vger.kernel.org
> Cc: linux-crypto@vger.kernel.org
> Cc: linux-gpio@vger.kernel.org
> Cc: linux-i2c@vger.kernel.org
> Cc: iommu@lists.linux-foundation.org
> Cc: linux-watchdog@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
Acked-by: Wolfram Sang <wsa@kernel.org> # for I2C
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples
@ 2021-02-06 1:25 ` Wolfram Sang
0 siblings, 0 replies; 45+ messages in thread
From: Wolfram Sang @ 2021-02-06 1:25 UTC (permalink / raw)
To: Rob Herring
Cc: Tomer Maimon, Linus Walleij, Vincent Cheng, Tali Perry,
Daniel Palmer, linux-i2c, Will Deacon, linux-clk, Herbert Xu,
Bartosz Golaszewski, Chen-Yu Tsai, Joel Stanley, Guenter Roeck,
devicetree, linux-watchdog, Maxime Ripard, linux-gpio,
Wim Van Sebroeck, Avi Fishman, Stephen Boyd, linux-kernel,
Andrew Jeffery, iommu, linux-crypto, David S. Miller
[-- Attachment #1.1: Type: text/plain, Size: 1385 bytes --]
On Tue, Feb 02, 2021 at 02:55:42PM -0600, Rob Herring wrote:
> Running 'dt-validate -m' will flag any compatible strings missing a schema.
> Fix all the errors found in DT binding examples. Most of these are just
> typos.
>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Daniel Palmer <daniel@thingy.jp>
> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Cc: Avi Fishman <avifishman70@gmail.com>
> Cc: Tomer Maimon <tmaimon77@gmail.com>
> Cc: Tali Perry <tali.perry1@gmail.com>
> Cc: Joerg Roedel <joro@8bytes.org>
> Cc: Will Deacon <will@kernel.org>
> Cc: Andrew Jeffery <andrew@aj.id.au>
> Cc: Joel Stanley <joel@jms.id.au>
> Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Cc: Vincent Cheng <vincent.cheng.xh@renesas.com>
> Cc: linux-clk@vger.kernel.org
> Cc: linux-crypto@vger.kernel.org
> Cc: linux-gpio@vger.kernel.org
> Cc: linux-i2c@vger.kernel.org
> Cc: iommu@lists.linux-foundation.org
> Cc: linux-watchdog@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
Acked-by: Wolfram Sang <wsa@kernel.org> # for I2C
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 156 bytes --]
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples
2021-02-02 20:55 ` Rob Herring
` (9 preceding siblings ...)
(?)
@ 2021-02-06 1:44 ` Stephen Boyd
-1 siblings, 0 replies; 45+ messages in thread
From: Stephen Boyd @ 2021-02-06 1:44 UTC (permalink / raw)
To: Rob Herring, devicetree
Cc: Tomer Maimon, Linus Walleij, Vincent Cheng, Tali Perry,
Daniel Palmer, linux-i2c, Will Deacon, linux-clk, Herbert Xu,
Bartosz Golaszewski, Chen-Yu Tsai, Joel Stanley, Guenter Roeck,
linux-watchdog, Maxime Ripard, linux-gpio, Wim Van Sebroeck,
Avi Fishman, linux-kernel, Andrew Jeffery, iommu, linux-crypto,
David S. Miller
Quoting Rob Herring (2021-02-02 12:55:42)
> Running 'dt-validate -m' will flag any compatible strings missing a schema.
> Fix all the errors found in DT binding examples. Most of these are just
> typos.
>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Daniel Palmer <daniel@thingy.jp>
> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Cc: Avi Fishman <avifishman70@gmail.com>
> Cc: Tomer Maimon <tmaimon77@gmail.com>
> Cc: Tali Perry <tali.perry1@gmail.com>
> Cc: Joerg Roedel <joro@8bytes.org>
> Cc: Will Deacon <will@kernel.org>
> Cc: Andrew Jeffery <andrew@aj.id.au>
> Cc: Joel Stanley <joel@jms.id.au>
> Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Cc: Vincent Cheng <vincent.cheng.xh@renesas.com>
> Cc: linux-clk@vger.kernel.org
> Cc: linux-crypto@vger.kernel.org
> Cc: linux-gpio@vger.kernel.org
> Cc: linux-i2c@vger.kernel.org
> Cc: iommu@lists.linux-foundation.org
> Cc: linux-watchdog@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
Acked-by: Stephen Boyd <sboyd@kernel.org>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 45+ messages in thread
end of thread, other threads:[~2021-02-06 3:29 UTC | newest]
Thread overview: 45+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-02 20:55 [PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples Rob Herring
2021-02-02 20:55 ` Rob Herring
2021-02-02 20:55 ` [PATCH 2/3] dt-bindings: iommu: renesas,ipmmu-vmsa: Make 'power-domains' conditionally required Rob Herring
2021-02-02 20:55 ` [PATCH 2/3] dt-bindings: iommu: renesas, ipmmu-vmsa: " Rob Herring
2021-02-04 1:23 ` [PATCH 2/3] dt-bindings: iommu: renesas,ipmmu-vmsa: " Yoshihiro Shimoda
2021-02-04 1:23 ` Yoshihiro Shimoda
2021-02-02 20:55 ` [PATCH 3/3] dt-bindings: Fix errors in 'if' schemas Rob Herring
2021-02-02 20:55 ` Rob Herring
2021-02-02 20:55 ` Rob Herring
2021-02-03 8:01 ` Geert Uytterhoeven
2021-02-03 8:01 ` Geert Uytterhoeven
2021-02-03 8:01 ` Geert Uytterhoeven
2021-02-03 15:55 ` Rob Herring
2021-02-03 15:55 ` Rob Herring
2021-02-03 15:55 ` Rob Herring
2021-02-03 16:02 ` Geert Uytterhoeven
2021-02-03 16:02 ` Geert Uytterhoeven
2021-02-03 16:02 ` Geert Uytterhoeven
2021-02-03 8:22 ` Maxime Ripard
2021-02-03 8:22 ` Maxime Ripard
2021-02-03 8:22 ` Maxime Ripard
2021-02-03 11:22 ` Vinod Koul
2021-02-03 11:22 ` Vinod Koul
2021-02-03 11:22 ` Vinod Koul
2021-02-03 11:55 ` Nicolas Saenz Julienne
2021-02-03 11:55 ` Nicolas Saenz Julienne
2021-02-03 11:55 ` Nicolas Saenz Julienne
2021-02-02 21:03 ` [PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples Guenter Roeck
2021-02-02 21:03 ` Guenter Roeck
2021-02-02 22:26 ` Andrew Jeffery
2021-02-02 22:26 ` Andrew Jeffery
2021-02-03 0:33 ` Stephen Boyd
2021-02-03 8:22 ` Maxime Ripard
2021-02-03 8:22 ` Maxime Ripard
2021-02-03 21:09 ` Rob Herring
2021-02-03 21:09 ` Rob Herring
2021-02-03 9:35 ` Linus Walleij
2021-02-03 9:35 ` Linus Walleij
2021-02-03 9:48 ` Daniel Palmer
2021-02-03 9:48 ` Daniel Palmer
2021-02-04 0:46 ` Yoshihiro Shimoda
2021-02-04 0:46 ` Yoshihiro Shimoda
2021-02-06 1:25 ` Wolfram Sang
2021-02-06 1:25 ` Wolfram Sang
2021-02-06 1:44 ` Stephen Boyd
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.