From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA212C433E0 for ; Wed, 3 Feb 2021 17:10:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7482664E93 for ; Wed, 3 Feb 2021 17:10:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231402AbhBCRJh (ORCPT ); Wed, 3 Feb 2021 12:09:37 -0500 Received: from mail.kernel.org ([198.145.29.99]:35128 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229931AbhBCRJY (ORCPT ); Wed, 3 Feb 2021 12:09:24 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 75C7E64F5D; Wed, 3 Feb 2021 17:08:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612372123; bh=GHbsnFhDAKV1JIiAdMod6/T28Z7gJtGSNqvDXFUzp7Q=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=aVWpfjyC0WbnXrg0oh2eYgYd568vaRIiw2RtW9hThCc4TrvkZ7jQlmZ+CYzk05Cnt iMzXpE596nT2mn/eKfK8lk3CM+X6F+VDwD3PB2NKrlPFgGlyMQLdbBPdbrXEXuh6/w +/MtdzqzD2fjGBxiJ40sZjBAeI3MEbVu1do5wusFdXjXQtsFmdZ0TPEPkUZcOqTxgY HoGrr3mjNB5NS2jfQhW+RTPU29ukyve6byturb1sfuLAFYGMGj3HfbNRMwFZas6SNE 2qoZcdbOu/MBheyTMs3mtZq7WD8uaIE7uW8X3350Q9MpbeeziMZHTith3pLGdFchND mj8nPxnQBYVIw== Date: Wed, 3 Feb 2021 09:08:42 -0800 From: Jakub Kicinski To: Pierre Cheynier , "Sokolowski, Jan" Cc: "intel-wired-lan@lists.osuosl.org" , "netdev@vger.kernel.org" Subject: Re: [Intel-wired-lan] [5.10] i40e/udp_tunnel: RTNL: assertion failed at net/ipv4/udp_tunnel_nic.c Message-ID: <20210203090842.22e5ccb4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: References: <20210129192750.7b2d8b25@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20210202083035.3d54f97c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 3 Feb 2021 16:05:40 +0000 Pierre Cheynier wrote: > On Wed, 3 Feb 2021 16:25:12 +0100 Pierre Cheynier wrote: > > On Wed, 3 Feb 2021 15:23:54 +0100 Sokolowski, Jan wrote: > > > > > It has been mentioned that the error only appeared recently, after upgrade to 5.10.X. What's the last known working configuration it was tested on? A bisection could help us investigate. > > > > I unfortunately moved from one LTS to another, meaning I was in 5.4 before, and this UDP tunnel offloading feature landed in 5.9 as far as I know. > > > > Maybe Jakub can give pointers to specific 5.9 or 5.10 kernel versions I can eventually try, so that I can help refine where this was introduced (or if it was present from the start)? > > So I think I was incorrect, the support of this infrastructure for i40e appears in 5.10. > From what I'm seeing, and Jakub will confirm, I think this started with the > initial implementation for i40e (see 40a98cb6f01f013b8ab0ce7b28f705423ee16836). Yup! I'm pretty sure it's my conversion. The full commit quote upstream: 40a98cb6f01f ("i40e: convert to new udp_tunnel infrastructure") It should trigger if you have vxlan module loaded (or built in) and then reload or re-probe i40e. Let us know if you can't repro it should pop up pretty reliably. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Date: Wed, 3 Feb 2021 09:08:42 -0800 Subject: [Intel-wired-lan] [5.10] i40e/udp_tunnel: RTNL: assertion failed at net/ipv4/udp_tunnel_nic.c In-Reply-To: References: <20210129192750.7b2d8b25@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20210202083035.3d54f97c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Message-ID: <20210203090842.22e5ccb4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On Wed, 3 Feb 2021 16:05:40 +0000 Pierre Cheynier wrote: > On Wed, 3 Feb 2021 16:25:12 +0100 Pierre Cheynier wrote: > > On Wed, 3 Feb 2021 15:23:54 +0100 Sokolowski, Jan wrote: > > > > > It has been mentioned that the error only appeared recently, after upgrade to 5.10.X. What's the last known working configuration it was tested on? A bisection could help us investigate. > > > > I unfortunately moved from one LTS to another, meaning I was in 5.4 before, and this UDP tunnel offloading feature landed in 5.9 as far as I know. > > > > Maybe Jakub can give pointers to specific 5.9 or 5.10 kernel versions I can eventually try, so that I can help refine where this was introduced (or if it was present from the start)? > > So I think I was incorrect, the support of this infrastructure for i40e appears in 5.10. > From what I'm seeing, and Jakub will confirm, I think this started with the > initial implementation for i40e (see 40a98cb6f01f013b8ab0ce7b28f705423ee16836). Yup! I'm pretty sure it's my conversion. The full commit quote upstream: 40a98cb6f01f ("i40e: convert to new udp_tunnel infrastructure") It should trigger if you have vxlan module loaded (or built in) and then reload or re-probe i40e. Let us know if you can't repro it should pop up pretty reliably.