From: Jakub Kicinski <kuba@kernel.org>
To: "Loktionov, Aleksandr" <aleksandr.loktionov@intel.com>
Cc: "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"Rybak, Eryk Roch" <eryk.roch.rybak@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"sassmann@redhat.com" <sassmann@redhat.com>,
"Topel, Bjorn" <bjorn.topel@intel.com>,
"Fijalkowski, Maciej" <maciej.fijalkowski@intel.com>,
"Karlsson, Magnus" <magnus.karlsson@intel.com>,
"Bhandare, KiranX" <kiranx.bhandare@intel.com>
Subject: Re: [PATCH net-next 6/6] i40e: Log error for oversized MTU on device
Date: Wed, 3 Feb 2021 10:37:39 -0800 [thread overview]
Message-ID: <20210203103739.563c13c2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <DM6PR11MB28761B036F7DDDFBE7D53CB5E5B49@DM6PR11MB2876.namprd11.prod.outlook.com>
On Wed, 3 Feb 2021 09:14:24 +0000 Loktionov, Aleksandr wrote:
> Good day Jakub
Please don't top post.
> We want to be user friendly to help users troubleshoot faster.
> Only dmesg message can have template parameters so we can provide
> exact acceptable maximum bytes. Can you could you take this into
> account?
I was making the same exact point when adding the message for NFP
years ago and it was shot down :)
Today upstream is getting close to removing the page-per-packet
requirement, so this will hopefully become irrelevant soon. Maciej
should have the details on that, he seems to be keeping up the most
with upstream in ITP.
prev parent reply other threads:[~2021-02-03 18:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 2:24 [PATCH net-next 0/6][pull request] 40GbE Intel Wired LAN Driver Updates 2021-02-01 Tony Nguyen
2021-02-02 2:24 ` [PATCH net-next 1/6] i40e: remove unnecessary memory writes of the next to clean pointer Tony Nguyen
2021-02-02 2:24 ` [PATCH net-next 2/6] i40e: remove unnecessary cleaned_count updates Tony Nguyen
2021-02-02 2:24 ` [PATCH net-next 3/6] i40e: remove the redundant buffer info updates Tony Nguyen
2021-02-02 2:24 ` [PATCH net-next 4/6] i40e: consolidate handling of XDP program actions Tony Nguyen
2021-02-02 2:24 ` [PATCH net-next 5/6] i40e: Add info trace at loading XDP program Tony Nguyen
2021-02-03 2:33 ` Jakub Kicinski
2021-02-03 10:00 ` Kubalewski, Arkadiusz
2021-02-03 18:32 ` Jakub Kicinski
2021-02-03 23:26 ` Kubalewski, Arkadiusz
2021-02-02 2:24 ` [PATCH net-next 6/6] i40e: Log error for oversized MTU on device Tony Nguyen
2021-02-03 2:34 ` Jakub Kicinski
2021-02-03 9:14 ` Loktionov, Aleksandr
2021-02-03 18:37 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210203103739.563c13c2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=aleksandr.loktionov@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=bjorn.topel@intel.com \
--cc=davem@davemloft.net \
--cc=eryk.roch.rybak@intel.com \
--cc=kiranx.bhandare@intel.com \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.