From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9226EC433E0 for ; Wed, 3 Feb 2021 11:47:47 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B4B8064F6A for ; Wed, 3 Feb 2021 11:47:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B4B8064F6A Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=disroot.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 7932D86793; Wed, 3 Feb 2021 11:47:46 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BCSAMiGSROxi; Wed, 3 Feb 2021 11:47:45 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 612B7865D4; Wed, 3 Feb 2021 11:47:45 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 139FD1BF386 for ; Wed, 3 Feb 2021 11:47:44 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 0FF1686CB6 for ; Wed, 3 Feb 2021 11:47:44 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kuC+tfdnM-fd for ; Wed, 3 Feb 2021 11:47:41 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from knopi.disroot.org (knopi.disroot.org [178.21.23.139]) by hemlock.osuosl.org (Postfix) with ESMTPS id 40B4B86132 for ; Wed, 3 Feb 2021 11:47:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id B44B250DCE; Wed, 3 Feb 2021 12:47:38 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id z0PHxJMcV63j; Wed, 3 Feb 2021 12:47:37 +0100 (CET) From: Ayush DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1612352857; bh=Vp8WSWs2HCMu3PWj9nuHcHUGOe/dyFvAXQ+Cbjl9rAc=; h=From:To:Cc:Subject:Date; b=GwPW2f+JxV4fpRZURPObmifWSUgtImprFmZx9k012jv+YxkWj4IDxeR41B9OANiNG 74Y8kO5tQhr6N86yQoIuT/beO6+7pj32d4NkIRmjtAxBzE5J5/erfv3/sOsEtRn33/ in/Behs59Sfk6LJfv+z40AamQC1PB0RkiUmOYT3EJW5xSZuG8Diy5wEsD7F2FjZQUP M5zI208tffY9/8I0ZCmECih8acFG/Tk38R57F5S0/eOS1r0YUENKhqiNw8QTUTTcaM /fkX8lYc8lsFcp6T3dTeogv/IRT+HRrHhF3v/U97Y00FgFqWiSbCg7HpnTBvrh4dfj e8beC0rkHyb/w== To: gregkh@linuxfoundation.org Subject: [PATCH] staging: wimax/i2400m: fix coding style issues Date: Wed, 3 Feb 2021 17:17:20 +0530 Message-Id: <20210203114720.263651-1-ayush@disroot.org> Mime-Version: 1.0 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, kuba@kernel.org, ayush@disroot.org, arnd@arndb.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" - fix "multiple blank lines" issues. - fix a couple of parenthesis alignment issues. - fix no space before parenthesis issue. - fix no blank line after declaration. compile tested only (on next-20210202). Signed-off-by: Ayush --- drivers/staging/wimax/i2400m/debugfs.c | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/staging/wimax/i2400m/debugfs.c b/drivers/staging/wimax/i2400m/debugfs.c index 1c640b41ea4c..80a6f833d1c2 100644 --- a/drivers/staging/wimax/i2400m/debugfs.c +++ b/drivers/staging/wimax/i2400m/debugfs.c @@ -15,7 +15,6 @@ #include #include "i2400m.h" - #define D_SUBMODULE debugfs #include "debug-levels.h" @@ -27,8 +26,8 @@ int debugfs_netdev_queue_stopped_get(void *data, u64 *val) return 0; } DEFINE_DEBUGFS_ATTRIBUTE(fops_netdev_queue_stopped, - debugfs_netdev_queue_stopped_get, - NULL, "%llu\n"); + debugfs_netdev_queue_stopped_get, + NULL, "%llu\n"); /* * We don't allow partial reads of this file, as then the reader would @@ -59,7 +58,6 @@ ssize_t i2400m_rx_stats_read(struct file *filp, char __user *buffer, return simple_read_from_buffer(buffer, count, ppos, buf, strlen(buf)); } - /* Any write clears the stats */ static ssize_t i2400m_rx_stats_write(struct file *filp, const char __user *buffer, @@ -89,7 +87,6 @@ const struct file_operations i2400m_rx_stats_fops = { .llseek = default_llseek, }; - /* See i2400m_rx_stats_read() */ static ssize_t i2400m_tx_stats_read(struct file *filp, char __user *buffer, @@ -142,21 +139,21 @@ const struct file_operations i2400m_tx_stats_fops = { .llseek = default_llseek, }; - /* Write 1 to ask the device to go into suspend */ static int debugfs_i2400m_suspend_set(void *data, u64 val) { int result; struct i2400m *i2400m = data; + result = i2400m_cmd_enter_powersave(i2400m); if (result >= 0) result = 0; return result; } DEFINE_DEBUGFS_ATTRIBUTE(fops_i2400m_suspend, - NULL, debugfs_i2400m_suspend_set, - "%llu\n"); + NULL, debugfs_i2400m_suspend_set, + "%llu\n"); /* * Reset the device @@ -170,7 +167,8 @@ int debugfs_i2400m_reset_set(void *data, u64 val) int result; struct i2400m *i2400m = data; enum i2400m_reset_type rt = val; - switch(rt) { + + switch (rt) { case I2400M_RT_WARM: case I2400M_RT_COLD: case I2400M_RT_BUS: @@ -184,8 +182,8 @@ int debugfs_i2400m_reset_set(void *data, u64 val) return result; } DEFINE_DEBUGFS_ATTRIBUTE(fops_i2400m_reset, - NULL, debugfs_i2400m_reset_set, - "%llu\n"); + NULL, debugfs_i2400m_reset_set, + "%llu\n"); void i2400m_debugfs_add(struct i2400m *i2400m) { -- 2.30.0 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel