From: Kees Cook <keescook@chromium.org>
To: Timur Tabi <timur@kernel.org>
Cc: Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
linux-kernel@vger.kernel.org, vbabka@suse.cz, linux-mm@kvack.org,
willy@infradead.org, akpm@linux-foundation.org,
torvalds@linux-foundation.org, roman.fietze@magna.com,
john.ogness@linutronix.de,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
akinobu.mita@gmail.com
Subject: Re: [PATCH][RESEND] lib/vsprintf: make-printk-non-secret printks all addresses as unhashed
Date: Wed, 3 Feb 2021 12:02:05 -0800 [thread overview]
Message-ID: <202102031201.FFED9547D@keescook> (raw)
In-Reply-To: <19c1c17e-d0b3-326e-97ec-a4ec1ebee749@kernel.org>
On Wed, Feb 03, 2021 at 12:58:41PM -0600, Timur Tabi wrote:
> On 2/3/21 7:31 AM, Petr Mladek wrote:
> > Also please make sure that lib/test_printf.c will work with
> > the new option.
>
> As you suspected, it doesn't work:
>
> [ 206.966478] test_printf: loaded.
> [ 206.966528] test_printf: plain 'p' does not appear to be hashed
> [ 206.966740] test_printf: failed 1 out of 388 tests
>
> What should I do about this?
>
> On one hand, it is working as expected: %p is not hashed, and that should be
> a warning.
>
> On the other hand, maybe test_printf should be aware of the command line
> parameter and test to make sure that %p is NOT hashed?
It seems like it'd be best for the test to fail, yes? It _is_ a problem
that %p is unhashed; it's just that the failure was intended.
--
Kees Cook
next prev parent reply other threads:[~2021-02-03 20:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 21:36 [PATCH][RESEND] lib/vsprintf: make-printk-non-secret printks all addresses as unhashed Timur Tabi
2021-02-03 3:24 ` Sergey Senozhatsky
2021-02-03 3:30 ` Randy Dunlap
2021-02-03 9:54 ` Petr Mladek
2021-02-03 13:31 ` Petr Mladek
2021-02-03 18:58 ` Timur Tabi
2021-02-03 19:30 ` Andy Shevchenko
2021-02-03 20:02 ` Kees Cook [this message]
2021-02-03 20:25 ` Steven Rostedt
2021-02-03 20:35 ` Kees Cook
2021-02-03 20:47 ` Steven Rostedt
2021-02-03 21:56 ` Timur Tabi
2021-02-03 22:38 ` Steven Rostedt
2021-02-04 9:36 ` Petr Mladek
2021-02-05 10:59 ` Vlastimil Babka
2021-02-05 18:25 ` Timur Tabi
2021-02-10 0:24 ` Kees Cook
2021-02-09 21:59 ` Marco Elver
2021-02-09 22:15 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202102031201.FFED9547D@keescook \
--to=keescook@chromium.org \
--cc=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pmladek@suse.com \
--cc=roman.fietze@magna.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=timur@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.