From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1C6EC433E0 for ; Wed, 3 Feb 2021 14:45:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7616D64F93 for ; Wed, 3 Feb 2021 14:45:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233186AbhBCOpa (ORCPT ); Wed, 3 Feb 2021 09:45:30 -0500 Received: from foss.arm.com ([217.140.110.172]:41424 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232948AbhBCOpQ (ORCPT ); Wed, 3 Feb 2021 09:45:16 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DB3A211FB; Wed, 3 Feb 2021 06:44:30 -0800 (PST) Received: from slackpad.fritz.box (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CA6E63F73B; Wed, 3 Feb 2021 06:44:29 -0800 (PST) Date: Wed, 3 Feb 2021 14:43:44 +0000 From: Andre Przywara To: Michal Simek Cc: Rob Herring , "linux-kernel@vger.kernel.org" , "Michal Simek" , git , , linux-arm-kernel Subject: Re: [PATCH] ARM: dts: zynq: Add address-cells property to interrupt controllers Message-ID: <20210203144344.4e261aea@slackpad.fritz.box> In-Reply-To: References: <91e3405245c89f134676449cf3822285798d2ed2.1612189652.git.michal.simek@xilinx.com> <210b0e5a-767b-c285-62e2-23de19bd3cf1@xilinx.com> Organization: Arm Ltd. X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 3 Feb 2021 15:15:19 +0100 Michal Simek wrote: > On 2/3/21 3:12 PM, Rob Herring wrote: > > On Wed, Feb 3, 2021 at 1:01 AM Michal Simek wrote: > >> > >> > >> > >> On 2/1/21 6:41 PM, Rob Herring wrote: > >>> On Mon, Feb 1, 2021 at 8:27 AM Michal Simek wrote: > >>>> > >>>> The commit 3eb619b2f7d8 ("scripts/dtc: Update to upstream version > >>>> v1.6.0-11-g9d7888cbf19c") updated dtc version which also contained DTC > >>>> commit > >>>> "81e0919a3e21 checks: Add interrupt provider test" > >>>> where reasons for this checking are mentioned as > >>>> "A missing #address-cells property is less critical, but creates > >>>> ambiguities when used in interrupt-map properties, so warn about this as > >>>> well now." > >>>> > >>>> Add address-cells property to gic and gpio nodes to get rid of this warning. > >>>> The similar change has been done for ZynqMP too. > >>> > >>> FYI, we're going to make this check dependent on having an > >>> interrupt-map property. So adding these isn't necessary. > >> > >> Good to know. Is there going to be report if interrupt-map doesn't > >> exist? Which can end up with reverting these changes? > > > > You mean a warning if '#address-cells' is present and interrupt-map is > > not? No, that would cause lots of warnings. > > yep. Why would we do that? That sounds dangerous and would be broken if the IRQ controller is in a generic .dtsi (as it usually is), but the interrupt map is only in *some* of the board .dts files. What is the problem of just putting #address-cells = <0>; in the IRQ controller node, after checking that there currently no interrupt maps in use and no IRQ children? And be safe for good? That's 16 bytes in the DTB, IIUC. Because otherwise we have that lovely ambiguity between the implicit default #address-cells = 2; and the assumed default of 0. And that's why I think we also cannot *automatically* add an #ac = <0>; property, because that would change behaviour. Cheers, Andre > What's the timeline for this? I mean I want to get to state that > all current warnings are gone that it will be much easier to add stuff > which we have in soc tree. > > Thanks, > Michal > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9B83C433E0 for ; Wed, 3 Feb 2021 14:45:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8E80964F8D for ; Wed, 3 Feb 2021 14:45:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E80964F8D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=98bTunwRPXqPCOxHJy+2h9M4il6mhdFjA4m9hGZbkoc=; b=NubM+rcGw7fM7bFjGB1qhJ+O/ aEH97Dm3WvZXLCar3Bak5icP2RZU+avOhyZVMv4w6VUAnPzs123nLHsubwsD6/R+eCStQER/l8CUu SPYLimqxWx+FK2Oj2/ieFGsO7mD9I5N/qzpO2KvkPwJinMIvZY7ER/kXMZa7g/M5QewAWehbFASeO 5vVU+RK/yQSAEMVKkft5tB+/Qo5vwreS/XvH+8ahZ16BaxlrozhdJe7Tz1fmsM740fbwq/g2lpaZT XofAVbWUHs+zSyWRt0RgBBDC+FP3B7k/bbhhN197wEDethlo9mxQwNSy+i+vCktviJ9oCxRbPHCOU QZb4u6tuQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7JOV-0007TJ-ES; Wed, 03 Feb 2021 14:44:35 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7JOS-0007SC-Is for linux-arm-kernel@lists.infradead.org; Wed, 03 Feb 2021 14:44:33 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DB3A211FB; Wed, 3 Feb 2021 06:44:30 -0800 (PST) Received: from slackpad.fritz.box (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CA6E63F73B; Wed, 3 Feb 2021 06:44:29 -0800 (PST) Date: Wed, 3 Feb 2021 14:43:44 +0000 From: Andre Przywara To: Michal Simek Subject: Re: [PATCH] ARM: dts: zynq: Add address-cells property to interrupt controllers Message-ID: <20210203144344.4e261aea@slackpad.fritz.box> In-Reply-To: References: <91e3405245c89f134676449cf3822285798d2ed2.1612189652.git.michal.simek@xilinx.com> <210b0e5a-767b-c285-62e2-23de19bd3cf1@xilinx.com> Organization: Arm Ltd. X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210203_094432_692751_FC381963 X-CRM114-Status: GOOD ( 23.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Michal Simek , "linux-kernel@vger.kernel.org" , Rob Herring , git , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 3 Feb 2021 15:15:19 +0100 Michal Simek wrote: > On 2/3/21 3:12 PM, Rob Herring wrote: > > On Wed, Feb 3, 2021 at 1:01 AM Michal Simek wrote: > >> > >> > >> > >> On 2/1/21 6:41 PM, Rob Herring wrote: > >>> On Mon, Feb 1, 2021 at 8:27 AM Michal Simek wrote: > >>>> > >>>> The commit 3eb619b2f7d8 ("scripts/dtc: Update to upstream version > >>>> v1.6.0-11-g9d7888cbf19c") updated dtc version which also contained DTC > >>>> commit > >>>> "81e0919a3e21 checks: Add interrupt provider test" > >>>> where reasons for this checking are mentioned as > >>>> "A missing #address-cells property is less critical, but creates > >>>> ambiguities when used in interrupt-map properties, so warn about this as > >>>> well now." > >>>> > >>>> Add address-cells property to gic and gpio nodes to get rid of this warning. > >>>> The similar change has been done for ZynqMP too. > >>> > >>> FYI, we're going to make this check dependent on having an > >>> interrupt-map property. So adding these isn't necessary. > >> > >> Good to know. Is there going to be report if interrupt-map doesn't > >> exist? Which can end up with reverting these changes? > > > > You mean a warning if '#address-cells' is present and interrupt-map is > > not? No, that would cause lots of warnings. > > yep. Why would we do that? That sounds dangerous and would be broken if the IRQ controller is in a generic .dtsi (as it usually is), but the interrupt map is only in *some* of the board .dts files. What is the problem of just putting #address-cells = <0>; in the IRQ controller node, after checking that there currently no interrupt maps in use and no IRQ children? And be safe for good? That's 16 bytes in the DTB, IIUC. Because otherwise we have that lovely ambiguity between the implicit default #address-cells = 2; and the assumed default of 0. And that's why I think we also cannot *automatically* add an #ac = <0>; property, because that would change behaviour. Cheers, Andre > What's the timeline for this? I mean I want to get to state that > all current warnings are gone that it will be much easier to add stuff > which we have in soc tree. > > Thanks, > Michal > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel