From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EDA6C433DB for ; Wed, 3 Feb 2021 16:12:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4544164E31 for ; Wed, 3 Feb 2021 16:12:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234944AbhBCQMb (ORCPT ); Wed, 3 Feb 2021 11:12:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234542AbhBCQMW (ORCPT ); Wed, 3 Feb 2021 11:12:22 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5356AC061573; Wed, 3 Feb 2021 08:11:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=NEM3B+5uDLhDBQoDrux6VhVo3KJnVlV4DNcGykNwGAQ=; b=xKMfu7bPPtW93HcxNB+zsRWo9 NbfYFb5ZBwm/8VBFC60rp9kYL6KqUYhVsLYisSxZ57GgjBv3ZxOlJ/dXWKUixABjQUtdp2lAqfRsE DDDS4DFPtIKy/wDtiH7g4Z1CJYx4jd3go2+TPmELkqY044O/8IhvtoaZwoyQnHUCR618jz3HKxOmj +7bN7ugy8G4RnnTCSnpvlBvQukbv66Tg8hRXvxjtwirveRd0WhUQMx18kGibMj1gIVnGMd+KyXCTX ENIaH7gpj7yUlIh22+fKjP1Ig7MJEyQ23Ne+dsbQixLAjZaMvDFtfp2wVNoeQ3t4bTO1tLm2V2M48 2BPD3FVDQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:38718) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l7Kkl-0005pO-5I; Wed, 03 Feb 2021 16:11:39 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1l7Kkk-0004GQ-15; Wed, 03 Feb 2021 16:11:38 +0000 Date: Wed, 3 Feb 2021 16:11:38 +0000 From: Russell King - ARM Linux admin To: Kostya Porotchkin Cc: Baruch Siach , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "andrew@lunn.ch" , "jaz@semihalf.com" , "gregory.clement@bootlin.com" , Nadav Haklai , "robh+dt@kernel.org" , Stefan Chulski , "mw@semihalf.com" , Ben Peled , "sebastian.hesselbarth@gmail.com" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [EXT] Re: [PATCH 02/11] dts: mvebu: Update A8K AP806 SDHCI settings Message-ID: <20210203161137.GS1463@shell.armlinux.org.uk> References: <20210203133138.10754-1-kostap@marvell.com> <20210203133138.10754-3-kostap@marvell.com> <87h7mtckxe.fsf@tarshish> <20210203143851.GR1463@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King - ARM Linux admin Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 03, 2021 at 02:50:45PM +0000, Kostya Porotchkin wrote: > [KP] So for older systems this "slow mode" parameter could be set on the board level. > When it is set in ap80x,dtsi file it downgrades all systems to HS-SDR52, even if they support HS400 on AP side. > MacchiatoBIN AP eMMC is connected to 3.3v regulator and has "no-1-8-v" flag set, so it should remain in low speed anyway. Your reasoning does not make sense. The ap80x.dtsi file does not specify "marvell,xenon-phy-slow-mode". It is not specified at this level. It is already specified at board level. Given that Macchiatobin will still use slow mode, why remove the marvell,xenon-phy-slow-mode property from this file? Also, if you're upgrading ap80x.dtsi to use a bus-width of 8, why keep the bus-width specifier of 8 in the board files? This patch just doesn't make sense, and your responses to our points seem to add to the confusion. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A0ADC433DB for ; Wed, 3 Feb 2021 16:12:58 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D8C3C64F74 for ; Wed, 3 Feb 2021 16:12:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D8C3C64F74 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZrUpCKsTTGuGUV9cy9E8xmoCpfeENFIHUjbz2V+18Io=; b=wMcOVuKJIDsc57diiNyWH2qT2 9jKSDT/3mpf7nQE/pm5PuRS1CO5wE3IbUlFInpJaxY2YEe04XR6UBsJxLFu/gImBad9+YcfjzoUJy RbnMu4alMTuS6iux2t2LkeQwKUVpFydHn6cyKq+akDyetZTp351V3T90AU3r2qg+Lf1ehm1f5IDy+ AYRgO2ZU/01OakV4floXJY9EPm0wGYGONBLpknYKR32eWZBIaLnPGz80hro6cbztCos9d/FdR3hmU RlgcTr/Vnt4RORnPnY1jbsvrceIax8ZLLvpJyFBdsFaooo6CX3VSlTNZwkhr8eGoFkU0z+f1OjCtM whPgMa5Yw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7Kks-00082V-9s; Wed, 03 Feb 2021 16:11:46 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7Kkp-00081x-LX for linux-arm-kernel@lists.infradead.org; Wed, 03 Feb 2021 16:11:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=NEM3B+5uDLhDBQoDrux6VhVo3KJnVlV4DNcGykNwGAQ=; b=xKMfu7bPPtW93HcxNB+zsRWo9 NbfYFb5ZBwm/8VBFC60rp9kYL6KqUYhVsLYisSxZ57GgjBv3ZxOlJ/dXWKUixABjQUtdp2lAqfRsE DDDS4DFPtIKy/wDtiH7g4Z1CJYx4jd3go2+TPmELkqY044O/8IhvtoaZwoyQnHUCR618jz3HKxOmj +7bN7ugy8G4RnnTCSnpvlBvQukbv66Tg8hRXvxjtwirveRd0WhUQMx18kGibMj1gIVnGMd+KyXCTX ENIaH7gpj7yUlIh22+fKjP1Ig7MJEyQ23Ne+dsbQixLAjZaMvDFtfp2wVNoeQ3t4bTO1tLm2V2M48 2BPD3FVDQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:38718) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l7Kkl-0005pO-5I; Wed, 03 Feb 2021 16:11:39 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1l7Kkk-0004GQ-15; Wed, 03 Feb 2021 16:11:38 +0000 Date: Wed, 3 Feb 2021 16:11:38 +0000 From: Russell King - ARM Linux admin To: Kostya Porotchkin Subject: Re: [EXT] Re: [PATCH 02/11] dts: mvebu: Update A8K AP806 SDHCI settings Message-ID: <20210203161137.GS1463@shell.armlinux.org.uk> References: <20210203133138.10754-1-kostap@marvell.com> <20210203133138.10754-3-kostap@marvell.com> <87h7mtckxe.fsf@tarshish> <20210203143851.GR1463@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210203_111143_738054_9B2960D8 X-CRM114-Status: GOOD ( 13.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , Baruch Siach , "andrew@lunn.ch" , "jaz@semihalf.com" , "gregory.clement@bootlin.com" , "linux-kernel@vger.kernel.org" , Nadav Haklai , "robh+dt@kernel.org" , Stefan Chulski , "mw@semihalf.com" , Ben Peled , "linux-arm-kernel@lists.infradead.org" , "sebastian.hesselbarth@gmail.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Feb 03, 2021 at 02:50:45PM +0000, Kostya Porotchkin wrote: > [KP] So for older systems this "slow mode" parameter could be set on the board level. > When it is set in ap80x,dtsi file it downgrades all systems to HS-SDR52, even if they support HS400 on AP side. > MacchiatoBIN AP eMMC is connected to 3.3v regulator and has "no-1-8-v" flag set, so it should remain in low speed anyway. Your reasoning does not make sense. The ap80x.dtsi file does not specify "marvell,xenon-phy-slow-mode". It is not specified at this level. It is already specified at board level. Given that Macchiatobin will still use slow mode, why remove the marvell,xenon-phy-slow-mode property from this file? Also, if you're upgrading ap80x.dtsi to use a bus-width of 8, why keep the bus-width specifier of 8 in the board files? This patch just doesn't make sense, and your responses to our points seem to add to the confusion. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel