From: Christoph Hellwig <hch@lst.de>
To: Martin Wilck <mwilck@suse.com>
Cc: Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
linux-nvme@lists.infradead.org, Hannes Reinecke <hare@suse.de>,
Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2] nvme: avoid "(efault)" from nvme_sysfs_show_subsysnqn()
Date: Wed, 3 Feb 2021 17:51:49 +0100 [thread overview]
Message-ID: <20210203165149.GA6691@lst.de> (raw)
In-Reply-To: <a7f3114e22a07e60abfd98155df91dea3a83b386.camel@suse.com>
On Wed, Feb 03, 2021 at 01:31:13PM +0100, Martin Wilck wrote:
> > This is just papering over symptoms. We should not be sending
> > events or display sysfs files until the controlle is live.
>
> I don't follow. What's wrong with a "connecting" controller device in
> sysfs?
>
> Controllers can loose connectivity any time. What's the difference
> between a controller that is reconnecting after a connection loss and a
> freshly created controller that's just not live yet? You wouldn't
> delete the former from sysfs, I suppose.
What is wrong is that we should only add the device and thus send the
uevent notifcations when the device is fully set up.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-02-03 16:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 0:59 [PATCH v2] nvme: avoid "(efault)" from nvme_sysfs_show_subsysnqn() mwilck
2021-02-02 1:34 ` Chaitanya Kulkarni
2021-02-02 7:58 ` Christoph Hellwig
2021-02-03 10:01 ` Sagi Grimberg
2021-02-03 12:31 ` Martin Wilck
2021-02-03 16:51 ` Christoph Hellwig [this message]
2021-02-03 16:52 ` Keith Busch
2021-02-03 22:19 ` Sagi Grimberg
2021-02-04 2:42 ` Keith Busch
2021-02-04 7:44 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210203165149.GA6691@lst.de \
--to=hch@lst.de \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mwilck@suse.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.