From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3DD1C433DB for ; Thu, 4 Feb 2021 14:03:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9829864F5C for ; Thu, 4 Feb 2021 14:03:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236325AbhBDOB4 (ORCPT ); Thu, 4 Feb 2021 09:01:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236502AbhBDN40 (ORCPT ); Thu, 4 Feb 2021 08:56:26 -0500 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2EEAC06178C for ; Thu, 4 Feb 2021 05:55:28 -0800 (PST) Received: by mail-wm1-x331.google.com with SMTP id y187so3061780wmd.3 for ; Thu, 04 Feb 2021 05:55:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=+zWXPoMWro9z8YmAH2sD5hl0vnIUc9rVzm7BOffQpxc=; b=m7Ec2oyeRYSUEI0DX38UiaNVijd0iI1QiTiChQCQm5Xvcwptz40gsINlaEFJi+0RWp 0Quw5xqzhOJ7ifiayJlOJWMmHIaL3Q0jwjXl/VvvCPrZeEDEObSiUgMBcQjnmVW0wWrN Ub07GT5giot2k5sR9hxkYjycUjCNi0+rV4dUQm1rJJ2iVRiejiapEAPkcAnJ3S2ZFMxi uLBkNbq79CWniMwmOjryIutYK79xFxIRIVwlcvUEhvGEbb35yOnFvIhhaswc4g/m7cjx CLON7I3WIXU7Qy2thvi7X+mPKgkNSGAKuUYYyrNFjyKcRSFyrDOirMRi+izqaUMuPmec FpPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=+zWXPoMWro9z8YmAH2sD5hl0vnIUc9rVzm7BOffQpxc=; b=anDmLYeLoB1Uwkihqmv430K6ClFuo8rBSmlhmHMm2qmq0OPSZIu9MsYzx8WG5GeP6e mw5FlxmpFstpXdzUwz9X6E9mRoysvcnZTXIzHQm5fQU33/1CKncmKNkOvldIKXWWZEiJ hobfVYP/0ojOglX3nOvc5x6CCni8ZJFceSIFn9xU5GbnVuzPByL1Yr6z0Vf+V8ZJCURD 7fbqVmjwn4hgqxpOZ/ttI3PYa8HWuz4ajR6d7hnpDhq+c57RrDlLX8kPxKJ2rdFMSYUx vuRIyUDvuH0Kw0NYQe/IcAEMBqdOm1YzStPRwWJ37RhYq2zCL/dplbvxJSGt7QOCQ/wS bRZg== X-Gm-Message-State: AOAM533oGOj8uzPxXTY2Fe2lYQxt3EJQLtrKMXUZPy4dIiY7L85SO22r kDsjGSzuOWogW43yzwAckYqwLw== X-Google-Smtp-Source: ABdhPJzcQL5JyoVR8CeS1RAcBqswo1ZPxXP5b1mnWO7335qavWdyOdHHkdriZYbHAmaSLHb6abh7PA== X-Received: by 2002:a1c:9c01:: with SMTP id f1mr7325353wme.159.1612446927456; Thu, 04 Feb 2021 05:55:27 -0800 (PST) Received: from dell ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id 13sm5464521wmj.11.2021.02.04.05.55.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 05:55:26 -0800 (PST) Date: Thu, 4 Feb 2021 13:55:25 +0000 From: Lee Jones To: Hans de Goede Cc: Cezary Rojewski , Pierre-Louis Bossart , Liam Girdwood , Jie Yang , Mark Brown , patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, Andy Shevchenko , Charles Keepax , alsa-devel@alsa-project.org Subject: Re: [PATCH v4 1/5] mfd: arizona: Add MODULE_SOFTDEP("pre: arizona_ldo1") Message-ID: <20210204135525.GJ2789116@dell> References: <20210120214957.140232-1-hdegoede@redhat.com> <20210120214957.140232-2-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210120214957.140232-2-hdegoede@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 20 Jan 2021, Hans de Goede wrote: > The (shared) probing code of the arizona-i2c and arizona-spi modules > takes the following steps during init: > > 1. Call mfd_add_devices() for a set of early child-devices, this > includes the arizona_ldo1 device which provides one of the > core-regulators. > > 2. Bulk enable the core-regulators. > > 3. Read the device id. > > 4. Call mfd_add_devices() for the other child-devices. > > This sequence depends on 1. leading to not only the child-device > being created, but also the driver for the child-device binding > to it and registering its regulator. > > This requires the arizona_ldo1 driver to be loaded before the > shared probing code runs. Add a softdep for this to both modules to > ensure that this requirement is met. > > Note this mirrors the existing MODULE_SOFTDEP("pre: wm8994_regulator") > in the wm8994 code, which has a similar init sequence. > > Reviewed-by: Andy Shevchenko > Acked-by: Charles Keepax > Signed-off-by: Hans de Goede > --- > drivers/mfd/arizona-i2c.c | 1 + > drivers/mfd/arizona-spi.c | 1 + > 2 files changed, 2 insertions(+) Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95B5BC433DB for ; Thu, 4 Feb 2021 13:57:08 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E392164E3F for ; Thu, 4 Feb 2021 13:57:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E392164E3F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 5F37416F9; Thu, 4 Feb 2021 14:56:16 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 5F37416F9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1612447026; bh=Mni2cD/zwfmwYm+ILfIfmROIbpS56ZuBHnWjWaNelfc=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=C6pPCGoMCVJQANAAXvgRBUZUmK1q/y5dMO9KaIgI/MwuxuKXsMbRXJYN8d9FFfwwA 5HpCiT6TrVyBYXg98xooGC7Xb220aroSgljbUHKJEgSDOyMZuwR8zgye4BVrNUPQu2 PjdUsuDIhHFikR6xj+6P6Asje/vVn4eVPu8bbdJU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id D38A3F8021C; Thu, 4 Feb 2021 14:55:33 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 86A80F8023C; Thu, 4 Feb 2021 14:55:32 +0100 (CET) Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 57EC8F80155 for ; Thu, 4 Feb 2021 14:55:28 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 57EC8F80155 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="m7Ec2oye" Received: by mail-wm1-x333.google.com with SMTP id m1so3071079wml.2 for ; Thu, 04 Feb 2021 05:55:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=+zWXPoMWro9z8YmAH2sD5hl0vnIUc9rVzm7BOffQpxc=; b=m7Ec2oyeRYSUEI0DX38UiaNVijd0iI1QiTiChQCQm5Xvcwptz40gsINlaEFJi+0RWp 0Quw5xqzhOJ7ifiayJlOJWMmHIaL3Q0jwjXl/VvvCPrZeEDEObSiUgMBcQjnmVW0wWrN Ub07GT5giot2k5sR9hxkYjycUjCNi0+rV4dUQm1rJJ2iVRiejiapEAPkcAnJ3S2ZFMxi uLBkNbq79CWniMwmOjryIutYK79xFxIRIVwlcvUEhvGEbb35yOnFvIhhaswc4g/m7cjx CLON7I3WIXU7Qy2thvi7X+mPKgkNSGAKuUYYyrNFjyKcRSFyrDOirMRi+izqaUMuPmec FpPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=+zWXPoMWro9z8YmAH2sD5hl0vnIUc9rVzm7BOffQpxc=; b=BxYyX3TkzrDJZOQBPoCgkAvuHvJaq3rMLGNdSQQkbABIfqtUH3K51GAGQXvVMrqSl+ 99YLPP3xBRZkK89L00019ahUDtX6EIjngE6Tr6TG5In3JRQl61CSM4OrMgPfXkSmyEZ4 gtpcdqhfbiUv90zKTAe27j2Y9u68cRuz8pHwshXQgafXIsCwmctTp9KGBgbU7u/e2FGi GqY2tdo8NLzjbPOrkSnfZo3ENaqNVz1nAKumX4RZzxQCVO2iDlNvocLieLSPk3B3w0A6 CgMgwACvuMEpbo9xzb2R3Qpe8aspAQpPyDWtPyuSAhQW0rJn6h5glzuGKCZQ6jiPYzvt IWig== X-Gm-Message-State: AOAM530eSkf5ckLNtUKF8QXLQCeNt3A1X4zN1VvUgfTpI7zJCBMTT5nG ToBV2e6aOxRa3tcc0ltV2OGlCw== X-Google-Smtp-Source: ABdhPJzcQL5JyoVR8CeS1RAcBqswo1ZPxXP5b1mnWO7335qavWdyOdHHkdriZYbHAmaSLHb6abh7PA== X-Received: by 2002:a1c:9c01:: with SMTP id f1mr7325353wme.159.1612446927456; Thu, 04 Feb 2021 05:55:27 -0800 (PST) Received: from dell ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id 13sm5464521wmj.11.2021.02.04.05.55.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 05:55:26 -0800 (PST) Date: Thu, 4 Feb 2021 13:55:25 +0000 From: Lee Jones To: Hans de Goede Subject: Re: [PATCH v4 1/5] mfd: arizona: Add MODULE_SOFTDEP("pre: arizona_ldo1") Message-ID: <20210204135525.GJ2789116@dell> References: <20210120214957.140232-1-hdegoede@redhat.com> <20210120214957.140232-2-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210120214957.140232-2-hdegoede@redhat.com> Cc: Cezary Rojewski , Charles Keepax , alsa-devel@alsa-project.org, patches@opensource.cirrus.com, Jie Yang , Pierre-Louis Bossart , linux-kernel@vger.kernel.org, Liam Girdwood , Andy Shevchenko , Mark Brown X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 20 Jan 2021, Hans de Goede wrote: > The (shared) probing code of the arizona-i2c and arizona-spi modules > takes the following steps during init: > > 1. Call mfd_add_devices() for a set of early child-devices, this > includes the arizona_ldo1 device which provides one of the > core-regulators. > > 2. Bulk enable the core-regulators. > > 3. Read the device id. > > 4. Call mfd_add_devices() for the other child-devices. > > This sequence depends on 1. leading to not only the child-device > being created, but also the driver for the child-device binding > to it and registering its regulator. > > This requires the arizona_ldo1 driver to be loaded before the > shared probing code runs. Add a softdep for this to both modules to > ensure that this requirement is met. > > Note this mirrors the existing MODULE_SOFTDEP("pre: wm8994_regulator") > in the wm8994 code, which has a similar init sequence. > > Reviewed-by: Andy Shevchenko > Acked-by: Charles Keepax > Signed-off-by: Hans de Goede > --- > drivers/mfd/arizona-i2c.c | 1 + > drivers/mfd/arizona-spi.c | 1 + > 2 files changed, 2 insertions(+) Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog