From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC77CC433DB for ; Thu, 4 Feb 2021 19:33:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A39D464F6A for ; Thu, 4 Feb 2021 19:33:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239908AbhBDTdv (ORCPT ); Thu, 4 Feb 2021 14:33:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236563AbhBDN6d (ORCPT ); Thu, 4 Feb 2021 08:58:33 -0500 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7FC16C061355 for ; Thu, 4 Feb 2021 05:56:31 -0800 (PST) Received: by mail-wm1-x335.google.com with SMTP id a16so6001051wmm.0 for ; Thu, 04 Feb 2021 05:56:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=PIhCp8il47YAvxqad9wdbokygqezWUysVvDAkwwnuTQ=; b=i5tL/xmNo+KoC4L+J++aT8o9sf0W4gpJ5zTnyIyHO8lfutg+zYLMGr72A2HPstt5ki DvBUkuAa0qhUwXb30x6BNaI06P1ROgBYC3Xzp6ovgfbZbqKQGVQHuMz5BkDDRHR7XE/u P7YFaJoeJ1OFtsLOZ8U5JgvO3zgSHfxNggH3cD7cuu2gaUBMmbQY/DXZK5x0r9cpX5Od i5sFKtVA7sm+QXyr711m6l0lEt4yiaFWzArLzqx4zsy14fu/R1fjwdqQVehbMnjI/3vJ RbsqDCJdDmMGGtQ+0pkPkJeL5Z9QYIwyUfzOoTiiBLrxaeeloIJ6meDfX36ZuFhzhp+/ L3Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=PIhCp8il47YAvxqad9wdbokygqezWUysVvDAkwwnuTQ=; b=kXqBj/IEXMrQPDQJSJLMKDFHsbPUN45REPY8X3NGP9IM6UbN/bpF5mFpucKytT0rzv 9AyvNrL7JOuIDf/6K73tZ5xnwV+l72/V4Mt/ixhaEyZA6/QUMmwbzHiVUphp3AJwqncQ QWZygVMFfvJbhReWj33YRsaf3pna8UsD5+WDFCeFwtZU2SOVMWmoDpFARpfnWQMkfm3S F3n7SvCAKIhju6A8/zPwxYrrBBl0yygwHsVrd1XyrCoB7NeoJI0oa+u3++sEsyI96kCM 8ksnx0saYI+0gfju4ccTBUWGsiFA1mgTVLpu+EXUTObUaJ5pvjDy8nzE5ih1/foIDVow GA2w== X-Gm-Message-State: AOAM5317eRBJKH21aS9tkCPG4KpsHTZNFIukdZfmmmBNJN5EH4BnbBLw lnZUY4edFvLcWzEwQ8ndFrRHbA== X-Google-Smtp-Source: ABdhPJzxt85Icg/KGkiKBlSAEikhPnZG1noHL4jUI+b++S85sT5D34hbYN70ykTecBBOWTCPRwpAgA== X-Received: by 2002:a1c:7e4e:: with SMTP id z75mr7686696wmc.168.1612446990254; Thu, 04 Feb 2021 05:56:30 -0800 (PST) Received: from dell ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id r13sm6788058wmh.9.2021.02.04.05.56.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 05:56:29 -0800 (PST) Date: Thu, 4 Feb 2021 13:56:27 +0000 From: Lee Jones To: Hans de Goede Cc: Cezary Rojewski , Pierre-Louis Bossart , Liam Girdwood , Jie Yang , Mark Brown , patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, Andy Shevchenko , Charles Keepax , alsa-devel@alsa-project.org Subject: Re: [PATCH v4 5/5] ASoC: Intel: bytcr_wm5102: Add machine driver for BYT/WM5102 Message-ID: <20210204135627.GM2789116@dell> References: <20210120214957.140232-1-hdegoede@redhat.com> <20210120214957.140232-6-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210120214957.140232-6-hdegoede@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 20 Jan 2021, Hans de Goede wrote: > From: Pierre-Louis Bossart > > Add a new ASoc Machine driver for Intel Baytrail platforms with a > Wolfson Microelectronics WM5102 codec. > > This is based on a past contributions [1] from Paulo Sergio Travaglia > based on the Levono kernel [2] combined with > insights in things like the speaker GPIO from the android-x86 android > port for the Lenovo Yoga Tablet 2 1051F/L [3]. > > [1] https://patchwork.kernel.org/project/alsa-devel/patch/593313f5.3636c80a.50e05.47e9@mx.google.com/ > [2] https://github.com/lenovo-yt2-dev/android_kernel_lenovo_baytrail/blob/cm-12.1/sound/soc/intel/board/byt_bl_wm5102.c > [3] https://github.com/Kitsune2222/Android_Yoga_Tablet_2-1051F_Kernel > > The original machine driver from the Android ports was a crude modified > copy of bytcr_rt5640.c adjusted to work with the WM5102 codec. > This version has been extensively reworked to: > > 1. Remove all rt5640 related quirk handling. to the best of my knowledge > this setup is only used on the Lenovo Yoga Tablet 2 series (8, 10 and 13 > inch models) which all use the same setup. So there is no need to deal > with all the variations with which we need to deal on rt5640 boards. > > 2. Rework clock handling, properly turn off the FLL and the platform-clock > when they are no longer necessary and don't reconfigure the FLL > unnecessarily when it is already running. This fixes a number of: > "Timed out waiting for lock" warnings being logged. > > 3. Add the GPIO controlled Speaker-VDD regulator as a DAPM_SUPPLY > > This only adds the machine driver and ACPI hooks, the BYT-CR detection > quirk which these devices need will be added in a separate patch. > > BugLink: https://github.com/thesofproject/linux/issues/2485 > Co-authored-by: Pierre-Louis Bossart > Signed-off-by: Pierre-Louis Bossart > Reviewed-by: Andy Shevchenko > Signed-off-by: Hans de Goede > --- > Changes in v2: > - Drop unnecessary configuring of OPCLK > - Fix error-msg when setting the SYSCLK fails > --- > sound/soc/intel/boards/Kconfig | 12 + > sound/soc/intel/boards/Makefile | 2 + > sound/soc/intel/boards/bytcr_wm5102.c | 465 ++++++++++++++++++ > .../intel/common/soc-acpi-intel-byt-match.c | 16 + > 4 files changed, 495 insertions(+) > create mode 100644 sound/soc/intel/boards/bytcr_wm5102.c Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CEDFC433DB for ; Thu, 4 Feb 2021 13:58:01 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9319B64DC4 for ; Thu, 4 Feb 2021 13:58:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9319B64DC4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 26B161706; Thu, 4 Feb 2021 14:57:09 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 26B161706 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1612447079; bh=RVxdmQ8XGLcyY3bvsXcMlq/mzNR1J3rKA5Rum2aWOj4=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=uoGGypoItU/N2UiGY9Y8KiUSmYfzl7TRSgb4cDtM53WjkeQkhzH0KYYWudSy7qTQm MFCLj2XnepEdu9oJeAd6NmuTV1eRCKWJcSPv4zG6Xze52fckmfoF4E/UQGAX94q65u Oqhm93eFdvCLW5EG6+IAdKJw8DiQxpjquSz/fnLM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C06ADF80264; Thu, 4 Feb 2021 14:56:36 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2C4B2F80277; Thu, 4 Feb 2021 14:56:35 +0100 (CET) Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D5FA7F80264 for ; Thu, 4 Feb 2021 14:56:31 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D5FA7F80264 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="i5tL/xmN" Received: by mail-wm1-x329.google.com with SMTP id l12so3205000wmq.2 for ; Thu, 04 Feb 2021 05:56:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=PIhCp8il47YAvxqad9wdbokygqezWUysVvDAkwwnuTQ=; b=i5tL/xmNo+KoC4L+J++aT8o9sf0W4gpJ5zTnyIyHO8lfutg+zYLMGr72A2HPstt5ki DvBUkuAa0qhUwXb30x6BNaI06P1ROgBYC3Xzp6ovgfbZbqKQGVQHuMz5BkDDRHR7XE/u P7YFaJoeJ1OFtsLOZ8U5JgvO3zgSHfxNggH3cD7cuu2gaUBMmbQY/DXZK5x0r9cpX5Od i5sFKtVA7sm+QXyr711m6l0lEt4yiaFWzArLzqx4zsy14fu/R1fjwdqQVehbMnjI/3vJ RbsqDCJdDmMGGtQ+0pkPkJeL5Z9QYIwyUfzOoTiiBLrxaeeloIJ6meDfX36ZuFhzhp+/ L3Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=PIhCp8il47YAvxqad9wdbokygqezWUysVvDAkwwnuTQ=; b=Ju3bQe/S1n3q77t78yzNAVTL+WWQAnyfyKVDRHTtVKkYDpQ5dnk1WUWVGR9A4QENQp j7j8WAlHJoCVHWlpEkERAxAzHiotCefL21cPMf89VvCCO7BM2EHHkcK1hBhE484SFp2J rCQgZpNfdTetdhcEB+iVBuzfQIPoMDQuTv7SKDr9+LVbbYLQ2W4gvIO1kjKztBJ3cfBG ph7foXU8N3L+cozo2pHXxg/2+IYIUthx17Hev2hVoh1MC02IJs4cw1krTD5Cb0AU6C9N VbLpKFL1gPgtO7w8EWwmzUi/VANy16XwSExk3jcZs8s6alD3zCMSLvWWXibY3r4kOyAW IIYw== X-Gm-Message-State: AOAM532Bvo5Vhr+67fmrJYJXingmDT0gSleJMyk4h+RjdNeFlEJ7uI3Y AcY1+wzoM+mO6s6yzaM2idAcCQ== X-Google-Smtp-Source: ABdhPJzxt85Icg/KGkiKBlSAEikhPnZG1noHL4jUI+b++S85sT5D34hbYN70ykTecBBOWTCPRwpAgA== X-Received: by 2002:a1c:7e4e:: with SMTP id z75mr7686696wmc.168.1612446990254; Thu, 04 Feb 2021 05:56:30 -0800 (PST) Received: from dell ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id r13sm6788058wmh.9.2021.02.04.05.56.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 05:56:29 -0800 (PST) Date: Thu, 4 Feb 2021 13:56:27 +0000 From: Lee Jones To: Hans de Goede Subject: Re: [PATCH v4 5/5] ASoC: Intel: bytcr_wm5102: Add machine driver for BYT/WM5102 Message-ID: <20210204135627.GM2789116@dell> References: <20210120214957.140232-1-hdegoede@redhat.com> <20210120214957.140232-6-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210120214957.140232-6-hdegoede@redhat.com> Cc: Cezary Rojewski , Charles Keepax , alsa-devel@alsa-project.org, patches@opensource.cirrus.com, Jie Yang , Pierre-Louis Bossart , linux-kernel@vger.kernel.org, Liam Girdwood , Andy Shevchenko , Mark Brown X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 20 Jan 2021, Hans de Goede wrote: > From: Pierre-Louis Bossart > > Add a new ASoc Machine driver for Intel Baytrail platforms with a > Wolfson Microelectronics WM5102 codec. > > This is based on a past contributions [1] from Paulo Sergio Travaglia > based on the Levono kernel [2] combined with > insights in things like the speaker GPIO from the android-x86 android > port for the Lenovo Yoga Tablet 2 1051F/L [3]. > > [1] https://patchwork.kernel.org/project/alsa-devel/patch/593313f5.3636c80a.50e05.47e9@mx.google.com/ > [2] https://github.com/lenovo-yt2-dev/android_kernel_lenovo_baytrail/blob/cm-12.1/sound/soc/intel/board/byt_bl_wm5102.c > [3] https://github.com/Kitsune2222/Android_Yoga_Tablet_2-1051F_Kernel > > The original machine driver from the Android ports was a crude modified > copy of bytcr_rt5640.c adjusted to work with the WM5102 codec. > This version has been extensively reworked to: > > 1. Remove all rt5640 related quirk handling. to the best of my knowledge > this setup is only used on the Lenovo Yoga Tablet 2 series (8, 10 and 13 > inch models) which all use the same setup. So there is no need to deal > with all the variations with which we need to deal on rt5640 boards. > > 2. Rework clock handling, properly turn off the FLL and the platform-clock > when they are no longer necessary and don't reconfigure the FLL > unnecessarily when it is already running. This fixes a number of: > "Timed out waiting for lock" warnings being logged. > > 3. Add the GPIO controlled Speaker-VDD regulator as a DAPM_SUPPLY > > This only adds the machine driver and ACPI hooks, the BYT-CR detection > quirk which these devices need will be added in a separate patch. > > BugLink: https://github.com/thesofproject/linux/issues/2485 > Co-authored-by: Pierre-Louis Bossart > Signed-off-by: Pierre-Louis Bossart > Reviewed-by: Andy Shevchenko > Signed-off-by: Hans de Goede > --- > Changes in v2: > - Drop unnecessary configuring of OPCLK > - Fix error-msg when setting the SYSCLK fails > --- > sound/soc/intel/boards/Kconfig | 12 + > sound/soc/intel/boards/Makefile | 2 + > sound/soc/intel/boards/bytcr_wm5102.c | 465 ++++++++++++++++++ > .../intel/common/soc-acpi-intel-byt-match.c | 16 + > 4 files changed, 495 insertions(+) > create mode 100644 sound/soc/intel/boards/bytcr_wm5102.c Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog