From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 388C5C433DB for ; Thu, 4 Feb 2021 15:38:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0E34864F3C for ; Thu, 4 Feb 2021 15:38:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237483AbhBDPiI (ORCPT ); Thu, 4 Feb 2021 10:38:08 -0500 Received: from verein.lst.de ([213.95.11.211]:56504 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237449AbhBDPhS (ORCPT ); Thu, 4 Feb 2021 10:37:18 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id 5FD9C6736F; Thu, 4 Feb 2021 16:36:32 +0100 (CET) Date: Thu, 4 Feb 2021 16:36:31 +0100 From: Christoph Hellwig To: Jens Axboe Cc: Christoph Hellwig , Chao Leng , linux-nvme@lists.infradead.org, kbusch@kernel.org, sagi@grimberg.me, linux-block@vger.kernel.org, axboe@kernel.dk Subject: Re: [PATCH v5 1/3] blk-mq: introduce blk_mq_set_request_complete Message-ID: <20210204153631.GA30261@lst.de> References: <20210201034940.18891-1-lengchao@huawei.com> <20210201034940.18891-2-lengchao@huawei.com> <3b75b43c-638b-b5ac-eb5e-e37314d25ce1@fb.com> <20210204153014.GA29736@lst.de> <70bdb0b1-c7aa-af25-4b28-f8f6675c73ae@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <70bdb0b1-c7aa-af25-4b28-f8f6675c73ae@fb.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, Feb 04, 2021 at 08:32:17AM -0700, Jens Axboe wrote: > On 2/4/21 8:30 AM, Christoph Hellwig wrote: > > On Thu, Feb 04, 2021 at 08:27:46AM -0700, Jens Axboe wrote: > >> On 1/31/21 8:49 PM, Chao Leng wrote: > >>> nvme drivers need to set the state of request to MQ_RQ_COMPLETE when > >>> directly complete request in queue_rq. > >>> So add blk_mq_set_request_complete. > >> > >> This is a bit iffy, but looks ok for the intended use case. We just have > >> to be careful NOT to add frivolous users of it... > > > > Yes, that is my main issue with it. The current use case looks fine, > > but I suspect every time someone else uses it it's probly going to be > > as misuse. I've applied this to nvme-5.12 with the rest of the patches, > > it should be on its way to you soon. > > Might benefit from a big fat comment on why you probably shouldn't > be using it... I actually reworded the comment a bit, this is the current version: http://git.infradead.org/nvme.git/commitdiff/bdd2a4a61460a341c1f8462e5caf63195e960623 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8DBBC433E0 for ; Thu, 4 Feb 2021 15:36:51 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 87E1B64DEB for ; Thu, 4 Feb 2021 15:36:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 87E1B64DEB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5bg5SyGcz7p5p5JOlZwSv+nCFrQSLXWMNLu7DEuK5dw=; b=PQ2IFp5yMGp6QDFHZUP3n986/ xGbtY7OpeXYIYA0srQvsL8HxZgBKUktCVTTgeyviYwGMrOxbz2BbNkQ8bA5qZlq4hy8hdMZhe+XQr DFR31DZuoT8cMu31QbUGtucuPeYT15dOnmn1uGfTxktiwLCBI+XX5GPDOJQhH7SudNmrkTup6icwW bqmWhfUsWjrGkN8MhR1cnrzTPCnidID12jjNEsD0fqhQ9ZPItzBZN+mkruNMoAU79FZqEX/r2AJxN 1jZ+pAh/jABmBIaySfQ2IKSsVHStxqKs+psRktNr+0SuMXcPHXCM5YsMmsuH+B1bGvX54YJ6nlBwD kALoCEnmg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7ggS-0004Cs-68; Thu, 04 Feb 2021 15:36:40 +0000 Received: from verein.lst.de ([213.95.11.211]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7ggP-0004Bi-4i for linux-nvme@lists.infradead.org; Thu, 04 Feb 2021 15:36:38 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 5FD9C6736F; Thu, 4 Feb 2021 16:36:32 +0100 (CET) Date: Thu, 4 Feb 2021 16:36:31 +0100 From: Christoph Hellwig To: Jens Axboe Subject: Re: [PATCH v5 1/3] blk-mq: introduce blk_mq_set_request_complete Message-ID: <20210204153631.GA30261@lst.de> References: <20210201034940.18891-1-lengchao@huawei.com> <20210201034940.18891-2-lengchao@huawei.com> <3b75b43c-638b-b5ac-eb5e-e37314d25ce1@fb.com> <20210204153014.GA29736@lst.de> <70bdb0b1-c7aa-af25-4b28-f8f6675c73ae@fb.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <70bdb0b1-c7aa-af25-4b28-f8f6675c73ae@fb.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210204_103637_378692_7D2CC274 X-CRM114-Status: GOOD ( 18.13 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: axboe@kernel.dk, sagi@grimberg.me, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, Chao Leng , kbusch@kernel.org, Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Thu, Feb 04, 2021 at 08:32:17AM -0700, Jens Axboe wrote: > On 2/4/21 8:30 AM, Christoph Hellwig wrote: > > On Thu, Feb 04, 2021 at 08:27:46AM -0700, Jens Axboe wrote: > >> On 1/31/21 8:49 PM, Chao Leng wrote: > >>> nvme drivers need to set the state of request to MQ_RQ_COMPLETE when > >>> directly complete request in queue_rq. > >>> So add blk_mq_set_request_complete. > >> > >> This is a bit iffy, but looks ok for the intended use case. We just have > >> to be careful NOT to add frivolous users of it... > > > > Yes, that is my main issue with it. The current use case looks fine, > > but I suspect every time someone else uses it it's probly going to be > > as misuse. I've applied this to nvme-5.12 with the rest of the patches, > > it should be on its way to you soon. > > Might benefit from a big fat comment on why you probably shouldn't > be using it... I actually reworded the comment a bit, this is the current version: http://git.infradead.org/nvme.git/commitdiff/bdd2a4a61460a341c1f8462e5caf63195e960623 _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme