From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31A7CC433DB for ; Thu, 4 Feb 2021 15:46:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E265464F4A for ; Thu, 4 Feb 2021 15:46:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237439AbhBDPqc (ORCPT ); Thu, 4 Feb 2021 10:46:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:60780 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237388AbhBDPlY (ORCPT ); Thu, 4 Feb 2021 10:41:24 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3AE3F64F47; Thu, 4 Feb 2021 15:40:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612453243; bh=94cY1u+hNd+/OdEI6Ip/ZV8/7uanpQEYhbCY1QFgwsQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SYOlSKMDU3k85Bue6/Kvbv8YYlR208G4wR+IqGqoxGeeBEl5q7f7hDS75PAk08Vay 0XfgTWIDrneQbfWOBqCMx/JOzMNaodgiE4PMwkXYG2b4/Am53ph/Q4LleNVwdt2kq4 lIUxJ7Qwfvlc3487jtpk9nS502ZxurDAG8f5h6DxREEcatMAfTg0h58i1xpgz2hrQv bQhiaVpSx9zLEpXcHtORU+KIU1zA+4B3WQWbcGR8f1oXm8d2AzfS3viZVrHU562E2N I16MbaV8JSF7ayzoil5coP0I94DuC1YjXJT/tI4jXWRO6hZE0w0kD73MRcBtIr5PAK SNu6WIVqxBdMQ== Date: Thu, 4 Feb 2021 15:40:39 +0000 From: Will Deacon To: Andrei Vagin Cc: Catalin Marinas , Oleg Nesterov , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, Anthony Steinhauser , Dave Martin , Keno Fischer , keescook@chromium.org Subject: Re: [PATCH 3/3] selftest/arm64/ptrace: add tests for PTRACE_O_ARM64_RAW_REGS Message-ID: <20210204154038.GC21058@willie-the-truck> References: <20210201194012.524831-1-avagin@gmail.com> <20210201194012.524831-4-avagin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210201194012.524831-4-avagin@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [+Kees] On Mon, Feb 01, 2021 at 11:40:12AM -0800, Andrei Vagin wrote: > Test output: > TAP version 13 > 1..2 > # selftests: arm64/ptrace: ptrace_syscall_raw_regs_test > # 1..2 > # ok 1 x7: 686920776f726c64 > # ok 2 The child exited with code 0. > # # Totals: pass:2 fail:0 xfail:0 xpass:0 skip:0 error:0 > ok 1 selftests: arm64/ptrace: ptrace_syscall_raw_regs_test > # selftests: arm64/ptrace: ptrace_syscall_regs_test > # 1..3 > # ok 1 x7: 0 > # ok 2 x7: 1 > # ok 3 The child exited with code 0. > # # Totals: pass:3 fail:0 xfail:0 xpass:0 skip:0 error:0 > ok 2 selftests: arm64/ptrace: ptrace_syscall_regs_test > > Signed-off-by: Andrei Vagin > --- > tools/testing/selftests/arm64/Makefile | 2 +- > tools/testing/selftests/arm64/ptrace/Makefile | 6 + > .../ptrace/ptrace_syscall_raw_regs_test.c | 142 +++++++++++++++++ > .../arm64/ptrace/ptrace_syscall_regs_test.c | 150 ++++++++++++++++++ > 4 files changed, 299 insertions(+), 1 deletion(-) > create mode 100644 tools/testing/selftests/arm64/ptrace/Makefile > create mode 100644 tools/testing/selftests/arm64/ptrace/ptrace_syscall_raw_regs_test.c > create mode 100644 tools/testing/selftests/arm64/ptrace/ptrace_syscall_regs_test.c Thanks for the tests! We already have a pretty extensive set of syscall entry tests in tools/testing/selftests/seccomp, so perhaps this would be better off as part of that? Maybe worth a look. Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAD20C433E0 for ; Thu, 4 Feb 2021 15:41:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 99E1664F4A for ; Thu, 4 Feb 2021 15:41:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 99E1664F4A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xes1vzYt9eDNe/0Lbcw7JZbevq9LF/lASG76UJ2iZVE=; b=JiARrXE+Wk8jLR8Ayylkyp1k8 0IRFxGB468dnucIofjnT5Y4zh5CRSOFxPkez/myJzMRt2t6pJg7YFO0TGUod1dpkigq3WAnZSJmJa lgZKS3It0legZFH8HBQreISguUGd0RfgVB5kS+UJrf5OzYp4A+VLXUxHPz3+czkOV8fYp9VxnHyjB DZF/wD6TlP5fcbi+iD65kfosAEIo5HFC90wsG6eZyy3P4UNtrkzs+m9B9SHQerR57q8Cj/jM7X6lN ayhlX23s3q+9ZaumiOg4fJbHJwgtL5o+qlFe0PBdeWtS7Rclba7BElItSvJ71FRVAyLX1dNcvNK2w F2wOgGuaQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7gkU-00057x-7f; Thu, 04 Feb 2021 15:40:50 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7gkQ-00056a-B9 for linux-arm-kernel@lists.infradead.org; Thu, 04 Feb 2021 15:40:48 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3AE3F64F47; Thu, 4 Feb 2021 15:40:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612453243; bh=94cY1u+hNd+/OdEI6Ip/ZV8/7uanpQEYhbCY1QFgwsQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SYOlSKMDU3k85Bue6/Kvbv8YYlR208G4wR+IqGqoxGeeBEl5q7f7hDS75PAk08Vay 0XfgTWIDrneQbfWOBqCMx/JOzMNaodgiE4PMwkXYG2b4/Am53ph/Q4LleNVwdt2kq4 lIUxJ7Qwfvlc3487jtpk9nS502ZxurDAG8f5h6DxREEcatMAfTg0h58i1xpgz2hrQv bQhiaVpSx9zLEpXcHtORU+KIU1zA+4B3WQWbcGR8f1oXm8d2AzfS3viZVrHU562E2N I16MbaV8JSF7ayzoil5coP0I94DuC1YjXJT/tI4jXWRO6hZE0w0kD73MRcBtIr5PAK SNu6WIVqxBdMQ== Date: Thu, 4 Feb 2021 15:40:39 +0000 From: Will Deacon To: Andrei Vagin Subject: Re: [PATCH 3/3] selftest/arm64/ptrace: add tests for PTRACE_O_ARM64_RAW_REGS Message-ID: <20210204154038.GC21058@willie-the-truck> References: <20210201194012.524831-1-avagin@gmail.com> <20210201194012.524831-4-avagin@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210201194012.524831-4-avagin@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210204_104046_500014_FAC06592 X-CRM114-Status: GOOD ( 11.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: keescook@chromium.org, Anthony Steinhauser , Catalin Marinas , Oleg Nesterov , linux-kernel@vger.kernel.org, Keno Fischer , linux-api@vger.kernel.org, Dave Martin , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org [+Kees] On Mon, Feb 01, 2021 at 11:40:12AM -0800, Andrei Vagin wrote: > Test output: > TAP version 13 > 1..2 > # selftests: arm64/ptrace: ptrace_syscall_raw_regs_test > # 1..2 > # ok 1 x7: 686920776f726c64 > # ok 2 The child exited with code 0. > # # Totals: pass:2 fail:0 xfail:0 xpass:0 skip:0 error:0 > ok 1 selftests: arm64/ptrace: ptrace_syscall_raw_regs_test > # selftests: arm64/ptrace: ptrace_syscall_regs_test > # 1..3 > # ok 1 x7: 0 > # ok 2 x7: 1 > # ok 3 The child exited with code 0. > # # Totals: pass:3 fail:0 xfail:0 xpass:0 skip:0 error:0 > ok 2 selftests: arm64/ptrace: ptrace_syscall_regs_test > > Signed-off-by: Andrei Vagin > --- > tools/testing/selftests/arm64/Makefile | 2 +- > tools/testing/selftests/arm64/ptrace/Makefile | 6 + > .../ptrace/ptrace_syscall_raw_regs_test.c | 142 +++++++++++++++++ > .../arm64/ptrace/ptrace_syscall_regs_test.c | 150 ++++++++++++++++++ > 4 files changed, 299 insertions(+), 1 deletion(-) > create mode 100644 tools/testing/selftests/arm64/ptrace/Makefile > create mode 100644 tools/testing/selftests/arm64/ptrace/ptrace_syscall_raw_regs_test.c > create mode 100644 tools/testing/selftests/arm64/ptrace/ptrace_syscall_regs_test.c Thanks for the tests! We already have a pretty extensive set of syscall entry tests in tools/testing/selftests/seccomp, so perhaps this would be better off as part of that? Maybe worth a look. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel