From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2091DC433E0 for ; Fri, 5 Feb 2021 00:42:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DBAF464F8C for ; Fri, 5 Feb 2021 00:42:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232066AbhBEAlp (ORCPT ); Thu, 4 Feb 2021 19:41:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231956AbhBEAlj (ORCPT ); Thu, 4 Feb 2021 19:41:39 -0500 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17F7CC061786 for ; Thu, 4 Feb 2021 16:40:59 -0800 (PST) Received: by mail-wr1-x434.google.com with SMTP id z6so5665324wrq.10 for ; Thu, 04 Feb 2021 16:40:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=DUZi2bTfy11l+UEZp8Mba5c7avH04XQB0vRN2ZYNQmk=; b=K9tE4mFU3BLsSxI1V2AXkjuvskB3tJ18kV+HRZihuX1+H1EdM+TRsaacDL1so2THx1 d/Mi+ipR3Os6ky7VMogMQf2sNnZ6EP2cdgAIHXUak+yMSYae/iXPjsMJmAh/PPj1JFYU GFxMCj64xKWuLD7wG0VeACaRwISb6RPSYm2+dvBFfLB6+9qCHUtg9HvME++UrMU/eCqI Xr3AFTUX26u6isiFu88LP0PRznl4DLu879/PcNlG89GckYeH9fKGbjGKjRWptKHyj3e3 rpqEOaTL3eMrOok0bXPGNO7w2jkkQKNalUDU/7gocnMatqhRA+6peYDUGWk120IXFI+3 Z+7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=DUZi2bTfy11l+UEZp8Mba5c7avH04XQB0vRN2ZYNQmk=; b=hPMUv77wVZNKarTeSVAZ4+ZxzEVvOpYsbiUAEkhs0aVRghLdtMwxVRIFfXznMRsKoK xXmJjYqFucg9X1pCYLdN0l7mhI37ljONcnHgz/YHspKuHCUP7bNBcFUSIa1Mar7G8YYH 5grEzWms+Zwm7rVRhF35htOh3Ah6fTj/vGhPCAPUxOS+CRZAC9/E9I7I9ndGVTFzvOCP YS1hmg0IEj1C3Dn++P17IBmIpP6S5G1/+yEsWrKu3RgmsCX6lutfbmNWWV8p0ihhZ3uZ Uz8JzXnNdRZnnCZATU4tF1XmbDG488cFyUYzCJ3pcV74rGgiWHHz3FKqjINJISofC9KL 5yXQ== X-Gm-Message-State: AOAM531+e6nTaqYycKb3tEEb7sD33cnjcOzC9KfYrNBCqguX4z4ogAJg h3dZUV2bgRKv9v6U4gxtQt4= X-Google-Smtp-Source: ABdhPJx6msIudNiBk4YjLEkzTDLhc93tgqv4KYCwjRMjKkTr8TvQy4L4rpv/Ga/5p2i8nmI9j1FRwA== X-Received: by 2002:a5d:4d0b:: with SMTP id z11mr2018935wrt.388.1612485657870; Thu, 04 Feb 2021 16:40:57 -0800 (PST) Received: from p4 ([151.44.37.244]) by smtp.gmail.com with ESMTPSA id d30sm11649255wrc.92.2021.02.04.16.40.56 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Feb 2021 16:40:57 -0800 (PST) Date: Fri, 5 Feb 2021 00:40:54 +0000 From: Giancarlo Ferrari To: Russell King - ARM Linux admin Cc: Mark Rutland , linux-kernel@vger.kernel.org, penberg@kernel.org, geert@linux-m68k.org, rppt@kernel.org, akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org, giancarlo.ferrari@nokia.com Subject: Re: [PATCH] ARM: kexec: Fix panic after TLB are invalidated Message-ID: <20210205004050.GA3319@p4> References: <1612140296-12546-1-git-send-email-giancarlo.ferrari89@gmail.com> <20210201124720.GA66060@C02TD0UTHF1T.local> <20210201130344.GF1463@shell.armlinux.org.uk> <20210201135714.GB66060@C02TD0UTHF1T.local> <20210201160838.GH1463@shell.armlinux.org.uk> <20210201200734.GC15399@p4> <20210201201633.GJ1463@shell.armlinux.org.uk> <20210201202742.GA17243@p4> <20210204234841.GA19339@p4> <20210205001833.GE1463@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210205001833.GE1463@shell.armlinux.org.uk> User-Agent: Mutt/1.5.24 (2015-08-30) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Russell, On Fri, Feb 05, 2021 at 12:18:33AM +0000, Russell King - ARM Linux admin wrote: > On Thu, Feb 04, 2021 at 11:48:42PM +0000, Giancarlo Ferrari wrote: > > Can I ask about having it integrated ? > > Thanks for testing. Are you willing for me to add: > > Tested-by: Giancarlo Ferrari > > to the commit log? > Sure. I have a question regarding the patch. I saw that the structure start at the end of the relocation code: data = reboot_code_buffer + relocate_new_kernel_size; which means it overlap with the global symbol relocate_new_kernel_size. I think is minor comment as the variable is only used in the fncpy() then thrown away. Something like: data = reboot_code_buffer + relocate_new_kernel_size + sizeof(long); and accordingly in the instruction (arch/arm/kernel/relocate_kernel.S): adr r7, relocate_new_kernel_end > I can move it into the fixes branch which I want to send to Linus by > Saturday at the very latest. > I am not used with all the merging process. However it sounds great ! > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! Thanks in advance, GF From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81A54C433DB for ; Fri, 5 Feb 2021 00:42:05 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2FC1264E0D for ; Fri, 5 Feb 2021 00:42:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2FC1264E0D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TRWkYXxGESVGIY3XhvrBVMEBfkbuqIDs/NLodwWMDrk=; b=zfgrRTAzbhDeWT9Ibg1t76bjT xzpcGCjoznBzxU3EpQv3aPMd/uKopEwcmLug65sPH5nGUNSLVALowgOLf/UEYrdxJUYYMD7cieA1K 72x3/WOev67Sah4J37HZk66udOqoFQOtpjEeMMWbWBzDbg5FCLDQuurDH4/jkuKept5AT/sv4EKaT B4y0HrK/Jc/1IgMh1s9AnLZ9gDOd12bXsExn0chuc8iTU9Myfab5+gs81aESJuvafAKtlY/t5OuIx wBTI+YWfnWtK9GogSwbE6zzvsuhYOMXFX9MoD82wOOF8icwwOw2AwGTHmKWeZgWJ91VwrHI9XkxX5 YfwJwV52Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7pBG-0001et-Ee; Fri, 05 Feb 2021 00:41:02 +0000 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7pBD-0001e7-RR for linux-arm-kernel@lists.infradead.org; Fri, 05 Feb 2021 00:41:00 +0000 Received: by mail-wr1-x432.google.com with SMTP id l12so5745298wry.2 for ; Thu, 04 Feb 2021 16:40:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=DUZi2bTfy11l+UEZp8Mba5c7avH04XQB0vRN2ZYNQmk=; b=K9tE4mFU3BLsSxI1V2AXkjuvskB3tJ18kV+HRZihuX1+H1EdM+TRsaacDL1so2THx1 d/Mi+ipR3Os6ky7VMogMQf2sNnZ6EP2cdgAIHXUak+yMSYae/iXPjsMJmAh/PPj1JFYU GFxMCj64xKWuLD7wG0VeACaRwISb6RPSYm2+dvBFfLB6+9qCHUtg9HvME++UrMU/eCqI Xr3AFTUX26u6isiFu88LP0PRznl4DLu879/PcNlG89GckYeH9fKGbjGKjRWptKHyj3e3 rpqEOaTL3eMrOok0bXPGNO7w2jkkQKNalUDU/7gocnMatqhRA+6peYDUGWk120IXFI+3 Z+7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=DUZi2bTfy11l+UEZp8Mba5c7avH04XQB0vRN2ZYNQmk=; b=je9Lncu4sdVL1eesS/DUOu0kCJJg9UuFH5H30v1l275TMPcvozpuYEnKa5yhloq3/P o2+zP7FdTVCkRO9Wr7WnDeahzVOYkdfc2nxv+0+w2bHIJ4Ku+L/TGXTAHb7Cw43PWavk R6pONOImWwt6oJ6c90LmB1YHV5jL5t8+Uhzj0AAqh1ZPMWubE/qsiS3JWHh6FL+H8/p0 Jtc5t3yL2pdPBxFjGHj5TIH0T6NoUxf4yZXqYS/ZwDxQdA+UXJvX8dQVva+WMv5Dv12y RmZWPRV/ENgDQnRqWNF/kqI7ILFjJgW6o1P65Gk/JDhXOj0mqOSAYqG70AFmAxVS8BhS Hx1A== X-Gm-Message-State: AOAM530nacqkVcsm0pqI9UwBwiB1vlTBdrYVU6YtbiIc/oIx2YGLmxkT 8j83ik33ig5wIUKxhp2ioUM= X-Google-Smtp-Source: ABdhPJx6msIudNiBk4YjLEkzTDLhc93tgqv4KYCwjRMjKkTr8TvQy4L4rpv/Ga/5p2i8nmI9j1FRwA== X-Received: by 2002:a5d:4d0b:: with SMTP id z11mr2018935wrt.388.1612485657870; Thu, 04 Feb 2021 16:40:57 -0800 (PST) Received: from p4 ([151.44.37.244]) by smtp.gmail.com with ESMTPSA id d30sm11649255wrc.92.2021.02.04.16.40.56 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Feb 2021 16:40:57 -0800 (PST) Date: Fri, 5 Feb 2021 00:40:54 +0000 From: Giancarlo Ferrari To: Russell King - ARM Linux admin Subject: Re: [PATCH] ARM: kexec: Fix panic after TLB are invalidated Message-ID: <20210205004050.GA3319@p4> References: <1612140296-12546-1-git-send-email-giancarlo.ferrari89@gmail.com> <20210201124720.GA66060@C02TD0UTHF1T.local> <20210201130344.GF1463@shell.armlinux.org.uk> <20210201135714.GB66060@C02TD0UTHF1T.local> <20210201160838.GH1463@shell.armlinux.org.uk> <20210201200734.GC15399@p4> <20210201201633.GJ1463@shell.armlinux.org.uk> <20210201202742.GA17243@p4> <20210204234841.GA19339@p4> <20210205001833.GE1463@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210205001833.GE1463@shell.armlinux.org.uk> User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210204_194059_910703_6754F19D X-CRM114-Status: GOOD ( 16.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-kernel@vger.kernel.org, penberg@kernel.org, geert@linux-m68k.org, linux-arm-kernel@lists.infradead.org, akpm@linux-foundation.org, rppt@kernel.org, giancarlo.ferrari@nokia.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Russell, On Fri, Feb 05, 2021 at 12:18:33AM +0000, Russell King - ARM Linux admin wrote: > On Thu, Feb 04, 2021 at 11:48:42PM +0000, Giancarlo Ferrari wrote: > > Can I ask about having it integrated ? > > Thanks for testing. Are you willing for me to add: > > Tested-by: Giancarlo Ferrari > > to the commit log? > Sure. I have a question regarding the patch. I saw that the structure start at the end of the relocation code: data = reboot_code_buffer + relocate_new_kernel_size; which means it overlap with the global symbol relocate_new_kernel_size. I think is minor comment as the variable is only used in the fncpy() then thrown away. Something like: data = reboot_code_buffer + relocate_new_kernel_size + sizeof(long); and accordingly in the instruction (arch/arm/kernel/relocate_kernel.S): adr r7, relocate_new_kernel_end > I can move it into the fixes branch which I want to send to Linus by > Saturday at the very latest. > I am not used with all the merging process. However it sounds great ! > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! Thanks in advance, GF _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel