From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B8E3C433E0 for ; Fri, 5 Feb 2021 09:24:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1279264F95 for ; Fri, 5 Feb 2021 09:24:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229976AbhBEJXl (ORCPT ); Fri, 5 Feb 2021 04:23:41 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:48326 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230153AbhBEJSX (ORCPT ); Fri, 5 Feb 2021 04:18:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612516617; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=57F239YtV0oHbCCj5J8DpWnEViN3tCKhKGovQyK+Lic=; b=ZzTPajMUgqW5xYX//MobQ/+xEIQNbQ2VWZ4IwSZwkV+jq4KgbNoxSxrjcDVb6MAHjcndBh LNzb2pK8TnuLb8Zoh6mDAvxIFK2jvmgzNfufEz3vQnKwOJRckHwnlhApVml1GDZ55OUqgx 98tAqUUdJb9gDzGrl7bTVFDBzTwhsKI= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-340-xWUnxE-gNEm18Y6ch7tOwg-1; Fri, 05 Feb 2021 04:16:55 -0500 X-MC-Unique: xWUnxE-gNEm18Y6ch7tOwg-1 Received: by mail-wr1-f71.google.com with SMTP id l7so4943593wrp.1 for ; Fri, 05 Feb 2021 01:16:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=57F239YtV0oHbCCj5J8DpWnEViN3tCKhKGovQyK+Lic=; b=qaT/ViU51IUNeHaX5lJH7dwWxByN3oy6Xt08rchgnno/zK7eELQyhQ82406Vvnjnvf JuwiSFlILd5aajQos+dS+k52lQ6B01AGLd6PfkjX2hDFJabX0Stylu6holalNUqcoCOb OttQvKIUDdqjzQ1AJy+e8mbvlBz/1OahKrc51M/ZE2IRpUsFr0MidUSBrBmqOTKxv9GW 1bHcKqLQ+UMcZSuH2AYaY4HcYMkTFNIyWyioxfZDw8v0SQt0IxnOF3EOkIO5WkQWwjOA fzPv/Z1/D9CjePdn6xkMwYlwpfmS384zaHpMfq15bSxY3Eb2vC+8IiwwdfkTVSQYmSYs vpXQ== X-Gm-Message-State: AOAM531z4PGfXwkvZJgFRfJYRR0stbuRQjNKfFY/PHLadZ356Ipej/Mf mfOEvukabek3ccufT06xpzLbN1ue82PdTt1kIcZK8OoZbIrFHrnxUha01zo0Qwhb8zwitaLznZj 4G3kGEb7je4b2/8Luw+u3/nVt X-Received: by 2002:adf:d84a:: with SMTP id k10mr3934400wrl.156.1612516614250; Fri, 05 Feb 2021 01:16:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJxm4rfj82uV3tGDph5pyyVq3oRWewQ+gBUMQfr86xZKT355ALHumrHiplodlmOUoLsCMMAfbw== X-Received: by 2002:adf:d84a:: with SMTP id k10mr3934381wrl.156.1612516614060; Fri, 05 Feb 2021 01:16:54 -0800 (PST) Received: from steredhat (host-79-34-249-199.business.telecomitalia.it. [79.34.249.199]) by smtp.gmail.com with ESMTPSA id g14sm12104482wru.45.2021.02.05.01.16.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 01:16:53 -0800 (PST) Date: Fri, 5 Feb 2021 10:16:51 +0100 From: Stefano Garzarella To: Jason Wang , "Michael S. Tsirkin" Cc: virtualization@lists.linux-foundation.org, Xie Yongji , kvm@vger.kernel.org, Laurent Vivier , Stefan Hajnoczi , Max Gurtovoy , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 09/13] vhost/vdpa: remove vhost_vdpa_config_validate() Message-ID: <20210205091651.xfcdyuvwwzew2ufo@steredhat> References: <20210204172230.85853-1-sgarzare@redhat.com> <20210204172230.85853-10-sgarzare@redhat.com> <6919d2d4-cc8e-2b67-2385-35803de5e38b@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6919d2d4-cc8e-2b67-2385-35803de5e38b@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 05, 2021 at 11:27:32AM +0800, Jason Wang wrote: > >On 2021/2/5 上午1:22, Stefano Garzarella wrote: >>get_config() and set_config() callbacks in the 'struct vdpa_config_ops' >>usually already validated the inputs. Also now they can return an error, >>so we don't need to validate them here anymore. >> >>Let's use the return value of these callbacks and return it in case of >>error in vhost_vdpa_get_config() and vhost_vdpa_set_config(). >> >>Originally-by: Xie Yongji >>Signed-off-by: Stefano Garzarella >>--- >> drivers/vhost/vdpa.c | 41 +++++++++++++---------------------------- >> 1 file changed, 13 insertions(+), 28 deletions(-) >> >>diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c >>index ef688c8c0e0e..d61e779000a8 100644 >>--- a/drivers/vhost/vdpa.c >>+++ b/drivers/vhost/vdpa.c >>@@ -185,51 +185,35 @@ static long vhost_vdpa_set_status(struct vhost_vdpa *v, u8 __user *statusp) >> return 0; >> } >>-static int vhost_vdpa_config_validate(struct vhost_vdpa *v, >>- struct vhost_vdpa_config *c) >>-{ >>- long size = 0; >>- >>- switch (v->virtio_id) { >>- case VIRTIO_ID_NET: >>- size = sizeof(struct virtio_net_config); >>- break; >>- } >>- >>- if (c->len == 0) >>- return -EINVAL; >>- >>- if (c->len > size - c->off) >>- return -E2BIG; >>- >>- return 0; >>-} >>- >> static long vhost_vdpa_get_config(struct vhost_vdpa *v, >> struct vhost_vdpa_config __user *c) >> { >> struct vdpa_device *vdpa = v->vdpa; >> struct vhost_vdpa_config config; >> unsigned long size = offsetof(struct vhost_vdpa_config, buf); >>+ long ret; >> u8 *buf; >> if (copy_from_user(&config, c, size)) >> return -EFAULT; >>- if (vhost_vdpa_config_validate(v, &config)) >>+ if (config.len == 0) >> return -EINVAL; >> buf = kvzalloc(config.len, GFP_KERNEL); > > >Then it means usersapce can allocate a very large memory. Good point. > >Rethink about this, we should limit the size here (e.g PAGE_SIZE) or >fetch the config size first (either through a config ops as you >suggested or a variable in the vdpa device that is initialized during >device creation). Maybe PAGE_SIZE is okay as a limit. If instead we want to fetch the config size, then better a config ops in my opinion, to avoid adding a new parameter to __vdpa_alloc_device(). I vote for PAGE_SIZE, but it isn't a strong opinion. What do you and @Michael suggest? Thanks, Stefano From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71D95C433E0 for ; Fri, 5 Feb 2021 09:17:03 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E139A64F4A for ; Fri, 5 Feb 2021 09:17:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E139A64F4A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 746022E0FE; Fri, 5 Feb 2021 09:17:02 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8vD6cljtDb6c; Fri, 5 Feb 2021 09:17:01 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id 34181203E8; Fri, 5 Feb 2021 09:17:01 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 19792C08A1; Fri, 5 Feb 2021 09:17:01 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id ECFF0C013A for ; Fri, 5 Feb 2021 09:16:59 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id D860687108 for ; Fri, 5 Feb 2021 09:16:59 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8YlB4qIHgEmY for ; Fri, 5 Feb 2021 09:16:58 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by whitealder.osuosl.org (Postfix) with ESMTPS id 67B6D87106 for ; Fri, 5 Feb 2021 09:16:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612516617; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=57F239YtV0oHbCCj5J8DpWnEViN3tCKhKGovQyK+Lic=; b=ZzTPajMUgqW5xYX//MobQ/+xEIQNbQ2VWZ4IwSZwkV+jq4KgbNoxSxrjcDVb6MAHjcndBh LNzb2pK8TnuLb8Zoh6mDAvxIFK2jvmgzNfufEz3vQnKwOJRckHwnlhApVml1GDZ55OUqgx 98tAqUUdJb9gDzGrl7bTVFDBzTwhsKI= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-102-LBeTqnURO7OXUXDAzftoPg-1; Fri, 05 Feb 2021 04:16:55 -0500 X-MC-Unique: LBeTqnURO7OXUXDAzftoPg-1 Received: by mail-wm1-f69.google.com with SMTP id h25so2776116wmb.6 for ; Fri, 05 Feb 2021 01:16:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=57F239YtV0oHbCCj5J8DpWnEViN3tCKhKGovQyK+Lic=; b=A6Yiv4cHG4MB6904w94fL3c4p2zZS3x8C/4wnUfa3aeuYmVYiCGjtUOq/XYhhXYL52 PhjQ6jJIJJozCu/VfShJFLLZXW+btUDxDq9NahDr6Ls799cwxovzNLLCLyhe/HH/dOpQ o1nznYAEdcoMYshJx1JUYKdR8Pvqk5PdHGeegd57BeFrcPpSnaxEmvb1XP1AbST5jc+2 AWNqouxhKW/LvffRibZ7P35BCZMcwP3g1XrAVPwhjJDdqUUhOlZQ+khRF7T5pcvHEFon Zu8dM/GIlk8tM31UP1vDFRAg3ZwK4pJEM8tDC7eDBJjCZJ7PeD3z/LeD3Hh+lEANZTHf vQWg== X-Gm-Message-State: AOAM530mchRYvxA/b1S/uxviIRieIIgP6vUmkecrh7CoPZAwbGBh9SBS uVUSZ+9rhorpkifFApY4bjGFRo09/Lz/wQG53SHlOT9MpbBoUmjKTOproZ4CIu9cK9GOHqD0+Ge +MQ3yCk/vDJrYi2lqbEPIigQkDF1doog+YNVZ5gihnQ== X-Received: by 2002:adf:d84a:: with SMTP id k10mr3934397wrl.156.1612516614250; Fri, 05 Feb 2021 01:16:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJxm4rfj82uV3tGDph5pyyVq3oRWewQ+gBUMQfr86xZKT355ALHumrHiplodlmOUoLsCMMAfbw== X-Received: by 2002:adf:d84a:: with SMTP id k10mr3934381wrl.156.1612516614060; Fri, 05 Feb 2021 01:16:54 -0800 (PST) Received: from steredhat (host-79-34-249-199.business.telecomitalia.it. [79.34.249.199]) by smtp.gmail.com with ESMTPSA id g14sm12104482wru.45.2021.02.05.01.16.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 01:16:53 -0800 (PST) Date: Fri, 5 Feb 2021 10:16:51 +0100 From: Stefano Garzarella To: Jason Wang , "Michael S. Tsirkin" Subject: Re: [PATCH v3 09/13] vhost/vdpa: remove vhost_vdpa_config_validate() Message-ID: <20210205091651.xfcdyuvwwzew2ufo@steredhat> References: <20210204172230.85853-1-sgarzare@redhat.com> <20210204172230.85853-10-sgarzare@redhat.com> <6919d2d4-cc8e-2b67-2385-35803de5e38b@redhat.com> MIME-Version: 1.0 In-Reply-To: <6919d2d4-cc8e-2b67-2385-35803de5e38b@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=sgarzare@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: Laurent Vivier , Max Gurtovoy , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Xie Yongji , Stefan Hajnoczi X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" T24gRnJpLCBGZWIgMDUsIDIwMjEgYXQgMTE6Mjc6MzJBTSArMDgwMCwgSmFzb24gV2FuZyB3cm90 ZToKPgo+T24gMjAyMS8yLzUg5LiK5Y2IMToyMiwgU3RlZmFubyBHYXJ6YXJlbGxhIHdyb3RlOgo+ PmdldF9jb25maWcoKSBhbmQgc2V0X2NvbmZpZygpIGNhbGxiYWNrcyBpbiB0aGUgJ3N0cnVjdCB2 ZHBhX2NvbmZpZ19vcHMnCj4+dXN1YWxseSBhbHJlYWR5IHZhbGlkYXRlZCB0aGUgaW5wdXRzLiBB bHNvIG5vdyB0aGV5IGNhbiByZXR1cm4gYW4gZXJyb3IsCj4+c28gd2UgZG9uJ3QgbmVlZCB0byB2 YWxpZGF0ZSB0aGVtIGhlcmUgYW55bW9yZS4KPj4KPj5MZXQncyB1c2UgdGhlIHJldHVybiB2YWx1 ZSBvZiB0aGVzZSBjYWxsYmFja3MgYW5kIHJldHVybiBpdCBpbiBjYXNlIG9mCj4+ZXJyb3IgaW4g dmhvc3RfdmRwYV9nZXRfY29uZmlnKCkgYW5kIHZob3N0X3ZkcGFfc2V0X2NvbmZpZygpLgo+Pgo+ Pk9yaWdpbmFsbHktYnk6IFhpZSBZb25namkgPHhpZXlvbmdqaUBieXRlZGFuY2UuY29tPgo+PlNp Z25lZC1vZmYtYnk6IFN0ZWZhbm8gR2FyemFyZWxsYSA8c2dhcnphcmVAcmVkaGF0LmNvbT4KPj4t LS0KPj4gIGRyaXZlcnMvdmhvc3QvdmRwYS5jIHwgNDEgKysrKysrKysrKysrKy0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0KPj4gIDEgZmlsZSBjaGFuZ2VkLCAxMyBpbnNlcnRpb25zKCspLCAy OCBkZWxldGlvbnMoLSkKPj4KPj5kaWZmIC0tZ2l0IGEvZHJpdmVycy92aG9zdC92ZHBhLmMgYi9k cml2ZXJzL3Zob3N0L3ZkcGEuYwo+PmluZGV4IGVmNjg4YzhjMGUwZS4uZDYxZTc3OTAwMGE4IDEw MDY0NAo+Pi0tLSBhL2RyaXZlcnMvdmhvc3QvdmRwYS5jCj4+KysrIGIvZHJpdmVycy92aG9zdC92 ZHBhLmMKPj5AQCAtMTg1LDUxICsxODUsMzUgQEAgc3RhdGljIGxvbmcgdmhvc3RfdmRwYV9zZXRf c3RhdHVzKHN0cnVjdCB2aG9zdF92ZHBhICp2LCB1OCBfX3VzZXIgKnN0YXR1c3ApCj4+ICAJcmV0 dXJuIDA7Cj4+ICB9Cj4+LXN0YXRpYyBpbnQgdmhvc3RfdmRwYV9jb25maWdfdmFsaWRhdGUoc3Ry dWN0IHZob3N0X3ZkcGEgKnYsCj4+LQkJCQkgICAgICBzdHJ1Y3Qgdmhvc3RfdmRwYV9jb25maWcg KmMpCj4+LXsKPj4tCWxvbmcgc2l6ZSA9IDA7Cj4+LQo+Pi0Jc3dpdGNoICh2LT52aXJ0aW9faWQp IHsKPj4tCWNhc2UgVklSVElPX0lEX05FVDoKPj4tCQlzaXplID0gc2l6ZW9mKHN0cnVjdCB2aXJ0 aW9fbmV0X2NvbmZpZyk7Cj4+LQkJYnJlYWs7Cj4+LQl9Cj4+LQo+Pi0JaWYgKGMtPmxlbiA9PSAw KQo+Pi0JCXJldHVybiAtRUlOVkFMOwo+Pi0KPj4tCWlmIChjLT5sZW4gPiBzaXplIC0gYy0+b2Zm KQo+Pi0JCXJldHVybiAtRTJCSUc7Cj4+LQo+Pi0JcmV0dXJuIDA7Cj4+LX0KPj4tCj4+ICBzdGF0 aWMgbG9uZyB2aG9zdF92ZHBhX2dldF9jb25maWcoc3RydWN0IHZob3N0X3ZkcGEgKnYsCj4+ICAJ CQkJICBzdHJ1Y3Qgdmhvc3RfdmRwYV9jb25maWcgX191c2VyICpjKQo+PiAgewo+PiAgCXN0cnVj dCB2ZHBhX2RldmljZSAqdmRwYSA9IHYtPnZkcGE7Cj4+ICAJc3RydWN0IHZob3N0X3ZkcGFfY29u ZmlnIGNvbmZpZzsKPj4gIAl1bnNpZ25lZCBsb25nIHNpemUgPSBvZmZzZXRvZihzdHJ1Y3Qgdmhv c3RfdmRwYV9jb25maWcsIGJ1Zik7Cj4+Kwlsb25nIHJldDsKPj4gIAl1OCAqYnVmOwo+PiAgCWlm IChjb3B5X2Zyb21fdXNlcigmY29uZmlnLCBjLCBzaXplKSkKPj4gIAkJcmV0dXJuIC1FRkFVTFQ7 Cj4+LQlpZiAodmhvc3RfdmRwYV9jb25maWdfdmFsaWRhdGUodiwgJmNvbmZpZykpCj4+KwlpZiAo Y29uZmlnLmxlbiA9PSAwKQo+PiAgCQlyZXR1cm4gLUVJTlZBTDsKPj4gIAlidWYgPSBrdnphbGxv Yyhjb25maWcubGVuLCBHRlBfS0VSTkVMKTsKPgo+Cj5UaGVuIGl0IG1lYW5zIHVzZXJzYXBjZSBj YW4gYWxsb2NhdGUgYSB2ZXJ5IGxhcmdlIG1lbW9yeS4KCkdvb2QgcG9pbnQuCgo+Cj5SZXRoaW5r IGFib3V0IHRoaXMsIHdlIHNob3VsZCBsaW1pdCB0aGUgc2l6ZSBoZXJlIChlLmcgUEFHRV9TSVpF KSBvciAKPmZldGNoIHRoZSBjb25maWcgc2l6ZSBmaXJzdCAoZWl0aGVyIHRocm91Z2ggYSBjb25m aWcgb3BzIGFzIHlvdSAKPnN1Z2dlc3RlZCBvciBhIHZhcmlhYmxlIGluIHRoZSB2ZHBhIGRldmlj ZSB0aGF0IGlzIGluaXRpYWxpemVkIGR1cmluZyAKPmRldmljZSBjcmVhdGlvbikuCgpNYXliZSBQ QUdFX1NJWkUgaXMgb2theSBhcyBhIGxpbWl0LgoKSWYgaW5zdGVhZCB3ZSB3YW50IHRvIGZldGNo IHRoZSBjb25maWcgc2l6ZSwgdGhlbiBiZXR0ZXIgYSBjb25maWcgb3BzIGluIApteSBvcGluaW9u LCB0byBhdm9pZCBhZGRpbmcgYSBuZXcgcGFyYW1ldGVyIHRvIF9fdmRwYV9hbGxvY19kZXZpY2Uo KS4KCkkgdm90ZSBmb3IgUEFHRV9TSVpFLCBidXQgaXQgaXNuJ3QgYSBzdHJvbmcgb3Bpbmlvbi4K CldoYXQgZG8geW91IGFuZCBATWljaGFlbCBzdWdnZXN0PwoKVGhhbmtzLApTdGVmYW5vCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpWaXJ0dWFsaXphdGlv biBtYWlsaW5nIGxpc3QKVmlydHVhbGl6YXRpb25AbGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcK aHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21haWxtYW4vbGlzdGluZm8vdmlydHVh bGl6YXRpb24=