From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F576C433E0 for ; Fri, 5 Feb 2021 10:27:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DADF264F38 for ; Fri, 5 Feb 2021 10:27:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231178AbhBEK0z (ORCPT ); Fri, 5 Feb 2021 05:26:55 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:36840 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229763AbhBEKYY (ORCPT ); Fri, 5 Feb 2021 05:24:24 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 803601C0B77; Fri, 5 Feb 2021 11:23:40 +0100 (CET) Date: Fri, 5 Feb 2021 11:23:38 +0100 From: Pavel Machek To: Sven Schuchmann Cc: Dan Murphy , Rob Herring , "linux-leds@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 1/4] leds: lp50xx: add setting of default intensity from DT Message-ID: <20210205102338.GA27854@amd> References: <20210204143726.27977-1-schuchmann@schleissheimer.de> <20210204145201.GB14305@duo.ucw.cz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="HcAYCG3uE/tztfnV" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org --HcAYCG3uE/tztfnV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > > patternProperties: > > > "(^led-[0-9a-f]$|led)": > > > @@ -99,6 +104,7 @@ examples: > > > reg =3D <0x1>; > > > color =3D ; > > > function =3D LED_FUNCTION_CHARGING; > > > + default-intensity =3D <100 0 0>; > > > > > > led-0 { > > > color =3D ; > >=20 > > Should this go to leds-class-multicolor.yaml ?=20 >=20 > I think then all drivers should support it, but I cannot change all driv= ers.=20 > So I would only leave it in there. It really should be in common binding, and no, that does not mean you need to change all the drivers. Plus there's at most two of them at the moment. Best regards, Pavel --=20 http://www.livejournal.com/~pavelmachek --HcAYCG3uE/tztfnV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAmAdHKoACgkQMOfwapXb+vLFegCgp5fsWD5ZfPr20YCODLcTu/2F YfMAmQEwkcFypjBKY/922iLgshcFNhVn =2653 -----END PGP SIGNATURE----- --HcAYCG3uE/tztfnV--