From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C2F7C433E0 for ; Fri, 5 Feb 2021 11:27:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E60EA64FD0 for ; Fri, 5 Feb 2021 11:27:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229753AbhBEL0a (ORCPT ); Fri, 5 Feb 2021 06:26:30 -0500 Received: from mail.kernel.org ([198.145.29.99]:48418 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231269AbhBELUK (ORCPT ); Fri, 5 Feb 2021 06:20:10 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id BA91164DB2; Fri, 5 Feb 2021 11:19:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612523969; bh=rm+DO8jRG9vXb505ghtG8o6BLLgA2frdzJnefVazWtA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TVK/pTsxIGKrL2Rz+z/51yT19TZeajQ+aLcfVitT1Fqz5q/iMvcQQyu8ESXGfjgqv ecxqDKAe9VHSgFoSOogOoqySVc3g5WUTu3Qhngd0P66a/4eroS5CiS96qn6Oi+cPTh xOCpwNInjgkQ7Hp5XTXsjGwD342+UMQAslRNTx1KKkaygNZo41zS1uC8vi2AWUKgma S3jfqQyd6pu4wKBjeOInrk/2Rs+sygNeh6Dvv7Bqb/Enq8GsotJX3pCY5Cclr8JC0d y/E8Mp1XhsE0lqRnqolLBbGfazddNLImalbB55ElDEW1Dd7AQMsvtO07TCKBsRBruz /9qyn1GHLifpw== Date: Fri, 5 Feb 2021 11:19:22 +0000 From: Will Deacon To: Steven Price Cc: Marc Zyngier , netdev@vger.kernel.org, yangbo.lu@nxp.com, john.stultz@linaro.org, tglx@linutronix.de, pbonzini@redhat.com, seanjc@google.com, richardcochran@gmail.com, Mark.Rutland@arm.com, suzuki.poulose@arm.com, Andre.Przywara@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Steve.Capper@arm.com, justin.he@arm.com, jianyong.wu@arm.com, kernel-team@android.com Subject: Re: [PATCH v17 1/7] arm/arm64: Probe for the presence of KVM hypervisor Message-ID: <20210205111921.GA22109@willie-the-truck> References: <20210202141204.3134855-1-maz@kernel.org> <20210202141204.3134855-2-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 05, 2021 at 09:11:00AM +0000, Steven Price wrote: > On 02/02/2021 14:11, Marc Zyngier wrote: > > diff --git a/drivers/firmware/smccc/kvm_guest.c b/drivers/firmware/smccc/kvm_guest.c > > new file mode 100644 > > index 000000000000..23ce1ded88b4 > > --- /dev/null > > +++ b/drivers/firmware/smccc/kvm_guest.c > > @@ -0,0 +1,51 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > + > > +#define pr_fmt(fmt) "smccc: KVM: " fmt > > + > > +#include > > +#include > > +#include > > +#include > > + > > +static DECLARE_BITMAP(__kvm_arm_hyp_services, ARM_SMCCC_KVM_NUM_FUNCS) __ro_after_init = { }; > > + > > +void __init kvm_init_hyp_services(void) > > +{ > > + int i; > > + struct arm_smccc_res res; > > + > > + if (arm_smccc_1_1_get_conduit() != SMCCC_CONDUIT_HVC) > > + return; > > + > > + arm_smccc_1_1_invoke(ARM_SMCCC_VENDOR_HYP_CALL_UID_FUNC_ID, &res); > > + if (res.a0 != ARM_SMCCC_VENDOR_HYP_UID_KVM_REG_0 || > > + res.a1 != ARM_SMCCC_VENDOR_HYP_UID_KVM_REG_1 || > > + res.a2 != ARM_SMCCC_VENDOR_HYP_UID_KVM_REG_2 || > > + res.a3 != ARM_SMCCC_VENDOR_HYP_UID_KVM_REG_3) > > + return; > > + > > + memset(&res, 0, sizeof(res)); > > + arm_smccc_1_1_invoke(ARM_SMCCC_VENDOR_HYP_KVM_FEATURES_FUNC_ID, &res); > > + for (i = 0; i < 32; ++i) { > > + if (res.a0 & (i)) > > + set_bit(i + (32 * 0), __kvm_arm_hyp_services); > > + if (res.a1 & (i)) > > + set_bit(i + (32 * 1), __kvm_arm_hyp_services); > > + if (res.a2 & (i)) > > + set_bit(i + (32 * 2), __kvm_arm_hyp_services); > > + if (res.a3 & (i)) > > + set_bit(i + (32 * 3), __kvm_arm_hyp_services); > > The bit shifts are missing, the tests should be of the form: > > if (res.a0 & (1 << i)) > > Or indeed using a BIT() macro. Maybe even test_bit()? Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFEB2C433E0 for ; Fri, 5 Feb 2021 11:19:36 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 040C764FA9 for ; Fri, 5 Feb 2021 11:19:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 040C764FA9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 805884B3C1; Fri, 5 Feb 2021 06:19:35 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oVEN8R5sCp45; Fri, 5 Feb 2021 06:19:33 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 41D3E4B3C4; Fri, 5 Feb 2021 06:19:33 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 961734B3C1 for ; Fri, 5 Feb 2021 06:19:31 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hRIPSc51JeWC for ; Fri, 5 Feb 2021 06:19:30 -0500 (EST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 9EFF54B3BF for ; Fri, 5 Feb 2021 06:19:30 -0500 (EST) Received: by mail.kernel.org (Postfix) with ESMTPSA id BA91164DB2; Fri, 5 Feb 2021 11:19:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612523969; bh=rm+DO8jRG9vXb505ghtG8o6BLLgA2frdzJnefVazWtA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TVK/pTsxIGKrL2Rz+z/51yT19TZeajQ+aLcfVitT1Fqz5q/iMvcQQyu8ESXGfjgqv ecxqDKAe9VHSgFoSOogOoqySVc3g5WUTu3Qhngd0P66a/4eroS5CiS96qn6Oi+cPTh xOCpwNInjgkQ7Hp5XTXsjGwD342+UMQAslRNTx1KKkaygNZo41zS1uC8vi2AWUKgma S3jfqQyd6pu4wKBjeOInrk/2Rs+sygNeh6Dvv7Bqb/Enq8GsotJX3pCY5Cclr8JC0d y/E8Mp1XhsE0lqRnqolLBbGfazddNLImalbB55ElDEW1Dd7AQMsvtO07TCKBsRBruz /9qyn1GHLifpw== Date: Fri, 5 Feb 2021 11:19:22 +0000 From: Will Deacon To: Steven Price Subject: Re: [PATCH v17 1/7] arm/arm64: Probe for the presence of KVM hypervisor Message-ID: <20210205111921.GA22109@willie-the-truck> References: <20210202141204.3134855-1-maz@kernel.org> <20210202141204.3134855-2-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Cc: justin.he@arm.com, kvm@vger.kernel.org, Marc Zyngier , richardcochran@gmail.com, seanjc@google.com, linux-kernel@vger.kernel.org, Andre.Przywara@arm.com, netdev@vger.kernel.org, john.stultz@linaro.org, yangbo.lu@nxp.com, pbonzini@redhat.com, tglx@linutronix.de, kernel-team@android.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Fri, Feb 05, 2021 at 09:11:00AM +0000, Steven Price wrote: > On 02/02/2021 14:11, Marc Zyngier wrote: > > diff --git a/drivers/firmware/smccc/kvm_guest.c b/drivers/firmware/smccc/kvm_guest.c > > new file mode 100644 > > index 000000000000..23ce1ded88b4 > > --- /dev/null > > +++ b/drivers/firmware/smccc/kvm_guest.c > > @@ -0,0 +1,51 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > + > > +#define pr_fmt(fmt) "smccc: KVM: " fmt > > + > > +#include > > +#include > > +#include > > +#include > > + > > +static DECLARE_BITMAP(__kvm_arm_hyp_services, ARM_SMCCC_KVM_NUM_FUNCS) __ro_after_init = { }; > > + > > +void __init kvm_init_hyp_services(void) > > +{ > > + int i; > > + struct arm_smccc_res res; > > + > > + if (arm_smccc_1_1_get_conduit() != SMCCC_CONDUIT_HVC) > > + return; > > + > > + arm_smccc_1_1_invoke(ARM_SMCCC_VENDOR_HYP_CALL_UID_FUNC_ID, &res); > > + if (res.a0 != ARM_SMCCC_VENDOR_HYP_UID_KVM_REG_0 || > > + res.a1 != ARM_SMCCC_VENDOR_HYP_UID_KVM_REG_1 || > > + res.a2 != ARM_SMCCC_VENDOR_HYP_UID_KVM_REG_2 || > > + res.a3 != ARM_SMCCC_VENDOR_HYP_UID_KVM_REG_3) > > + return; > > + > > + memset(&res, 0, sizeof(res)); > > + arm_smccc_1_1_invoke(ARM_SMCCC_VENDOR_HYP_KVM_FEATURES_FUNC_ID, &res); > > + for (i = 0; i < 32; ++i) { > > + if (res.a0 & (i)) > > + set_bit(i + (32 * 0), __kvm_arm_hyp_services); > > + if (res.a1 & (i)) > > + set_bit(i + (32 * 1), __kvm_arm_hyp_services); > > + if (res.a2 & (i)) > > + set_bit(i + (32 * 2), __kvm_arm_hyp_services); > > + if (res.a3 & (i)) > > + set_bit(i + (32 * 3), __kvm_arm_hyp_services); > > The bit shifts are missing, the tests should be of the form: > > if (res.a0 & (1 << i)) > > Or indeed using a BIT() macro. Maybe even test_bit()? Will _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF7C1C433E0 for ; Fri, 5 Feb 2021 11:20:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3F0F264FA3 for ; Fri, 5 Feb 2021 11:20:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3F0F264FA3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=94qWZ1rMzsHzBmBatj07pvttMTlpmFnMSd1jVIB/AYM=; b=QV5On66N9fD8dpL9GQVkdFJlR 4EvkT6OwO9H0VwqA+u+p33uIb7nlQUcPO8NvDdCk4t4MsAn+01HzGNkH2L2jcDNLSmFr3JFYaxkMc 8BDZCz1y/GWfKZrAnZAeVEhq43Z2ksXyOFiM3FuQBe60Sq3w49N8BW4Ner/muEb4vMmqcpXVqMhsR BPSIN0ny5XxuAfGqRNv/OVrBk0mey54X/LXRVNhCR7rJMpF4Xagodu7aNOXXPvzi09E8REYKc447J vVO+WDBnSMxYUC2P7zvlJA4C1scRUVUNXbs6IR0b+C/bRSlqaCMteGwO4siTTsfVMXKHiPMuvvKkJ VORggDkXA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7z9B-0005rX-CO; Fri, 05 Feb 2021 11:19:33 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7z98-0005qx-8C for linux-arm-kernel@lists.infradead.org; Fri, 05 Feb 2021 11:19:31 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id BA91164DB2; Fri, 5 Feb 2021 11:19:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612523969; bh=rm+DO8jRG9vXb505ghtG8o6BLLgA2frdzJnefVazWtA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TVK/pTsxIGKrL2Rz+z/51yT19TZeajQ+aLcfVitT1Fqz5q/iMvcQQyu8ESXGfjgqv ecxqDKAe9VHSgFoSOogOoqySVc3g5WUTu3Qhngd0P66a/4eroS5CiS96qn6Oi+cPTh xOCpwNInjgkQ7Hp5XTXsjGwD342+UMQAslRNTx1KKkaygNZo41zS1uC8vi2AWUKgma S3jfqQyd6pu4wKBjeOInrk/2Rs+sygNeh6Dvv7Bqb/Enq8GsotJX3pCY5Cclr8JC0d y/E8Mp1XhsE0lqRnqolLBbGfazddNLImalbB55ElDEW1Dd7AQMsvtO07TCKBsRBruz /9qyn1GHLifpw== Date: Fri, 5 Feb 2021 11:19:22 +0000 From: Will Deacon To: Steven Price Subject: Re: [PATCH v17 1/7] arm/arm64: Probe for the presence of KVM hypervisor Message-ID: <20210205111921.GA22109@willie-the-truck> References: <20210202141204.3134855-1-maz@kernel.org> <20210202141204.3134855-2-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210205_061930_480330_F569AB1A X-CRM114-Status: GOOD ( 15.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark.Rutland@arm.com, jianyong.wu@arm.com, justin.he@arm.com, kvm@vger.kernel.org, suzuki.poulose@arm.com, Marc Zyngier , richardcochran@gmail.com, seanjc@google.com, linux-kernel@vger.kernel.org, Andre.Przywara@arm.com, netdev@vger.kernel.org, john.stultz@linaro.org, yangbo.lu@nxp.com, pbonzini@redhat.com, tglx@linutronix.de, kernel-team@android.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, Steve.Capper@arm.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 05, 2021 at 09:11:00AM +0000, Steven Price wrote: > On 02/02/2021 14:11, Marc Zyngier wrote: > > diff --git a/drivers/firmware/smccc/kvm_guest.c b/drivers/firmware/smccc/kvm_guest.c > > new file mode 100644 > > index 000000000000..23ce1ded88b4 > > --- /dev/null > > +++ b/drivers/firmware/smccc/kvm_guest.c > > @@ -0,0 +1,51 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > + > > +#define pr_fmt(fmt) "smccc: KVM: " fmt > > + > > +#include > > +#include > > +#include > > +#include > > + > > +static DECLARE_BITMAP(__kvm_arm_hyp_services, ARM_SMCCC_KVM_NUM_FUNCS) __ro_after_init = { }; > > + > > +void __init kvm_init_hyp_services(void) > > +{ > > + int i; > > + struct arm_smccc_res res; > > + > > + if (arm_smccc_1_1_get_conduit() != SMCCC_CONDUIT_HVC) > > + return; > > + > > + arm_smccc_1_1_invoke(ARM_SMCCC_VENDOR_HYP_CALL_UID_FUNC_ID, &res); > > + if (res.a0 != ARM_SMCCC_VENDOR_HYP_UID_KVM_REG_0 || > > + res.a1 != ARM_SMCCC_VENDOR_HYP_UID_KVM_REG_1 || > > + res.a2 != ARM_SMCCC_VENDOR_HYP_UID_KVM_REG_2 || > > + res.a3 != ARM_SMCCC_VENDOR_HYP_UID_KVM_REG_3) > > + return; > > + > > + memset(&res, 0, sizeof(res)); > > + arm_smccc_1_1_invoke(ARM_SMCCC_VENDOR_HYP_KVM_FEATURES_FUNC_ID, &res); > > + for (i = 0; i < 32; ++i) { > > + if (res.a0 & (i)) > > + set_bit(i + (32 * 0), __kvm_arm_hyp_services); > > + if (res.a1 & (i)) > > + set_bit(i + (32 * 1), __kvm_arm_hyp_services); > > + if (res.a2 & (i)) > > + set_bit(i + (32 * 2), __kvm_arm_hyp_services); > > + if (res.a3 & (i)) > > + set_bit(i + (32 * 3), __kvm_arm_hyp_services); > > The bit shifts are missing, the tests should be of the form: > > if (res.a0 & (1 << i)) > > Or indeed using a BIT() macro. Maybe even test_bit()? Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel