All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Thomas Huth <thuth@redhat.com>,
	David Hildenbrand <david@redhat.com>
Subject: [PULL v2 09/16] hw/virtio/virtio-balloon: Remove the "class" property
Date: Fri, 5 Feb 2021 10:03:54 -0500	[thread overview]
Message-ID: <20210205150135.94643-10-mst@redhat.com> (raw)
In-Reply-To: <20210205150135.94643-1-mst@redhat.com>

From: Thomas Huth <thuth@redhat.com>

This property was only required for compatibility reasons in the
pc-1.0 machine type and earlier. Now that these machine types have
been removed, the property is not useful anymore.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20210203171832.483176-4-thuth@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: David Hildenbrand <david@redhat.com>
---
 hw/virtio/virtio-balloon-pci.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/hw/virtio/virtio-balloon-pci.c b/hw/virtio/virtio-balloon-pci.c
index a2c5cc7207..79a3ba979a 100644
--- a/hw/virtio/virtio-balloon-pci.c
+++ b/hw/virtio/virtio-balloon-pci.c
@@ -34,21 +34,13 @@ struct VirtIOBalloonPCI {
     VirtIOPCIProxy parent_obj;
     VirtIOBalloon vdev;
 };
-static Property virtio_balloon_pci_properties[] = {
-    DEFINE_PROP_UINT32("class", VirtIOPCIProxy, class_code, 0),
-    DEFINE_PROP_END_OF_LIST(),
-};
 
 static void virtio_balloon_pci_realize(VirtIOPCIProxy *vpci_dev, Error **errp)
 {
     VirtIOBalloonPCI *dev = VIRTIO_BALLOON_PCI(vpci_dev);
     DeviceState *vdev = DEVICE(&dev->vdev);
 
-    if (vpci_dev->class_code != PCI_CLASS_OTHERS &&
-        vpci_dev->class_code != PCI_CLASS_MEMORY_RAM) { /* qemu < 1.1 */
-        vpci_dev->class_code = PCI_CLASS_OTHERS;
-    }
-
+    vpci_dev->class_code = PCI_CLASS_OTHERS;
     qdev_realize(vdev, BUS(&vpci_dev->bus), errp);
 }
 
@@ -59,7 +51,6 @@ static void virtio_balloon_pci_class_init(ObjectClass *klass, void *data)
     PCIDeviceClass *pcidev_k = PCI_DEVICE_CLASS(klass);
     k->realize = virtio_balloon_pci_realize;
     set_bit(DEVICE_CATEGORY_MISC, dc->categories);
-    device_class_set_props(dc, virtio_balloon_pci_properties);
     pcidev_k->vendor_id = PCI_VENDOR_ID_REDHAT_QUMRANET;
     pcidev_k->device_id = PCI_DEVICE_ID_VIRTIO_BALLOON;
     pcidev_k->revision = VIRTIO_PCI_ABI_VERSION;
-- 
MST



  parent reply	other threads:[~2021-02-05 15:11 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-05 15:03 [PULL v2 00/16] pc,virtio,pci: fixes, features,code removal Michael S. Tsirkin
2021-02-05 15:03 ` [PULL v2 01/16] pci: reject too large ROMs Michael S. Tsirkin
2021-02-05 15:03 ` [PULL v2 02/16] pci: add romsize property Michael S. Tsirkin
2021-02-05 15:03   ` Michael S. Tsirkin
2021-02-05 15:03 ` [PULL v2 03/16] virtio: move 'use-disabled-flag' property to hw_compat_4_2 Michael S. Tsirkin
2021-02-05 15:03 ` [PULL v2 04/16] virtio-mmio: fix guest kernel crash with SHM regions Michael S. Tsirkin
2021-02-05 15:03 ` [PULL v2 05/16] virtio: Add corresponding memory_listener_unregister to unrealize Michael S. Tsirkin
2021-02-05 15:03 ` [PULL v2 06/16] virtio-pmem: add trace events Michael S. Tsirkin
2021-02-05 15:03 ` [PULL v2 07/16] vhost: Unbreak SMMU and virtio-iommu on dev-iotlb support Michael S. Tsirkin
2021-02-05 15:03 ` [PULL v2 08/16] hw/i386: Remove the deprecated pc-1.x machine types Michael S. Tsirkin
2021-02-05 15:03 ` Michael S. Tsirkin [this message]
2021-02-05 15:03 ` [PULL v2 10/16] vhost: Check for valid vdev in vhost_backend_handle_iotlb_msg Michael S. Tsirkin
2021-02-05 15:04 ` [PULL v2 11/16] tests/acpi: allow updates for expected data files Michael S. Tsirkin
2021-02-05 15:04 ` [PULL v2 12/16] acpi: Permit OEM ID and OEM table ID fields to be changed Michael S. Tsirkin
2021-02-05 15:04 ` [PULL v2 13/16] acpi: use constants as strncpy limit Michael S. Tsirkin
2021-02-05 15:04 ` [PULL v2 14/16] tests/acpi: add OEM ID and OEM TABLE ID test Michael S. Tsirkin
2021-02-05 15:04 ` [PULL v2 15/16] tests/acpi: update expected data files Michael S. Tsirkin
2021-02-05 15:04 ` [PULL v2 16/16] tests/acpi: disallow updates for " Michael S. Tsirkin
2021-02-05 16:46 ` [PULL v2 00/16] pc,virtio,pci: fixes, features,code removal Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210205150135.94643-10-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=david@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.