From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D616C433DB for ; Fri, 5 Feb 2021 15:35:28 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 41236650F0 for ; Fri, 5 Feb 2021 15:35:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41236650F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 78EB3165E; Fri, 5 Feb 2021 16:34:35 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 78EB3165E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1612539325; bh=MH7HER6PDYJ8JoYrgdtxHVW7qruJH6JUPYjuTg7pwEs=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=EaquPazBQ+IGXqwPJiVYBg1cw+t6MzoRg26Y3u7NxSo6qlZ44pvedv+ZIljGfncB2 MmSnxhgv9k7gc4CnfYVI4MMVAfmqmxJGl94JiOgqHiGo0TYuNu/iycwTKOeAlLh/bE OvhhtmDxu7uFz2LGKjRPMbMpHUm1W/0/6K8MyKXg= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id EAF0AF80152; Fri, 5 Feb 2021 16:34:34 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id CD70FF8015A; Fri, 5 Feb 2021 16:34:33 +0100 (CET) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1C469F80139 for ; Fri, 5 Feb 2021 16:34:28 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1C469F80139 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="He9HDG8+" Received: by mail.kernel.org (Postfix) with ESMTPSA id A1221650ED; Fri, 5 Feb 2021 15:34:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612539266; bh=MH7HER6PDYJ8JoYrgdtxHVW7qruJH6JUPYjuTg7pwEs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=He9HDG8+UbuMeqaJuWMeKrofXu1JjdYfOcLVyyklPihKWeObloClfnxd5tIhMMIWq lCXxtgNEu5Ko7TtlwHCRqm8+++hoqYYtb1sXZYQkBij8bto5jS+JkcaTLiXFaPAACb 1pJeYH/B3yH2o0Ks5LlZKBozb9xbUDA8VJPaO640rjD5T5kyr2BOzakY5BMqM8o+5B mob1BR7+P/uxcemeHgk7n2URLBlwlqWTWIyOuwx/x58vqwErut43llVVmAIGE1KLpj DM+T/+oGLaE8amdyeWGAuuERcZ7aKsGguoETd2rKGUuxoiFhcGLvQzfOKEWcfhbp7j 5o6sZzwsAvsYg== Date: Fri, 5 Feb 2021 15:33:36 +0000 From: Mark Brown To: Pierre-Louis Bossart Subject: Re: [PATCH 14/14] ASoC: SOF: Intel: hda: add dev_dbg() when DMIC number is overridden Message-ID: <20210205153336.GE4720@sirena.org.uk> References: <20210204203312.27112-1-pierre-louis.bossart@linux.intel.com> <20210204203312.27112-15-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="TD8GDToEDw0WLGOL" Content-Disposition: inline In-Reply-To: <20210204203312.27112-15-pierre-louis.bossart@linux.intel.com> X-Cookie: Huh? User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Guennadi Liakhovetski , alsa-devel@alsa-project.org, Kai Vehmanen , Guennadi Liakhovetski , tiwai@suse.de, vkoul@kernel.org, Bard liao , Rander Wang X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --TD8GDToEDw0WLGOL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Feb 04, 2021 at 02:33:12PM -0600, Pierre-Louis Bossart wrote: > /* allow for module parameter override */ > - if (hda_dmic_num != -1) > + if (hda_dmic_num != -1) { This is breaking in an x86 allmodconfig build due to: /mnt/kernel/sound/soc/sof/intel/hda.c: In function 'dmic_topology_fixup': /mnt/kernel/sound/soc/sof/intel/hda.c:615:6: error: 'hda_dmic_num' undeclared (first use in this function); did you mean 'dmic_num'? if (hda_dmic_num != -1) { ^~~~~~~~~~~~ dmic_num /mnt/kernel/sound/soc/sof/intel/hda.c:615:6: note: each undeclared identifier is reported only once for each function it appears in which will actually be triggered by one of the earlier patches in the series (my script is going through things in reverse order), that variable is only defined for CONFIG_SOC_SOF_HDA. --TD8GDToEDw0WLGOL Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmAdZU8ACgkQJNaLcl1U h9Dg0wf/dUJP9q+onLFVQyeEUVoqAG7m5KWHF0+AOUx8e4yrQVlPKomE5fLtQWiB 25HR1qqW8TWKVRctJO3dJofSRbFWs3+br6AVZxh0qu4Mz7YlB9THOXqdfAcieTIW mNU0AnqdgZu3ti2LeLKCjjN1QZaofARVFO1UOeEDTd2+zG1lnwmnpZFAWZraBoa1 /wClgd9yyXcIv9KZwdHSvE1ys/7GTy6fZJd4gRLecfhINjZA8QpZalPVAEoqhTo1 Agg+x7RHtn+hu5qbBJw/safm7ERwHCkGTu5PcUMAFWrCXVALReC9QdWvNNjVDW3g UdJohQu/yAxxqzAKJKsiLJW5Sg6z3w== =3cY7 -----END PGP SIGNATURE----- --TD8GDToEDw0WLGOL--