From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1ADDFC43332 for ; Sat, 6 Feb 2021 03:17:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E529064F99 for ; Sat, 6 Feb 2021 03:17:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232105AbhBFDQR (ORCPT ); Fri, 5 Feb 2021 22:16:17 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:47447 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230206AbhBFCdD (ORCPT ); Fri, 5 Feb 2021 21:33:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612578691; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TMLLiiXlekZ69dnRkThVGErl0XxjrQAWy5GuWYc9Jr0=; b=RjrNQn4u7v+bTUusfcIrpkSwkwAj8CMvRVa3SB0K5jG8bA52v3li2p8CwVBggTCaLsyaBJ yi8S9aMeGyEIdfEViV0wLPaiyXUcYdUXrSMngbHCfN+sfWCxGTfzIPeFOEOCGLFbJ+2HVv Tzm3hYyQi4HgS5e6CBM1sIQgrXRvCu0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-455-40_f3PNtPfO6pDG2ntpQvg-1; Fri, 05 Feb 2021 21:31:29 -0500 X-MC-Unique: 40_f3PNtPfO6pDG2ntpQvg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4D8368030C1; Sat, 6 Feb 2021 02:31:27 +0000 (UTC) Received: from treble (ovpn-112-217.rdu2.redhat.com [10.10.112.217]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B965110074FC; Sat, 6 Feb 2021 02:31:25 +0000 (UTC) Date: Fri, 5 Feb 2021 20:31:22 -0600 From: Josh Poimboeuf To: Peter Zijlstra Cc: Frederic Weisbecker , LKML , Mel Gorman , Michal Hocko , Thomas Gleixner , "Paul E . McKenney" , Ingo Molnar , Michal Hocko , rostedt@goodmis.org, jbaron@akamai.com, ardb@kernel.org Subject: Re: [RFC PATCH 6/8] preempt/dynamic: Provide preempt_schedule[_notrace]() static calls Message-ID: <20210206023122.ijbihwpzrcxzhi52@treble> References: <20210127155914.jfmr4jay47yck5h5@treble> <20210127163308.cgiq7jxx2uziuhcc@treble> <20210127190003.64rdwoxyjgnq2rtx@treble> <20210127190218.hoztl7eidujqarkt@treble> <20210127231837.ifddpn7rhwdaepiu@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 05, 2021 at 04:30:56PM +0100, Peter Zijlstra wrote: > On Wed, Feb 03, 2021 at 03:04:23PM +0100, Peter Zijlstra wrote: > > Fair enough I suppose. I'll slap a changelog and your SoB on it and I > > suppose I'll got commit the whole lot. Then we can forget about it > > again. > > FWIW, the whole thing looks like this.. > > --- > Subject: static_call: Allow module use without exposing static_call_key > From: Josh Poimboeuf > Date: Wed, 27 Jan 2021 17:18:37 -0600 > > From: Josh Poimboeuf > > When exporting static_call_key; with EXPORT_STATIC_CALL*(), the module > can use static_call_update() to change the function called. This is > not desirable in general. Looks good to me, thanks for fixing that up. Never said I tested it ;-) -- Josh