From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4B7EC433E0 for ; Sat, 6 Feb 2021 11:28:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A218164E28 for ; Sat, 6 Feb 2021 11:28:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229691AbhBFL2M (ORCPT ); Sat, 6 Feb 2021 06:28:12 -0500 Received: from mail-wm1-f50.google.com ([209.85.128.50]:40287 "EHLO mail-wm1-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229508AbhBFL2I (ORCPT ); Sat, 6 Feb 2021 06:28:08 -0500 Received: by mail-wm1-f50.google.com with SMTP id o24so374324wmh.5; Sat, 06 Feb 2021 03:27:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=XcXJGM0kwz/A+LLJn3fSvAukZQQd0FRTmmT0NH0TzLk=; b=HcHFZUfmeUgdpLOyuUpXhB9XlFlBkObQPVqCusvYaRRjpLCDvkPF3bHvzGtIJUG5G9 USRRUCZwnn5Xm9FBnUZXRiX2g/FwgUfDd0+GayLkFSzghLNBppFSH93p1lOdJaHJnEpY sSJ+SwsvhxqgGGudA8yXts+PxpCw1lbC5fw4FXYVKyygPF012KSltDay5JP8VI5SeQUV 8/Y9uhTuxmdsWT1bcn2TtUq+MBVs3vu4QsBT2nmOxSsR8Pdph8IvrpaP4+fygcuPFtQO ZtwlUkjWz77KWleJLlXeONnZDwz7V1jiMOkqzst92PX18rHevrR8j5N8LUKVn+0Mqduy TVwg== X-Gm-Message-State: AOAM530T4vFq55YUf0xFaSJrcgGKqw52Lh/4bDsgqX02auX45bR3iKZy uVZ6FF2DdThrAZLWMaOhTnQ= X-Google-Smtp-Source: ABdhPJxLRvEAmib95xNiRyWkyAzcIv9y2f+CrABiiX9yxmJBrYK3J0rlMhjpBAR6HZx4t/Ud2ZVPHw== X-Received: by 2002:a1c:ed0b:: with SMTP id l11mr7147307wmh.47.1612610846393; Sat, 06 Feb 2021 03:27:26 -0800 (PST) Received: from kozik-lap (194-95-143-94.dyn.cable.fcom.ch. [94.143.95.194]) by smtp.googlemail.com with ESMTPSA id m24sm11124427wmi.24.2021.02.06.03.27.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Feb 2021 03:27:25 -0800 (PST) Date: Sat, 6 Feb 2021 12:27:23 +0100 From: Krzysztof Kozlowski To: Li Yang Cc: Shawn Guo , Rob Herring , devicetree@vger.kernel.org, Oleksij Rempel , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/15] dt-bindings: i2c: imx: update schema to align with original binding Message-ID: <20210206112723.zmpdxaqlgu6vzmm2@kozik-lap> References: <20210205234734.3397-1-leoyang.li@nxp.com> <20210205234734.3397-3-leoyang.li@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210205234734.3397-3-leoyang.li@nxp.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 05, 2021 at 05:47:21PM -0600, Li Yang wrote: > Layerscape SoCs doesn't use ipg as clock name. Remove the clock name > requirement in the schema. Also the original binding doesn't enforce > the order of "tx" and "rx" in dma-names. Both orders are used > extensively in existing dtses, update the schema to allow both. > > Signed-off-by: Li Yang > --- > Documentation/devicetree/bindings/i2c/i2c-imx.yaml | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-imx.yaml b/Documentation/devicetree/bindings/i2c/i2c-imx.yaml > index f23966b0d6c6..57237b0b7d89 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c-imx.yaml > +++ b/Documentation/devicetree/bindings/i2c/i2c-imx.yaml > @@ -54,20 +54,19 @@ properties: > maxItems: 1 > > clock-names: > - const: ipg > + maxItems: 1 No, for other SoCs the clock is I think required, so it should be there. Add an allof-if statements to require it on specific compatibles and skip on others. > > clock-frequency: > enum: [ 100000, 400000 ] > > dmas: > - items: > - - description: DMA controller phandle and request line for RX > - - description: DMA controller phandle and request line for TX > + minItems: 2 > + maxItems: 2 > > dma-names: > items: > - - const: rx > - - const: tx > + - enum: [ "rx", "tx" ] > + - enum: [ "tx", "rx" ] No, the order should be enforced. That was a generic recommendation from Rob. Also, I don't get the what does it mean "the original binding" in commit msg. This is the original binding. Upstream. Mainline. If your DTSes have different order, please adjust them, not the binding. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48B3CC433E0 for ; Sat, 6 Feb 2021 11:28:45 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E9B2464E0D for ; Sat, 6 Feb 2021 11:28:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E9B2464E0D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=u5rlZomPvcQ/VmWGPVH6aZ0gaojri1EpXt3xPh1494M=; b=iTn+kh8vSDTgLU8OIazkbR0D9 cr88R9RQQHa2ruMX/ZnZs4PDVxTv8xawJ+26TGDDBQLzQBie9Y9IRcgUb0jiviDflQLuj+IbBAYdA yak7FCgAeBVyHnXr3q1OjBGDV5SkuUhMvKstiF5yTLoBTLuqgE9wGtyDVSs4CSrSve60qmWL5kgtc sCPeLJ/KZCgxB6TmnCGDcvMz3a6vPsP60Y81rVzm2gWE+aXV+s8rcUigraEIlbTozmSy8sRW/AgFi 0SNeZNKdny6pJnDQhUOYCEMcZB2rdbCHKg4vtPwD1cJa6aXSRbUrNIaaHkGUsR43G2wKSd/mwQDyo eYEr5BWyA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l8LkQ-0004eM-2X; Sat, 06 Feb 2021 11:27:30 +0000 Received: from mail-wm1-f49.google.com ([209.85.128.49]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l8LkN-0004dx-TQ for linux-arm-kernel@lists.infradead.org; Sat, 06 Feb 2021 11:27:28 +0000 Received: by mail-wm1-f49.google.com with SMTP id o10so9281941wmc.1 for ; Sat, 06 Feb 2021 03:27:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=XcXJGM0kwz/A+LLJn3fSvAukZQQd0FRTmmT0NH0TzLk=; b=ksFQEL2upqRcXv0/6KOQfys7xRHHdgY3lpuco7YHqGjoutjGhdworjs1PBEyMvrWJ8 dHH4BI31b9Y81vm8MuXEvZawq95BhX17zaulycRQyIv5zkV+rdc0MQIez8lctXuwu4ut x34M1RpnXOD5lq6cVq3+4zCLdm2voiY7svNfeuV6vhVB2oqAv4N4Rd4XCfTm4d53P8Dz nEVRs+oFJnXJhCMk4j/iIMp/FoV7M676IPT7UnGfbPkzvUFiitUb5AEED+Z1ndW/XrhM h9wzqKJXRVVwqtmRUIqFjdyGVPA3FdwXkbwLD0zfe4X5E7r4iAXMiTcTbjs78LGIasID HV4Q== X-Gm-Message-State: AOAM532PwMvMYaAtx5P50UzcP/0/erK+BnYU5eBZsMN4lHqL+kRDg7ni jVpNPKoTIwRZT13g5dsi4kQ= X-Google-Smtp-Source: ABdhPJxLRvEAmib95xNiRyWkyAzcIv9y2f+CrABiiX9yxmJBrYK3J0rlMhjpBAR6HZx4t/Ud2ZVPHw== X-Received: by 2002:a1c:ed0b:: with SMTP id l11mr7147307wmh.47.1612610846393; Sat, 06 Feb 2021 03:27:26 -0800 (PST) Received: from kozik-lap (194-95-143-94.dyn.cable.fcom.ch. [94.143.95.194]) by smtp.googlemail.com with ESMTPSA id m24sm11124427wmi.24.2021.02.06.03.27.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Feb 2021 03:27:25 -0800 (PST) Date: Sat, 6 Feb 2021 12:27:23 +0100 From: Krzysztof Kozlowski To: Li Yang Subject: Re: [PATCH 02/15] dt-bindings: i2c: imx: update schema to align with original binding Message-ID: <20210206112723.zmpdxaqlgu6vzmm2@kozik-lap> References: <20210205234734.3397-1-leoyang.li@nxp.com> <20210205234734.3397-3-leoyang.li@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210205234734.3397-3-leoyang.li@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210206_062728_091883_FAB64675 X-CRM114-Status: GOOD ( 19.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Oleksij Rempel , Rob Herring , Shawn Guo , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 05, 2021 at 05:47:21PM -0600, Li Yang wrote: > Layerscape SoCs doesn't use ipg as clock name. Remove the clock name > requirement in the schema. Also the original binding doesn't enforce > the order of "tx" and "rx" in dma-names. Both orders are used > extensively in existing dtses, update the schema to allow both. > > Signed-off-by: Li Yang > --- > Documentation/devicetree/bindings/i2c/i2c-imx.yaml | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-imx.yaml b/Documentation/devicetree/bindings/i2c/i2c-imx.yaml > index f23966b0d6c6..57237b0b7d89 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c-imx.yaml > +++ b/Documentation/devicetree/bindings/i2c/i2c-imx.yaml > @@ -54,20 +54,19 @@ properties: > maxItems: 1 > > clock-names: > - const: ipg > + maxItems: 1 No, for other SoCs the clock is I think required, so it should be there. Add an allof-if statements to require it on specific compatibles and skip on others. > > clock-frequency: > enum: [ 100000, 400000 ] > > dmas: > - items: > - - description: DMA controller phandle and request line for RX > - - description: DMA controller phandle and request line for TX > + minItems: 2 > + maxItems: 2 > > dma-names: > items: > - - const: rx > - - const: tx > + - enum: [ "rx", "tx" ] > + - enum: [ "tx", "rx" ] No, the order should be enforced. That was a generic recommendation from Rob. Also, I don't get the what does it mean "the original binding" in commit msg. This is the original binding. Upstream. Mainline. If your DTSes have different order, please adjust them, not the binding. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel