From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16086C433E0 for ; Sat, 6 Feb 2021 22:59:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D6F3A64E31 for ; Sat, 6 Feb 2021 22:59:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229683AbhBFW67 (ORCPT ); Sat, 6 Feb 2021 17:58:59 -0500 Received: from mail.kernel.org ([198.145.29.99]:48226 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229522AbhBFW64 (ORCPT ); Sat, 6 Feb 2021 17:58:56 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id D464A64E33; Sat, 6 Feb 2021 22:58:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612652296; bh=QAqNyRM5hmPHOGZUsUZJhXXvXlIEDMHraTzFBBKjuis=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=h4VKX6fn6tyC5AJ7Kac2AS8J9yXLhCUapeDEEgbKluLVhJeOKU2gwg6/ZPIOvf3BP dq+S09hTNXsM+arUzefBZBV5RnCSXW9DFqhqjQw366VIsDD9gku/JuqSusQY9S8+kI 2kNhQJ/tpHDNi/zCWpFB5E5LuggNkfL0Dqpg/OWaiFoLahmAPkZU4wqscQygtXKQBk /pQT6S50RZvl543XCXbY+9RUGJwnSuEed3IF3sWH4jkW0kcpU+mJ3l9Jy0XEUf+3BZ cb1MSx20R/hyI0mAvIAh4bB1bQUMCJwzIn2D6yg1LWYxkKfyL04ZvH/n7EN+qiO0gF KYMZl//E87fWw== Date: Sat, 6 Feb 2021 14:58:14 -0800 From: Jakub Kicinski To: Alex Elder Cc: davem@davemloft.net, elder@kernel.org, evgreen@chromium.org, bjorn.andersson@linaro.org, cpratapa@codeaurora.org, subashab@codeaurora.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2 0/7] net: ipa: a mix of small improvements Message-ID: <20210206145814.6a25b8dd@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20210205221100.1738-1-elder@linaro.org> References: <20210205221100.1738-1-elder@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 5 Feb 2021 16:10:53 -0600 Alex Elder wrote: > Version 2 of this series restructures a couple of the changed > functions (in patches 1 and 2) to avoid blocks of indented code > by returning early when possible, as suggested by Jakub. The > description of the first patch was changed as a result, to better > reflect what the updated patch does. It also fixes one spot I > identified when updating the code, where gsi_channel_stop() was > doing the wrong thing on error. Fixed the repeated word in patch 1 and applied. Thanks!